@prettier/plugin-php 0.17.3 → 0.18.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@prettier/plugin-php",
-  "version": "0.17.3",
+  "version": "0.18.0",
   "description": "Prettier PHP Plugin",
   "repository": "prettier/prettier-php",
   "author": "Lucas Azzola <@azz>",
@@ -13,22 +13,22 @@
   "dependencies": {
     "linguist-languages": "^7.5.1",
     "mem": "^8.0.0",
-    "php-parser": "https://github.com/glayzzle/php-parser#e61e26102144f267ecf5e09020865a9baa6ca2f1"
+    "php-parser": "3.1.0-beta.0"
   },
   "devDependencies": {
-    "@babel/preset-env": "^7.7.5",
+    "@babel/preset-env": "^7.16.11",
     "codecov": "3.8.3",
     "cross-env": "^7.0.2",
-    "eslint": "7.31.0",
+    "eslint": "7.32.0",
     "eslint-config-prettier": "8.3.0",
-    "eslint-plugin-import": "2.23.4",
-    "eslint-plugin-jest": "24.4.0",
-    "eslint-plugin-prettier": "3.4.0",
-    "jest": "27.0.6",
-    "jest-runner-eslint": "0.10.1",
+    "eslint-plugin-import": "2.25.4",
+    "eslint-plugin-jest": "26.0.0",
+    "eslint-plugin-prettier": "4.0.0",
+    "jest": "27.4.7",
+    "jest-runner-eslint": "1.0.0",
     "jest-snapshot-serializer-raw": "^1.1.0",
     "prettier": "2.1.2",
-    "rollup": "^2.7.5",
+    "rollup": "^2.67.0",
     "rollup-plugin-alias": "^2.0.0",
     "rollup-plugin-babel": "^4.3.2",
     "rollup-plugin-commonjs": "^10.0.2",
@@ -49,10 +49,5 @@
     "prettier": "prettier --plugin=. --parser=php",
     "build-standalone": "rollup -c build/rollup.config.js",
     "debug": "node --inspect-brk node_modules/.bin/jest --runInBand"
-  },
-  "jest": {
-    "projects": [
-      "<rootDir>/jest.*.config.js"
-    ]
   }
 }

package/src/index.js

@@ -115,16 +115,29 @@ const printers = {
       }
     },
     hasPrettierIgnore(path) {
-      const node = path.getNode();
       const isSimpleIgnore = (comment) =>
         comment.value.includes("prettier-ignore") &&
         !comment.value.includes("prettier-ignore-start") &&
         !comment.value.includes("prettier-ignore-end");
+
+      const parentNode = path.getParentNode();
+      const node = path.getNode();
+
       return (
-        node &&
-        node.comments &&
-        node.comments.length > 0 &&
-        node.comments.some(isSimpleIgnore)
+        (node &&
+          node.kind !== "classconstant" &&
+          node.comments &&
+          node.comments.length > 0 &&
+          node.comments.some(isSimpleIgnore)) ||
+        // For proper formatting, the classconstant ignore formatting should
+        // run on the "constant" child
+        (node &&
+          node.kind === "constant" &&
+          parentNode &&
+          parentNode.kind === "classconstant" &&
+          parentNode.comments &&
+          parentNode.comments.length > 0 &&
+          parentNode.comments.some(isSimpleIgnore))
       );
     },
   },

package/src/needs-parens.js

@@ -52,6 +52,7 @@ function needsParens(path) {
             (node.type === "+" || node.type === "-")
           );
         case "propertylookup":
+        case "nullsafepropertylookup":
         case "staticlookup":
         case "offsetlookup":
         case "call":
@@ -76,6 +77,7 @@ function needsParens(path) {
           return true;
         case "call":
         case "propertylookup":
+        case "nullsafepropertylookup":
         case "staticlookup":
         case "offsetlookup":
           return name === "what" && parent.what === node;
@@ -121,6 +123,7 @@ function needsParens(path) {
       }
     }
     case "propertylookup":
+    case "nullsafepropertylookup":
     case "staticlookup": {
       switch (parent.kind) {
         case "call":
@@ -138,6 +141,7 @@ function needsParens(path) {
     case "new": {
       switch (parent.kind) {
         case "propertylookup":
+        case "nullsafepropertylookup":
         case "staticlookup":
         case "offsetlookup":
         case "call":
@@ -149,6 +153,7 @@ function needsParens(path) {
     case "yield": {
       switch (parent.kind) {
         case "propertylookup":
+        case "nullsafepropertylookup":
         case "staticlookup":
         case "offsetlookup":
         case "call":
@@ -196,6 +201,7 @@ function needsParens(path) {
 
           return true;
         case "propertylookup":
+        case "nullsafepropertylookup":
         case "staticlookup":
         case "offsetlookup":
         case "call":
@@ -211,6 +217,7 @@ function needsParens(path) {
 
         // https://github.com/prettier/plugin-php/issues/1675
         case "propertylookup":
+        case "nullsafepropertylookup":
           return true;
 
         default:
@@ -225,6 +232,7 @@ function needsParens(path) {
     case "array":
       switch (parent.kind) {
         case "propertylookup":
+        case "nullsafepropertylookup":
         case "staticlookup":
         case "offsetlookup":
         case "call":

package/src/printer.js

@@ -288,7 +288,7 @@ function printMemberChain(path, options, print) {
     if (
       printedNodes[i].node.kind === "call" &&
       printedNodes[i - 1] &&
-      ["propertylookup", "staticlookup"].includes(
+      ["propertylookup", "nullsafepropertylookup", "staticlookup"].includes(
         printedNodes[i - 1].node.kind
       ) &&
       printedNodes[i - 1].needsParens
@@ -635,7 +635,9 @@ function printArgumentsList(path, options, print, argumentsKey = "arguments") {
     (shouldPrintComma(options, "7.3") &&
       ["call", "new", "unset", "isset"].includes(node.kind)) ||
     (shouldPrintComma(options, "8.0") &&
-      ["function", "closure", "method", "arrowfunc"].includes(node.kind))
+      ["function", "closure", "method", "arrowfunc", "attribute"].includes(
+        node.kind
+      ))
       ? indent(
           concat([
             lastArg && shouldPrintHardlineBeforeTrailingComma(lastArg)
@@ -1049,14 +1051,20 @@ function printLines(path, options, print, childrenAttribute = "children") {
           : isProgramLikeNode(node) && isFirstNode && node.kind !== "namespace"
           ? ""
           : concat([beforeCloseTagInlineNode, "?>"]);
+
+      const nextV = path.getNode(index + 1);
+      const skipLastComment = nextV && nextV.children && nextV.children.length;
+
       const afterInline =
         childNode.comments && childNode.comments.length
           ? concat([
               openTag,
               hardline,
-              comments.printComments(childNode.comments, options),
+              skipLastComment
+                ? comments.printComments(childNode.comments, options)
+                : "",
               hardline,
-              "?>",
+              skipLastComment ? "?>" : "",
             ])
           : isProgramLikeNode(node) && isLastNode
           ? ""
@@ -1199,10 +1207,51 @@ function printClassPart(
   );
 }
 
+function printAttrs(path, options, print, { inline = false } = {}) {
+  const allAttrs = [];
+  if (!path.getValue().attrGroups) {
+    return [];
+  }
+  path.each((agPath) => {
+    const attrGroup = ["#["];
+    if (!inline && allAttrs.length > 0) {
+      allAttrs.push(hardline);
+    }
+    attrGroup.push(softline);
+    agPath.each((attrPath) => {
+      const attrNode = attrPath.getValue();
+      if (attrGroup.length > 2) {
+        attrGroup.push(",", line);
+      }
+      const attrStmt = [attrNode.name];
+      if (attrNode.args.length > 0) {
+        attrStmt.push(printArgumentsList(attrPath, options, print, "args"));
+      }
+      attrGroup.push(group(concat(attrStmt)));
+    }, "attrs");
+    allAttrs.push(
+      group(
+        concat([
+          indent(concat(attrGroup)),
+          ifBreak(shouldPrintComma(options, "8.0") ? "," : ""),
+          softline,
+          "]",
+          inline ? ifBreak(softline, " ") : "",
+        ])
+      )
+    );
+  }, "attrGroups");
+  if (allAttrs.length === 0) {
+    return [];
+  }
+  return [concat([...allAttrs, inline ? "" : hardline])];
+}
+
 function printClass(path, options, print) {
   const node = path.getValue();
-
-  const declaration = [];
+  const isAnonymousClass = node.kind === "class" && node.isAnonymous;
+  const attrs = printAttrs(path, options, print, { inline: isAnonymousClass });
+  const declaration = isAnonymousClass ? [] : [...attrs];
 
   if (node.isFinal) {
     declaration.push("final ");
@@ -1212,8 +1261,6 @@ function printClass(path, options, print) {
     declaration.push("abstract ");
   }
 
-  const isAnonymousClass = node.kind === "class" && node.isAnonymous;
-
   // `new` print `class` keyword with arguments
   declaration.push(isAnonymousClass ? "" : node.kind);
 
@@ -1318,7 +1365,9 @@ function printClass(path, options, print) {
 
 function printFunction(path, options, print) {
   const node = path.getValue();
-  const declaration = [];
+  const declaration = [
+    ...printAttrs(path, options, print, { inline: node.kind === "closure" }),
+  ];
 
   if (node.isFinal) {
     declaration.push("final ");
@@ -1745,6 +1794,7 @@ function printNode(path, options, print) {
       return printFunction(path, options, print);
     case "arrowfunc":
       return concat([
+        ...printAttrs(path, options, print, { inline: true }),
         node.isStatic ? "static " : "",
         "fn",
         printArgumentsList(path, options, print),
@@ -1764,6 +1814,7 @@ function printNode(path, options, print) {
         promoted = "private ";
       }
       const name = concat([
+        ...printAttrs(path, options, print, { inline: true }),
         promoted,
         node.nullable ? "?" : "",
         node.type ? concat([path.call(print, "type"), " "]) : "",
@@ -1823,6 +1874,11 @@ function printNode(path, options, print) {
         ])
       );
     case "propertystatement": {
+      const attrs = [];
+      path.map(
+        (propPath) => attrs.push(...printAttrs(propPath, options, print)),
+        "properties"
+      );
       const printed = path.map((childPath) => {
         return print(childPath);
       }, "properties");
@@ -1842,6 +1898,7 @@ function printNode(path, options, print) {
 
       return group(
         concat([
+          ...attrs,
           hasVisibility
             ? concat([node.visibility === null ? "var" : node.visibility, ""])
             : "",
@@ -2148,6 +2205,7 @@ function printNode(path, options, print) {
       ) {
         return concat([
           "new ",
+          ...path.call(printAttrs, "what"),
           path.call(print, "what"),
           "(",
           join(", ", path.map(print, "arguments")),
@@ -2168,6 +2226,10 @@ function printNode(path, options, print) {
                 " ",
               ])
             : "",
+          ...path.call(
+            (pa) => printAttrs(pa, options, print, { inline: true }),
+            "what"
+          ),
           "class",
           node.arguments.length > 0
             ? concat([" ", printArgumentsList(path, options, print)])
@@ -2406,9 +2468,8 @@ function printNode(path, options, print) {
     }
     case "constantstatement":
     case "classconstant": {
-      const printed = path.map((childPath) => {
-        return print(childPath);
-      }, "constants");
+      const attrs = printAttrs(path, options, print);
+      const printed = path.map((childPath) => print(childPath), "constants");
 
       let firstVariable;
 
@@ -2421,6 +2482,7 @@ function printNode(path, options, print) {
 
       return group(
         concat([
+          ...attrs,
           node.visibility ? concat([node.visibility, " "]) : "",
           "const",
           firstVariable ? concat([" ", firstVariable]) : "",
@@ -2759,7 +2821,11 @@ function printNode(path, options, print) {
       const parentParent = path.getParentNode(1);
       const pureParent =
         parent.kind === "cast" && parentParent ? parentParent : parent;
-      const breakLookupNodes = ["propertylookup", "staticlookup"];
+      const breakLookupNodes = [
+        "propertylookup",
+        "nullsafepropertylookup",
+        "staticlookup",
+      ];
       const breakClosingParens = breakLookupNodes.includes(pureParent.kind);
 
       const printedTest = path.call(print, "test");

package/src/util.js

@@ -485,6 +485,7 @@ function hasTrailingComment(node) {
 function isLookupNode(node) {
   return (
     node.kind === "propertylookup" ||
+    node.kind === "nullsafepropertylookup" ||
     node.kind === "staticlookup" ||
     node.kind === "offsetlookup"
   );