@prenta/admin 1.16.0 → 1.17.1

package/src/__tests__/components/faq-proposal-preview.render.test.tsx

@@ -0,0 +1,137 @@
+// @vitest-environment happy-dom
+import { describe, expect, it, vi } from 'vitest'
+import { fireEvent, render, screen } from '@testing-library/react'
+import {
+  FAQ_MIN_SELECTED,
+  FaqProposalPreview,
+  faqDraftBlocker,
+  faqSignalLine,
+  type FaqProposalPreviewProps,
+} from '../../components/seo/FaqProposalPreview.js'
+
+const items = [
+  {
+    question: 'How long does it take?',
+    answer: 'Three to five days.',
+    sourceQuote: 'take three to five days',
+  },
+  { question: 'Can I finance?', answer: 'Yes, zero down.', sourceQuote: 'zero down' },
+  { question: 'Warranty?', answer: '25 years.', sourceQuote: '25-year' },
+]
+const signals = {
+  geo: { referralVisits: 14, retrievalHits: 0, engines: ['chatgpt'] },
+  queries: [{ query: 'how long does it take', impressions: 120, clicks: 3 }],
+}
+
+function setup(selected = [true, true, true], over: Partial<FaqProposalPreviewProps> = {}) {
+  const onToggle = vi.fn()
+  const onHeadingChange = vi.fn()
+  render(
+    <FaqProposalPreview
+      heading="Questions"
+      items={items}
+      signals={signals}
+      selected={selected}
+      onToggle={onToggle}
+      headingValue="Questions"
+      onHeadingChange={onHeadingChange}
+      {...over}
+    />,
+  )
+  return { onToggle, onHeadingChange }
+}
+
+describe('FaqProposalPreview', () => {
+  it('renders every Q&A with its source quote and a labelled checkbox', () => {
+    setup()
+    expect(screen.getAllByRole('checkbox')).toHaveLength(3)
+    expect(screen.getByRole('checkbox', { name: /How long does it take\?/ })).toHaveProperty(
+      'checked',
+      true,
+    )
+    expect(screen.getByText('Three to five days.')).toBeTruthy()
+    expect(screen.getByText(/take three to five days/)).toBeTruthy()
+  })
+
+  it('shows the signal line', () => {
+    setup()
+    expect(screen.getByText(/Cited by chatgpt 14×/)).toBeTruthy()
+    expect(screen.getByText(/"how long does it take"/)).toBeTruthy()
+  })
+
+  it('calls onToggle with the index and onHeadingChange with the value', () => {
+    const { onToggle, onHeadingChange } = setup()
+    fireEvent.click(screen.getByRole('checkbox', { name: /Warranty\?/ }))
+    expect(onToggle).toHaveBeenCalledWith(2)
+    fireEvent.change(screen.getByLabelText('Section heading'), {
+      target: { value: 'Top questions' },
+    })
+    expect(onHeadingChange).toHaveBeenCalledWith('Top questions')
+  })
+
+  it('warns when fewer than two items are selected', () => {
+    setup([true, false, false])
+    expect(screen.getByRole('status').textContent).toBe(
+      `Select at least ${FAQ_MIN_SELECTED} questions to approve (1 selected).`,
+    )
+  })
+
+  it('reports how many questions will be added when the draft is approvable', () => {
+    setup([true, true, false])
+    expect(screen.getByRole('status').textContent).toBe('2 of 3 questions will be added.')
+  })
+
+  it('treats a blank heading as "use the drafted heading", not a blocker', () => {
+    setup([true, true, true], { headingValue: '   ' })
+    expect(screen.getByRole('status').textContent).toBe('3 of 3 questions will be added.')
+    expect(screen.getByLabelText('Section heading')).toHaveProperty('placeholder', 'Questions')
+  })
+
+  it('renders no source line for an item without a quote', () => {
+    setup([true, true], {
+      items: [
+        { question: 'Q1?', answer: 'A1.', sourceQuote: '' },
+        { question: 'Q2?', answer: 'A2.' },
+      ],
+    })
+    expect(screen.queryByText(/^Source:/)).toBeNull()
+    expect(screen.queryByText(/“”/)).toBeNull()
+  })
+
+  it('omits the signal line when there are no signals', () => {
+    setup([true, true, true], { signals: null })
+    expect(screen.queryByText(/Cited by|Fetched by|asked/)).toBeNull()
+  })
+
+  it('disables the heading field and every checkbox when disabled', () => {
+    setup([true, true, true], { disabled: true })
+    expect(screen.getByLabelText('Section heading')).toHaveProperty('disabled', true)
+    for (const box of screen.getAllByRole('checkbox')) expect(box).toHaveProperty('disabled', true)
+  })
+})
+
+describe('faqSignalLine', () => {
+  it('prefers referral citations, then retrieval fetches, then the top query', () => {
+    expect(faqSignalLine(signals)).toBe(
+      'Cited by chatgpt 14× in 28 days · asked "how long does it take" 120× on Google',
+    )
+    expect(
+      faqSignalLine({ geo: { referralVisits: 0, retrievalHits: 40, engines: [] }, queries: [] }),
+    ).toBe('Fetched by AI engines 40× in 28 days')
+    expect(
+      faqSignalLine({ geo: null, queries: [{ query: 'why', impressions: 9, clicks: 0 }] }),
+    ).toBe('asked "why" 9× on Google')
+    expect(faqSignalLine({ geo: null, queries: [] })).toBeNull()
+    expect(faqSignalLine(null)).toBeNull()
+  })
+})
+
+describe('faqDraftBlocker', () => {
+  it('blocks only on too few selected items', () => {
+    expect(faqDraftBlocker([true, false, false])).toBe(
+      `Select at least ${FAQ_MIN_SELECTED} questions to approve (1 selected).`,
+    )
+    expect(faqDraftBlocker([false, false, false])).toMatch(/\(0 selected\)/)
+    expect(faqDraftBlocker([true, true, false])).toBeNull()
+  })
+})

package/src/__tests__/components/seo-issue-fix-panel.render.test.tsx

@@ -27,21 +27,45 @@ const orphanIssue: SeoIssue = {
   resolvedAt: null,
 }
 
+const faqSchemaIssue: SeoIssue = {
+  ...orphanIssue,
+  id: 'iss-faq-schema',
+  entityTitle: 'Pricing',
+  url: '/pricing',
+  category: 'schema',
+  type: 'faq-schema-missing',
+  title: 'FAQ section without FAQPage schema',
+  fixActionType: 'edit-schema',
+}
+
+const fetchSuggestionMock = vi.fn(async (issueId: string) => ({
+  suggestion:
+    issueId === faqSchemaIssue.id
+      ? {
+          autoFixable: true,
+          source: 'deterministic',
+          // Metadata/schema fixes carry no strategy — only redirects do.
+          fingerprint: 'fp-faq',
+          patch: { structuredData: {} },
+          changes: [],
+          justification: 'Adds a FAQPage node.',
+        }
+      : {
+          autoFixable: true,
+          source: 'deterministic',
+          fixStrategy: 'insert-link',
+          fingerprint: 'fp-insert',
+          patch: {},
+          changes: [],
+          justification: 'Add an inbound link from a related page.',
+        },
+}))
+
 vi.mock('../../lib/seo-service.js', async (importOriginal) => {
   const actual = await importOriginal<typeof import('../../lib/seo-service.js')>()
   return {
     ...actual,
-    fetchSeoIssueFixSuggestion: vi.fn(async () => ({
-      suggestion: {
-        autoFixable: true,
-        source: 'deterministic',
-        fixStrategy: 'insert-link',
-        fingerprint: 'fp-insert',
-        patch: {},
-        changes: [],
-        justification: 'Add an inbound link from a related page.',
-      },
-    })),
+    fetchSeoIssueFixSuggestion: (issueId: string) => fetchSuggestionMock(issueId),
     applySeoIssueFix: vi.fn(async () => ({})),
     fetchSeoContentBrief: vi.fn(async () => ({})),
     fetchSeoContentResearch: vi.fn(async () => ({})),
@@ -62,4 +86,11 @@ describe('SeoIssueFixPanel insert-link copy', () => {
     expect(await screen.findByRole('button', { name: 'Approve link' })).toBeTruthy()
     expect(screen.queryByRole('button', { name: 'Approve redirect' })).toBeNull()
   })
+
+  it('labels a strategy-less schema fix (faq-schema-missing) Approve fix, not Approve redirect', async () => {
+    render(<SeoIssueFixPanel issue={faqSchemaIssue} expanded />)
+
+    expect(await screen.findByRole('button', { name: 'Approve fix' })).toBeTruthy()
+    expect(screen.queryByRole('button', { name: 'Approve redirect' })).toBeNull()
+  })
 })

package/src/__tests__/lib/seo-service-errors.test.ts

@@ -17,7 +17,6 @@ const {
   fetchRedirectRules,
   generate404RecoverySuggestions,
   generateSeoField,
-  generateStructuredData,
   isInlineSeoFixIssue,
   runSeoAudit,
   summarizeSeoAudit,
@@ -113,7 +112,7 @@ describe('SEO service read fetchers surface errors', () => {
 
 /**
  * Regression tests for the "swallowed governance errors" gap: the governed AI
- * runtime returns crafted 429/403 messages (daily request cap, monthly budget,
+ * runtime returns crafted 429/503 messages (daily request cap, monthly budget,
  * disabled feature) and the copilot helpers must surface them, not collapse to
  * `{}` — which the UI renders as the misleading "No suggestion was returned."
  * Unavailability (501/503) stays a distinct graceful state.
@@ -141,13 +140,6 @@ describe('AI copilot helpers surface governance errors', () => {
     await expect(explainSeoIssue('issue-1')).resolves.toEqual({ error: capMsg })
   })
 
-  it('generateStructuredData returns the server message on 403', async () => {
-    cmsApi.mockResolvedValue({ error: 'This AI feature is disabled.', status: 403 })
-    await expect(
-      generateStructuredData({ entityType: 'page', entityId: 'p1', schemaType: 'Article' }),
-    ).resolves.toEqual({ error: 'This AI feature is disabled.' })
-  })
-
   it('summarizeSeoAudit returns the server message on 429', async () => {
     cmsApi.mockResolvedValue({ error: capMsg, status: 429 })
     await expect(summarizeSeoAudit()).resolves.toEqual({ error: capMsg })
@@ -220,6 +212,10 @@ describe('inline SEO fix issue types', () => {
   it('treats orphan-page as an inline Approve issue', () => {
     expect(isInlineSeoFixIssue('orphan-page')).toBe(true)
   })
+
+  it('treats faq-schema-missing as an inline Approve issue (mirrors core DETERMINISTIC_FIX_TYPES)', () => {
+    expect(isInlineSeoFixIssue('faq-schema-missing')).toBe(true)
+  })
 })
 
 describe('SEO audit mutation contract', () => {

package/src/__tests__/lib/seo-service-proposals.test.ts

@@ -100,6 +100,36 @@ describe('proposal service helpers', () => {
     })
   })
 
+  it('applySeoIssueFix sends includeItems and headingOverride only when given', async () => {
+    cmsApi.mockResolvedValueOnce({ status: 200, data: { issue: { id: 'i1' } } })
+    await expect(
+      svc.applySeoIssueFix('i1', 'fp', { includeItems: [0, 2], headingOverride: 'H' }),
+    ).resolves.toEqual({ issue: { id: 'i1' } })
+    expect(cmsApi).toHaveBeenLastCalledWith('/seo/issues/i1/apply-fix', {
+      method: 'POST',
+      body: JSON.stringify({ fingerprint: 'fp', includeItems: [0, 2], headingOverride: 'H' }),
+    })
+
+    cmsApi.mockResolvedValueOnce({ status: 200, data: { issue: { id: 'i1' } } })
+    await svc.applySeoIssueFix('i1', 'fp')
+    expect(cmsApi).toHaveBeenLastCalledWith('/seo/issues/i1/apply-fix', {
+      method: 'POST',
+      body: JSON.stringify({ fingerprint: 'fp' }),
+    })
+
+    cmsApi.mockResolvedValueOnce({ status: 200, data: { issue: { id: 'i1' } } })
+    await svc.applySeoIssueFix('i1', 'fp', {})
+    expect(cmsApi).toHaveBeenLastCalledWith('/seo/issues/i1/apply-fix', {
+      method: 'POST',
+      body: JSON.stringify({ fingerprint: 'fp' }),
+    })
+
+    cmsApi.mockResolvedValueOnce({ status: 409, error: 'Fix suggestion is stale.' })
+    await expect(svc.applySeoIssueFix('i1', 'fp', { includeItems: [0, 1] })).resolves.toEqual({
+      error: 'Fix suggestion is stale.',
+    })
+  })
+
   it('dismissSeoIssueFix POSTs to the encoded issue path', async () => {
     cmsApi.mockResolvedValueOnce({ status: 200, data: { dismissed: true } })
     await expect(svc.dismissSeoIssueFix('a/b')).resolves.toEqual({})