@prenta/admin 1.16.0 → 1.17.0

package/src/__tests__/components/faq-proposal-preview.render.test.tsx

@@ -0,0 +1,137 @@
+// @vitest-environment happy-dom
+import { describe, expect, it, vi } from 'vitest'
+import { fireEvent, render, screen } from '@testing-library/react'
+import {
+  FAQ_MIN_SELECTED,
+  FaqProposalPreview,
+  faqDraftBlocker,
+  faqSignalLine,
+  type FaqProposalPreviewProps,
+} from '../../components/seo/FaqProposalPreview.js'
+
+const items = [
+  {
+    question: 'How long does it take?',
+    answer: 'Three to five days.',
+    sourceQuote: 'take three to five days',
+  },
+  { question: 'Can I finance?', answer: 'Yes, zero down.', sourceQuote: 'zero down' },
+  { question: 'Warranty?', answer: '25 years.', sourceQuote: '25-year' },
+]
+const signals = {
+  geo: { referralVisits: 14, retrievalHits: 0, engines: ['chatgpt'] },
+  queries: [{ query: 'how long does it take', impressions: 120, clicks: 3 }],
+}
+
+function setup(selected = [true, true, true], over: Partial<FaqProposalPreviewProps> = {}) {
+  const onToggle = vi.fn()
+  const onHeadingChange = vi.fn()
+  render(
+    <FaqProposalPreview
+      heading="Questions"
+      items={items}
+      signals={signals}
+      selected={selected}
+      onToggle={onToggle}
+      headingValue="Questions"
+      onHeadingChange={onHeadingChange}
+      {...over}
+    />,
+  )
+  return { onToggle, onHeadingChange }
+}
+
+describe('FaqProposalPreview', () => {
+  it('renders every Q&A with its source quote and a labelled checkbox', () => {
+    setup()
+    expect(screen.getAllByRole('checkbox')).toHaveLength(3)
+    expect(screen.getByRole('checkbox', { name: /How long does it take\?/ })).toHaveProperty(
+      'checked',
+      true,
+    )
+    expect(screen.getByText('Three to five days.')).toBeTruthy()
+    expect(screen.getByText(/take three to five days/)).toBeTruthy()
+  })
+
+  it('shows the signal line', () => {
+    setup()
+    expect(screen.getByText(/Cited by chatgpt 14×/)).toBeTruthy()
+    expect(screen.getByText(/"how long does it take"/)).toBeTruthy()
+  })
+
+  it('calls onToggle with the index and onHeadingChange with the value', () => {
+    const { onToggle, onHeadingChange } = setup()
+    fireEvent.click(screen.getByRole('checkbox', { name: /Warranty\?/ }))
+    expect(onToggle).toHaveBeenCalledWith(2)
+    fireEvent.change(screen.getByLabelText('Section heading'), {
+      target: { value: 'Top questions' },
+    })
+    expect(onHeadingChange).toHaveBeenCalledWith('Top questions')
+  })
+
+  it('warns when fewer than two items are selected', () => {
+    setup([true, false, false])
+    expect(screen.getByRole('status').textContent).toBe(
+      `Select at least ${FAQ_MIN_SELECTED} questions to approve (1 selected).`,
+    )
+  })
+
+  it('reports how many questions will be added when the draft is approvable', () => {
+    setup([true, true, false])
+    expect(screen.getByRole('status').textContent).toBe('2 of 3 questions will be added.')
+  })
+
+  it('treats a blank heading as "use the drafted heading", not a blocker', () => {
+    setup([true, true, true], { headingValue: '   ' })
+    expect(screen.getByRole('status').textContent).toBe('3 of 3 questions will be added.')
+    expect(screen.getByLabelText('Section heading')).toHaveProperty('placeholder', 'Questions')
+  })
+
+  it('renders no source line for an item without a quote', () => {
+    setup([true, true], {
+      items: [
+        { question: 'Q1?', answer: 'A1.', sourceQuote: '' },
+        { question: 'Q2?', answer: 'A2.' },
+      ],
+    })
+    expect(screen.queryByText(/^Source:/)).toBeNull()
+    expect(screen.queryByText(/“”/)).toBeNull()
+  })
+
+  it('omits the signal line when there are no signals', () => {
+    setup([true, true, true], { signals: null })
+    expect(screen.queryByText(/Cited by|Fetched by|asked/)).toBeNull()
+  })
+
+  it('disables the heading field and every checkbox when disabled', () => {
+    setup([true, true, true], { disabled: true })
+    expect(screen.getByLabelText('Section heading')).toHaveProperty('disabled', true)
+    for (const box of screen.getAllByRole('checkbox')) expect(box).toHaveProperty('disabled', true)
+  })
+})
+
+describe('faqSignalLine', () => {
+  it('prefers referral citations, then retrieval fetches, then the top query', () => {
+    expect(faqSignalLine(signals)).toBe(
+      'Cited by chatgpt 14× in 28 days · asked "how long does it take" 120× on Google',
+    )
+    expect(
+      faqSignalLine({ geo: { referralVisits: 0, retrievalHits: 40, engines: [] }, queries: [] }),
+    ).toBe('Fetched by AI engines 40× in 28 days')
+    expect(
+      faqSignalLine({ geo: null, queries: [{ query: 'why', impressions: 9, clicks: 0 }] }),
+    ).toBe('asked "why" 9× on Google')
+    expect(faqSignalLine({ geo: null, queries: [] })).toBeNull()
+    expect(faqSignalLine(null)).toBeNull()
+  })
+})
+
+describe('faqDraftBlocker', () => {
+  it('blocks only on too few selected items', () => {
+    expect(faqDraftBlocker([true, false, false])).toBe(
+      `Select at least ${FAQ_MIN_SELECTED} questions to approve (1 selected).`,
+    )
+    expect(faqDraftBlocker([false, false, false])).toMatch(/\(0 selected\)/)
+    expect(faqDraftBlocker([true, true, false])).toBeNull()
+  })
+})

package/src/__tests__/components/seo-issue-fix-panel.render.test.tsx

@@ -27,21 +27,45 @@ const orphanIssue: SeoIssue = {
   resolvedAt: null,
 }
 
+const faqSchemaIssue: SeoIssue = {
+  ...orphanIssue,
+  id: 'iss-faq-schema',
+  entityTitle: 'Pricing',
+  url: '/pricing',
+  category: 'schema',
+  type: 'faq-schema-missing',
+  title: 'FAQ section without FAQPage schema',
+  fixActionType: 'edit-schema',
+}
+
+const fetchSuggestionMock = vi.fn(async (issueId: string) => ({
+  suggestion:
+    issueId === faqSchemaIssue.id
+      ? {
+          autoFixable: true,
+          source: 'deterministic',
+          // Metadata/schema fixes carry no strategy — only redirects do.
+          fingerprint: 'fp-faq',
+          patch: { structuredData: {} },
+          changes: [],
+          justification: 'Adds a FAQPage node.',
+        }
+      : {
+          autoFixable: true,
+          source: 'deterministic',
+          fixStrategy: 'insert-link',
+          fingerprint: 'fp-insert',
+          patch: {},
+          changes: [],
+          justification: 'Add an inbound link from a related page.',
+        },
+}))
+
 vi.mock('../../lib/seo-service.js', async (importOriginal) => {
   const actual = await importOriginal<typeof import('../../lib/seo-service.js')>()
   return {
     ...actual,
-    fetchSeoIssueFixSuggestion: vi.fn(async () => ({
-      suggestion: {
-        autoFixable: true,
-        source: 'deterministic',
-        fixStrategy: 'insert-link',
-        fingerprint: 'fp-insert',
-        patch: {},
-        changes: [],
-        justification: 'Add an inbound link from a related page.',
-      },
-    })),
+    fetchSeoIssueFixSuggestion: (issueId: string) => fetchSuggestionMock(issueId),
     applySeoIssueFix: vi.fn(async () => ({})),
     fetchSeoContentBrief: vi.fn(async () => ({})),
     fetchSeoContentResearch: vi.fn(async () => ({})),
@@ -62,4 +86,11 @@ describe('SeoIssueFixPanel insert-link copy', () => {
     expect(await screen.findByRole('button', { name: 'Approve link' })).toBeTruthy()
     expect(screen.queryByRole('button', { name: 'Approve redirect' })).toBeNull()
   })
+
+  it('labels a strategy-less schema fix (faq-schema-missing) Approve fix, not Approve redirect', async () => {
+    render(<SeoIssueFixPanel issue={faqSchemaIssue} expanded />)
+
+    expect(await screen.findByRole('button', { name: 'Approve fix' })).toBeTruthy()
+    expect(screen.queryByRole('button', { name: 'Approve redirect' })).toBeNull()
+  })
 })

package/src/__tests__/lib/seo-service-errors.test.ts

@@ -220,6 +220,10 @@ describe('inline SEO fix issue types', () => {
   it('treats orphan-page as an inline Approve issue', () => {
     expect(isInlineSeoFixIssue('orphan-page')).toBe(true)
   })
+
+  it('treats faq-schema-missing as an inline Approve issue (mirrors core DETERMINISTIC_FIX_TYPES)', () => {
+    expect(isInlineSeoFixIssue('faq-schema-missing')).toBe(true)
+  })
 })
 
 describe('SEO audit mutation contract', () => {

package/src/__tests__/lib/seo-service-proposals.test.ts

@@ -100,6 +100,36 @@ describe('proposal service helpers', () => {
     })
   })
 
+  it('applySeoIssueFix sends includeItems and headingOverride only when given', async () => {
+    cmsApi.mockResolvedValueOnce({ status: 200, data: { issue: { id: 'i1' } } })
+    await expect(
+      svc.applySeoIssueFix('i1', 'fp', { includeItems: [0, 2], headingOverride: 'H' }),
+    ).resolves.toEqual({ issue: { id: 'i1' } })
+    expect(cmsApi).toHaveBeenLastCalledWith('/seo/issues/i1/apply-fix', {
+      method: 'POST',
+      body: JSON.stringify({ fingerprint: 'fp', includeItems: [0, 2], headingOverride: 'H' }),
+    })
+
+    cmsApi.mockResolvedValueOnce({ status: 200, data: { issue: { id: 'i1' } } })
+    await svc.applySeoIssueFix('i1', 'fp')
+    expect(cmsApi).toHaveBeenLastCalledWith('/seo/issues/i1/apply-fix', {
+      method: 'POST',
+      body: JSON.stringify({ fingerprint: 'fp' }),
+    })
+
+    cmsApi.mockResolvedValueOnce({ status: 200, data: { issue: { id: 'i1' } } })
+    await svc.applySeoIssueFix('i1', 'fp', {})
+    expect(cmsApi).toHaveBeenLastCalledWith('/seo/issues/i1/apply-fix', {
+      method: 'POST',
+      body: JSON.stringify({ fingerprint: 'fp' }),
+    })
+
+    cmsApi.mockResolvedValueOnce({ status: 409, error: 'Fix suggestion is stale.' })
+    await expect(svc.applySeoIssueFix('i1', 'fp', { includeItems: [0, 1] })).resolves.toEqual({
+      error: 'Fix suggestion is stale.',
+    })
+  })
+
   it('dismissSeoIssueFix POSTs to the encoded issue path', async () => {
     cmsApi.mockResolvedValueOnce({ status: 200, data: { dismissed: true } })
     await expect(svc.dismissSeoIssueFix('a/b')).resolves.toEqual({})

package/src/__tests__/views/seo-proposals-tab.render.test.tsx

@@ -27,10 +27,51 @@ function proposal(over: Partial<SeoProposal> = {}): SeoProposal {
     severity: 'warning',
     issueId: 'i1',
     suggestionId: null,
+    fixStrategy: null,
+    section: null,
+    grounding: null,
+    signals: null,
     ...over,
   }
 }
 
+/** An `add-section` FAQ proposal with three grounded questions and both signal kinds. */
+function faqProposal(over: Partial<SeoProposal> = {}): SeoProposal {
+  return proposal({
+    id: 'issue:faq1',
+    issueId: 'faq1',
+    fingerprint: 'fp-faq',
+    title: 'Page lacks an FAQ section',
+    issueType: 'missing-faq',
+    severity: 'info',
+    entity: { type: 'page', id: 'd9', title: 'Solar installs', url: '/solar' },
+    changes: [{ field: 'sections', label: 'Sections', before: null, after: 'FAQ (3 questions)' }],
+    justification: 'Answer engines cite this page; an FAQ makes the answers extractable.',
+    fixStrategy: 'add-section',
+    section: {
+      sectionType: 'faq',
+      content: {
+        heading: 'Questions',
+        items: [
+          { question: 'How long does it take?', answer: 'Three to five days.' },
+          { question: 'Can I finance?', answer: 'Yes, zero down.' },
+          { question: 'Warranty?', answer: '25 years.' },
+        ],
+      },
+    },
+    grounding: [
+      { sourceQuote: 'take three to five days' },
+      { sourceQuote: 'zero down' },
+      { sourceQuote: '' },
+    ],
+    signals: {
+      geo: { referralVisits: 14, retrievalHits: 0, engines: ['chatgpt'] },
+      queries: [{ query: 'how long does it take', impressions: 120, clicks: 3 }],
+    },
+    ...over,
+  })
+}
+
 function payload(over: Partial<SeoProposalsPayload> = {}): SeoProposalsPayload {
   return {
     proposals: [
@@ -54,6 +95,7 @@ function payload(over: Partial<SeoProposalsPayload> = {}): SeoProposalsPayload {
         suggestionId: 's1',
         severity: null,
         changes: [{ field: 'redirect', label: 'Redirect', before: '/old', after: '/new' }],
+        fixStrategy: 'redirect',
       }),
     ],
     counts: { issueFixes: 2, redirects: 1, stale: 0, eligibleForGeneration: 5 },
@@ -86,11 +128,23 @@ const bulkApplySeoProposals = vi.fn(
 )
 const dismissSeoIssueFix = vi.fn(async (_id: string): Promise<{ error?: string }> => ({}))
 const dismissRedirectSuggestion = vi.fn(async (_id: string): Promise<{ error?: string }> => ({}))
+const applySeoIssueFix = vi.fn(
+  async (
+    _issueId: string,
+    _fingerprint: string,
+    _opts?: { includeItems?: number[]; headingOverride?: string },
+  ): Promise<{ issue?: unknown; error?: string }> => ({}),
+)
 
 vi.mock('../../lib/seo-service.js', () => ({
   fetchSeoProposals: () => fetchSeoProposals(),
   generateSeoProposals: () => generateSeoProposals(),
   bulkApplySeoProposals: (items: unknown) => bulkApplySeoProposals(items),
+  applySeoIssueFix: (
+    issueId: string,
+    fingerprint: string,
+    opts?: { includeItems?: number[]; headingOverride?: string },
+  ) => applySeoIssueFix(issueId, fingerprint, opts),
   dismissSeoIssueFix: (id: string) => dismissSeoIssueFix(id),
   dismissRedirectSuggestion: (id: string) => dismissRedirectSuggestion(id),
   fetchAutopilotApplied: (params: unknown) => fetchAutopilotApplied(params),
@@ -125,6 +179,8 @@ beforeEach(() => {
   bulkApplySeoProposals.mockClear()
   dismissSeoIssueFix.mockClear()
   dismissRedirectSuggestion.mockClear()
+  applySeoIssueFix.mockClear()
+  applySeoIssueFix.mockImplementation(async () => ({}))
   fetchAutopilotApplied.mockClear()
   revertAutopilotChange.mockClear()
   vi.mocked(toast.success).mockClear()
@@ -522,6 +578,308 @@ describe('ProposalsTab', () => {
     expect(fetchAutopilotApplied).toHaveBeenCalledTimes(2)
   })
 
+  describe('FAQ (add-section) proposals', () => {
+    function faqPayload(row: SeoProposal = faqProposal()): SeoProposalsPayload {
+      return payload({
+        proposals: [row],
+        counts: { issueFixes: 1, redirects: 0, stale: 0, eligibleForGeneration: 0 },
+      })
+    }
+
+    it('shows the FAQ badge and a question-count summary with the strongest signal', async () => {
+      fetchSeoProposals.mockImplementationOnce(async () => faqPayload())
+      render(<ProposalsTab planInfo={null} />)
+      await screen.findByText('FAQ section')
+      expect(screen.getByText(/^3 questions · Cited by chatgpt 14× in 28 days/)).toBeTruthy()
+    })
+
+    it('approves a FAQ proposal through applySeoIssueFix with includeItems and headingOverride', async () => {
+      fetchSeoProposals.mockImplementationOnce(async () => faqPayload())
+      render(<ProposalsTab planInfo={null} onNavigate={vi.fn()} />)
+      await screen.findByText('FAQ section')
+      fireEvent.click(
+        screen.getByRole('button', { name: 'Show changes for Page lacks an FAQ section' }),
+      )
+      // The third grounding row is malformed (`''`): it must render as "no quote".
+      expect(screen.getByText(/take three to five days/)).toBeTruthy()
+      expect(screen.queryByText(/“”/)).toBeNull()
+      fireEvent.click(screen.getByRole('checkbox', { name: /Warranty\?/ }))
+      fireEvent.change(screen.getByLabelText('Section heading'), {
+        target: { value: 'Top questions' },
+      })
+      fireEvent.click(screen.getByRole('button', { name: /^Approve$/ }))
+      await waitFor(() =>
+        expect(applySeoIssueFix).toHaveBeenCalledWith('faq1', 'fp-faq', {
+          includeItems: [0, 1],
+          headingOverride: 'Top questions',
+        }),
+      )
+      expect(bulkApplySeoProposals).not.toHaveBeenCalled()
+      await waitFor(() => expect(toast.success).toHaveBeenCalledWith('FAQ section added.'))
+      await waitFor(() => expect(fetchSeoProposals).toHaveBeenCalledTimes(2))
+    })
+
+    it('sends neither includeItems nor headingOverride when nothing was changed', async () => {
+      fetchSeoProposals.mockImplementationOnce(async () => faqPayload())
+      render(<ProposalsTab planInfo={null} />)
+      await screen.findByText('FAQ section')
+      fireEvent.click(screen.getByRole('button', { name: 'Approve Page lacks an FAQ section' }))
+      await waitFor(() => expect(applySeoIssueFix).toHaveBeenCalledTimes(1))
+      expect(applySeoIssueFix).toHaveBeenCalledWith('faq1', 'fp-faq', {})
+      expect(bulkApplySeoProposals).not.toHaveBeenCalled()
+    })
+
+    it('does not send a heading override that only differs by whitespace', async () => {
+      fetchSeoProposals.mockImplementationOnce(async () => faqPayload())
+      render(<ProposalsTab planInfo={null} />)
+      await screen.findByText('FAQ section')
+      fireEvent.click(
+        screen.getByRole('button', { name: 'Show changes for Page lacks an FAQ section' }),
+      )
+      fireEvent.change(screen.getByLabelText('Section heading'), {
+        target: { value: '  Questions  ' },
+      })
+      fireEvent.click(screen.getByRole('button', { name: /^Approve$/ }))
+      await waitFor(() => expect(applySeoIssueFix).toHaveBeenCalledWith('faq1', 'fp-faq', {}))
+    })
+
+    it('falls back to the drafted heading when the heading field is cleared', async () => {
+      fetchSeoProposals.mockImplementationOnce(async () => faqPayload())
+      render(<ProposalsTab planInfo={null} />)
+      await screen.findByText('FAQ section')
+      fireEvent.click(
+        screen.getByRole('button', { name: 'Show changes for Page lacks an FAQ section' }),
+      )
+      fireEvent.change(screen.getByLabelText('Section heading'), { target: { value: '' } })
+      expect(screen.getByText('3 of 3 questions will be added.')).toBeTruthy()
+      const approve = screen.getByRole('button', { name: /^Approve$/ })
+      expect(approve).toHaveProperty('disabled', false)
+      fireEvent.click(approve)
+      await waitFor(() => expect(applySeoIssueFix).toHaveBeenCalledWith('faq1', 'fp-faq', {}))
+    })
+
+    it('disables approve with a hint once fewer than two questions are selected', async () => {
+      fetchSeoProposals.mockImplementationOnce(async () => faqPayload())
+      render(<ProposalsTab planInfo={null} />)
+      await screen.findByText('FAQ section')
+      fireEvent.click(
+        screen.getByRole('button', { name: 'Show changes for Page lacks an FAQ section' }),
+      )
+      fireEvent.click(screen.getByRole('checkbox', { name: /Warranty\?/ }))
+      fireEvent.click(screen.getByRole('checkbox', { name: /Can I finance\?/ }))
+      // The visible hint (the sr-only copy on the row button is asserted separately).
+      expect(
+        screen.getByText(/Select at least 2 questions to approve \(1 selected\)/, {
+          selector: '[role="status"]',
+        }),
+      ).toBeTruthy()
+      const approve = screen.getByRole('button', { name: /^Approve$/ })
+      expect(approve).toHaveProperty('disabled', true)
+      expect(
+        screen.getByRole('button', { name: 'Approve Page lacks an FAQ section' }),
+      ).toHaveProperty('disabled', true)
+      fireEvent.click(approve)
+      expect(applySeoIssueFix).not.toHaveBeenCalled()
+      // Re-checking one restores the button.
+      fireEvent.click(screen.getByRole('checkbox', { name: /Can I finance\?/ }))
+      expect(screen.getByRole('button', { name: /^Approve$/ })).toHaveProperty('disabled', false)
+    })
+
+    it('exposes the blocker on the collapsed row approve button', async () => {
+      fetchSeoProposals.mockImplementationOnce(async () => faqPayload())
+      render(<ProposalsTab planInfo={null} />)
+      await screen.findByText('FAQ section')
+      fireEvent.click(
+        screen.getByRole('button', { name: 'Show changes for Page lacks an FAQ section' }),
+      )
+      fireEvent.click(screen.getByRole('checkbox', { name: /Warranty\?/ }))
+      fireEvent.click(screen.getByRole('checkbox', { name: /Can I finance\?/ }))
+      fireEvent.click(
+        screen.getByRole('button', { name: 'Hide changes for Page lacks an FAQ section' }),
+      )
+      const approve = screen.getByRole('button', { name: 'Approve Page lacks an FAQ section' })
+      expect(approve).toHaveProperty('disabled', true)
+      expect(approve.getAttribute('title')).toMatch(/Select at least 2 questions/)
+      const describedBy = approve.getAttribute('aria-describedby') ?? ''
+      expect(describedBy).not.toBe('')
+      expect(document.getElementById(describedBy)?.textContent).toMatch(
+        /Select at least 2 questions to approve \(1 selected\)/,
+      )
+    })
+
+    it('keeps per-row drafts isolated between two FAQ rows', async () => {
+      const rowB = faqProposal({
+        id: 'issue:faq2',
+        issueId: 'faq2',
+        fingerprint: 'fp-faq2',
+        title: 'Roofing page lacks an FAQ section',
+        entity: { type: 'page', id: 'd10', title: 'Roofing', url: '/roofing' },
+        section: {
+          sectionType: 'faq',
+          content: {
+            heading: 'Roofing questions',
+            items: [
+              { question: 'Is it insured?', answer: 'Yes.' },
+              { question: 'Do you travel?', answer: 'Statewide.' },
+              { question: 'Deposit?', answer: '10%.' },
+            ],
+          },
+        },
+        grounding: null,
+      })
+      fetchSeoProposals.mockImplementationOnce(async () =>
+        payload({ proposals: [faqProposal(), rowB] }),
+      )
+      render(<ProposalsTab planInfo={null} />)
+      await screen.findAllByText('FAQ section')
+      fireEvent.click(
+        screen.getByRole('button', { name: 'Show changes for Page lacks an FAQ section' }),
+      )
+      fireEvent.click(
+        screen.getByRole('button', { name: 'Show changes for Roofing page lacks an FAQ section' }),
+      )
+      fireEvent.click(screen.getByRole('checkbox', { name: /Warranty\?/ }))
+      expect(screen.getByRole('checkbox', { name: /Warranty\?/ })).toHaveProperty('checked', false)
+      for (const name of [/Is it insured\?/, /Do you travel\?/, /Deposit\?/]) {
+        expect(screen.getByRole('checkbox', { name })).toHaveProperty('checked', true)
+      }
+      fireEvent.click(screen.getByRole('checkbox', { name: /Deposit\?/ }))
+      expect(screen.getByRole('checkbox', { name: /Deposit\?/ })).toHaveProperty('checked', false)
+      expect(screen.getByRole('checkbox', { name: /Is it insured\?/ })).toHaveProperty(
+        'checked',
+        true,
+      )
+      expect(screen.getByRole('checkbox', { name: /Warranty\?/ })).toHaveProperty('checked', false)
+      expect(screen.getByRole('checkbox', { name: /How long does it take\?/ })).toHaveProperty(
+        'checked',
+        true,
+      )
+    })
+
+    it('starts a fresh draft when a refetch returns new questions under the same id and fingerprint', async () => {
+      const regenerated = faqProposal({
+        section: {
+          sectionType: 'faq',
+          content: {
+            heading: 'Common questions',
+            items: [
+              { question: 'Is it insured?', answer: 'Yes.' },
+              { question: 'Do you travel?', answer: 'Statewide.' },
+              { question: 'Deposit?', answer: '10%.' },
+            ],
+          },
+        },
+        grounding: null,
+      })
+      fetchSeoProposals
+        .mockImplementationOnce(async () => payload({ proposals: [proposal(), faqProposal()] }))
+        .mockImplementationOnce(async () => payload({ proposals: [regenerated] }))
+      render(<ProposalsTab planInfo={null} />)
+      await screen.findByText('FAQ section')
+      fireEvent.click(
+        screen.getByRole('button', { name: 'Show changes for Page lacks an FAQ section' }),
+      )
+      fireEvent.click(screen.getByRole('checkbox', { name: /Warranty\?/ }))
+      fireEvent.change(screen.getByLabelText('Section heading'), {
+        target: { value: 'Top questions' },
+      })
+      // Dismissing another row refetches the inbox; the FAQ row comes back regenerated.
+      fireEvent.click(screen.getByRole('button', { name: 'Dismiss Duplicate meta title' }))
+      await screen.findByRole('checkbox', { name: /Deposit\?/ })
+      for (const name of [/Is it insured\?/, /Do you travel\?/, /Deposit\?/]) {
+        expect(screen.getByRole('checkbox', { name })).toHaveProperty('checked', true)
+      }
+      expect(screen.getByLabelText('Section heading')).toHaveProperty('value', 'Common questions')
+      expect(screen.getByText('3 of 3 questions will be added.')).toBeTruthy()
+    })
+
+    it('degrades when the cached section is unreadable: badge + signal, approve disabled', async () => {
+      fetchSeoProposals.mockImplementationOnce(async () =>
+        faqPayload(faqProposal({ section: null, grounding: null })),
+      )
+      render(<ProposalsTab planInfo={null} />)
+      await screen.findByText('FAQ section')
+      expect(screen.getByText(/Cited by chatgpt 14× in 28 days/)).toBeTruthy()
+      const rowApprove = screen.getByRole('button', {
+        name: 'Approve Page lacks an FAQ section',
+      })
+      expect(rowApprove).toHaveProperty('disabled', true)
+      expect(rowApprove.getAttribute('title')).toMatch(/could not be read/i)
+      expect(
+        document.getElementById(rowApprove.getAttribute('aria-describedby') ?? '')?.textContent,
+      ).toMatch(/could not be read/i)
+      fireEvent.click(
+        screen.getByRole('button', { name: 'Show changes for Page lacks an FAQ section' }),
+      )
+      // Once in the expanded body, once as the row button's sr-only description.
+      expect(screen.getAllByText(/could not be read/i)).toHaveLength(2)
+      expect(screen.queryByRole('checkbox', { name: /Warranty\?/ })).toBeNull()
+      expect(screen.queryByRole('button', { name: /^Approve$/ })).toBeNull()
+    })
+
+    it('surfaces a server error and re-enables the controls', async () => {
+      fetchSeoProposals.mockImplementationOnce(async () => faqPayload())
+      applySeoIssueFix.mockResolvedValueOnce({ error: 'Fix suggestion is stale.' })
+      render(<ProposalsTab planInfo={null} />)
+      await screen.findByText('FAQ section')
+      fireEvent.click(screen.getByRole('button', { name: 'Approve Page lacks an FAQ section' }))
+      await waitFor(() => expect(toast.error).toHaveBeenCalledWith('Fix suggestion is stale.'))
+      await waitFor(() =>
+        expect(
+          screen.getByRole('button', { name: 'Approve Page lacks an FAQ section' }),
+        ).toHaveProperty('disabled', false),
+      )
+      expect(fetchSeoProposals).toHaveBeenCalledTimes(1)
+    })
+
+    it('issues a single request when approve is clicked twice while in flight', async () => {
+      // Persistent: the row must survive the post-approve refetch so the button can be re-read.
+      fetchSeoProposals.mockImplementation(async () => faqPayload())
+      const inflight = deferred<{ issue?: unknown; error?: string }>()
+      applySeoIssueFix.mockImplementationOnce(() => inflight.promise)
+      render(<ProposalsTab planInfo={null} />)
+      await screen.findByText('FAQ section')
+      const approve = screen.getByRole('button', { name: 'Approve Page lacks an FAQ section' })
+      fireEvent.click(approve)
+      fireEvent.click(approve)
+      await flushMicrotasks()
+      expect(applySeoIssueFix).toHaveBeenCalledTimes(1)
+      expect(approve).toHaveProperty('disabled', true)
+      expect(
+        screen.getByRole('button', { name: 'Dismiss Page lacks an FAQ section' }),
+      ).toHaveProperty('disabled', true)
+      inflight.resolve({})
+      await waitFor(() =>
+        expect(
+          screen.getByRole('button', { name: 'Approve Page lacks an FAQ section' }),
+        ).toHaveProperty('disabled', false),
+      )
+      expect(applySeoIssueFix).toHaveBeenCalledTimes(1)
+    })
+
+    it('bulk approve still sends the whole section through bulk-apply', async () => {
+      fetchSeoProposals.mockImplementationOnce(async () =>
+        payload({ proposals: [proposal(), faqProposal()] }),
+      )
+      render(<ProposalsTab planInfo={null} />)
+      await screen.findByText('FAQ section')
+      fireEvent.click(
+        screen.getByRole('button', { name: 'Show changes for Page lacks an FAQ section' }),
+      )
+      fireEvent.click(screen.getByRole('checkbox', { name: /Warranty\?/ }))
+      fireEvent.click(screen.getByLabelText('Select all proposals'))
+      fireEvent.click(screen.getByRole('button', { name: 'Approve selected' }))
+      fireEvent.click(await screen.findByRole('button', { name: 'Apply 2 proposals' }))
+      await waitFor(() =>
+        expect(bulkApplySeoProposals).toHaveBeenCalledWith([
+          { kind: 'issue-fix', id: 'i1', fingerprint: 'fp-1' },
+          { kind: 'issue-fix', id: 'faq1', fingerprint: 'fp-faq' },
+        ]),
+      )
+      expect(applySeoIssueFix).not.toHaveBeenCalled()
+    })
+  })
+
   it('hides Generate behind the plan callout when seo.inlineApply is off', async () => {
     render(<ProposalsTab planInfo={{ tier: 'starter', features: [], upgradeUrl: null }} />)
     await screen.findByText('Duplicate meta title')