@preference-sl/pref-viewer 2.17.2-beta.0 → 2.17.2-beta.1

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@preference-sl/pref-viewer",
-    "version": "2.17.2-beta.0",
+    "version": "2.17.2-beta.1",
     "description": "Web Component to preview GLTF models with Babylon.js",
     "author": "Alex Moreno Palacio <amoreno@preference.es>",
     "scripts": {

package/src/babylonjs-view-cube-renderer.js

@@ -168,7 +168,8 @@ export default class BabylonJSViewCubeRenderer {
     /**
      * Orients the cube like the host camera and follows its projection. An orthographic host gives an orthographic
      * cube (radius 5, extents +-1.15). A perspective host gives a perspective cube with the host's vertical fov at
-     * radius 1.15 / tan(fov / 2), so the cube keeps the same on-screen size.
+     * radius 0.5 + 1.15 / tan(fov / 2), so the near face and its corner knobs keep the on-screen size of the
+     * orthographic layout (the rest of the cube foreshortens behind it).
      * @param {{alpha: number, beta: number, mode?: number, fov?: number}} pose - Host camera angles in radians (beta is clamped away from the poles), projection mode (Camera.ORTHOGRAPHIC_CAMERA or Camera.PERSPECTIVE_CAMERA; absent keeps the last one) and vertical field of view in radians (absent or not a finite positive number keeps the last one, 0.8 initially).
      * @returns {void}
      */
@@ -393,13 +394,14 @@ export default class BabylonJSViewCubeRenderer {
         return best?.id ?? null;
     }
 
-    // Orthographic: fixed radius and extents. Perspective: the host fov and the radius that frames the same half extent.
+    // Orthographic: fixed radius and extents. Perspective: the host fov and the radius that frames the same half extent
+    // at the near face plane (CUBE_HALF in front of the centre), where the corner knobs and the face in view are drawn.
     #applyProjection(camera) {
         if (this.#mode === Camera.PERSPECTIVE_CAMERA) {
             camera.mode = Camera.PERSPECTIVE_CAMERA;
             camera.fovMode = Camera.FOVMODE_VERTICAL_FIXED;
             camera.fov = this.#fov;
-            camera.radius = ORTHO_EXTENT / Math.tan(this.#fov / 2);
+            camera.radius = CUBE_HALF + ORTHO_EXTENT / Math.tan(this.#fov / 2);
             // A wide fov brings the camera closer than the margin: keep the near plane positive and before the nearest corner.
             camera.minZ = Math.max(camera.radius - PERSPECTIVE_DEPTH_MARGIN, Math.min(0.1, (camera.radius - CORNER_DISTANCE) / 2));
             camera.maxZ = camera.radius + PERSPECTIVE_DEPTH_MARGIN;