@preference-sl/pref-viewer 2.13.0 → 2.13.1-beta.0

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@preference-sl/pref-viewer",
-    "version": "2.13.0",
+    "version": "2.13.1-beta.0",
     "description": "Web Component to preview GLTF models with Babylon.js",
     "author": "Alex Moreno Palacio <amoreno@preference.es>",
     "scripts": {

package/src/babylonjs-controller.js

@@ -1224,6 +1224,7 @@ export default class BabylonJSController {
      * @returns {void}
      */
     #setMaxSimultaneousLights() {
+        if (!this.#scene) return;
         let lightsNumber = 1; // At least one light coming from the environment texture contribution
         this.#scene.lights.forEach((light) => {
             if (light.isEnabled()) {
@@ -1917,6 +1918,12 @@ export default class BabylonJSController {
             container.assetContainer.dispose();
             container.assetContainer = null;
         }
+        if (!this.#scene) {
+            // Scene was disposed (disconnect) while async loading was in progress; discard the
+            // newly loaded container so we don't leak GPU resources and avoid the null-deref below.
+            newAssetContainer?.dispose();
+            return false;
+        }
         this.#scene.getEngine().releaseEffects();
         this.#scene.getEngine().releaseComputeEffects();
 
@@ -2004,6 +2011,7 @@ export default class BabylonJSController {
      * @returns {Promise<void>}
      */
     async #startRender() {
+        if (!this.#scene) return;
         await this.#loadCameraDependentEffects();
         await this.#scene.whenReadyAsync();
         const frames = this.#settings.antiAliasingEnabled || this.#settings.ambientOcclusionEnabled || this.#settings.iblEnabled ? this.#config.render.burstFramesEnhanced : this.#config.render.burstFramesBase;
@@ -2105,6 +2113,13 @@ export default class BabylonJSController {
 
         await Promise.allSettled(promiseArray)
             .then(async (values) => {
+                // Scene may have been disposed (disconnectedCallback) while async loading was in
+                // progress.  Abort cleanly: #replaceContainer already guards the GPU calls, but
+                // we skip the post-load option/visibility calls too to avoid further null-derefs.
+                if (!this.#scene) {
+                    values.forEach((result) => { result.value?.[1]?.dispose(); });
+                    return;
+                }
                 this.#disposeAnimationController();
                 values.forEach((result) => {
                     const container = result.value ? result.value[0] : null;