@preact/signals 1.1.3 → 1.1.4

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @preact/signals
 
+## 1.1.4
+
+### Patch Changes
+
+- [#373](https://github.com/preactjs/signals/pull/373) [`8c12a0d`](https://github.com/preactjs/signals/commit/8c12a0df74f00e9cab04e999fc443889b3528c04) Thanks [@rschristian](https://github.com/rschristian)! - Removes package.json#exports.umd, which had invalid paths if they were ever to be consumed
+
+- Updated dependencies [[`8c12a0d`](https://github.com/preactjs/signals/commit/8c12a0df74f00e9cab04e999fc443889b3528c04), [`26f6526`](https://github.com/preactjs/signals/commit/26f6526875ef0968621c4113594ac95b93de5163)]:
+  - @preact/signals-core@1.3.1
+
 ## 1.1.3
 
 ### Patch Changes

package/README.md

@@ -1,4 +1,3 @@
-
 # Signals
 
 Signals is a performant state management library with two primary goals:
@@ -15,15 +14,15 @@ npm install @preact/signals
 ```
 
 - [Guide / API](../../README.md#guide--api)
-	- [`signal(initialValue)`](../../README.md#signalinitialvalue)
-		- [`signal.peek()`](../../README.md#signalpeek)
-	- [`computed(fn)`](../../README.md#computedfn)
-	- [`effect(fn)`](../../README.md#effectfn)
-	- [`batch(fn)`](../../README.md#batchfn)
+  - [`signal(initialValue)`](../../README.md#signalinitialvalue)
+    - [`signal.peek()`](../../README.md#signalpeek)
+  - [`computed(fn)`](../../README.md#computedfn)
+  - [`effect(fn)`](../../README.md#effectfn)
+  - [`batch(fn)`](../../README.md#batchfn)
 - [Preact Integration](#preact-integration)
-	- [Hooks](#hooks)
-	- [Rendering optimizations](#rendering-optimizations)
-		- [Attribute optimization (experimental)](#attribute-optimization-experimental)
+  - [Hooks](#hooks)
+  - [Rendering optimizations](#rendering-optimizations)
+    - [Attribute optimization (experimental)](#attribute-optimization-experimental)
 - [License](#license)
 
 ## Preact Integration

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@preact/signals",
-  "version": "1.1.3",
+  "version": "1.1.4",
   "license": "MIT",
   "description": "Manage state with style in Preact",
   "keywords": [],
@@ -28,14 +28,13 @@
     ".": {
       "types": "./dist/signals.d.ts",
       "browser": "./dist/signals.module.js",
-      "umd": "./dist/signals.umd.js",
       "import": "./dist/signals.mjs",
       "require": "./dist/signals.js"
     }
   },
   "mangle": "../../mangle.json",
   "dependencies": {
-    "@preact/signals-core": "^1.2.3"
+    "@preact/signals-core": "^1.3.1"
   },
   "peerDependencies": {
     "preact": "10.x"

package/test/index.test.tsx

@@ -189,6 +189,70 @@ describe("@preact/signals", () => {
 			rerender();
 			expect(spy).to.be.calledOnce;
 		});
+
+		it("should not subscribe to computed signals only created and not used", () => {
+			const sig = signal(0);
+			const childSpy = sinon.spy();
+			const parentSpy = sinon.spy();
+
+			function Child({ num }: { num: Signal<number> }) {
+				childSpy();
+				return <p>{num.value}</p>;
+			}
+
+			function Parent({ num }: { num: Signal<number> }) {
+				parentSpy();
+				const sig2 = useComputed(() => num.value + 1);
+				return <Child num={sig2} />;
+			}
+
+			render(<Parent num={sig} />, scratch);
+			expect(scratch.innerHTML).to.equal("<p>1</p>");
+			expect(parentSpy).to.be.calledOnce;
+			expect(childSpy).to.be.calledOnce;
+
+			sig.value += 1;
+			rerender();
+			expect(scratch.innerHTML).to.equal("<p>2</p>");
+			expect(parentSpy).to.be.calledOnce;
+			expect(childSpy).to.be.calledTwice;
+		});
+
+		it("should properly subscribe and unsubscribe to conditionally rendered computed signals ", () => {
+			const computedDep = signal(0);
+			const renderComputed = signal(true);
+			const renderSpy = sinon.spy();
+			const computer = sinon.spy(() => computedDep.value + 1);
+
+			function App() {
+				renderSpy();
+				const computed = useComputed(computer);
+				return renderComputed.value ? <p>{computed.value}</p> : null;
+			}
+
+			render(<App />, scratch);
+			expect(scratch.innerHTML).to.equal("<p>1</p>");
+			expect(renderSpy).to.be.calledOnce;
+			expect(computer).to.be.calledOnce;
+
+			computedDep.value += 1;
+			rerender();
+			expect(scratch.innerHTML).to.equal("<p>2</p>");
+			expect(renderSpy).to.be.calledTwice;
+			expect(computer).to.be.calledTwice;
+
+			renderComputed.value = false;
+			rerender();
+			expect(scratch.innerHTML).to.equal("");
+			expect(renderSpy).to.be.calledThrice;
+			expect(computer).to.be.calledTwice;
+
+			computedDep.value += 1;
+			rerender();
+			expect(scratch.innerHTML).to.equal("");
+			expect(renderSpy).to.be.calledThrice; // Should not be called again
+			expect(computer).to.be.calledTwice; // Should not be called again
+		});
 	});
 
 	describe("prop bindings", () => {