@prave/cli 1.4.11 → 1.4.12

package/dist/lib/credentials.js

@@ -1,14 +1,39 @@
-import { chmod, mkdir, readFile, unlink, writeFile } from 'node:fs/promises';
+import { chmod, mkdir, readFile, rename, unlink, writeFile } from 'node:fs/promises';
 import { dirname } from 'node:path';
 import { CONFIG } from './config.js';
+/**
+ * Persist credentials atomically.
+ *
+ * The PostToolUse hook fires once per tool call, so two concurrent CLI
+ * processes refreshing the access token at the same second is the
+ * common case, not the edge. A plain `writeFile` then leaves the file
+ * in a partial / interleaved state for the brief window the bytes are
+ * being flushed — a concurrent `loadCredentials` reads that partial
+ * blob, `JSON.parse` throws, the catch swallows it and returns null,
+ * and the user is silently treated as logged out for every subsequent
+ * hook fire until they manually run `prave login` again.
+ *
+ * Writing to a sibling temp file and renaming over the target is
+ * atomic on POSIX (rename(2)) so readers either see the previous
+ * complete file or the new complete file — never a half-written one.
+ */
 export async function saveCredentials(creds) {
-    await mkdir(dirname(CONFIG.credentialsPath), { recursive: true });
-    await writeFile(CONFIG.credentialsPath, JSON.stringify(creds, null, 2), 'utf8');
-    await chmod(CONFIG.credentialsPath, 0o600);
+    const target = CONFIG.credentialsPath;
+    await mkdir(dirname(target), { recursive: true });
+    // Per-process tmp suffix so two parallel writers don't stomp each
+    // other's tmp file — the OS still serialises the final rename.
+    const tmp = `${target}.${process.pid}.${Date.now()}.tmp`;
+    await writeFile(tmp, JSON.stringify(creds, null, 2), 'utf8');
+    await chmod(tmp, 0o600);
+    await rename(tmp, target);
 }
 export async function loadCredentials() {
     try {
         const raw = await readFile(CONFIG.credentialsPath, 'utf8');
+        // Belt + suspenders: even with atomic writes, a credentials file
+        // can land truncated if a previous CLI version was killed mid-write
+        // or the FS had a power loss. Treat unparseable content as logged
+        // out instead of crashing — the next `prave login` repairs it.
         return JSON.parse(raw);
     }
     catch {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@prave/cli",
-  "version": "1.4.11",
+  "version": "1.4.12",
   "description": "Prave CLI — discover, install, version, test, and ship Claude Skills. The developer platform for the complete Skill lifecycle.",
   "type": "module",
   "keywords": [
@@ -54,7 +54,7 @@
     "ora": "^8.0.1",
     "tar": "^7.4.3",
     "undici": "^6.18.0",
-    "@prave/shared": "1.4.11"
+    "@prave/shared": "1.4.12"
   },
   "devDependencies": {
     "@types/node": "^20.12.7",
@@ -71,6 +71,6 @@
     "build": "tsc -p tsconfig.json && node scripts/inject-config.mjs",
     "typecheck": "tsc -p tsconfig.json --noEmit",
     "lint": "tsc -p tsconfig.json --noEmit",
-    "postinstall": "node scripts/postinstall.mjs || true"
+    "postinstall": "test -f scripts/postinstall.mjs && node scripts/postinstall.mjs || true"
   }
 }