@prairielearn/eslint-plugin 2.0.9 → 2.1.0

package/.mocharc.cjs

@@ -0,0 +1,3 @@
+module.exports = {
+  require: ['tsx'],
+};

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @prairielearn/eslint-plugin
 
+## 2.1.0
+
+### Minor Changes
+
+- 284df1c: Introduce `jsx-no-dollar-interpolation` rule
+
 ## 2.0.9
 
 ### Patch Changes

package/dist/index.d.ts

@@ -1,14 +1,5 @@
 export declare const rules: {
-    'aws-client-mandatory-config': {
-        create(context: any): {
-            ImportDeclaration(node: any): void;
-            NewExpression(node: any): void;
-        };
-    };
-    'aws-client-shared-config': {
-        create(context: any): {
-            ImportDeclaration(node: any): void;
-            NewExpression(node: any): void;
-        };
-    };
+    'aws-client-mandatory-config': import("@typescript-eslint/utils/ts-eslint").RuleModule<"missingConfig", [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'aws-client-shared-config': import("@typescript-eslint/utils/ts-eslint").RuleModule<"improperConfig" | "unknownConfig", [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'jsx-no-dollar-interpolation': import("@typescript-eslint/utils/ts-eslint").RuleModule<"dollarInterpolationNotAllowed", [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
 };

package/dist/index.js

@@ -3,8 +3,10 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.rules = void 0;
 const aws_client_mandatory_config_js_1 = require("./rules/aws-client-mandatory-config.js");
 const aws_client_shared_config_js_1 = require("./rules/aws-client-shared-config.js");
+const jsx_no_dollar_interpolation_js_1 = require("./rules/jsx-no-dollar-interpolation.js");
 exports.rules = {
     'aws-client-mandatory-config': aws_client_mandatory_config_js_1.default,
     'aws-client-shared-config': aws_client_shared_config_js_1.default,
+    'jsx-no-dollar-interpolation': jsx_no_dollar_interpolation_js_1.default,
 };
 //# sourceMappingURL=index.js.map

package/dist/index.js.map

@@ -1 +1 @@
-{"version":3,"file":"index.js","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":";;;AAAA,2FAA8E;AAC9E,qFAAwE;AAE3D,QAAA,KAAK,GAAG;IACnB,6BAA6B,EAAE,wCAAwB;IACvD,0BAA0B,EAAE,qCAAqB;CAClD,CAAC","sourcesContent":["import awsClientMandatoryConfig from './rules/aws-client-mandatory-config.js';\nimport awsClientSharedConfig from './rules/aws-client-shared-config.js';\n\nexport const rules = {\n  'aws-client-mandatory-config': awsClientMandatoryConfig,\n  'aws-client-shared-config': awsClientSharedConfig,\n};\n"]}
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":";;;AAAA,2FAA8E;AAC9E,qFAAwE;AACxE,2FAA8E;AAEjE,QAAA,KAAK,GAAG;IACnB,6BAA6B,EAAE,wCAAwB;IACvD,0BAA0B,EAAE,qCAAqB;IACjD,6BAA6B,EAAE,wCAAwB;CACxD,CAAC","sourcesContent":["import awsClientMandatoryConfig from './rules/aws-client-mandatory-config.js';\nimport awsClientSharedConfig from './rules/aws-client-shared-config.js';\nimport jsxNoDollarInterpolation from './rules/jsx-no-dollar-interpolation.js';\n\nexport const rules = {\n  'aws-client-mandatory-config': awsClientMandatoryConfig,\n  'aws-client-shared-config': awsClientSharedConfig,\n  'jsx-no-dollar-interpolation': jsxNoDollarInterpolation,\n};\n"]}

package/dist/rules/aws-client-mandatory-config.d.ts

@@ -1,3 +1,4 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
 /**
  * This rule enforces that we always explicitly provide a config to AWS clients.
  * This helps ensure that we always construct a client with a specific region.
@@ -5,10 +6,5 @@
  * This rules works in tandem with `aws-client-shared-config` to ensure that
  * we're properly configuring AWS SDK clients.
  */
-declare const _default: {
-    create(context: any): {
-        ImportDeclaration(node: any): void;
-        NewExpression(node: any): void;
-    };
-};
+declare const _default: ESLintUtils.RuleModule<"missingConfig", [], unknown, ESLintUtils.RuleListener>;
 export default _default;

package/dist/rules/aws-client-mandatory-config.js

@@ -1,5 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+const utils_1 = require("@typescript-eslint/utils");
 const utils_js_1 = require("../utils.js");
 /**
  * This rule enforces that we always explicitly provide a config to AWS clients.
@@ -8,7 +9,15 @@ const utils_js_1 = require("../utils.js");
  * This rules works in tandem with `aws-client-shared-config` to ensure that
  * we're properly configuring AWS SDK clients.
  */
-exports.default = {
+exports.default = utils_1.ESLintUtils.RuleCreator.withoutDocs({
+    meta: {
+        type: 'problem',
+        messages: {
+            missingConfig: '{{clientName}} must be constructed with a config object.',
+        },
+        schema: [],
+    },
+    defaultOptions: [],
     create(context) {
         const awsClientImports = new Set();
         return {
@@ -24,7 +33,10 @@ exports.default = {
                     if (node.arguments.length === 0) {
                         context.report({
                             node,
-                            message: `${node.callee.name} must be constructed with a config object.`,
+                            messageId: 'missingConfig',
+                            data: {
+                                clientName: node.callee.name,
+                            },
                         });
                         return;
                     }
@@ -32,5 +44,5 @@ exports.default = {
             },
         };
     },
-};
+});
 //# sourceMappingURL=aws-client-mandatory-config.js.map

package/dist/rules/aws-client-mandatory-config.js.map

@@ -1 +1 @@
-{"version":3,"file":"aws-client-mandatory-config.js","sourceRoot":"","sources":["../../src/rules/aws-client-mandatory-config.ts"],"names":[],"mappings":";;AAAA,0CAAqE;AAErE;;;;;;GAMG;AACH,kBAAe;IACb,MAAM,CAAC,OAAY;QACjB,MAAM,gBAAgB,GAAG,IAAI,GAAG,EAAE,CAAC;QAEnC,OAAO;YACL,iCAAiC;YACjC,iBAAiB,CAAC,IAAS;gBACzB,MAAM,WAAW,GAAG,IAAA,iDAAsC,EAAC,IAAI,CAAC,CAAC;gBACjE,WAAW,CAAC,OAAO,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,gBAAgB,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC,CAAC;YACxE,CAAC;YACD,aAAa,CAAC,IAAS;gBACrB,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY,IAAI,gBAAgB,CAAC,GAAG,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC;oBAChF,gEAAgE;oBAChE,uDAAuD;oBACvD,IAAI,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;wBAChC,OAAO,CAAC,MAAM,CAAC;4BACb,IAAI;4BACJ,OAAO,EAAE,GAAG,IAAI,CAAC,MAAM,CAAC,IAAI,4CAA4C;yBACzE,CAAC,CAAC;wBACH,OAAO;oBACT,CAAC;gBACH,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC","sourcesContent":["import { getAwsClientNamesFromImportDeclaration } from '../utils.js';\n\n/**\n * This rule enforces that we always explicitly provide a config to AWS clients.\n * This helps ensure that we always construct a client with a specific region.\n *\n * This rules works in tandem with `aws-client-shared-config` to ensure that\n * we're properly configuring AWS SDK clients.\n */\nexport default {\n  create(context: any) {\n    const awsClientImports = new Set();\n\n    return {\n      // Handle `import ...` statements\n      ImportDeclaration(node: any) {\n        const clientNames = getAwsClientNamesFromImportDeclaration(node);\n        clientNames.forEach((clientName) => awsClientImports.add(clientName));\n      },\n      NewExpression(node: any) {\n        if (node.callee.type === 'Identifier' && awsClientImports.has(node.callee.name)) {\n          // We're constructing an AWS client. Ensure that the call has at\n          // least one argument corresponding to a config object.\n          if (node.arguments.length === 0) {\n            context.report({\n              node,\n              message: `${node.callee.name} must be constructed with a config object.`,\n            });\n            return;\n          }\n        }\n      },\n    };\n  },\n};\n"]}
+{"version":3,"file":"aws-client-mandatory-config.js","sourceRoot":"","sources":["../../src/rules/aws-client-mandatory-config.ts"],"names":[],"mappings":";;AAAA,oDAAuD;AAEvD,0CAAqE;AAErE;;;;;;GAMG;AACH,kBAAe,mBAAW,CAAC,WAAW,CAAC,WAAW,CAAC;IACjD,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,QAAQ,EAAE;YACR,aAAa,EAAE,0DAA0D;SAC1E;QACD,MAAM,EAAE,EAAE;KACX;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,CAAC,OAAO;QACZ,MAAM,gBAAgB,GAAG,IAAI,GAAG,EAAE,CAAC;QAEnC,OAAO;YACL,iCAAiC;YACjC,iBAAiB,CAAC,IAAI;gBACpB,MAAM,WAAW,GAAG,IAAA,iDAAsC,EAAC,IAAI,CAAC,CAAC;gBACjE,WAAW,CAAC,OAAO,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,gBAAgB,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC,CAAC;YACxE,CAAC;YACD,aAAa,CAAC,IAAI;gBAChB,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY,IAAI,gBAAgB,CAAC,GAAG,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC;oBAChF,gEAAgE;oBAChE,uDAAuD;oBACvD,IAAI,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;wBAChC,OAAO,CAAC,MAAM,CAAC;4BACb,IAAI;4BACJ,SAAS,EAAE,eAAe;4BAC1B,IAAI,EAAE;gCACJ,UAAU,EAAE,IAAI,CAAC,MAAM,CAAC,IAAI;6BAC7B;yBACF,CAAC,CAAC;wBACH,OAAO;oBACT,CAAC;gBACH,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import { ESLintUtils } from '@typescript-eslint/utils';\n\nimport { getAwsClientNamesFromImportDeclaration } from '../utils.js';\n\n/**\n * This rule enforces that we always explicitly provide a config to AWS clients.\n * This helps ensure that we always construct a client with a specific region.\n *\n * This rules works in tandem with `aws-client-shared-config` to ensure that\n * we're properly configuring AWS SDK clients.\n */\nexport default ESLintUtils.RuleCreator.withoutDocs({\n  meta: {\n    type: 'problem',\n    messages: {\n      missingConfig: '{{clientName}} must be constructed with a config object.',\n    },\n    schema: [],\n  },\n  defaultOptions: [],\n  create(context) {\n    const awsClientImports = new Set();\n\n    return {\n      // Handle `import ...` statements\n      ImportDeclaration(node) {\n        const clientNames = getAwsClientNamesFromImportDeclaration(node);\n        clientNames.forEach((clientName) => awsClientImports.add(clientName));\n      },\n      NewExpression(node) {\n        if (node.callee.type === 'Identifier' && awsClientImports.has(node.callee.name)) {\n          // We're constructing an AWS client. Ensure that the call has at\n          // least one argument corresponding to a config object.\n          if (node.arguments.length === 0) {\n            context.report({\n              node,\n              messageId: 'missingConfig',\n              data: {\n                clientName: node.callee.name,\n              },\n            });\n            return;\n          }\n        }\n      },\n    };\n  },\n});\n"]}

package/dist/rules/aws-client-shared-config.d.ts

@@ -1,3 +1,4 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
 /**
  * This ESLint rules enforces that we always provide a "shared" config to AWS
  * clients.
@@ -16,10 +17,5 @@
  * This rules works in tandem with `aws-client-mandatory-config` to ensure that
  * we're properly configuring AWS SDK clients.
  */
-declare const _default: {
-    create(context: any): {
-        ImportDeclaration(node: any): void;
-        NewExpression(node: any): void;
-    };
-};
+declare const _default: ESLintUtils.RuleModule<"improperConfig" | "unknownConfig", [], unknown, ESLintUtils.RuleListener>;
 export default _default;

package/dist/rules/aws-client-shared-config.js

@@ -1,5 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+const utils_1 = require("@typescript-eslint/utils");
 const utils_js_1 = require("../utils.js");
 /**
  * This ESLint rules enforces that we always provide a "shared" config to AWS
@@ -19,7 +20,16 @@ const utils_js_1 = require("../utils.js");
  * This rules works in tandem with `aws-client-mandatory-config` to ensure that
  * we're properly configuring AWS SDK clients.
  */
-exports.default = {
+exports.default = utils_1.ESLintUtils.RuleCreator.withoutDocs({
+    meta: {
+        type: 'problem',
+        messages: {
+            improperConfig: 'Config for {{clientName}} must be obtained by calling {{desiredConfigFunctionName}}().',
+            unknownConfig: 'Unknown config provided to AWS client.',
+        },
+        schema: [],
+    },
+    defaultOptions: [],
     create(context) {
         const awsClientImports = new Set();
         return {
@@ -46,17 +56,26 @@ exports.default = {
                     if (configArgument.type !== 'CallExpression') {
                         context.report({
                             node,
-                            message: `Config for ${node.callee.name} must be obtained by calling ${desiredConfigFunctionName}().`,
+                            messageId: 'improperConfig',
+                            data: {
+                                clientName: node.callee.name,
+                                desiredConfigFunctionName,
+                            },
                         });
                         return;
                     }
                     // Handle member calls to the function.
-                    if (configArgument.callee.type === 'MemberExpression') {
+                    if (configArgument.callee.type === 'MemberExpression' &&
+                        configArgument.callee.property.type === 'Identifier') {
                         const functionName = configArgument.callee.property.name;
                         if (functionName !== desiredConfigFunctionName) {
                             context.report({
                                 node,
-                                message: `Config for ${node.callee.name} must be obtained by calling ${desiredConfigFunctionName}().`,
+                                messageId: 'improperConfig',
+                                data: {
+                                    clientName: node.callee.name,
+                                    desiredConfigFunctionName,
+                                },
                             });
                         }
                         return;
@@ -66,18 +85,22 @@ exports.default = {
                         if (functionName !== desiredConfigFunctionName) {
                             context.report({
                                 node,
-                                message: `Config for ${node.callee.name} must be obtained by calling ${desiredConfigFunctionName}().`,
+                                messageId: 'improperConfig',
+                                data: {
+                                    clientName: node.callee.name,
+                                    desiredConfigFunctionName,
+                                },
                             });
                         }
                         return;
                     }
                     context.report({
                         node,
-                        message: 'Unknown config provided to AWS client.',
+                        messageId: 'unknownConfig',
                     });
                 }
             },
         };
     },
-};
+});
 //# sourceMappingURL=aws-client-shared-config.js.map

package/dist/rules/aws-client-shared-config.js.map

@@ -1 +1 @@
-{"version":3,"file":"aws-client-shared-config.js","sourceRoot":"","sources":["../../src/rules/aws-client-shared-config.ts"],"names":[],"mappings":";;AAAA,0CAAqE;AAErE;;;;;;;;;;;;;;;;;GAiBG;AACH,kBAAe;IACb,MAAM,CAAC,OAAY;QACjB,MAAM,gBAAgB,GAAG,IAAI,GAAG,EAAU,CAAC;QAE3C,OAAO;YACL,iCAAiC;YACjC,iBAAiB,CAAC,IAAS;gBACzB,MAAM,WAAW,GAAG,IAAA,iDAAsC,EAAC,IAAI,CAAC,CAAC;gBACjE,WAAW,CAAC,OAAO,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,gBAAgB,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC,CAAC;YACxE,CAAC;YACD,aAAa,CAAC,IAAS;gBACrB,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY,IAAI,gBAAgB,CAAC,GAAG,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC;oBAChF,mEAAmE;oBACnE,0CAA0C;oBAE1C,IAAI,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;wBAChC,sEAAsE;wBACtE,4CAA4C;wBAC5C,OAAO;oBACT,CAAC;oBAED,IAAI,yBAAyB,GAAG,qBAAqB,CAAC;oBAEtD,2BAA2B;oBAC3B,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,UAAU,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,IAAI,EAAE,CAAC;wBACjE,yBAAyB,GAAG,oBAAoB,CAAC;oBACnD,CAAC;oBAED,MAAM,cAAc,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;oBACzC,IAAI,cAAc,CAAC,IAAI,KAAK,gBAAgB,EAAE,CAAC;wBAC7C,OAAO,CAAC,MAAM,CAAC;4BACb,IAAI;4BACJ,OAAO,EAAE,cAAc,IAAI,CAAC,MAAM,CAAC,IAAI,gCAAgC,yBAAyB,KAAK;yBACtG,CAAC,CAAC;wBACH,OAAO;oBACT,CAAC;oBAED,uCAAuC;oBACvC,IAAI,cAAc,CAAC,MAAM,CAAC,IAAI,KAAK,kBAAkB,EAAE,CAAC;wBACtD,MAAM,YAAY,GAAG,cAAc,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC;wBACzD,IAAI,YAAY,KAAK,yBAAyB,EAAE,CAAC;4BAC/C,OAAO,CAAC,MAAM,CAAC;gCACb,IAAI;gCACJ,OAAO,EAAE,cAAc,IAAI,CAAC,MAAM,CAAC,IAAI,gCAAgC,yBAAyB,KAAK;6BACtG,CAAC,CAAC;wBACL,CAAC;wBACD,OAAO;oBACT,CAAC;oBAED,IAAI,cAAc,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY,EAAE,CAAC;wBAChD,MAAM,YAAY,GAAG,cAAc,CAAC,MAAM,CAAC,IAAI,CAAC;wBAChD,IAAI,YAAY,KAAK,yBAAyB,EAAE,CAAC;4BAC/C,OAAO,CAAC,MAAM,CAAC;gCACb,IAAI;gCACJ,OAAO,EAAE,cAAc,IAAI,CAAC,MAAM,CAAC,IAAI,gCAAgC,yBAAyB,KAAK;6BACtG,CAAC,CAAC;wBACL,CAAC;wBACD,OAAO;oBACT,CAAC;oBAED,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI;wBACJ,OAAO,EAAE,wCAAwC;qBAClD,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC","sourcesContent":["import { getAwsClientNamesFromImportDeclaration } from '../utils.js';\n\n/**\n * This ESLint rules enforces that we always provide a \"shared\" config to AWS\n * clients.\n *\n * This rule is extremely opinionated: it checks that the first argument to an\n * AWS client constructor consists of a function call to a function named\n * `makeAwsClientConfig()` (or `makeS3ClientConfig()` for S3 clients). This\n * is our convention to ensure that all clients will reuse credential providers,\n * which is important for ensuring that we don't overload IMDS with requests\n * for credentials if we construct a lot of clients in rapid succession.\n *\n * This is perhaps less than ideal, but the risk of misconfiguring a client is\n * high enough that we err towards being extremely prescriptive about how we\n * configure them.\n *\n * This rules works in tandem with `aws-client-mandatory-config` to ensure that\n * we're properly configuring AWS SDK clients.\n */\nexport default {\n  create(context: any) {\n    const awsClientImports = new Set<string>();\n\n    return {\n      // Handle `import ...` statements\n      ImportDeclaration(node: any) {\n        const clientNames = getAwsClientNamesFromImportDeclaration(node);\n        clientNames.forEach((clientName) => awsClientImports.add(clientName));\n      },\n      NewExpression(node: any) {\n        if (node.callee.type === 'Identifier' && awsClientImports.has(node.callee.name)) {\n          // We're constructing an AWS client. Ensure that the first argument\n          // comes from one of our config providers.\n\n          if (node.arguments.length === 0) {\n            // There is no argument to check. If the `aws-client-mandatory-config`\n            // rule is enabled, it will catch this case.\n            return;\n          }\n\n          let desiredConfigFunctionName = 'makeAwsClientConfig';\n\n          // Special-case: S3 client.\n          if (node.callee.name === 'S3Client' || node.callee.name === 'S3') {\n            desiredConfigFunctionName = 'makeS3ClientConfig';\n          }\n\n          const configArgument = node.arguments[0];\n          if (configArgument.type !== 'CallExpression') {\n            context.report({\n              node,\n              message: `Config for ${node.callee.name} must be obtained by calling ${desiredConfigFunctionName}().`,\n            });\n            return;\n          }\n\n          // Handle member calls to the function.\n          if (configArgument.callee.type === 'MemberExpression') {\n            const functionName = configArgument.callee.property.name;\n            if (functionName !== desiredConfigFunctionName) {\n              context.report({\n                node,\n                message: `Config for ${node.callee.name} must be obtained by calling ${desiredConfigFunctionName}().`,\n              });\n            }\n            return;\n          }\n\n          if (configArgument.callee.type === 'Identifier') {\n            const functionName = configArgument.callee.name;\n            if (functionName !== desiredConfigFunctionName) {\n              context.report({\n                node,\n                message: `Config for ${node.callee.name} must be obtained by calling ${desiredConfigFunctionName}().`,\n              });\n            }\n            return;\n          }\n\n          context.report({\n            node,\n            message: 'Unknown config provided to AWS client.',\n          });\n        }\n      },\n    };\n  },\n};\n"]}
+{"version":3,"file":"aws-client-shared-config.js","sourceRoot":"","sources":["../../src/rules/aws-client-shared-config.ts"],"names":[],"mappings":";;AAAA,oDAAuD;AAEvD,0CAAqE;AAErE;;;;;;;;;;;;;;;;;GAiBG;AACH,kBAAe,mBAAW,CAAC,WAAW,CAAC,WAAW,CAAC;IACjD,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,QAAQ,EAAE;YACR,cAAc,EACZ,wFAAwF;YAC1F,aAAa,EAAE,wCAAwC;SACxD;QACD,MAAM,EAAE,EAAE;KACX;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,CAAC,OAAO;QACZ,MAAM,gBAAgB,GAAG,IAAI,GAAG,EAAU,CAAC;QAE3C,OAAO;YACL,iCAAiC;YACjC,iBAAiB,CAAC,IAAI;gBACpB,MAAM,WAAW,GAAG,IAAA,iDAAsC,EAAC,IAAI,CAAC,CAAC;gBACjE,WAAW,CAAC,OAAO,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,gBAAgB,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC,CAAC;YACxE,CAAC;YACD,aAAa,CAAC,IAAI;gBAChB,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY,IAAI,gBAAgB,CAAC,GAAG,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC;oBAChF,mEAAmE;oBACnE,0CAA0C;oBAE1C,IAAI,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;wBAChC,sEAAsE;wBACtE,4CAA4C;wBAC5C,OAAO;oBACT,CAAC;oBAED,IAAI,yBAAyB,GAAG,qBAAqB,CAAC;oBAEtD,2BAA2B;oBAC3B,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,UAAU,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,IAAI,EAAE,CAAC;wBACjE,yBAAyB,GAAG,oBAAoB,CAAC;oBACnD,CAAC;oBAED,MAAM,cAAc,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;oBACzC,IAAI,cAAc,CAAC,IAAI,KAAK,gBAAgB,EAAE,CAAC;wBAC7C,OAAO,CAAC,MAAM,CAAC;4BACb,IAAI;4BACJ,SAAS,EAAE,gBAAgB;4BAC3B,IAAI,EAAE;gCACJ,UAAU,EAAE,IAAI,CAAC,MAAM,CAAC,IAAI;gCAC5B,yBAAyB;6BAC1B;yBACF,CAAC,CAAC;wBACH,OAAO;oBACT,CAAC;oBAED,uCAAuC;oBACvC,IACE,cAAc,CAAC,MAAM,CAAC,IAAI,KAAK,kBAAkB;wBACjD,cAAc,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY,EACpD,CAAC;wBACD,MAAM,YAAY,GAAG,cAAc,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC;wBACzD,IAAI,YAAY,KAAK,yBAAyB,EAAE,CAAC;4BAC/C,OAAO,CAAC,MAAM,CAAC;gCACb,IAAI;gCACJ,SAAS,EAAE,gBAAgB;gCAC3B,IAAI,EAAE;oCACJ,UAAU,EAAE,IAAI,CAAC,MAAM,CAAC,IAAI;oCAC5B,yBAAyB;iCAC1B;6BACF,CAAC,CAAC;wBACL,CAAC;wBACD,OAAO;oBACT,CAAC;oBAED,IAAI,cAAc,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY,EAAE,CAAC;wBAChD,MAAM,YAAY,GAAG,cAAc,CAAC,MAAM,CAAC,IAAI,CAAC;wBAChD,IAAI,YAAY,KAAK,yBAAyB,EAAE,CAAC;4BAC/C,OAAO,CAAC,MAAM,CAAC;gCACb,IAAI;gCACJ,SAAS,EAAE,gBAAgB;gCAC3B,IAAI,EAAE;oCACJ,UAAU,EAAE,IAAI,CAAC,MAAM,CAAC,IAAI;oCAC5B,yBAAyB;iCAC1B;6BACF,CAAC,CAAC;wBACL,CAAC;wBACD,OAAO;oBACT,CAAC;oBAED,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI;wBACJ,SAAS,EAAE,eAAe;qBAC3B,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import { ESLintUtils } from '@typescript-eslint/utils';\n\nimport { getAwsClientNamesFromImportDeclaration } from '../utils.js';\n\n/**\n * This ESLint rules enforces that we always provide a \"shared\" config to AWS\n * clients.\n *\n * This rule is extremely opinionated: it checks that the first argument to an\n * AWS client constructor consists of a function call to a function named\n * `makeAwsClientConfig()` (or `makeS3ClientConfig()` for S3 clients). This\n * is our convention to ensure that all clients will reuse credential providers,\n * which is important for ensuring that we don't overload IMDS with requests\n * for credentials if we construct a lot of clients in rapid succession.\n *\n * This is perhaps less than ideal, but the risk of misconfiguring a client is\n * high enough that we err towards being extremely prescriptive about how we\n * configure them.\n *\n * This rules works in tandem with `aws-client-mandatory-config` to ensure that\n * we're properly configuring AWS SDK clients.\n */\nexport default ESLintUtils.RuleCreator.withoutDocs({\n  meta: {\n    type: 'problem',\n    messages: {\n      improperConfig:\n        'Config for {{clientName}} must be obtained by calling {{desiredConfigFunctionName}}().',\n      unknownConfig: 'Unknown config provided to AWS client.',\n    },\n    schema: [],\n  },\n  defaultOptions: [],\n  create(context) {\n    const awsClientImports = new Set<string>();\n\n    return {\n      // Handle `import ...` statements\n      ImportDeclaration(node) {\n        const clientNames = getAwsClientNamesFromImportDeclaration(node);\n        clientNames.forEach((clientName) => awsClientImports.add(clientName));\n      },\n      NewExpression(node) {\n        if (node.callee.type === 'Identifier' && awsClientImports.has(node.callee.name)) {\n          // We're constructing an AWS client. Ensure that the first argument\n          // comes from one of our config providers.\n\n          if (node.arguments.length === 0) {\n            // There is no argument to check. If the `aws-client-mandatory-config`\n            // rule is enabled, it will catch this case.\n            return;\n          }\n\n          let desiredConfigFunctionName = 'makeAwsClientConfig';\n\n          // Special-case: S3 client.\n          if (node.callee.name === 'S3Client' || node.callee.name === 'S3') {\n            desiredConfigFunctionName = 'makeS3ClientConfig';\n          }\n\n          const configArgument = node.arguments[0];\n          if (configArgument.type !== 'CallExpression') {\n            context.report({\n              node,\n              messageId: 'improperConfig',\n              data: {\n                clientName: node.callee.name,\n                desiredConfigFunctionName,\n              },\n            });\n            return;\n          }\n\n          // Handle member calls to the function.\n          if (\n            configArgument.callee.type === 'MemberExpression' &&\n            configArgument.callee.property.type === 'Identifier'\n          ) {\n            const functionName = configArgument.callee.property.name;\n            if (functionName !== desiredConfigFunctionName) {\n              context.report({\n                node,\n                messageId: 'improperConfig',\n                data: {\n                  clientName: node.callee.name,\n                  desiredConfigFunctionName,\n                },\n              });\n            }\n            return;\n          }\n\n          if (configArgument.callee.type === 'Identifier') {\n            const functionName = configArgument.callee.name;\n            if (functionName !== desiredConfigFunctionName) {\n              context.report({\n                node,\n                messageId: 'improperConfig',\n                data: {\n                  clientName: node.callee.name,\n                  desiredConfigFunctionName,\n                },\n              });\n            }\n            return;\n          }\n\n          context.report({\n            node,\n            messageId: 'unknownConfig',\n          });\n        }\n      },\n    };\n  },\n});\n"]}

package/dist/rules/jsx-no-dollar-interpolation.d.ts

@@ -0,0 +1,13 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+/**
+ * This rule will report things that look like template string interpolations
+ * that were improperly converted to JSX. For example, the following code will
+ * trigger an error:
+ *
+ * ```tsx
+ * const a = <div>${message}</div>;
+ * const b = <div>$ {message}</div>;
+ * ```
+ */
+declare const _default: ESLintUtils.RuleModule<"dollarInterpolationNotAllowed", [], unknown, ESLintUtils.RuleListener>;
+export default _default;

package/dist/rules/jsx-no-dollar-interpolation.js

@@ -0,0 +1,60 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const utils_1 = require("@typescript-eslint/utils");
+/**
+ * This rule will report things that look like template string interpolations
+ * that were improperly converted to JSX. For example, the following code will
+ * trigger an error:
+ *
+ * ```tsx
+ * const a = <div>${message}</div>;
+ * const b = <div>$ {message}</div>;
+ * ```
+ */
+exports.default = utils_1.ESLintUtils.RuleCreator.withoutDocs({
+    meta: {
+        type: 'problem',
+        messages: {
+            dollarInterpolationNotAllowed: 'Interpolation with a dollar sign is not allowed in JSX.',
+        },
+        schema: [],
+    },
+    defaultOptions: [],
+    create(context) {
+        return {
+            JSXElement(node) {
+                node.children.forEach((child, index) => {
+                    // Skip the first child since it can't be preceded by a JSXText node.
+                    if (index === 0)
+                        return;
+                    // Skip anything that's not a JSXExpressionContainer.
+                    if (child.type !== 'JSXExpressionContainer')
+                        return;
+                    const previousChild = node.children[index - 1];
+                    // Skip nodes that aren't preceded by a JSXText node.
+                    if (previousChild.type !== 'JSXText')
+                        return;
+                    // Skip nodes that aren't preceded by a dollar sign.
+                    if (!previousChild.value.trimEnd().endsWith('$'))
+                        return;
+                    // Determine the range of characters that should be reported. We
+                    // include the dollar sign, any following whitespace, and the
+                    // expression container.
+                    const start = context.sourceCode.getIndexFromLoc(previousChild.loc.start);
+                    const lastIndex = previousChild.value.lastIndexOf('$');
+                    const dollarStart = start + lastIndex;
+                    const dollarStartLoc = context.sourceCode.getLocFromIndex(dollarStart);
+                    context.report({
+                        node,
+                        loc: {
+                            start: dollarStartLoc,
+                            end: child.loc.end,
+                        },
+                        messageId: 'dollarInterpolationNotAllowed',
+                    });
+                });
+            },
+        };
+    },
+});
+//# sourceMappingURL=jsx-no-dollar-interpolation.js.map

package/dist/rules/jsx-no-dollar-interpolation.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"jsx-no-dollar-interpolation.js","sourceRoot":"","sources":["../../src/rules/jsx-no-dollar-interpolation.ts"],"names":[],"mappings":";;AAAA,oDAAuD;AAEvD;;;;;;;;;GASG;AACH,kBAAe,mBAAW,CAAC,WAAW,CAAC,WAAW,CAAC;IACjD,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,QAAQ,EAAE;YACR,6BAA6B,EAAE,yDAAyD;SACzF;QACD,MAAM,EAAE,EAAE;KACX;IACD,cAAc,EAAE,EAAE;IAElB,MAAM,CAAC,OAAO;QACZ,OAAO;YACL,UAAU,CAAC,IAAI;gBACb,IAAI,CAAC,QAAQ,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,KAAK,EAAE,EAAE;oBACrC,qEAAqE;oBACrE,IAAI,KAAK,KAAK,CAAC;wBAAE,OAAO;oBAExB,qDAAqD;oBACrD,IAAI,KAAK,CAAC,IAAI,KAAK,wBAAwB;wBAAE,OAAO;oBAEpD,MAAM,aAAa,GAAG,IAAI,CAAC,QAAQ,CAAC,KAAK,GAAG,CAAC,CAAC,CAAC;oBAE/C,qDAAqD;oBACrD,IAAI,aAAa,CAAC,IAAI,KAAK,SAAS;wBAAE,OAAO;oBAE7C,oDAAoD;oBACpD,IAAI,CAAC,aAAa,CAAC,KAAK,CAAC,OAAO,EAAE,CAAC,QAAQ,CAAC,GAAG,CAAC;wBAAE,OAAO;oBAEzD,gEAAgE;oBAChE,6DAA6D;oBAC7D,wBAAwB;oBACxB,MAAM,KAAK,GAAG,OAAO,CAAC,UAAU,CAAC,eAAe,CAAC,aAAa,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC;oBAC1E,MAAM,SAAS,GAAG,aAAa,CAAC,KAAK,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC;oBACvD,MAAM,WAAW,GAAG,KAAK,GAAG,SAAS,CAAC;oBACtC,MAAM,cAAc,GAAG,OAAO,CAAC,UAAU,CAAC,eAAe,CAAC,WAAW,CAAC,CAAC;oBAEvE,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI;wBACJ,GAAG,EAAE;4BACH,KAAK,EAAE,cAAc;4BACrB,GAAG,EAAE,KAAK,CAAC,GAAG,CAAC,GAAG;yBACnB;wBACD,SAAS,EAAE,+BAA+B;qBAC3C,CAAC,CAAC;gBACL,CAAC,CAAC,CAAC;YACL,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import { ESLintUtils } from '@typescript-eslint/utils';\n\n/**\n * This rule will report things that look like template string interpolations\n * that were improperly converted to JSX. For example, the following code will\n * trigger an error:\n *\n * ```tsx\n * const a = <div>${message}</div>;\n * const b = <div>$ {message}</div>;\n * ```\n */\nexport default ESLintUtils.RuleCreator.withoutDocs({\n  meta: {\n    type: 'problem',\n    messages: {\n      dollarInterpolationNotAllowed: 'Interpolation with a dollar sign is not allowed in JSX.',\n    },\n    schema: [],\n  },\n  defaultOptions: [],\n\n  create(context) {\n    return {\n      JSXElement(node) {\n        node.children.forEach((child, index) => {\n          // Skip the first child since it can't be preceded by a JSXText node.\n          if (index === 0) return;\n\n          // Skip anything that's not a JSXExpressionContainer.\n          if (child.type !== 'JSXExpressionContainer') return;\n\n          const previousChild = node.children[index - 1];\n\n          // Skip nodes that aren't preceded by a JSXText node.\n          if (previousChild.type !== 'JSXText') return;\n\n          // Skip nodes that aren't preceded by a dollar sign.\n          if (!previousChild.value.trimEnd().endsWith('$')) return;\n\n          // Determine the range of characters that should be reported. We\n          // include the dollar sign, any following whitespace, and the\n          // expression container.\n          const start = context.sourceCode.getIndexFromLoc(previousChild.loc.start);\n          const lastIndex = previousChild.value.lastIndexOf('$');\n          const dollarStart = start + lastIndex;\n          const dollarStartLoc = context.sourceCode.getLocFromIndex(dollarStart);\n\n          context.report({\n            node,\n            loc: {\n              start: dollarStartLoc,\n              end: child.loc.end,\n            },\n            messageId: 'dollarInterpolationNotAllowed',\n          });\n        });\n      },\n    };\n  },\n});\n"]}

package/dist/tests/aws-client-mandatory-config.test.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/tests/aws-client-mandatory-config.test.js

@@ -0,0 +1,29 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const rule_tester_1 = require("@typescript-eslint/rule-tester");
+const aws_client_mandatory_config_1 = require("../rules/aws-client-mandatory-config");
+rule_tester_1.RuleTester.afterAll = after;
+const ruleTester = new rule_tester_1.RuleTester();
+ruleTester.run('aws-client-mandatory-config', aws_client_mandatory_config_1.default, {
+    valid: [
+        {
+            code: "import { S3 } from '@aws-sdk/client-s3'; new S3({ region: 'us-east-2' })",
+        },
+        {
+            code: "import { S3Client } from '@aws-sdk/client-s3'; new S3Client({ region: 'us-east-2' })",
+        },
+        {
+            code: "import { EC2 } from '@aws-sdk/client-ec2'; new EC2({ region: 'us-east-2' })",
+        },
+        {
+            code: "import { EC2Client } from '@aws-sdk/client-ec2'; new EC2Client({ region: 'us-east-2' })",
+        },
+    ],
+    invalid: [
+        {
+            code: "import { S3 } from '@aws-sdk/client-s3'; new S3()",
+            errors: [{ messageId: 'missingConfig' }],
+        },
+    ],
+});
+//# sourceMappingURL=aws-client-mandatory-config.test.js.map

package/dist/tests/aws-client-mandatory-config.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"aws-client-mandatory-config.test.js","sourceRoot":"","sources":["../../src/tests/aws-client-mandatory-config.test.ts"],"names":[],"mappings":";;AAAA,gEAA4D;AAE5D,sFAAwD;AAExD,wBAAU,CAAC,QAAQ,GAAG,KAAK,CAAC;AAE5B,MAAM,UAAU,GAAG,IAAI,wBAAU,EAAE,CAAC;AAEpC,UAAU,CAAC,GAAG,CAAC,6BAA6B,EAAE,qCAAI,EAAE;IAClD,KAAK,EAAE;QACL;YACE,IAAI,EAAE,0EAA0E;SACjF;QACD;YACE,IAAI,EAAE,sFAAsF;SAC7F;QACD;YACE,IAAI,EAAE,6EAA6E;SACpF;QACD;YACE,IAAI,EAAE,yFAAyF;SAChG;KACF;IACD,OAAO,EAAE;QACP;YACE,IAAI,EAAE,mDAAmD;YACzD,MAAM,EAAE,CAAC,EAAE,SAAS,EAAE,eAAe,EAAE,CAAC;SACzC;KACF;CACF,CAAC,CAAC","sourcesContent":["import { RuleTester } from '@typescript-eslint/rule-tester';\n\nimport rule from '../rules/aws-client-mandatory-config';\n\nRuleTester.afterAll = after;\n\nconst ruleTester = new RuleTester();\n\nruleTester.run('aws-client-mandatory-config', rule, {\n  valid: [\n    {\n      code: \"import { S3 } from '@aws-sdk/client-s3'; new S3({ region: 'us-east-2' })\",\n    },\n    {\n      code: \"import { S3Client } from '@aws-sdk/client-s3'; new S3Client({ region: 'us-east-2' })\",\n    },\n    {\n      code: \"import { EC2 } from '@aws-sdk/client-ec2'; new EC2({ region: 'us-east-2' })\",\n    },\n    {\n      code: \"import { EC2Client } from '@aws-sdk/client-ec2'; new EC2Client({ region: 'us-east-2' })\",\n    },\n  ],\n  invalid: [\n    {\n      code: \"import { S3 } from '@aws-sdk/client-s3'; new S3()\",\n      errors: [{ messageId: 'missingConfig' }],\n    },\n  ],\n});\n"]}

package/dist/tests/aws-client-shared-config.test.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/tests/aws-client-shared-config.test.js

@@ -0,0 +1,40 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const rule_tester_1 = require("@typescript-eslint/rule-tester");
+const aws_client_shared_config_1 = require("../rules/aws-client-shared-config");
+rule_tester_1.RuleTester.afterAll = after;
+const ruleTester = new rule_tester_1.RuleTester();
+ruleTester.run('aws-client-shared-config', aws_client_shared_config_1.default, {
+    valid: [
+        {
+            code: "import { S3 } from '@aws-sdk/client-s3'; new S3(makeS3ClientConfig());",
+        },
+        {
+            code: "import { S3Client } from '@aws-sdk/client-s3'; new S3Client(makeS3ClientConfig());",
+        },
+        {
+            code: "import { EC2 } from '@aws-sdk/client-ec2'; new EC2(makeAwsClientConfig());",
+        },
+        {
+            code: "import { EC2Client } from '@aws-sdk/client-ec2'; new EC2Client(makeAwsClientConfig());",
+        },
+        {
+            code: "import { EC2 } from '@aws-sdk/client-ec2'; new EC2(aws.makeAwsClientConfig());",
+        },
+    ],
+    invalid: [
+        {
+            code: "import { S3 } from '@aws-sdk/client-s3'; new S3({ region: 'us-east-2' });",
+            errors: [{ messageId: 'improperConfig' }],
+        },
+        {
+            code: "import { EC2 } from '@aws-sdk/client-ec2'; new EC2({ region: 'us-east-2' });",
+            errors: [{ messageId: 'improperConfig' }],
+        },
+        {
+            code: "import { S3 } from '@aws-sdk/client-s3'; new S3(wrongFunction());",
+            errors: [{ messageId: 'improperConfig' }],
+        },
+    ],
+});
+//# sourceMappingURL=aws-client-shared-config.test.js.map

package/dist/tests/aws-client-shared-config.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"aws-client-shared-config.test.js","sourceRoot":"","sources":["../../src/tests/aws-client-shared-config.test.ts"],"names":[],"mappings":";;AAAA,gEAA4D;AAE5D,gFAAqD;AAErD,wBAAU,CAAC,QAAQ,GAAG,KAAK,CAAC;AAE5B,MAAM,UAAU,GAAG,IAAI,wBAAU,EAAE,CAAC;AAEpC,UAAU,CAAC,GAAG,CAAC,0BAA0B,EAAE,kCAAI,EAAE;IAC/C,KAAK,EAAE;QACL;YACE,IAAI,EAAE,wEAAwE;SAC/E;QACD;YACE,IAAI,EAAE,oFAAoF;SAC3F;QACD;YACE,IAAI,EAAE,4EAA4E;SACnF;QACD;YACE,IAAI,EAAE,wFAAwF;SAC/F;QACD;YACE,IAAI,EAAE,gFAAgF;SACvF;KACF;IACD,OAAO,EAAE;QACP;YACE,IAAI,EAAE,2EAA2E;YACjF,MAAM,EAAE,CAAC,EAAE,SAAS,EAAE,gBAAgB,EAAE,CAAC;SAC1C;QACD;YACE,IAAI,EAAE,8EAA8E;YACpF,MAAM,EAAE,CAAC,EAAE,SAAS,EAAE,gBAAgB,EAAE,CAAC;SAC1C;QACD;YACE,IAAI,EAAE,mEAAmE;YACzE,MAAM,EAAE,CAAC,EAAE,SAAS,EAAE,gBAAgB,EAAE,CAAC;SAC1C;KACF;CACF,CAAC,CAAC","sourcesContent":["import { RuleTester } from '@typescript-eslint/rule-tester';\n\nimport rule from '../rules/aws-client-shared-config';\n\nRuleTester.afterAll = after;\n\nconst ruleTester = new RuleTester();\n\nruleTester.run('aws-client-shared-config', rule, {\n  valid: [\n    {\n      code: \"import { S3 } from '@aws-sdk/client-s3'; new S3(makeS3ClientConfig());\",\n    },\n    {\n      code: \"import { S3Client } from '@aws-sdk/client-s3'; new S3Client(makeS3ClientConfig());\",\n    },\n    {\n      code: \"import { EC2 } from '@aws-sdk/client-ec2'; new EC2(makeAwsClientConfig());\",\n    },\n    {\n      code: \"import { EC2Client } from '@aws-sdk/client-ec2'; new EC2Client(makeAwsClientConfig());\",\n    },\n    {\n      code: \"import { EC2 } from '@aws-sdk/client-ec2'; new EC2(aws.makeAwsClientConfig());\",\n    },\n  ],\n  invalid: [\n    {\n      code: \"import { S3 } from '@aws-sdk/client-s3'; new S3({ region: 'us-east-2' });\",\n      errors: [{ messageId: 'improperConfig' }],\n    },\n    {\n      code: \"import { EC2 } from '@aws-sdk/client-ec2'; new EC2({ region: 'us-east-2' });\",\n      errors: [{ messageId: 'improperConfig' }],\n    },\n    {\n      code: \"import { S3 } from '@aws-sdk/client-s3'; new S3(wrongFunction());\",\n      errors: [{ messageId: 'improperConfig' }],\n    },\n  ],\n});\n"]}

package/dist/tests/jsx-no-dollar-interpolation.test.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/tests/jsx-no-dollar-interpolation.test.js

@@ -0,0 +1,58 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const rule_tester_1 = require("@typescript-eslint/rule-tester");
+const jsx_no_dollar_interpolation_1 = require("../rules/jsx-no-dollar-interpolation");
+rule_tester_1.RuleTester.afterAll = after;
+const ruleTester = new rule_tester_1.RuleTester({
+    languageOptions: {
+        parserOptions: {
+            ecmaFeatures: {
+                jsx: true,
+            },
+        },
+    },
+});
+ruleTester.run('jsx-no-dollar-interpolation', jsx_no_dollar_interpolation_1.default, {
+    valid: [
+        {
+            code: '<div>hello</div>',
+        },
+        {
+            code: '<div>100$</div>',
+        },
+        {
+            code: '<div>$100</div>',
+        },
+        {
+            code: '<div>$</div>',
+        },
+    ],
+    invalid: [
+        {
+            // eslint-disable-next-line no-template-curly-in-string
+            code: '<div>${message}</div>',
+            errors: [
+                {
+                    messageId: 'dollarInterpolationNotAllowed',
+                    line: 1,
+                    column: 6,
+                    endLine: 1,
+                    endColumn: 16,
+                },
+            ],
+        },
+        {
+            code: '<div>$ {message}</div>',
+            errors: [
+                {
+                    messageId: 'dollarInterpolationNotAllowed',
+                    line: 1,
+                    column: 6,
+                    endLine: 1,
+                    endColumn: 17,
+                },
+            ],
+        },
+    ],
+});
+//# sourceMappingURL=jsx-no-dollar-interpolation.test.js.map

package/dist/tests/jsx-no-dollar-interpolation.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"jsx-no-dollar-interpolation.test.js","sourceRoot":"","sources":["../../src/tests/jsx-no-dollar-interpolation.test.ts"],"names":[],"mappings":";;AAAA,gEAA4D;AAE5D,sFAAwD;AAExD,wBAAU,CAAC,QAAQ,GAAG,KAAK,CAAC;AAE5B,MAAM,UAAU,GAAG,IAAI,wBAAU,CAAC;IAChC,eAAe,EAAE;QACf,aAAa,EAAE;YACb,YAAY,EAAE;gBACZ,GAAG,EAAE,IAAI;aACV;SACF;KACF;CACF,CAAC,CAAC;AAEH,UAAU,CAAC,GAAG,CAAC,6BAA6B,EAAE,qCAAI,EAAE;IAClD,KAAK,EAAE;QACL;YACE,IAAI,EAAE,kBAAkB;SACzB;QACD;YACE,IAAI,EAAE,iBAAiB;SACxB;QACD;YACE,IAAI,EAAE,iBAAiB;SACxB;QACD;YACE,IAAI,EAAE,cAAc;SACrB;KACF;IACD,OAAO,EAAE;QACP;YACE,uDAAuD;YACvD,IAAI,EAAE,uBAAuB;YAC7B,MAAM,EAAE;gBACN;oBACE,SAAS,EAAE,+BAA+B;oBAC1C,IAAI,EAAE,CAAC;oBACP,MAAM,EAAE,CAAC;oBACT,OAAO,EAAE,CAAC;oBACV,SAAS,EAAE,EAAE;iBACd;aACF;SACF;QACD;YACE,IAAI,EAAE,wBAAwB;YAC9B,MAAM,EAAE;gBACN;oBACE,SAAS,EAAE,+BAA+B;oBAC1C,IAAI,EAAE,CAAC;oBACP,MAAM,EAAE,CAAC;oBACT,OAAO,EAAE,CAAC;oBACV,SAAS,EAAE,EAAE;iBACd;aACF;SACF;KACF;CACF,CAAC,CAAC","sourcesContent":["import { RuleTester } from '@typescript-eslint/rule-tester';\n\nimport rule from '../rules/jsx-no-dollar-interpolation';\n\nRuleTester.afterAll = after;\n\nconst ruleTester = new RuleTester({\n  languageOptions: {\n    parserOptions: {\n      ecmaFeatures: {\n        jsx: true,\n      },\n    },\n  },\n});\n\nruleTester.run('jsx-no-dollar-interpolation', rule, {\n  valid: [\n    {\n      code: '<div>hello</div>',\n    },\n    {\n      code: '<div>100$</div>',\n    },\n    {\n      code: '<div>$100</div>',\n    },\n    {\n      code: '<div>$</div>',\n    },\n  ],\n  invalid: [\n    {\n      // eslint-disable-next-line no-template-curly-in-string\n      code: '<div>${message}</div>',\n      errors: [\n        {\n          messageId: 'dollarInterpolationNotAllowed',\n          line: 1,\n          column: 6,\n          endLine: 1,\n          endColumn: 16,\n        },\n      ],\n    },\n    {\n      code: '<div>$ {message}</div>',\n      errors: [\n        {\n          messageId: 'dollarInterpolationNotAllowed',\n          line: 1,\n          column: 6,\n          endLine: 1,\n          endColumn: 17,\n        },\n      ],\n    },\n  ],\n});\n"]}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@prairielearn/eslint-plugin",
-  "version": "2.0.9",
+  "version": "2.1.0",
   "main": "./dist/index.js",
   "repository": {
     "type": "git",
@@ -9,11 +9,33 @@
   },
   "scripts": {
     "build": "tsc",
-    "dev": "tsc --watch --preserveWatchOutput"
+    "dev": "tsc --watch --preserveWatchOutput",
+    "test": "c8 mocha src/**/*.test.ts"
   },
   "devDependencies": {
     "@prairielearn/tsconfig": "^0.0.0",
+    "@types/chai": "^5.0.1",
+    "@types/mocha": "^10.0.10",
     "@types/node": "^20.17.23",
+    "@typescript-eslint/rule-tester": "^8.26.0",
+    "c8": "^10.1.3",
+    "chai": "^5.2.0",
+    "mocha": "^11.1.0",
+    "tsx": "^4.19.3",
     "typescript": "^5.8.2"
+  },
+  "dependencies": {
+    "@typescript-eslint/utils": "^8.26.0"
+  },
+  "c8": {
+    "reporter": [
+      "html",
+      "text-summary",
+      "cobertura"
+    ],
+    "all": true,
+    "include": [
+      "src/**"
+    ]
   }
 }

package/src/index.ts

@@ -1,7 +1,9 @@
 import awsClientMandatoryConfig from './rules/aws-client-mandatory-config.js';
 import awsClientSharedConfig from './rules/aws-client-shared-config.js';
+import jsxNoDollarInterpolation from './rules/jsx-no-dollar-interpolation.js';
 
 export const rules = {
   'aws-client-mandatory-config': awsClientMandatoryConfig,
   'aws-client-shared-config': awsClientSharedConfig,
+  'jsx-no-dollar-interpolation': jsxNoDollarInterpolation,
 };

package/src/rules/aws-client-mandatory-config.ts

@@ -1,3 +1,5 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+
 import { getAwsClientNamesFromImportDeclaration } from '../utils.js';
 
 /**
@@ -7,24 +9,35 @@ import { getAwsClientNamesFromImportDeclaration } from '../utils.js';
  * This rules works in tandem with `aws-client-shared-config` to ensure that
  * we're properly configuring AWS SDK clients.
  */
-export default {
-  create(context: any) {
+export default ESLintUtils.RuleCreator.withoutDocs({
+  meta: {
+    type: 'problem',
+    messages: {
+      missingConfig: '{{clientName}} must be constructed with a config object.',
+    },
+    schema: [],
+  },
+  defaultOptions: [],
+  create(context) {
     const awsClientImports = new Set();
 
     return {
       // Handle `import ...` statements
-      ImportDeclaration(node: any) {
+      ImportDeclaration(node) {
         const clientNames = getAwsClientNamesFromImportDeclaration(node);
         clientNames.forEach((clientName) => awsClientImports.add(clientName));
       },
-      NewExpression(node: any) {
+      NewExpression(node) {
         if (node.callee.type === 'Identifier' && awsClientImports.has(node.callee.name)) {
           // We're constructing an AWS client. Ensure that the call has at
           // least one argument corresponding to a config object.
           if (node.arguments.length === 0) {
             context.report({
               node,
-              message: `${node.callee.name} must be constructed with a config object.`,
+              messageId: 'missingConfig',
+              data: {
+                clientName: node.callee.name,
+              },
             });
             return;
           }
@@ -32,4 +45,4 @@ export default {
       },
     };
   },
-};
+});

package/src/rules/aws-client-shared-config.ts

@@ -1,3 +1,5 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+
 import { getAwsClientNamesFromImportDeclaration } from '../utils.js';
 
 /**
@@ -18,17 +20,27 @@ import { getAwsClientNamesFromImportDeclaration } from '../utils.js';
  * This rules works in tandem with `aws-client-mandatory-config` to ensure that
  * we're properly configuring AWS SDK clients.
  */
-export default {
-  create(context: any) {
+export default ESLintUtils.RuleCreator.withoutDocs({
+  meta: {
+    type: 'problem',
+    messages: {
+      improperConfig:
+        'Config for {{clientName}} must be obtained by calling {{desiredConfigFunctionName}}().',
+      unknownConfig: 'Unknown config provided to AWS client.',
+    },
+    schema: [],
+  },
+  defaultOptions: [],
+  create(context) {
     const awsClientImports = new Set<string>();
 
     return {
       // Handle `import ...` statements
-      ImportDeclaration(node: any) {
+      ImportDeclaration(node) {
         const clientNames = getAwsClientNamesFromImportDeclaration(node);
         clientNames.forEach((clientName) => awsClientImports.add(clientName));
       },
-      NewExpression(node: any) {
+      NewExpression(node) {
         if (node.callee.type === 'Identifier' && awsClientImports.has(node.callee.name)) {
           // We're constructing an AWS client. Ensure that the first argument
           // comes from one of our config providers.
@@ -50,18 +62,29 @@ export default {
           if (configArgument.type !== 'CallExpression') {
             context.report({
               node,
-              message: `Config for ${node.callee.name} must be obtained by calling ${desiredConfigFunctionName}().`,
+              messageId: 'improperConfig',
+              data: {
+                clientName: node.callee.name,
+                desiredConfigFunctionName,
+              },
             });
             return;
           }
 
           // Handle member calls to the function.
-          if (configArgument.callee.type === 'MemberExpression') {
+          if (
+            configArgument.callee.type === 'MemberExpression' &&
+            configArgument.callee.property.type === 'Identifier'
+          ) {
             const functionName = configArgument.callee.property.name;
             if (functionName !== desiredConfigFunctionName) {
               context.report({
                 node,
-                message: `Config for ${node.callee.name} must be obtained by calling ${desiredConfigFunctionName}().`,
+                messageId: 'improperConfig',
+                data: {
+                  clientName: node.callee.name,
+                  desiredConfigFunctionName,
+                },
               });
             }
             return;
@@ -72,7 +95,11 @@ export default {
             if (functionName !== desiredConfigFunctionName) {
               context.report({
                 node,
-                message: `Config for ${node.callee.name} must be obtained by calling ${desiredConfigFunctionName}().`,
+                messageId: 'improperConfig',
+                data: {
+                  clientName: node.callee.name,
+                  desiredConfigFunctionName,
+                },
               });
             }
             return;
@@ -80,10 +107,10 @@ export default {
 
           context.report({
             node,
-            message: 'Unknown config provided to AWS client.',
+            messageId: 'unknownConfig',
           });
         }
       },
     };
   },
-};
+});

package/src/rules/jsx-no-dollar-interpolation.ts

@@ -0,0 +1,61 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+
+/**
+ * This rule will report things that look like template string interpolations
+ * that were improperly converted to JSX. For example, the following code will
+ * trigger an error:
+ *
+ * ```tsx
+ * const a = <div>${message}</div>;
+ * const b = <div>$ {message}</div>;
+ * ```
+ */
+export default ESLintUtils.RuleCreator.withoutDocs({
+  meta: {
+    type: 'problem',
+    messages: {
+      dollarInterpolationNotAllowed: 'Interpolation with a dollar sign is not allowed in JSX.',
+    },
+    schema: [],
+  },
+  defaultOptions: [],
+
+  create(context) {
+    return {
+      JSXElement(node) {
+        node.children.forEach((child, index) => {
+          // Skip the first child since it can't be preceded by a JSXText node.
+          if (index === 0) return;
+
+          // Skip anything that's not a JSXExpressionContainer.
+          if (child.type !== 'JSXExpressionContainer') return;
+
+          const previousChild = node.children[index - 1];
+
+          // Skip nodes that aren't preceded by a JSXText node.
+          if (previousChild.type !== 'JSXText') return;
+
+          // Skip nodes that aren't preceded by a dollar sign.
+          if (!previousChild.value.trimEnd().endsWith('$')) return;
+
+          // Determine the range of characters that should be reported. We
+          // include the dollar sign, any following whitespace, and the
+          // expression container.
+          const start = context.sourceCode.getIndexFromLoc(previousChild.loc.start);
+          const lastIndex = previousChild.value.lastIndexOf('$');
+          const dollarStart = start + lastIndex;
+          const dollarStartLoc = context.sourceCode.getLocFromIndex(dollarStart);
+
+          context.report({
+            node,
+            loc: {
+              start: dollarStartLoc,
+              end: child.loc.end,
+            },
+            messageId: 'dollarInterpolationNotAllowed',
+          });
+        });
+      },
+    };
+  },
+});

package/src/tests/aws-client-mandatory-config.test.ts

@@ -0,0 +1,30 @@
+import { RuleTester } from '@typescript-eslint/rule-tester';
+
+import rule from '../rules/aws-client-mandatory-config';
+
+RuleTester.afterAll = after;
+
+const ruleTester = new RuleTester();
+
+ruleTester.run('aws-client-mandatory-config', rule, {
+  valid: [
+    {
+      code: "import { S3 } from '@aws-sdk/client-s3'; new S3({ region: 'us-east-2' })",
+    },
+    {
+      code: "import { S3Client } from '@aws-sdk/client-s3'; new S3Client({ region: 'us-east-2' })",
+    },
+    {
+      code: "import { EC2 } from '@aws-sdk/client-ec2'; new EC2({ region: 'us-east-2' })",
+    },
+    {
+      code: "import { EC2Client } from '@aws-sdk/client-ec2'; new EC2Client({ region: 'us-east-2' })",
+    },
+  ],
+  invalid: [
+    {
+      code: "import { S3 } from '@aws-sdk/client-s3'; new S3()",
+      errors: [{ messageId: 'missingConfig' }],
+    },
+  ],
+});

package/src/tests/aws-client-shared-config.test.ts

@@ -0,0 +1,41 @@
+import { RuleTester } from '@typescript-eslint/rule-tester';
+
+import rule from '../rules/aws-client-shared-config';
+
+RuleTester.afterAll = after;
+
+const ruleTester = new RuleTester();
+
+ruleTester.run('aws-client-shared-config', rule, {
+  valid: [
+    {
+      code: "import { S3 } from '@aws-sdk/client-s3'; new S3(makeS3ClientConfig());",
+    },
+    {
+      code: "import { S3Client } from '@aws-sdk/client-s3'; new S3Client(makeS3ClientConfig());",
+    },
+    {
+      code: "import { EC2 } from '@aws-sdk/client-ec2'; new EC2(makeAwsClientConfig());",
+    },
+    {
+      code: "import { EC2Client } from '@aws-sdk/client-ec2'; new EC2Client(makeAwsClientConfig());",
+    },
+    {
+      code: "import { EC2 } from '@aws-sdk/client-ec2'; new EC2(aws.makeAwsClientConfig());",
+    },
+  ],
+  invalid: [
+    {
+      code: "import { S3 } from '@aws-sdk/client-s3'; new S3({ region: 'us-east-2' });",
+      errors: [{ messageId: 'improperConfig' }],
+    },
+    {
+      code: "import { EC2 } from '@aws-sdk/client-ec2'; new EC2({ region: 'us-east-2' });",
+      errors: [{ messageId: 'improperConfig' }],
+    },
+    {
+      code: "import { S3 } from '@aws-sdk/client-s3'; new S3(wrongFunction());",
+      errors: [{ messageId: 'improperConfig' }],
+    },
+  ],
+});

package/src/tests/jsx-no-dollar-interpolation.test.ts

@@ -0,0 +1,59 @@
+import { RuleTester } from '@typescript-eslint/rule-tester';
+
+import rule from '../rules/jsx-no-dollar-interpolation';
+
+RuleTester.afterAll = after;
+
+const ruleTester = new RuleTester({
+  languageOptions: {
+    parserOptions: {
+      ecmaFeatures: {
+        jsx: true,
+      },
+    },
+  },
+});
+
+ruleTester.run('jsx-no-dollar-interpolation', rule, {
+  valid: [
+    {
+      code: '<div>hello</div>',
+    },
+    {
+      code: '<div>100$</div>',
+    },
+    {
+      code: '<div>$100</div>',
+    },
+    {
+      code: '<div>$</div>',
+    },
+  ],
+  invalid: [
+    {
+      // eslint-disable-next-line no-template-curly-in-string
+      code: '<div>${message}</div>',
+      errors: [
+        {
+          messageId: 'dollarInterpolationNotAllowed',
+          line: 1,
+          column: 6,
+          endLine: 1,
+          endColumn: 16,
+        },
+      ],
+    },
+    {
+      code: '<div>$ {message}</div>',
+      errors: [
+        {
+          messageId: 'dollarInterpolationNotAllowed',
+          line: 1,
+          column: 6,
+          endLine: 1,
+          endColumn: 17,
+        },
+      ],
+    },
+  ],
+});