@powersync/service-module-postgres-storage 0.7.2 → 0.7.4

package/src/storage/batch/PostgresBucketBatch.ts

@@ -208,13 +208,7 @@ export class PostgresBucketBatch
       return null;
     }
 
-    const currentSequence = await this.db.sql`
-      SELECT
-        LAST_VALUE AS value
-      FROM
-        op_id_sequence;
-    `.first<{ value: bigint }>();
-    return currentSequence!.value;
+    return this.getLastOpIdSequence(this.db);
   }
 
   async drop(sourceTables: storage.SourceTable[]): Promise<storage.FlushedResult | null> {
@@ -262,13 +256,7 @@ export class PostgresBucketBatch
     const lastOp = await this.withReplicationTransaction(async (db) => {
       resumeBatch = await this.replicateBatch(db, batch);
 
-      const sequence = await db.sql`
-        SELECT
-          LAST_VALUE AS value
-        FROM
-          op_id_sequence;
-      `.first<{ value: bigint }>();
-      return sequence!.value;
+      return this.getLastOpIdSequence(db);
     });
 
     // null if done, set if we need another flush
@@ -895,6 +883,23 @@ export class PostgresBucketBatch
       `.execute();
     }
   }
+
+  private async getLastOpIdSequence(db: lib_postgres.AbstractPostgresConnection) {
+    // When no op_id has been generated, last_value = 1 and nextval() will be 1.
+    // To cater for this case, we check is_called, and default to 0 if no value has been generated.
+    const sequence = await db.sql`
+      SELECT
+        (
+          CASE
+            WHEN is_called THEN last_value
+            ELSE 0
+          END
+        ) AS value
+      FROM
+        op_id_sequence;
+    `.first<{ value: bigint }>();
+    return sequence!.value;
+  }
 }
 
 /**

package/test/src/storage.test.ts

@@ -93,7 +93,11 @@ describe('Postgres Sync Bucket Storage', () => {
     });
 
     const batch2 = await test_utils.fromAsync(
-      bucketStorage.getBucketDataBatch(checkpoint, new Map([['global[]', BigInt(batch1[0].batch.next_after)]]), options)
+      bucketStorage.getBucketDataBatch(
+        checkpoint,
+        new Map([['global[]', BigInt(batch1[0].chunkData.next_after)]]),
+        options
+      )
     );
     expect(test_utils.getBatchData(batch2)).toEqual([
       { op_id: '2', op: 'PUT', object_id: 'large1', checksum: 1178768505 }
@@ -105,7 +109,11 @@ describe('Postgres Sync Bucket Storage', () => {
     });
 
     const batch3 = await test_utils.fromAsync(
-      bucketStorage.getBucketDataBatch(checkpoint, new Map([['global[]', BigInt(batch2[0].batch.next_after)]]), options)
+      bucketStorage.getBucketDataBatch(
+        checkpoint,
+        new Map([['global[]', BigInt(batch2[0].chunkData.next_after)]]),
+        options
+      )
     );
     expect(test_utils.getBatchData(batch3)).toEqual([
       { op_id: '3', op: 'PUT', object_id: 'large2', checksum: 1607205872 }
@@ -117,7 +125,11 @@ describe('Postgres Sync Bucket Storage', () => {
     });
 
     const batch4 = await test_utils.fromAsync(
-      bucketStorage.getBucketDataBatch(checkpoint, new Map([['global[]', BigInt(batch3[0].batch.next_after)]]), options)
+      bucketStorage.getBucketDataBatch(
+        checkpoint,
+        new Map([['global[]', BigInt(batch3[0].chunkData.next_after)]]),
+        options
+      )
     );
     expect(test_utils.getBatchData(batch4)).toEqual([
       { op_id: '4', op: 'PUT', object_id: 'test3', checksum: 1359888332 }