@powersync/service-core 1.21.0 → 1.22.0

package/test/src/storage/SourceTable.test.ts

@@ -0,0 +1,89 @@
+import { describe, expect, test } from 'vitest';
+import * as storage from '../../../src/storage/storage-index.js';
+
+/**
+ * Build a SourceTable with the current `ref`-based options shape.
+ * Data/parameter sources are not relevant to the storeCurrentData behaviour, so they default to empty.
+ */
+function makeTable(options: Partial<storage.SourceTableOptions> = {}): storage.SourceTable {
+  return new storage.SourceTable({
+    id: 'test-id',
+    ref: { connectionTag: 'test', schema: 'public', name: 'test_table' },
+    objectId: 123,
+    replicaIdColumns: [{ name: 'id' }],
+    snapshotComplete: true,
+    bucketDataSources: [],
+    parameterLookupSources: [],
+    ...options
+  });
+}
+
+describe('SourceTable', () => {
+  describe('storeCurrentData property', () => {
+    test('defaults to true', () => {
+      const table = makeTable();
+      expect(table.storeCurrentData).toBe(true);
+    });
+
+    test('can be set to false', () => {
+      const table = makeTable();
+      table.storeCurrentData = false;
+      expect(table.storeCurrentData).toBe(false);
+    });
+
+    test('is preserved when cloning', () => {
+      const table = makeTable();
+      table.storeCurrentData = false;
+      const cloned = table.clone();
+
+      expect(cloned.storeCurrentData).toBe(false);
+      expect(cloned).not.toBe(table);
+    });
+
+    test('clone preserves all properties including storeCurrentData', () => {
+      const table = makeTable({
+        replicaIdColumns: [{ name: 'id', type: 'int4' }],
+        snapshotComplete: false
+      });
+
+      table.syncData = false;
+      table.syncParameters = false;
+      table.syncEvent = false;
+      table.storeCurrentData = false;
+      table.snapshotStatus = {
+        totalEstimatedCount: 100,
+        replicatedCount: 50,
+        lastKey: Buffer.from('test')
+      };
+
+      const cloned = table.clone();
+
+      expect(cloned.syncData).toBe(false);
+      expect(cloned.syncParameters).toBe(false);
+      expect(cloned.syncEvent).toBe(false);
+      expect(cloned.storeCurrentData).toBe(false);
+      expect(cloned.snapshotStatus).toEqual(table.snapshotStatus);
+    });
+  });
+
+  describe('integration with other properties', () => {
+    test('storeCurrentData does not affect syncAny', () => {
+      const table = makeTable();
+
+      table.storeCurrentData = false;
+      table.syncData = true;
+      table.syncParameters = false;
+      table.syncEvent = false;
+
+      expect(table.syncAny).toBe(true); // Should still be true
+    });
+
+    test('storeCurrentData is independent of snapshot status', () => {
+      const table = makeTable({ snapshotComplete: false });
+
+      table.storeCurrentData = false;
+      expect(table.snapshotComplete).toBe(false);
+      expect(table.storeCurrentData).toBe(false);
+    });
+  });
+});

package/test/src/sync/BucketChecksumState.test.ts

@@ -15,34 +15,39 @@ import {
 } from '@/index.js';
 import { JSONBig } from '@powersync/service-jsonbig';
 import {
+  nodeSqlite,
   ParameterIndexLookupCreator,
+  ParameterLookupDefinitionId,
   ParameterLookupRows,
+  ParameterLookupScope,
   ScopedParameterLookup,
-  SourceTableInterface,
-  SqliteRow,
+  SourceTableRef,
   SqlSyncRules,
   TablePattern,
   versionedHydrationState
 } from '@powersync/service-sync-rules';
-import { ParameterLookupScope } from '@powersync/service-sync-rules/src/HydrationState.js';
+import * as sqlite from 'node:sqlite';
 import { beforeEach, describe, expect, test } from 'vitest';
 
 describe('BucketChecksumState', () => {
   const LOOKUP_SOURCE: ParameterIndexLookupCreator = {
-    get defaultLookupScope(): ParameterLookupScope {
+    get sourceId(): ParameterLookupDefinitionId {
       return {
         lookupName: 'lookup',
-        queryId: '0',
-        source: LOOKUP_SOURCE
+        queryId: '0'
       };
     },
     getSourceTables(): Set<TablePattern> {
       return new Set();
     },
-    evaluateParameterRow(_sourceTable: SourceTableInterface, _row: SqliteRow) {
-      return [];
+    createEvaluator() {
+      return {
+        evaluateParameterRow() {
+          return [];
+        }
+      };
     },
-    tableSyncsParameters(_table: SourceTableInterface): boolean {
+    tableSyncsParameters(_table: SourceTableRef): boolean {
       return false;
     }
   };
@@ -60,7 +65,7 @@ bucket_definitions:
     data: []
     `,
     { defaultSchema: 'public' }
-  ).config.hydrate({ hydrationState: versionedHydrationState(1) });
+  ).config.hydrate({ hydrationState: versionedHydrationState(1), sqlite: nodeSqlite(sqlite) });
 
   // global[1] and global[2]
   const SYNC_RULES_GLOBAL_TWO = SqlSyncRules.fromYaml(
@@ -73,7 +78,7 @@ bucket_definitions:
     data: []
     `,
     { defaultSchema: 'public' }
-  ).config.hydrate({ hydrationState: versionedHydrationState(2) });
+  ).config.hydrate({ hydrationState: versionedHydrationState(2), sqlite: nodeSqlite(sqlite) });
 
   // by_project[n]
   const SYNC_RULES_DYNAMIC = SqlSyncRules.fromYaml(
@@ -84,7 +89,7 @@ bucket_definitions:
     data: []
     `,
     { defaultSchema: 'public' }
-  ).config.hydrate({ hydrationState: versionedHydrationState(3) });
+  ).config.hydrate({ hydrationState: versionedHydrationState(3), sqlite: nodeSqlite(sqlite) });
 
   const syncContext = new SyncContext({
     maxBuckets: 100,
@@ -655,7 +660,7 @@ config:
 
       const rules = SqlSyncRules.fromYaml(source, {
         defaultSchema: 'public'
-      }).config.hydrate({ hydrationState: versionedHydrationState(1) });
+      }).config.hydrate({ hydrationState: versionedHydrationState(1), sqlite: nodeSqlite(sqlite) });
 
       return new BucketChecksumState({
         syncContext,
@@ -921,7 +926,8 @@ streams:
 `,
         { defaultSchema: 'public' }
       ).config.hydrate({
-        hydrationState: versionedHydrationState(1)
+        hydrationState: versionedHydrationState(1),
+        sqlite: nodeSqlite(sqlite)
       });
 
       const storage = new MockBucketChecksumStateStorage();
@@ -1018,7 +1024,8 @@ streams:
 `,
         { defaultSchema: 'public' }
       ).config.hydrate({
-        hydrationState: versionedHydrationState(1)
+        hydrationState: versionedHydrationState(1),
+        sqlite: nodeSqlite(sqlite)
       });
 
       const storage = new MockBucketChecksumStateStorage();
@@ -1090,7 +1097,7 @@ streams:
     query: SELECT id FROM comments WHERE p IN auth.parameter('c')
     `,
         { defaultSchema: 'public' }
-      ).config.hydrate({ hydrationState: versionedHydrationState(4) });
+      ).config.hydrate({ hydrationState: versionedHydrationState(4), sqlite: nodeSqlite(sqlite) });
 
       const storage = new MockBucketChecksumStateStorage();
 
@@ -1165,7 +1172,8 @@ streams:
       }
 
       const SYNC_RULES_MANY = SqlSyncRules.fromYaml(yamlDefinitions, { defaultSchema: 'public' }).config.hydrate({
-        hydrationState: versionedHydrationState(5)
+        hydrationState: versionedHydrationState(5),
+        sqlite: nodeSqlite(sqlite)
       });
 
       const storage = new MockBucketChecksumStateStorage();