@powersync/common 0.0.0-dev-20250528152729 → 0.0.0-dev-20250529141956

package/lib/client/AbstractPowerSyncDatabase.d.ts

@@ -122,7 +122,7 @@ export declare abstract class AbstractPowerSyncDatabase extends BaseObserver<Pow
     get syncStreamImplementation(): StreamingSyncImplementation | null;
     protected _schema: Schema;
     private _database;
-    protected connectionMutex: Mutex;
+    protected runExclusiveMutex: Mutex;
     constructor(options: PowerSyncDatabaseOptionsWithDBAdapter);
     constructor(options: PowerSyncDatabaseOptionsWithOpenFactory);
     constructor(options: PowerSyncDatabaseOptionsWithSettings);

package/lib/client/AbstractPowerSyncDatabase.js

@@ -69,7 +69,7 @@ export class AbstractPowerSyncDatabase extends BaseObserver {
     }
     _schema;
     _database;
-    connectionMutex;
+    runExclusiveMutex;
     constructor(options) {
         super();
         this.options = options;
@@ -96,7 +96,7 @@ export class AbstractPowerSyncDatabase extends BaseObserver {
         this._schema = schema;
         this.ready = false;
         this.sdkVersion = '';
-        this.connectionMutex = new Mutex();
+        this.runExclusiveMutex = new Mutex();
         // Start async init
         this.connectionManager = new ConnectionManager({
             createSyncImplementation: async (connector, options) => {
@@ -298,7 +298,7 @@ export class AbstractPowerSyncDatabase extends BaseObserver {
      * Locking here is mostly only important on web for multiple tab scenarios.
      */
     runExclusive(callback) {
-        return this.connectionMutex.runExclusive(callback);
+        return this.runExclusiveMutex.runExclusive(callback);
     }
     /**
      * Connects to stream of events from the PowerSync instance.

package/lib/client/ConnectionManager.d.ts

@@ -7,6 +7,10 @@ import { PowerSyncConnectionOptions, StreamingSyncImplementation } from './sync/
  */
 export interface ConnectionManagerSyncImplementationResult {
     sync: StreamingSyncImplementation;
+    /**
+     * Additional cleanup function which is called after the sync stream implementation
+     * is disposed.
+     */
     onDispose: () => Promise<void> | void;
 }
 /**
@@ -54,7 +58,11 @@ export declare class ConnectionManager extends BaseObserver<ConnectionManagerLis
      */
     protected pendingConnectionOptions: StoredConnectionOptions | null;
     syncStreamImplementation: StreamingSyncImplementation | null;
-    syncDisposer: (() => Promise<void> | void) | null;
+    /**
+     * Additional cleanup function which is called after the sync stream implementation
+     * is disposed.
+     */
+    protected syncDisposer: (() => Promise<void> | void) | null;
     constructor(options: ConnectionManagerOptions);
     get logger(): ILogger;
     close(): Promise<void>;

package/lib/client/ConnectionManager.js

@@ -27,6 +27,10 @@ export class ConnectionManager extends BaseObserver {
      */
     pendingConnectionOptions;
     syncStreamImplementation;
+    /**
+     * Additional cleanup function which is called after the sync stream implementation
+     * is disposed.
+     */
     syncDisposer;
     constructor(options) {
         super();
@@ -42,6 +46,7 @@ export class ConnectionManager extends BaseObserver {
         return this.options.logger;
     }
     async close() {
+        await this.syncStreamImplementation?.dispose();
         await this.syncDisposer?.();
     }
     async connect(connector, options) {
@@ -58,7 +63,7 @@ export class ConnectionManager extends BaseObserver {
         // If we do already have pending options, a disconnect has already been performed.
         // The connectInternal method also does a sanity disconnect to prevent straggler connections.
         // We should also disconnect if we have already completed a connection attempt.
-        if (!hadPendingOptions) {
+        if (!hadPendingOptions || this.syncStreamImplementation) {
             await this.disconnectInternal();
         }
         // Triggers a connect which checks if pending options are available after the connect completes.
@@ -97,6 +102,9 @@ export class ConnectionManager extends BaseObserver {
                     // A disconnect could have cleared this.
                     return;
                 }
+                if (this.disconnectingPromise) {
+                    return;
+                }
                 const { connector, options } = this.pendingConnectionOptions;
                 appliedOptions = options;
                 this.pendingConnectionOptions = null;
@@ -139,14 +147,14 @@ export class ConnectionManager extends BaseObserver {
             // A disconnect is already in progress
             return this.disconnectingPromise;
         }
-        // Wait if a sync stream implementation is being created before closing it
-        // (syncStreamImplementation must be assigned before we can properly dispose it)
-        await this.syncStreamInitPromise;
         this.disconnectingPromise = this.performDisconnect();
         await this.disconnectingPromise;
         this.disconnectingPromise = null;
     }
     async performDisconnect() {
+        // Wait if a sync stream implementation is being created before closing it
+        // (syncStreamImplementation must be assigned before we can properly dispose it)
+        await this.syncStreamInitPromise;
         // Keep reference to the sync stream implementation and disposer
         // The class members will be cleared before we trigger the disconnect
         // to prevent any further calls to the sync stream implementation.

package/lib/client/sync/stream/AbstractRemote.js

@@ -2,10 +2,10 @@ import { Buffer } from 'buffer';
 import ndjsonStream from 'can-ndjson-stream';
 import Logger from 'js-logger';
 import { RSocketConnector } from 'rsocket-core';
-import { WebsocketClientTransport } from 'rsocket-websocket-client';
 import PACKAGE from '../../../../package.json' with { type: 'json' };
 import { AbortOperation } from '../../../utils/AbortOperation.js';
 import { DataStream } from '../../../utils/DataStream.js';
+import { WebsocketClientTransport } from './WebsocketClientTransport.js';
 const POWERSYNC_TRAILING_SLASH_MATCH = /\/+$/;
 const POWERSYNC_JS_VERSION = PACKAGE.version;
 const SYNC_QUEUE_REQUEST_LOW_WATER = 5;

package/lib/client/sync/stream/AbstractStreamingSyncImplementation.js

@@ -298,12 +298,16 @@ The next upload iteration will be delayed.`);
                  * Either:
                  *  - A network request failed with a failed connection or not OKAY response code.
                  *  - There was a sync processing error.
-                 * This loop will retry.
+                 *  - The connection was aborted.
+                 * This loop will retry after a delay if the connection was not aborted.
                  * The nested abort controller will cleanup any open network requests and streams.
                  * The WebRemote should only abort pending fetch requests or close active Readable streams.
                  */
+                let delay = true;
                 if (ex instanceof AbortOperation) {
                     this.logger.warn(ex);
+                    delay = false;
+                    // A disconnect was requested, we should not delay since there is no explicit retry
                 }
                 else {
                     this.logger.error(ex);
@@ -314,7 +318,9 @@ The next upload iteration will be delayed.`);
                     }
                 });
                 // On error, wait a little before retrying
-                await this.delayRetry();
+                if (delay) {
+                    await this.delayRetry();
+                }
             }
             finally {
                 if (!signal.aborted) {

package/lib/client/sync/stream/WebsocketClientTransport.d.ts

@@ -0,0 +1,15 @@
+/**
+ * Adapted from rsocket-websocket-client
+ * https://github.com/rsocket/rsocket-js/blob/e224cf379e747c4f1ddc4f2fa111854626cc8575/packages/rsocket-websocket-client/src/WebsocketClientTransport.ts#L17
+ * This adds additional error handling for React Native iOS.
+ * This particularly adds a close listener to handle cases where the WebSocket
+ * connection closes immediately after opening without emitting an error.
+ */
+import { ClientTransport, Closeable, Demultiplexer, DuplexConnection, FrameHandler, Multiplexer, Outbound } from 'rsocket-core';
+import { ClientOptions } from 'rsocket-websocket-client';
+export declare class WebsocketClientTransport implements ClientTransport {
+    private readonly url;
+    private readonly factory;
+    constructor(options: ClientOptions);
+    connect(multiplexerDemultiplexerFactory: (outbound: Outbound & Closeable) => Multiplexer & Demultiplexer & FrameHandler): Promise<DuplexConnection>;
+}

package/lib/client/sync/stream/WebsocketClientTransport.js

@@ -0,0 +1,48 @@
+/**
+ * Adapted from rsocket-websocket-client
+ * https://github.com/rsocket/rsocket-js/blob/e224cf379e747c4f1ddc4f2fa111854626cc8575/packages/rsocket-websocket-client/src/WebsocketClientTransport.ts#L17
+ * This adds additional error handling for React Native iOS.
+ * This particularly adds a close listener to handle cases where the WebSocket
+ * connection closes immediately after opening without emitting an error.
+ */
+import { Deserializer } from 'rsocket-core';
+import { WebsocketDuplexConnection } from 'rsocket-websocket-client/dist/WebsocketDuplexConnection.js';
+export class WebsocketClientTransport {
+    url;
+    factory;
+    constructor(options) {
+        this.url = options.url;
+        this.factory = options.wsCreator ?? ((url) => new WebSocket(url));
+    }
+    connect(multiplexerDemultiplexerFactory) {
+        return new Promise((resolve, reject) => {
+            const websocket = this.factory(this.url);
+            websocket.binaryType = 'arraybuffer';
+            let removeListeners;
+            const openListener = () => {
+                removeListeners();
+                resolve(new WebsocketDuplexConnection(websocket, new Deserializer(), multiplexerDemultiplexerFactory));
+            };
+            const errorListener = (ev) => {
+                removeListeners();
+                reject(ev.error);
+            };
+            /**
+             * In some cases, such as React Native iOS, the WebSocket connection may close immediately after opening
+             * without and error. In such cases, we need to handle the close event to reject the promise.
+             */
+            const closeListener = () => {
+                removeListeners();
+                reject(new Error('WebSocket connection closed while opening'));
+            };
+            removeListeners = () => {
+                websocket.removeEventListener('open', openListener);
+                websocket.removeEventListener('error', errorListener);
+                websocket.removeEventListener('close', closeListener);
+            };
+            websocket.addEventListener('open', openListener);
+            websocket.addEventListener('error', errorListener);
+            websocket.addEventListener('close', closeListener);
+        });
+    }
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@powersync/common",
-  "version": "0.0.0-dev-20250528152729",
+  "version": "0.0.0-dev-20250529141956",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/",
     "access": "public"