@posthog/core 1.50.1 → 1.50.2

package/dist/utils/otlp-any-value.js

@@ -170,6 +170,10 @@ function encodeArrayValues(values, logger, state, depth) {
 function encodeKeyValueList(attrs, logger, state, depth) {
     const result = [];
     for(const key in attrs)if (propertyIsEnumerable.call(attrs, key)) {
+        if (!key) {
+            logger?.debug('Dropping an attribute with an empty key');
+            continue;
+        }
         if (result.length >= external_json_utils_js_namespaceObject.MAX_JSON_SAFE_VALUE_ITEMS || state.remainingNodes <= 0) {
             logger?.debug('Attributes truncated: the value exceeds the OTLP encoder budget');
             break;

package/dist/utils/otlp-any-value.mjs

@@ -141,6 +141,10 @@ function encodeArrayValues(values, logger, state, depth) {
 function encodeKeyValueList(attrs, logger, state, depth) {
     const result = [];
     for(const key in attrs)if (propertyIsEnumerable.call(attrs, key)) {
+        if (!key) {
+            logger?.debug('Dropping an attribute with an empty key');
+            continue;
+        }
         if (result.length >= MAX_JSON_SAFE_VALUE_ITEMS || state.remainingNodes <= 0) {
             logger?.debug('Attributes truncated: the value exceeds the OTLP encoder budget');
             break;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@posthog/core",
-  "version": "1.50.1",
+  "version": "1.50.2",
   "bugs": {
     "url": "https://github.com/PostHog/posthog-js/issues"
   },

package/src/utils/otlp-any-value.spec.ts

@@ -357,5 +357,20 @@ describe('otlp-any-value', () => {
         })
       ).toEqual([{ key: 'kept', value: { stringValue: 'yes' } }])
     })
+
+    it('skips an empty key, which OTLP does not allow', () => {
+      expect(toOtlpKeyValueList({ '': 'nameless', kept: 'yes' })).toEqual([
+        { key: 'kept', value: { stringValue: 'yes' } },
+      ])
+    })
+
+    it('skips an empty key nested inside a value', () => {
+      expect(toOtlpKeyValueList({ outer: { '': 'nameless', kept: 'yes' } })).toEqual([
+        {
+          key: 'outer',
+          value: { kvlistValue: { values: [{ key: 'kept', value: { stringValue: 'yes' } }] } },
+        },
+      ])
+    })
   })
 })

package/src/utils/otlp-any-value.ts

@@ -204,6 +204,12 @@ function encodeKeyValueList(
     if (!propertyIsEnumerable.call(attrs, key)) {
       continue
     }
+    if (!key) {
+      // OTLP requires a non-empty key. The server stores one verbatim, where it
+      // shows up as a nameless attribute nothing can filter on.
+      logger?.debug('Dropping an attribute with an empty key')
+      continue
+    }
     if (result.length >= MAX_JSON_SAFE_VALUE_ITEMS || state.remainingNodes <= 0) {
       // Reported rather than written into the attributes: a synthetic key would
       // land in the user's own namespace and could collide with a real one.