@posthog/core 1.49.1 → 1.49.2

package/dist/surveys/events.d.ts

@@ -4,7 +4,7 @@ export declare const SURVEY_LANGUAGE_PROPERTY = "$survey_language";
 export declare function getSurveyResponseKey(questionId: string): string;
 export declare function getSurveyOldResponseKey(originalQuestionIndex: number): string;
 export declare function getSurveyResponseValue(responses: SurveyResponses, questionId?: string): SurveyResponseValue | undefined;
-export declare function buildSurveyResponseProperties(responses: SurveyResponses | undefined, survey: SurveyForResponses): Record<string, unknown>;
+export declare function buildSurveyResponseProperties(responses: SurveyResponses | undefined, survey: SurveyForResponses, questionSnapshots?: Record<string, string>): Record<string, unknown>;
 export declare function surveyHasResponses(responses?: SurveyResponses): boolean;
 export declare function getSurveyInteractionProperty(survey: SurveyWithIteration, action: string): string;
 type SurveyQuestionForResponses = {

package/dist/surveys/events.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"events.d.ts","sourceRoot":"","sources":["../../src/surveys/events.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,mBAAmB,EAAE,MAAM,QAAQ,CAAA;AAC5C,OAAO,EAAE,eAAe,EAAE,mBAAmB,EAAE,MAAM,UAAU,CAAA;AAG/D,eAAO,MAAM,wBAAwB,qBAAqB,CAAA;AAE1D,wBAAgB,oBAAoB,CAAC,UAAU,EAAE,MAAM,GAAG,MAAM,CAE/D;AAED,wBAAgB,uBAAuB,CAAC,qBAAqB,EAAE,MAAM,GAAG,MAAM,CAE7E;AAED,wBAAgB,sBAAsB,CACpC,SAAS,EAAE,eAAe,EAC1B,UAAU,CAAC,EAAE,MAAM,GAClB,mBAAmB,GAAG,SAAS,CASjC;AAED,wBAAgB,6BAA6B,CAC3C,SAAS,EAAE,eAAe,YAAK,EAC/B,MAAM,EAAE,kBAAkB,GACzB,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAsBzB;AAED,wBAAgB,kBAAkB,CAAC,SAAS,GAAE,eAAoB,GAAG,OAAO,CAE3E;AAED,wBAAgB,4BAA4B,CAAC,MAAM,EAAE,mBAAmB,EAAE,MAAM,EAAE,MAAM,GAAG,MAAM,CAOhG;AACD,KAAK,0BAA0B,GAAG;IAChC,EAAE,CAAC,EAAE,MAAM,CAAA;IACX,QAAQ,EAAE,MAAM,CAAA;IAChB,qBAAqB,CAAC,EAAE,MAAM,CAAA;CAC/B,CAAA;AAED,KAAK,kBAAkB,GAAG;IACxB,SAAS,EAAE,0BAA0B,EAAE,CAAA;CACxC,CAAA"}
+{"version":3,"file":"events.d.ts","sourceRoot":"","sources":["../../src/surveys/events.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,mBAAmB,EAAE,MAAM,QAAQ,CAAA;AAC5C,OAAO,EAAE,eAAe,EAAE,mBAAmB,EAAE,MAAM,UAAU,CAAA;AAG/D,eAAO,MAAM,wBAAwB,qBAAqB,CAAA;AAE1D,wBAAgB,oBAAoB,CAAC,UAAU,EAAE,MAAM,GAAG,MAAM,CAE/D;AAED,wBAAgB,uBAAuB,CAAC,qBAAqB,EAAE,MAAM,GAAG,MAAM,CAE7E;AAED,wBAAgB,sBAAsB,CACpC,SAAS,EAAE,eAAe,EAC1B,UAAU,CAAC,EAAE,MAAM,GAClB,mBAAmB,GAAG,SAAS,CASjC;AAED,wBAAgB,6BAA6B,CAC3C,SAAS,EAAE,eAAe,YAAK,EAC/B,MAAM,EAAE,kBAAkB,EAC1B,iBAAiB,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,GACzC,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAsBzB;AAED,wBAAgB,kBAAkB,CAAC,SAAS,GAAE,eAAoB,GAAG,OAAO,CAE3E;AAED,wBAAgB,4BAA4B,CAAC,MAAM,EAAE,mBAAmB,EAAE,MAAM,EAAE,MAAM,GAAG,MAAM,CAOhG;AACD,KAAK,0BAA0B,GAAG;IAChC,EAAE,CAAC,EAAE,MAAM,CAAA;IACX,QAAQ,EAAE,MAAM,CAAA;IAChB,qBAAqB,CAAC,EAAE,MAAM,CAAA;CAC/B,CAAA;AAED,KAAK,kBAAkB,GAAG;IACxB,SAAS,EAAE,0BAA0B,EAAE,CAAA;CACxC,CAAA"}

package/dist/surveys/events.js

@@ -48,7 +48,7 @@ function getSurveyResponseValue(responses, questionId) {
     ];
     return response;
 }
-function buildSurveyResponseProperties(responses = {}, survey) {
+function buildSurveyResponseProperties(responses = {}, survey, questionSnapshots) {
     const oldFormatResponses = {};
     survey.questions.forEach((question)=>{
         if ((0, index_js_namespaceObject.isUndefined)(question.originalQuestionIndex)) return;
@@ -59,7 +59,7 @@ function buildSurveyResponseProperties(responses = {}, survey) {
     return {
         $survey_questions: survey.questions.map((question)=>({
                 id: question.id,
-                question: question.question,
+                question: questionSnapshots?.[question.id ?? ''] ?? question.question,
                 response: getSurveyResponseValue(responses, question.id)
             })),
         ...responses,

package/dist/surveys/events.mjs

@@ -14,7 +14,7 @@ function getSurveyResponseValue(responses, questionId) {
     ];
     return response;
 }
-function buildSurveyResponseProperties(responses = {}, survey) {
+function buildSurveyResponseProperties(responses = {}, survey, questionSnapshots) {
     const oldFormatResponses = {};
     survey.questions.forEach((question)=>{
         if (isUndefined(question.originalQuestionIndex)) return;
@@ -25,7 +25,7 @@ function buildSurveyResponseProperties(responses = {}, survey) {
     return {
         $survey_questions: survey.questions.map((question)=>({
                 id: question.id,
-                question: question.question,
+                question: questionSnapshots?.[question.id ?? ''] ?? question.question,
                 response: getSurveyResponseValue(responses, question.id)
             })),
         ...responses,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@posthog/core",
-  "version": "1.49.1",
+  "version": "1.49.2",
   "bugs": {
     "url": "https://github.com/PostHog/posthog-js/issues"
   },
@@ -70,7 +70,7 @@
     }
   },
   "dependencies": {
-    "@posthog/types": "^1.407.0"
+    "@posthog/types": "^1.407.1"
   },
   "devDependencies": {
     "@rslib/core": "0.10.6",

package/src/surveys/events.spec.ts

@@ -35,6 +35,47 @@ describe('survey event helpers', () => {
     })
   })
 
+  it('prefers question snapshots over the current question text', () => {
+    const responses = { [getSurveyResponseKey('q1')]: 5 }
+    const questionSnapshots = { q1: 'Rate us (French)' }
+
+    expect(buildSurveyResponseProperties(responses, survey, questionSnapshots)).toEqual(
+      expect.objectContaining({
+        $survey_questions: [
+          { id: 'q1', question: 'Rate us (French)', response: 5 },
+          { id: 'q2', question: 'Anything else?', response: undefined },
+        ],
+      })
+    )
+  })
+
+  it('falls back to the current question text for a question with no snapshot', () => {
+    const questionSnapshots = { q1: 'Rate us (French)' }
+
+    expect(buildSurveyResponseProperties({}, survey, questionSnapshots)).toEqual(
+      expect.objectContaining({
+        $survey_questions: expect.arrayContaining([{ id: 'q2', question: 'Anything else?', response: undefined }]),
+      })
+    )
+  })
+
+  it('falls back to the current question text when the question id is an empty string', () => {
+    const surveyWithEmptyId = {
+      ...survey,
+      questions: [{ id: '', question: 'Untitled', originalQuestionIndex: 0 }],
+    }
+    // A snapshot recorded under the empty-string key must not be picked up for a
+    // question whose id is also '' — only an explicit questionSnapshots[''] set by
+    // the caller should ever surface here, and there is none in this case.
+    const questionSnapshots = {}
+
+    expect(buildSurveyResponseProperties({}, surveyWithEmptyId, questionSnapshots)).toEqual(
+      expect.objectContaining({
+        $survey_questions: [{ id: '', question: 'Untitled', response: null }],
+      })
+    )
+  })
+
   it('copies array response values before returning them', () => {
     const responses = { [getSurveyResponseKey('q1')]: ['a'] }
 

package/src/surveys/events.ts

@@ -28,7 +28,8 @@ export function getSurveyResponseValue(
 
 export function buildSurveyResponseProperties(
   responses: SurveyResponses = {},
-  survey: SurveyForResponses
+  survey: SurveyForResponses,
+  questionSnapshots?: Record<string, string>
 ): Record<string, unknown> {
   const oldFormatResponses: SurveyResponses = {}
   survey.questions.forEach((question: SurveyQuestionForResponses) => {
@@ -45,7 +46,7 @@ export function buildSurveyResponseProperties(
   return {
     $survey_questions: survey.questions.map((question: SurveyQuestionForResponses) => ({
       id: question.id,
-      question: question.question,
+      question: questionSnapshots?.[question.id ?? ''] ?? question.question,
       response: getSurveyResponseValue(responses, question.id),
     })),
     ...responses,