@posthog/core 1.48.4 → 1.48.5

package/dist/error-tracking/parsers/base.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"base.d.ts","sourceRoot":"","sources":["../../../src/error-tracking/parsers/base.ts"],"names":[],"mappings":"AAKA,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAA;AAErC,eAAO,MAAM,gBAAgB,MAAM,CAAA;AASnC,wBAAgB,WAAW,CACzB,QAAQ,EAAE,UAAU,CAAC,UAAU,CAAC,EAChC,QAAQ,EAAE,MAAM,EAChB,IAAI,EAAE,MAAM,EACZ,MAAM,CAAC,EAAE,MAAM,EACf,KAAK,CAAC,EAAE,MAAM,GACb,UAAU,CAmBZ"}
+{"version":3,"file":"base.d.ts","sourceRoot":"","sources":["../../../src/error-tracking/parsers/base.ts"],"names":[],"mappings":"AAKA,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAA;AAErC,eAAO,MAAM,gBAAgB,MAAM,CAAA;AAiBnC,wBAAgB,WAAW,CACzB,QAAQ,EAAE,UAAU,CAAC,UAAU,CAAC,EAChC,QAAQ,EAAE,MAAM,EAChB,IAAI,EAAE,MAAM,EACZ,MAAM,CAAC,EAAE,MAAM,EACf,KAAK,CAAC,EAAE,MAAM,GACb,UAAU,CAmBZ"}

package/dist/error-tracking/parsers/base.js

@@ -30,12 +30,13 @@ __webpack_require__.d(__webpack_exports__, {
 const index_js_namespaceObject = require("../../utils/index.js");
 const UNKNOWN_FUNCTION = '?';
 const MASKED_URL_PREFIX = 'webkit-masked-url://';
+const ANONYMOUS_FILENAME = '<anonymous>';
 function createFrame(platform, filename, func, lineno, colno) {
     const frame = {
         platform,
         filename,
         function: '<anonymous>' === func ? UNKNOWN_FUNCTION : func,
-        in_app: !filename?.startsWith(MASKED_URL_PREFIX)
+        in_app: !filename?.startsWith(MASKED_URL_PREFIX) && filename !== ANONYMOUS_FILENAME
     };
     if (!(0, index_js_namespaceObject.isUndefined)(lineno)) frame.lineno = lineno;
     if (!(0, index_js_namespaceObject.isUndefined)(colno)) frame.colno = colno;

package/dist/error-tracking/parsers/base.mjs

@@ -1,12 +1,13 @@
 import { isUndefined } from "../../utils/index.mjs";
 const UNKNOWN_FUNCTION = '?';
 const MASKED_URL_PREFIX = 'webkit-masked-url://';
+const ANONYMOUS_FILENAME = '<anonymous>';
 function createFrame(platform, filename, func, lineno, colno) {
     const frame = {
         platform,
         filename,
         function: '<anonymous>' === func ? UNKNOWN_FUNCTION : func,
-        in_app: !filename?.startsWith(MASKED_URL_PREFIX)
+        in_app: !filename?.startsWith(MASKED_URL_PREFIX) && filename !== ANONYMOUS_FILENAME
     };
     if (!isUndefined(lineno)) frame.lineno = lineno;
     if (!isUndefined(colno)) frame.colno = colno;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@posthog/core",
-  "version": "1.48.4",
+  "version": "1.48.5",
   "bugs": {
     "url": "https://github.com/PostHog/posthog-js/issues"
   },

package/src/error-tracking/parsers/base.spec.ts

@@ -1,4 +1,5 @@
 import { createFrame } from './base'
+import { createDefaultStackParser } from './index'
 
 describe('createFrame', () => {
   const platform = 'web:javascript'
@@ -25,9 +26,42 @@ describe('createFrame', () => {
     })
   })
 
+  it('does not mark Chromium <anonymous> frames as in_app', () => {
+    // Chromium reports scripts that have no URL (extension-injected code, devtools, string eval)
+    // as `<anonymous>`. They can never be symbolicated and are not attributable to the page.
+    const frame = createFrame(platform, '<anonymous>', '?', 1, 394)
+    expect(frame.in_app).toBe(false)
+    expect(frame).toMatchObject({ filename: '<anonymous>', function: '?', lineno: 1, colno: 394 })
+  })
+
   it('falls back to in_app when the parser could not determine a filename', () => {
     // Regex capture groups that do not participate arrive here as undefined despite the type
     const frame = createFrame(platform, undefined as unknown as string, 'doThing')
     expect(frame.in_app).toBe(true)
   })
 })
+
+describe('createDefaultStackParser in_app classification', () => {
+  const parse = createDefaultStackParser()
+
+  it('demotes a bare <anonymous> frame from injected code', () => {
+    const frames = parse("SyntaxError: Failed to execute 'appendChild' on 'Node': boom\n    at <anonymous>:1:394")
+    expect(frames).toEqual([
+      { platform: 'web:javascript', filename: '<anonymous>', function: '?', in_app: false, lineno: 1, colno: 394 },
+    ])
+  })
+
+  it("keeps the page's own eval'd code as in_app", () => {
+    // V8 attributes eval'd code to the script that called eval; the chrome parser already
+    // rewrites these frames to that URL, so they must not be caught by the <anonymous> rule.
+    const frames = parse(
+      'Error: boom\n' +
+        '    at eval (eval at <anonymous> (https://example.com/app.js:10:5), <anonymous>:1:394)\n' +
+        '    at https://example.com/app.js:10:5'
+    )
+    expect(frames.map((f) => [f.filename, f.in_app])).toEqual([
+      ['https://example.com/app.js', true],
+      ['https://example.com/app.js', true],
+    ])
+  })
+})

package/src/error-tracking/parsers/base.ts

@@ -14,6 +14,14 @@ export const UNKNOWN_FUNCTION = '?'
 // but do not let it count as in_app and pull the issue into the site's own stack.
 const MASKED_URL_PREFIX = 'webkit-masked-url://'
 
+// Chromium's counterpart: a script with no URL at all -- code injected by an extension
+// (`chrome.scripting.executeScript`), pasted into devtools, or evaluated from a string -- shows
+// up as a bare `<anonymous>:line:col` frame. The page's own eval'd code is *not* affected: V8
+// reports it as `eval at <anonymous> (https://site/app.js:1:2)` and the chrome parser already
+// rewrites that to the site URL. A bare `<anonymous>` can never be symbolicated, so treating it
+// as in_app only ever pulled an unresolvable frame into the site's own stack.
+const ANONYMOUS_FILENAME = '<anonymous>'
+
 export function createFrame(
   platform: StackFrame['platform'],
   filename: string,
@@ -26,8 +34,8 @@ export function createFrame(
     platform,
     filename,
     function: func === '<anonymous>' ? UNKNOWN_FUNCTION : func,
-    // Browser frames are considered in_app unless the runtime has masked their origin
-    in_app: !filename?.startsWith(MASKED_URL_PREFIX),
+    // Browser frames are considered in_app unless the runtime has masked or dropped their origin
+    in_app: !filename?.startsWith(MASKED_URL_PREFIX) && filename !== ANONYMOUS_FILENAME,
   }
 
   if (!isUndefined(lineno)) {