@posthog/core 1.48.2 → 1.48.4

package/dist/error-tracking/coercers/error-coercer.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"error-coercer.d.ts","sourceRoot":"","sources":["../../../src/error-tracking/coercers/error-coercer.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,eAAe,EAAE,oBAAoB,EAAE,aAAa,EAAE,MAAM,UAAU,CAAA;AAE/E,qBAAa,YAAa,YAAW,oBAAoB,CAAC,KAAK,CAAC;IAC9D,KAAK,CAAC,GAAG,EAAE,OAAO,GAAG,GAAG,IAAI,KAAK;IAIjC,MAAM,CAAC,GAAG,EAAE,KAAK,EAAE,GAAG,EAAE,eAAe,GAAG,aAAa;IAUvD,OAAO,CAAC,OAAO;IAIf,OAAO,CAAC,UAAU;IAUlB,OAAO,CAAC,QAAQ;CAGjB"}
+{"version":3,"file":"error-coercer.d.ts","sourceRoot":"","sources":["../../../src/error-tracking/coercers/error-coercer.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,eAAe,EAAE,oBAAoB,EAAE,aAAa,EAAE,MAAM,UAAU,CAAA;AAE/E,qBAAa,YAAa,YAAW,oBAAoB,CAAC,KAAK,CAAC;IAC9D,KAAK,CAAC,GAAG,EAAE,OAAO,GAAG,GAAG,IAAI,KAAK;IAIjC,MAAM,CAAC,GAAG,EAAE,KAAK,EAAE,GAAG,EAAE,eAAe,GAAG,aAAa;IAgBvD,OAAO,CAAC,OAAO;IAIf,OAAO,CAAC,UAAU;IAUlB,OAAO,CAAC,QAAQ;CAGjB"}

package/dist/error-tracking/coercers/error-coercer.js

@@ -32,12 +32,14 @@ class ErrorCoercer {
         return (0, type_utils_js_namespaceObject.isError)(err);
     }
     coerce(err, ctx) {
+        const stack = this.getStack(err);
+        const synthetic = void 0 === stack;
         return {
             type: this.getType(err),
             value: this.getMessage(err, ctx),
-            stack: this.getStack(err),
+            stack: stack ?? ctx.syntheticException?.stack,
             cause: err.cause ? ctx.next(err.cause) : void 0,
-            synthetic: false
+            synthetic
         };
     }
     getType(err) {

package/dist/error-tracking/coercers/error-coercer.mjs

@@ -4,12 +4,14 @@ class ErrorCoercer {
         return isError(err);
     }
     coerce(err, ctx) {
+        const stack = this.getStack(err);
+        const synthetic = void 0 === stack;
         return {
             type: this.getType(err),
             value: this.getMessage(err, ctx),
-            stack: this.getStack(err),
+            stack: stack ?? ctx.syntheticException?.stack,
             cause: err.cause ? ctx.next(err.cause) : void 0,
-            synthetic: false
+            synthetic
         };
     }
     getType(err) {

package/dist/error-tracking/parsers/base.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"base.d.ts","sourceRoot":"","sources":["../../../src/error-tracking/parsers/base.ts"],"names":[],"mappings":"AAKA,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAA;AAErC,eAAO,MAAM,gBAAgB,MAAM,CAAA;AAEnC,wBAAgB,WAAW,CACzB,QAAQ,EAAE,UAAU,CAAC,UAAU,CAAC,EAChC,QAAQ,EAAE,MAAM,EAChB,IAAI,EAAE,MAAM,EACZ,MAAM,CAAC,EAAE,MAAM,EACf,KAAK,CAAC,EAAE,MAAM,GACb,UAAU,CAkBZ"}
+{"version":3,"file":"base.d.ts","sourceRoot":"","sources":["../../../src/error-tracking/parsers/base.ts"],"names":[],"mappings":"AAKA,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAA;AAErC,eAAO,MAAM,gBAAgB,MAAM,CAAA;AASnC,wBAAgB,WAAW,CACzB,QAAQ,EAAE,UAAU,CAAC,UAAU,CAAC,EAChC,QAAQ,EAAE,MAAM,EAChB,IAAI,EAAE,MAAM,EACZ,MAAM,CAAC,EAAE,MAAM,EACf,KAAK,CAAC,EAAE,MAAM,GACb,UAAU,CAmBZ"}

package/dist/error-tracking/parsers/base.js

@@ -29,12 +29,13 @@ __webpack_require__.d(__webpack_exports__, {
 });
 const index_js_namespaceObject = require("../../utils/index.js");
 const UNKNOWN_FUNCTION = '?';
+const MASKED_URL_PREFIX = 'webkit-masked-url://';
 function createFrame(platform, filename, func, lineno, colno) {
     const frame = {
         platform,
         filename,
         function: '<anonymous>' === func ? UNKNOWN_FUNCTION : func,
-        in_app: true
+        in_app: !filename?.startsWith(MASKED_URL_PREFIX)
     };
     if (!(0, index_js_namespaceObject.isUndefined)(lineno)) frame.lineno = lineno;
     if (!(0, index_js_namespaceObject.isUndefined)(colno)) frame.colno = colno;

package/dist/error-tracking/parsers/base.mjs

@@ -1,11 +1,12 @@
 import { isUndefined } from "../../utils/index.mjs";
 const UNKNOWN_FUNCTION = '?';
+const MASKED_URL_PREFIX = 'webkit-masked-url://';
 function createFrame(platform, filename, func, lineno, colno) {
     const frame = {
         platform,
         filename,
         function: '<anonymous>' === func ? UNKNOWN_FUNCTION : func,
-        in_app: true
+        in_app: !filename?.startsWith(MASKED_URL_PREFIX)
     };
     if (!isUndefined(lineno)) frame.lineno = lineno;
     if (!isUndefined(colno)) frame.colno = colno;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@posthog/core",
-  "version": "1.48.2",
+  "version": "1.48.4",
   "bugs": {
     "url": "https://github.com/PostHog/posthog-js/issues"
   },
@@ -70,7 +70,7 @@
     }
   },
   "dependencies": {
-    "@posthog/types": "^1.404.1"
+    "@posthog/types": "^1.405.0"
   },
   "devDependencies": {
     "@rslib/core": "0.10.6",

package/src/error-tracking/coercers/error-coercer.ts

@@ -7,12 +7,18 @@ export class ErrorCoercer implements ErrorTrackingCoercer<Error> {
   }
 
   coerce(err: Error, ctx: CoercingContext): ExceptionLike {
+    const stack = this.getStack(err)
+    // Some errors carry no usable stack (for example a Firefox network `fetch`
+    // `TypeError`). Fall back to the synthetic exception captured at the call
+    // site so the frames still point at the caller. Mark it synthetic so the
+    // parser trims the SDK's own frames.
+    const synthetic = stack === undefined
     return {
       type: this.getType(err),
       value: this.getMessage(err, ctx),
-      stack: this.getStack(err),
+      stack: stack ?? ctx.syntheticException?.stack,
       cause: err.cause ? ctx.next(err.cause) : undefined,
-      synthetic: false,
+      synthetic,
     }
   }
 

package/src/error-tracking/error-properties-builder.coerce.spec.ts

@@ -112,6 +112,21 @@ describe('ErrorPropertiesBuilder', () => {
       })
     })
 
+    it('should fall back to the synthetic stack when the error has no stack', () => {
+      // Firefox rejects a network `fetch` with a `TypeError` that carries no
+      // stack, so the frames must come from the synthetic exception instead.
+      const errorObject = new CustomTestError('My special error')
+      errorObject.stack = ''
+      const syntheticError = new Error()
+      const exception = coerceInput(errorObject, syntheticError)
+      expect(exception).toMatchObject({
+        type: 'CustomTestError',
+        value: 'My special error',
+        stack: syntheticError.stack,
+        synthetic: true,
+      })
+    })
+
     it('should preserve a cross-realm error', () => {
       const crossRealmError = runInNewContext(
         `new TypeError('cross-realm error', {

package/src/error-tracking/parsers/base.spec.ts

@@ -0,0 +1,33 @@
+import { createFrame } from './base'
+
+describe('createFrame', () => {
+  const platform = 'web:javascript'
+
+  it('marks ordinary browser frames as in_app', () => {
+    const frame = createFrame(platform, 'https://example.com/app.js', 'doThing', 1, 2)
+    expect(frame.in_app).toBe(true)
+  })
+
+  it('does not mark frames Safari has masked as in_app', () => {
+    // Safari hides the origin of extension content scripts, and of blob:/eval'd code, behind
+    // this placeholder. None of it is the page's own code.
+    const frame = createFrame(platform, 'webkit-masked-url://hidden/', '_classCallCheck', 1, 2)
+    expect(frame.in_app).toBe(false)
+  })
+
+  it('keeps the masked frame rather than discarding it', () => {
+    const frame = createFrame(platform, 'webkit-masked-url://hidden/', 'someFn', 3, 4)
+    expect(frame).toMatchObject({
+      filename: 'webkit-masked-url://hidden/',
+      function: 'someFn',
+      lineno: 3,
+      colno: 4,
+    })
+  })
+
+  it('falls back to in_app when the parser could not determine a filename', () => {
+    // Regex capture groups that do not participate arrive here as undefined despite the type
+    const frame = createFrame(platform, undefined as unknown as string, 'doThing')
+    expect(frame.in_app).toBe(true)
+  })
+})

package/src/error-tracking/parsers/base.ts

@@ -7,6 +7,13 @@ import { StackFrame } from '../types'
 
 export const UNKNOWN_FUNCTION = '?'
 
+// Safari replaces the URL of scripts it will not attribute to the page with this placeholder.
+// Web extension content scripts are the common source, but blob:, eval'd and injected code can
+// be masked the same way, so the filename alone cannot tell us which one we are looking at.
+// Either way it is not the page's own code, so keep the frame -- it is still useful context --
+// but do not let it count as in_app and pull the issue into the site's own stack.
+const MASKED_URL_PREFIX = 'webkit-masked-url://'
+
 export function createFrame(
   platform: StackFrame['platform'],
   filename: string,
@@ -19,7 +26,8 @@ export function createFrame(
     platform,
     filename,
     function: func === '<anonymous>' ? UNKNOWN_FUNCTION : func,
-    in_app: true, // All browser frames are considered in_app
+    // Browser frames are considered in_app unless the runtime has masked their origin
+    in_app: !filename?.startsWith(MASKED_URL_PREFIX),
   }
 
   if (!isUndefined(lineno)) {