@posthog/core 1.32.1 → 1.32.2

package/dist/logs/index.d.ts

@@ -24,9 +24,7 @@ export declare class PostHogLogs {
      * Runs the configured `beforeSend` hook(s) on a capture record:
      *   - single fn OR array of fns (chain, left-to-right)
      *   - returning `null` drops the record (logged at info)
-     *   - a thrown error is logged and the chain *continues* with the previous
-     *     result — a buggy user filter must never crash the caller's
-     *     `captureLog()` call
+     *   - a thrown error is logged and the record is dropped
      */
     private _runBeforeSend;
     /**

package/dist/logs/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/logs/index.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,MAAM,EAA4B,MAAM,UAAU,CAAA;AAC3D,OAAO,KAAK,EAAE,oBAAoB,EAAE,MAAM,2BAA2B,CAAA;AAErE,OAAO,KAAK,EAGV,iBAAiB,EACjB,aAAa,EACb,yBAAyB,EAC1B,MAAM,SAAS,CAAA;AAEhB,qBAAa,WAAW;IAuBpB,OAAO,CAAC,QAAQ,CAAC,SAAS;IAC1B,OAAO,CAAC,QAAQ,CAAC,OAAO;IACxB,OAAO,CAAC,QAAQ,CAAC,OAAO;IACxB,OAAO,CAAC,QAAQ,CAAC,WAAW;IAC5B,OAAO,CAAC,QAAQ,CAAC,QAAQ;IAMzB,OAAO,CAAC,QAAQ,CAAC,sBAAsB;IAhCzC,OAAO,CAAC,cAAc,CAAQ;IAC9B,OAAO,CAAC,gBAAgB,CAAQ;IAIhC,OAAO,CAAC,uBAAuB,CAAQ;IACvC,OAAO,CAAC,WAAW,CAAC,CAAmC;IAGvD,OAAO,CAAC,aAAa,CAA6B;IAMlD,OAAO,CAAC,gBAAgB,CAAQ;IAChC,OAAO,CAAC,mBAAmB,CAAC,CAAQ;IACpC,OAAO,CAAC,oBAAoB,CAAI;IAChC,OAAO,CAAC,iBAAiB,CAAI;IAC7B,OAAO,CAAC,cAAc,CAAQ;gBAGX,SAAS,EAAE,oBAAoB,EAC/B,OAAO,EAAE,yBAAyB,EAClC,OAAO,EAAE,MAAM,EACf,WAAW,EAAE,MAAM,aAAa,EAChC,QAAQ,EAAE,CAAC,EAAE,EAAE,MAAM,IAAI,KAAK,IAAI,EAMlC,sBAAsB,GAAE,MAAM,OAAO,CAAC,IAAI,CAA2B;IASxF,UAAU,CAAC,OAAO,EAAE,iBAAiB,GAAG,IAAI;IAmC5C;;;;;;;OAOG;IACH,OAAO,CAAC,cAAc;IAwBtB;;;;;;;;;;;;;;;;;;;OAmBG;IACH,OAAO,CAAC,eAAe;IAwBvB;;;;;;;;;OASG;IACG,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC;YAad,WAAW;YAiEX,oBAAoB;IAUlC;;;;;;;;;;;OAWG;IACH,OAAO,CAAC,wBAAwB;IAWhC,OAAO,CAAC,QAAQ;IAgChB;;;;;;;;;OASG;IACG,QAAQ,CAAC,SAAS,CAAC,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC;IAcjD;;;;;;;;;;;OAWG;IACG,gBAAgB,CAAC,SAAS,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC;IAoBxD,OAAO,CAAC,kBAAkB;IAM1B,OAAO,CAAC,gBAAgB;CAMzB"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/logs/index.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,MAAM,EAA4B,MAAM,UAAU,CAAA;AAC3D,OAAO,KAAK,EAAE,oBAAoB,EAAE,MAAM,2BAA2B,CAAA;AAErE,OAAO,KAAK,EAGV,iBAAiB,EACjB,aAAa,EACb,yBAAyB,EAC1B,MAAM,SAAS,CAAA;AAEhB,qBAAa,WAAW;IAuBpB,OAAO,CAAC,QAAQ,CAAC,SAAS;IAC1B,OAAO,CAAC,QAAQ,CAAC,OAAO;IACxB,OAAO,CAAC,QAAQ,CAAC,OAAO;IACxB,OAAO,CAAC,QAAQ,CAAC,WAAW;IAC5B,OAAO,CAAC,QAAQ,CAAC,QAAQ;IAMzB,OAAO,CAAC,QAAQ,CAAC,sBAAsB;IAhCzC,OAAO,CAAC,cAAc,CAAQ;IAC9B,OAAO,CAAC,gBAAgB,CAAQ;IAIhC,OAAO,CAAC,uBAAuB,CAAQ;IACvC,OAAO,CAAC,WAAW,CAAC,CAAmC;IAGvD,OAAO,CAAC,aAAa,CAA6B;IAMlD,OAAO,CAAC,gBAAgB,CAAQ;IAChC,OAAO,CAAC,mBAAmB,CAAC,CAAQ;IACpC,OAAO,CAAC,oBAAoB,CAAI;IAChC,OAAO,CAAC,iBAAiB,CAAI;IAC7B,OAAO,CAAC,cAAc,CAAQ;gBAGX,SAAS,EAAE,oBAAoB,EAC/B,OAAO,EAAE,yBAAyB,EAClC,OAAO,EAAE,MAAM,EACf,WAAW,EAAE,MAAM,aAAa,EAChC,QAAQ,EAAE,CAAC,EAAE,EAAE,MAAM,IAAI,KAAK,IAAI,EAMlC,sBAAsB,GAAE,MAAM,OAAO,CAAC,IAAI,CAA2B;IASxF,UAAU,CAAC,OAAO,EAAE,iBAAiB,GAAG,IAAI;IAmC5C;;;;;OAKG;IACH,OAAO,CAAC,cAAc;IAuBtB;;;;;;;;;;;;;;;;;;;OAmBG;IACH,OAAO,CAAC,eAAe;IAwBvB;;;;;;;;;OASG;IACG,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC;YAad,WAAW;YAiEX,oBAAoB;IAUlC;;;;;;;;;;;OAWG;IACH,OAAO,CAAC,wBAAwB;IAWhC,OAAO,CAAC,QAAQ;IAgChB;;;;;;;;;OASG;IACG,QAAQ,CAAC,SAAS,CAAC,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC;IAcjD;;;;;;;;;;;OAWG;IACG,gBAAgB,CAAC,SAAS,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC;IAoBxD,OAAO,CAAC,kBAAkB;IAM1B,OAAO,CAAC,gBAAgB;CAMzB"}

package/dist/logs/index.js

@@ -77,6 +77,7 @@ class PostHogLogs {
             result = next;
         } catch (e) {
             this._logger.error("Error in beforeSend function for log:", e);
+            return null;
         }
         return result;
     }

package/dist/logs/index.mjs

@@ -49,6 +49,7 @@ class PostHogLogs {
             result = next;
         } catch (e) {
             this._logger.error("Error in beforeSend function for log:", e);
+            return null;
         }
         return result;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@posthog/core",
-  "version": "1.32.1",
+  "version": "1.32.2",
   "license": "MIT",
   "main": "dist/index.js",
   "module": "dist/index.mjs",
@@ -67,7 +67,7 @@
     }
   },
   "dependencies": {
-    "@posthog/types": "1.386.1"
+    "@posthog/types": "1.386.2"
   },
   "devDependencies": {
     "@rslib/core": "0.10.6",

package/src/logs/index.spec.ts

@@ -961,9 +961,8 @@ describe('PostHogLogs', () => {
       )
 
     // Cases that share a "captureLog → assert queue body" shape. Bespoke
-    // assertions (logger expectations, throw-doesn't-crash, post-chain
-    // continuation after throw) live in their own `it` blocks below — those
-    // were warping the table when forced into it.
+    // assertions (logger expectations, throw-drops-the-record) live in their
+    // own `it` blocks below — those were warping the table when forced into it.
     type Case = {
       name: string
       beforeSend: PostHogLogsConfig['beforeSend']
@@ -1030,10 +1029,7 @@ describe('PostHogLogs', () => {
       expect(logger.info).toHaveBeenCalledWith('Log was rejected in beforeSend function')
     })
 
-    it('never crashes the caller when a fn throws — the chain continues with the prior result', () => {
-      // Bespoke: needs to verify (a) no throw escapes captureLog, (b) the
-      // chain continues with the previous result so a buggy filter degrades
-      // to a no-op, and (c) the failure is logged. Doesn't fit the table.
+    it('never crashes the caller when a fn throws — drops the record (fail closed) and logs', () => {
       const thrower = jest.fn(() => {
         throw new Error('bad filter')
       })
@@ -1047,7 +1043,8 @@ describe('PostHogLogs', () => {
       )
 
       expect(() => logs.captureLog({ body: 'hi' })).not.toThrow()
-      expect(readQueue(mockInstance)[0].record.body.stringValue).toBe('hi!')
+      expect(readQueue(mockInstance)).toHaveLength(0)
+      expect(after).not.toHaveBeenCalled()
       expect(logger.error).toHaveBeenCalledWith(
         expect.stringContaining('Error in beforeSend function for log:'),
         expect.any(Error)

package/src/logs/index.ts

@@ -92,9 +92,7 @@ export class PostHogLogs {
    * Runs the configured `beforeSend` hook(s) on a capture record:
    *   - single fn OR array of fns (chain, left-to-right)
    *   - returning `null` drops the record (logged at info)
-   *   - a thrown error is logged and the chain *continues* with the previous
-   *     result — a buggy user filter must never crash the caller's
-   *     `captureLog()` call
+   *   - a thrown error is logged and the record is dropped
    */
   private _runBeforeSend(options: CaptureLogOptions): CaptureLogOptions | null {
     const beforeSend = this._config.beforeSend
@@ -112,9 +110,8 @@ export class PostHogLogs {
         }
         result = next
       } catch (e) {
-        // Swallow the throw — the chain continues with `result` unchanged so
-        // a buggy filter degrades to a no-op rather than crashing the app.
         this._logger.error(`Error in beforeSend function for log:`, e)
+        return null
       }
     }
     return result