@posthog/core 1.23.2 → 1.23.3

package/dist/error-tracking/coercers/promise-rejection-event.d.ts

@@ -1,7 +1,14 @@
 import { CoercingContext, ErrorTrackingCoercer, ExceptionLike } from '../types';
-export declare class PromiseRejectionEventCoercer implements ErrorTrackingCoercer<PromiseRejectionEvent> {
-    match(err: unknown): err is PromiseRejectionEvent;
-    coerce(err: PromiseRejectionEvent, ctx: CoercingContext): ExceptionLike | undefined;
+type EventWithDetailReason = Event & {
+    detail: {
+        reason: unknown;
+    };
+};
+export declare class PromiseRejectionEventCoercer implements ErrorTrackingCoercer<PromiseRejectionEvent | EventWithDetailReason> {
+    match(err: unknown): err is PromiseRejectionEvent | EventWithDetailReason;
+    private isCustomEventWrappingRejection;
+    coerce(err: PromiseRejectionEvent | EventWithDetailReason, ctx: CoercingContext): ExceptionLike | undefined;
     private getUnhandledRejectionReason;
 }
+export {};
 //# sourceMappingURL=promise-rejection-event.d.ts.map

package/dist/error-tracking/coercers/promise-rejection-event.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"promise-rejection-event.d.ts","sourceRoot":"","sources":["../../../src/error-tracking/coercers/promise-rejection-event.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,eAAe,EAAE,oBAAoB,EAAE,aAAa,EAAE,MAAM,UAAU,CAAA;AAG/E,qBAAa,4BAA6B,YAAW,oBAAoB,CAAC,qBAAqB,CAAC;IAC9F,KAAK,CAAC,GAAG,EAAE,OAAO,GAAG,GAAG,IAAI,qBAAqB;IAIjD,MAAM,CAAC,GAAG,EAAE,qBAAqB,EAAE,GAAG,EAAE,eAAe,GAAG,aAAa,GAAG,SAAS;IAcnF,OAAO,CAAC,2BAA2B;CA6BpC"}
+{"version":3,"file":"promise-rejection-event.d.ts","sourceRoot":"","sources":["../../../src/error-tracking/coercers/promise-rejection-event.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,eAAe,EAAE,oBAAoB,EAAE,aAAa,EAAE,MAAM,UAAU,CAAA;AAE/E,KAAK,qBAAqB,GAAG,KAAK,GAAG;IAAE,MAAM,EAAE;QAAE,MAAM,EAAE,OAAO,CAAA;KAAE,CAAA;CAAE,CAAA;AAGpE,qBAAa,4BAA6B,YAAW,oBAAoB,CACvE,qBAAqB,GAAG,qBAAqB,CAC9C;IACC,KAAK,CAAC,GAAG,EAAE,OAAO,GAAG,GAAG,IAAI,qBAAqB,GAAG,qBAAqB;IAIzE,OAAO,CAAC,8BAA8B;IAYtC,MAAM,CAAC,GAAG,EAAE,qBAAqB,GAAG,qBAAqB,EAAE,GAAG,EAAE,eAAe,GAAG,aAAa,GAAG,SAAS;IAc3G,OAAO,CAAC,2BAA2B;CAsBpC"}

package/dist/error-tracking/coercers/promise-rejection-event.js

@@ -29,7 +29,16 @@ __webpack_require__.d(__webpack_exports__, {
 const index_js_namespaceObject = require("../../utils/index.js");
 class PromiseRejectionEventCoercer {
     match(err) {
-        return (0, index_js_namespaceObject.isBuiltin)(err, 'PromiseRejectionEvent');
+        return (0, index_js_namespaceObject.isBuiltin)(err, 'PromiseRejectionEvent') || this.isCustomEventWrappingRejection(err);
+    }
+    isCustomEventWrappingRejection(err) {
+        if (!(0, index_js_namespaceObject.isEvent)(err)) return false;
+        try {
+            const detail = err.detail;
+            return null != detail && 'object' == typeof detail && 'reason' in detail;
+        } catch  {
+            return false;
+        }
     }
     coerce(err, ctx) {
         const reason = this.getUnhandledRejectionReason(err);
@@ -42,10 +51,9 @@ class PromiseRejectionEventCoercer {
         return ctx.apply(reason);
     }
     getUnhandledRejectionReason(error) {
-        if ((0, index_js_namespaceObject.isPrimitive)(error)) return error;
         try {
             if ('reason' in error) return error.reason;
-            if ('detail' in error && 'reason' in error.detail) return error.detail.reason;
+            if ('detail' in error && null != error.detail && 'object' == typeof error.detail && 'reason' in error.detail) return error.detail.reason;
         } catch  {}
         return error;
     }

package/dist/error-tracking/coercers/promise-rejection-event.mjs

@@ -1,7 +1,16 @@
-import { isBuiltin, isPrimitive } from "../../utils/index.mjs";
+import { isBuiltin, isEvent, isPrimitive } from "../../utils/index.mjs";
 class PromiseRejectionEventCoercer {
     match(err) {
-        return isBuiltin(err, 'PromiseRejectionEvent');
+        return isBuiltin(err, 'PromiseRejectionEvent') || this.isCustomEventWrappingRejection(err);
+    }
+    isCustomEventWrappingRejection(err) {
+        if (!isEvent(err)) return false;
+        try {
+            const detail = err.detail;
+            return null != detail && 'object' == typeof detail && 'reason' in detail;
+        } catch  {
+            return false;
+        }
     }
     coerce(err, ctx) {
         const reason = this.getUnhandledRejectionReason(err);
@@ -14,10 +23,9 @@ class PromiseRejectionEventCoercer {
         return ctx.apply(reason);
     }
     getUnhandledRejectionReason(error) {
-        if (isPrimitive(error)) return error;
         try {
             if ('reason' in error) return error.reason;
-            if ('detail' in error && 'reason' in error.detail) return error.detail.reason;
+            if ('detail' in error && null != error.detail && 'object' == typeof error.detail && 'reason' in error.detail) return error.detail.reason;
         } catch  {}
         return error;
     }

package/dist/utils/user-agent-utils.d.ts

@@ -15,5 +15,11 @@ export declare const detectBrowser: (user_agent: string, vendor: string | undefi
 export declare const detectBrowserVersion: (userAgent: string, vendor: string | undefined) => number | null;
 export declare const detectOS: (user_agent: string) => [string, string];
 export declare const detectDevice: (user_agent: string) => string;
-export declare const detectDeviceType: (user_agent: string) => string;
+export declare const detectDeviceType: (user_agent: string, options?: {
+    userAgentDataPlatform?: string;
+    maxTouchPoints?: number;
+    screenWidth?: number;
+    screenHeight?: number;
+    devicePixelRatio?: number;
+}) => string;
 //# sourceMappingURL=user-agent-utils.d.ts.map

package/dist/utils/user-agent-utils.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"user-agent-utils.d.ts","sourceRoot":"","sources":["../../src/utils/user-agent-utils.ts"],"names":[],"mappings":"AAqFA;;;;GAIG;AACH,eAAO,MAAM,aAAa,GAAa,YAAY,MAAM,EAAE,QAAQ,MAAM,GAAG,SAAS,KAAG,MA4CvF,CAAA;AAsBD;;;;;;;GAOG;AACH,eAAO,MAAM,oBAAoB,GAAa,WAAW,MAAM,EAAE,QAAQ,MAAM,GAAG,SAAS,KAAG,MAAM,GAAG,IAetG,CAAA;AA0FD,eAAO,MAAM,QAAQ,GAAa,YAAY,MAAM,KAAG,CAAC,MAAM,EAAE,MAAM,CAUrE,CAAA;AAED,eAAO,MAAM,YAAY,GAAa,YAAY,MAAM,KAAG,MAuD1D,CAAA;AAED,eAAO,MAAM,gBAAgB,GAAa,YAAY,MAAM,KAAG,MAmB9D,CAAA"}
+{"version":3,"file":"user-agent-utils.d.ts","sourceRoot":"","sources":["../../src/utils/user-agent-utils.ts"],"names":[],"mappings":"AAqFA;;;;GAIG;AACH,eAAO,MAAM,aAAa,GAAa,YAAY,MAAM,EAAE,QAAQ,MAAM,GAAG,SAAS,KAAG,MA4CvF,CAAA;AAsBD;;;;;;;GAOG;AACH,eAAO,MAAM,oBAAoB,GAAa,WAAW,MAAM,EAAE,QAAQ,MAAM,GAAG,SAAS,KAAG,MAAM,GAAG,IAetG,CAAA;AA0FD,eAAO,MAAM,QAAQ,GAAa,YAAY,MAAM,KAAG,CAAC,MAAM,EAAE,MAAM,CAUrE,CAAA;AAED,eAAO,MAAM,YAAY,GAAa,YAAY,MAAM,KAAG,MAuD1D,CAAA;AAED,eAAO,MAAM,gBAAgB,GAC3B,YAAY,MAAM,EAClB,UAAU;IACR,qBAAqB,CAAC,EAAE,MAAM,CAAA;IAC9B,cAAc,CAAC,EAAE,MAAM,CAAA;IACvB,WAAW,CAAC,EAAE,MAAM,CAAA;IACpB,YAAY,CAAC,EAAE,MAAM,CAAA;IACrB,gBAAgB,CAAC,EAAE,MAAM,CAAA;CAC1B,KACA,MA4BF,CAAA"}

package/dist/utils/user-agent-utils.js

@@ -359,12 +359,17 @@ const detectDevice = function(user_agent) {
     else if (new RegExp(TABLET, 'i').test(user_agent) && !new RegExp(TABLET + ' pc', 'i').test(user_agent)) return GENERIC_TABLET;
     else return '';
 };
-const detectDeviceType = function(user_agent) {
+const detectDeviceType = function(user_agent, options) {
     const device = detectDevice(user_agent);
     if (device === IPAD || device === ANDROID_TABLET || 'Kobo' === device || 'Kindle Fire' === device || device === GENERIC_TABLET) return TABLET;
     if (device === NINTENDO || device === XBOX || device === PLAYSTATION || device === OUYA) return 'Console';
     if (device === APPLE_WATCH) return 'Wearable';
     if (device) return MOBILE;
+    if (options?.userAgentDataPlatform === 'Android' && (options?.maxTouchPoints ?? 0) > 0) {
+        const shortSide = Math.min(options?.screenWidth ?? 0, options?.screenHeight ?? 0);
+        const shortSideDp = shortSide / (options?.devicePixelRatio ?? 1);
+        return shortSideDp >= 600 ? TABLET : MOBILE;
+    }
     return 'Desktop';
 };
 exports.detectBrowser = __webpack_exports__.detectBrowser;

package/dist/utils/user-agent-utils.mjs

@@ -327,12 +327,17 @@ const detectDevice = function(user_agent) {
     else if (new RegExp(TABLET, 'i').test(user_agent) && !new RegExp(TABLET + ' pc', 'i').test(user_agent)) return GENERIC_TABLET;
     else return '';
 };
-const detectDeviceType = function(user_agent) {
+const detectDeviceType = function(user_agent, options) {
     const device = detectDevice(user_agent);
     if (device === IPAD || device === ANDROID_TABLET || 'Kobo' === device || 'Kindle Fire' === device || device === GENERIC_TABLET) return TABLET;
     if (device === NINTENDO || device === XBOX || device === PLAYSTATION || device === OUYA) return 'Console';
     if (device === APPLE_WATCH) return 'Wearable';
     if (device) return MOBILE;
+    if (options?.userAgentDataPlatform === 'Android' && (options?.maxTouchPoints ?? 0) > 0) {
+        const shortSide = Math.min(options?.screenWidth ?? 0, options?.screenHeight ?? 0);
+        const shortSideDp = shortSide / (options?.devicePixelRatio ?? 1);
+        return shortSideDp >= 600 ? TABLET : MOBILE;
+    }
     return 'Desktop';
 };
 export { detectBrowser, detectBrowserVersion, detectDevice, detectDeviceType, detectOS };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@posthog/core",
-  "version": "1.23.2",
+  "version": "1.23.3",
   "license": "MIT",
   "main": "dist/index.js",
   "module": "dist/index.mjs",

package/src/error-tracking/coercers/promise-rejection-event.ts

@@ -1,13 +1,29 @@
-import { isBuiltin, isPrimitive } from '@/utils'
+import { isBuiltin, isEvent, isPrimitive } from '@/utils'
 import { CoercingContext, ErrorTrackingCoercer, ExceptionLike } from '../types'
 
+type EventWithDetailReason = Event & { detail: { reason: unknown } }
+
 // Web only
-export class PromiseRejectionEventCoercer implements ErrorTrackingCoercer<PromiseRejectionEvent> {
-  match(err: unknown): err is PromiseRejectionEvent {
-    return isBuiltin(err, 'PromiseRejectionEvent')
+export class PromiseRejectionEventCoercer implements ErrorTrackingCoercer<
+  PromiseRejectionEvent | EventWithDetailReason
+> {
+  match(err: unknown): err is PromiseRejectionEvent | EventWithDetailReason {
+    return isBuiltin(err, 'PromiseRejectionEvent') || this.isCustomEventWrappingRejection(err)
   }
 
-  coerce(err: PromiseRejectionEvent, ctx: CoercingContext): ExceptionLike | undefined {
+  private isCustomEventWrappingRejection(err: unknown): err is EventWithDetailReason {
+    if (!isEvent(err)) {
+      return false
+    }
+    try {
+      const detail = (err as EventWithDetailReason).detail
+      return detail != null && typeof detail === 'object' && 'reason' in detail
+    } catch {
+      return false
+    }
+  }
+
+  coerce(err: PromiseRejectionEvent | EventWithDetailReason, ctx: CoercingContext): ExceptionLike | undefined {
     const reason = this.getUnhandledRejectionReason(err)
     if (isPrimitive(reason)) {
       return {
@@ -21,28 +37,21 @@ export class PromiseRejectionEventCoercer implements ErrorTrackingCoercer<Promis
     }
   }
 
-  private getUnhandledRejectionReason(error: unknown): unknown {
-    if (isPrimitive(error)) {
-      return error
-    }
-
-    // dig the object of the rejection out of known event types
+  private getUnhandledRejectionReason(error: PromiseRejectionEvent | EventWithDetailReason): unknown {
     try {
-      type ErrorWithReason = { reason: unknown }
       // PromiseRejectionEvents store the object of the rejection under 'reason'
       // see https://developer.mozilla.org/en-US/docs/Web/API/PromiseRejectionEvent
-      if ('reason' in (error as ErrorWithReason)) {
-        return (error as ErrorWithReason).reason
+      if ('reason' in error) {
+        return error.reason
       }
 
-      type CustomEventWithDetail = { detail: { reason: unknown } }
       // something, somewhere, (likely a browser extension) effectively casts PromiseRejectionEvents
       // to CustomEvents, moving the `promise` and `reason` attributes of the PRE into
       // the CustomEvent's `detail` attribute, since they're not part of CustomEvent's spec
       // see https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent and
       // https://github.com/getsentry/sentry-javascript/issues/2380
-      if ('detail' in (error as CustomEventWithDetail) && 'reason' in (error as CustomEventWithDetail).detail) {
-        return (error as CustomEventWithDetail).detail.reason
+      if ('detail' in error && error.detail != null && typeof error.detail === 'object' && 'reason' in error.detail) {
+        return error.detail.reason
       }
     } catch {
       // no-empty

package/src/error-tracking/error-properties-builder.coerce.spec.ts

@@ -1,4 +1,11 @@
-import { DOMExceptionCoercer, ErrorEventCoercer, ErrorCoercer, ObjectCoercer, StringCoercer } from './coercers'
+import {
+  DOMExceptionCoercer,
+  ErrorEventCoercer,
+  ErrorCoercer,
+  ObjectCoercer,
+  StringCoercer,
+  EventCoercer,
+} from './coercers'
 import { PrimitiveCoercer } from './coercers/primitive-coercer'
 import { PromiseRejectionEventCoercer } from './coercers/promise-rejection-event'
 import { ErrorPropertiesBuilder } from './error-properties-builder'
@@ -21,6 +28,7 @@ describe('ErrorPropertiesBuilder', () => {
         new ErrorEventCoercer(),
         new ErrorCoercer(),
         new PromiseRejectionEventCoercer(),
+        new EventCoercer(),
         new ObjectCoercer(),
         new StringCoercer(),
         new PrimitiveCoercer(),
@@ -165,7 +173,7 @@ describe('ErrorPropertiesBuilder', () => {
       const exception = coerceInput(event, syntheticError)
       expect(exception).toMatchObject({
         type: 'MouseEvent',
-        value: "'MouseEvent' captured as exception with keys: [object has no keys]",
+        value: 'MouseEvent captured as exception with keys: [object has no keys]',
         stack: syntheticError.stack,
         synthetic: true,
       })
@@ -199,5 +207,23 @@ describe('ErrorPropertiesBuilder', () => {
         synthetic: false,
       })
     })
+
+    it('should extract the buried Error from a CustomEvent wrapping a PromiseRejectionEvent', () => {
+      const buriedError = new Error('Extension context invalidated.')
+      const customEvent = new CustomEvent('unhandledrejection', {
+        detail: {
+          reason: buriedError,
+          promise: Promise.resolve(),
+        },
+      })
+
+      const exception = coerceInput(customEvent)
+
+      expect(exception).toMatchObject({
+        type: 'Error',
+        value: 'Extension context invalidated.',
+        stack: buriedError.stack,
+      })
+    })
   })
 })

package/src/utils/user-agent-utils.ts

@@ -336,7 +336,16 @@ export const detectDevice = function (user_agent: string): string {
   }
 }
 
-export const detectDeviceType = function (user_agent: string): string {
+export const detectDeviceType = function (
+  user_agent: string,
+  options?: {
+    userAgentDataPlatform?: string
+    maxTouchPoints?: number
+    screenWidth?: number
+    screenHeight?: number
+    devicePixelRatio?: number
+  }
+): string {
   const device = detectDevice(user_agent)
   if (
     device === IPAD ||
@@ -352,7 +361,16 @@ export const detectDeviceType = function (user_agent: string): string {
     return 'Wearable'
   } else if (device) {
     return MOBILE
-  } else {
-    return 'Desktop'
   }
+
+  // Chrome on Android tablets defaults to "request desktop site" mode, sending
+  // a desktop-like UA (e.g. "X11; Linux x86_64") indistinguishable from desktop Linux.
+  // The Client Hints API reports the true platform even when the UA lies.
+  if (options?.userAgentDataPlatform === 'Android' && (options?.maxTouchPoints ?? 0) > 0) {
+    const shortSide = Math.min(options?.screenWidth ?? 0, options?.screenHeight ?? 0)
+    const shortSideDp = shortSide / (options?.devicePixelRatio ?? 1)
+    return shortSideDp >= 600 ? TABLET : MOBILE
+  }
+
+  return 'Desktop'
 }