@posthog/agent 2.3.616 → 2.3.643

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@posthog/agent",
-  "version": "2.3.616",
+  "version": "2.3.643",
   "repository": "https://github.com/PostHog/code",
   "description": "TypeScript agent framework wrapping Claude Agent SDK with Git-based task execution for PostHog",
   "exports": {
@@ -106,9 +106,9 @@
     "tsx": "^4.20.6",
     "typescript": "^5.5.0",
     "vitest": "^2.1.8",
+    "@posthog/git": "1.0.0",
     "@posthog/shared": "1.0.0",
-    "@posthog/enricher": "1.0.0",
-    "@posthog/git": "1.0.0"
+    "@posthog/enricher": "1.0.0"
   },
   "dependencies": {
     "@agentclientprotocol/sdk": "0.19.0",

package/src/adapters/claude/conversion/acp-to-sdk.test.ts

@@ -1,8 +1,34 @@
+import type { PromptRequest } from "@agentclientprotocol/sdk";
 import { describe, expect, it } from "vitest";
-import { promptToClaude } from "./acp-to-sdk";
+import {
+  promptToClaude,
+  readToolGuidanceForPath,
+  workspacePromptFromFileUri,
+} from "./acp-to-sdk";
+
+describe("readToolGuidanceForPath", () => {
+  it.each([
+    ["/docs/x.pdf", ["pages"]],
+    ["/proj/app.ts", ["offset", "limit"]],
+    ["/assets/logo.png", ["Binary", "file_path"]],
+  ])("guides reads for %s", (filePath, keywords) => {
+    const guidance = readToolGuidanceForPath(filePath);
+    for (const keyword of keywords) {
+      expect(guidance).toContain(keyword);
+    }
+  });
+});
+
+describe("workspacePromptFromFileUri", () => {
+  it("includes file_path and Read-oriented chunking hints", () => {
+    const s = workspacePromptFromFileUri("file:///tmp/x.pdf");
+    expect(s).toContain("Read");
+    expect(s).toContain("file_path: /tmp/x.pdf");
+  });
+});
 
 describe("promptToClaude", () => {
-  it("renders file resource links as explicit workspace attachments", () => {
+  it("maps file resource_link to workspace path + Read guidance", () => {
     const result = promptToClaude({
       sessionId: "session-1",
       prompt: [
@@ -14,17 +40,87 @@ describe("promptToClaude", () => {
       ],
     });
 
-    expect(result.message.content).toEqual([
-      {
-        type: "text",
-        text: [
-          "Attached file available in the workspace:",
-          "- name: report.pdf",
-          "- path: /tmp/workspace/.posthog/attachments/run-1/report.pdf",
-          "Use the available tools to inspect this file if needed.",
-        ].join("\n"),
-      },
-    ]);
+    expect(result.message.content.length).toBe(1);
+    expect(result.message.content[0]).toMatchObject({
+      type: "text",
+      text: expect.any(String),
+    });
+    expect(
+      (result.message.content[0] as { type: string; text: string }).text,
+    ).toContain("file_path:");
+    expect(
+      (result.message.content[0] as { type: string; text: string }).text,
+    ).toContain("/tmp/workspace/.posthog/attachments/run-1/report.pdf");
+    const text = (result.message.content[0] as { text: string }).text;
+    expect(text.toLowerCase()).toContain("read");
+    expect(text).toContain("pages");
+  });
+
+  it("drops embedded body for file:// resource but keeps attachment:// payload", () => {
+    const hugeInline = `${"y".repeat(30_000)}KEEP_ATTACH${"y".repeat(30_000)}`;
+    const fileRes = promptToClaude({
+      sessionId: "x",
+      prompt: [
+        {
+          type: "resource",
+          resource: {
+            uri: "file:///tmp/note.txt",
+            text: `${"x".repeat(50_000)}DROP_THIS${"x".repeat(50_000)}`,
+            mimeType: "text/plain",
+          },
+        },
+      ],
+    });
+    expect(fileRes.message.content.length).toBe(1);
+    expect(JSON.stringify(fileRes)).not.toContain("DROP_THIS");
+    expect(fileRes.message.content[0]).toMatchObject({
+      type: "text",
+      text: expect.stringContaining("file_path: /tmp/note.txt"),
+    });
+
+    const attachRes = promptToClaude({
+      sessionId: "y",
+      prompt: [
+        {
+          type: "resource",
+          resource: {
+            uri: "attachment://z?label=f.txt",
+            text: hugeInline,
+            mimeType: "text/plain",
+          },
+        },
+      ],
+    });
+    expect(attachRes.message.content.length).toBe(2);
+    expect(JSON.stringify(attachRes)).toContain("KEEP_ATTACH");
+  });
+
+  it("maps file URI-only image blocks to workspace Read prompt text", () => {
+    const req: PromptRequest = {
+      sessionId: "session-1",
+      prompt: [
+        {
+          type: "image",
+          uri: "file:///tmp/ui/screenshot.png",
+          mimeType: "image/png",
+        } as PromptRequest["prompt"][number],
+      ],
+    };
+    const result = promptToClaude(req);
+
+    expect(result.message.content).toHaveLength(1);
+    expect(result.message.content[0]).toMatchObject({
+      type: "text",
+      text: expect.any(String),
+    });
+    expect(
+      (result.message.content[0] as { type: string; text: string }).text,
+    ).toContain("/tmp/ui/screenshot.png");
+    expect(
+      (
+        result.message.content[0] as { type: string; text: string }
+      ).text.toLowerCase(),
+    ).toContain("read");
   });
 
   it("preserves non-file resource links as links", () => {

package/src/adapters/claude/conversion/acp-to-sdk.ts

@@ -6,6 +6,31 @@ import type { ContentBlockParam } from "@anthropic-ai/sdk/resources";
 
 type ImageMimeType = "image/jpeg" | "image/png" | "image/gif" | "image/webp";
 
+const PDF_EXTENSIONS = new Set(["pdf"]);
+
+const COMMON_IMAGE_EXTENSIONS = new Set([
+  "png",
+  "jpg",
+  "jpeg",
+  "gif",
+  "webp",
+  "bmp",
+  "svg",
+  "heic",
+  "tif",
+  "tiff",
+]);
+
+const VIDEO_EXTENSIONS = new Set([
+  "mp4",
+  "mov",
+  "webm",
+  "mkv",
+  "avi",
+  "mpeg",
+  "mpg",
+]);
+
 function sdkText(value: string): ContentBlockParam {
   return { type: "text", text: value };
 }
@@ -22,21 +47,42 @@ function formatUriAsLink(uri: string): string {
   }
 }
 
-function formatFileAttachment(uri: string): string {
+/** Chunking hints for Claude Code `Read` (`file_path`, optional `pages` / `offset` / `limit`). */
+export function readToolGuidanceForPath(filePath: string): string {
+  const ext = path.extname(filePath).slice(1).toLowerCase();
+  if (PDF_EXTENSIONS.has(ext)) {
+    return 'Optional `pages` string (e.g. "1-5") per Read call instead of loading the entire PDF.';
+  }
+  if (COMMON_IMAGE_EXTENSIONS.has(ext) || VIDEO_EXTENSIONS.has(ext)) {
+    return "Binary file — use Read with `file_path`; prefer bounded reads where supported.";
+  }
+  return "Large text — use multiple Read calls with optional `offset` and `limit`.";
+}
+
+/** Path-only workspace attach text (never embed `resource.text` from disk). */
+export function workspacePromptFromFileUri(uri: string): string {
   try {
     const filePath = fileURLToPath(uri);
     const name = path.basename(filePath) || filePath;
     return [
-      "Attached file available in the workspace:",
-      `- name: ${name}`,
-      `- path: ${filePath}`,
-      "Use the available tools to inspect this file if needed.",
+      "Attached workspace file — use Read with required `file_path`:",
+      `- file_path: ${filePath}`,
+      `- name (context): ${name}`,
+      readToolGuidanceForPath(filePath),
     ].join("\n");
   } catch {
-    return `Attached file available at ${uri}`;
+    return [
+      "Attached file — decode path from URI, call Read with that path as `file_path`:",
+      uri,
+      'Chunk PDFs with `pages` (e.g. "1-5"); long text with `offset`/`limit`.',
+    ].join("\n");
   }
 }
 
+function isFileSchemeUri(uri: string | undefined | null): boolean {
+  return Boolean(uri?.startsWith("file://"));
+}
+
 function transformMcpCommand(text: string): string {
   const mcpMatch = text.match(/^\/mcp:([^:\s]+):(\S+)(\s+.*)?$/);
   if (mcpMatch) {
@@ -60,7 +106,7 @@ function processPromptChunk(
       content.push(
         sdkText(
           chunk.uri.startsWith("file://")
-            ? formatFileAttachment(chunk.uri)
+            ? workspacePromptFromFileUri(chunk.uri)
             : formatUriAsLink(chunk.uri),
         ),
       );
@@ -68,10 +114,16 @@ function processPromptChunk(
 
     case "resource":
       if ("text" in chunk.resource) {
-        content.push(sdkText(formatUriAsLink(chunk.resource.uri)));
+        const uri = chunk.resource.uri;
+        if (uri != null && isFileSchemeUri(uri)) {
+          content.push(sdkText(workspacePromptFromFileUri(uri)));
+          break;
+        }
+
+        content.push(sdkText(formatUriAsLink(uri ?? "")));
         context.push(
           sdkText(
-            `\n<context ref="${chunk.resource.uri}">\n${chunk.resource.text}\n</context>`,
+            `\n<context ref="${uri ?? ""}">\n${chunk.resource.text}\n</context>`,
           ),
         );
       }
@@ -92,6 +144,8 @@ function processPromptChunk(
           type: "image",
           source: { type: "url", url: chunk.uri },
         });
+      } else if (chunk.uri != null && isFileSchemeUri(chunk.uri)) {
+        content.push(sdkText(workspacePromptFromFileUri(chunk.uri)));
       }
       break;
 

package/src/server/agent-server.test.ts

@@ -826,6 +826,9 @@ describe("AgentServer HTTP Mode", () => {
           "If the user explicitly asks you to open or update a pull request",
           "open a draft pull request",
           "unless the user explicitly asks",
+          ".github/pull_request_template.md",
+          "gh issue list --search",
+          "Closes #<n>",
           "Generated-By: PostHog Code",
           "Task-Id: test-task-id",
         ],
@@ -868,6 +871,13 @@ describe("AgentServer HTTP Mode", () => {
       expect(prompt).toContain("Generated-By: PostHog Code");
       expect(prompt).toContain("Task-Id: test-task-id");
       expect(prompt).toContain("Created with [PostHog Code]");
+      // PR template detection (repo first, org `.github` fallback)
+      expect(prompt).toContain(".github/pull_request_template.md");
+      expect(prompt).toContain("org's `.github` repo");
+      // Related-issue linking
+      expect(prompt).toContain("gh issue list --state open --search");
+      expect(prompt).toContain("Closes #<n>");
+      expect(prompt).toContain("Refs #<n>");
       delete process.env.POSTHOG_CODE_INTERACTION_ORIGIN;
     });
 
@@ -895,6 +905,13 @@ describe("AgentServer HTTP Mode", () => {
       );
       expect(prompt).toContain("Push to the existing PR branch");
       expect(prompt).not.toContain("Create a draft pull request");
+      // Review-comment thread handling: reply + resolve
+      expect(prompt).toContain("review thread");
+      expect(prompt).toContain("/pulls/{n}/comments/{id}/replies");
+      expect(prompt).toContain("resolveReviewThread");
+      expect(prompt).toContain(
+        "Do NOT push fixes for review comments without replying to and resolving each related thread.",
+      );
       delete process.env.POSTHOG_CODE_INTERACTION_ORIGIN;
     });
 

package/src/server/agent-server.ts

@@ -1643,9 +1643,14 @@ After completing the requested changes:
 1. Check out the existing PR branch with \`gh pr checkout ${prUrl}\`
 2. Stage and commit all changes with a clear commit message
 3. Push to the existing PR branch
+4. For every PR review comment or review thread you addressed, treat the thread as done only after BOTH of these:
+   - Reply on the thread with a short note describing what changed (reference the commit SHA when useful) using \`gh api -X POST /repos/{owner}/{repo}/pulls/{n}/comments/{id}/replies -f body='...'\`.
+   - Resolve the thread via the \`resolveReviewThread\` GraphQL mutation: \`gh api graphql -f query='mutation($id:ID!){resolveReviewThread(input:{threadId:$id}){thread{isResolved}}}' -f id="<thread-node-id>"\`.
+   List unresolved threads first with \`gh api graphql -f query='{repository(owner:"<owner>",name:"<repo>"){pullRequest(number:<n>){reviewThreads(first:100){nodes{id isResolved comments(first:1){nodes{body}}}}}}}'\` so you can resolve each one you fixed.
 
 Important:
 - Do NOT create a new branch or a new pull request.
+- Do NOT push fixes for review comments without replying to and resolving each related thread.
 ${attributionInstructions}
 `;
     }
@@ -1661,7 +1666,7 @@ When the user asks for code changes:
 When the user explicitly asks to clone or work in a GitHub repository:
 - Clone the repository into /tmp/workspace/repos/<owner>/<repo> using \`gh repo clone <owner>/<repo> /tmp/workspace/repos/<owner>/<repo>\`
 - Work from inside that cloned repository for follow-up code changes
-- If the user explicitly asks you to open or update a pull request, create a branch, commit the requested changes, push it, and open a draft pull request from inside the clone
+- If the user explicitly asks you to open or update a pull request, create a branch, commit the requested changes, push it, and open a draft pull request from inside the clone. Before opening the PR, check the cloned repo for a PR template at \`.github/pull_request_template.md\` (or variants; fall back to the org's \`.github\` repo via \`gh api\`) and use it as the body structure, and search for matching open issues with \`gh issue list --search\` to include \`Closes #<n>\` / \`Refs #<n>\` links.
 - Do NOT create branches, commits, push changes, or open pull requests unless the user explicitly asks for that`;
 
       return `
@@ -1704,7 +1709,11 @@ After completing the requested changes:
 1. Create a new branch prefixed with \`posthog-code/\` (e.g. \`posthog-code/fix-login-redirect\`) based on the work done
 2. Stage and commit all changes with a clear commit message
 3. Push the branch to origin
-4. Create a draft pull request using \`gh pr create --draft${this.config.baseBranch ? ` --base ${this.config.baseBranch}` : ""}\` with a descriptive title and body. Add the following footer at the end of the PR description:
+4. Before opening the PR, prepare the body:
+   - Check the repo for a PR template at \`.github/pull_request_template.md\` (also try \`.github/PULL_REQUEST_TEMPLATE.md\`, \`docs/pull_request_template.md\`, and root variants). If one exists, use its exact section headings as the PR body — do NOT fall back to a generic Summary/Test plan format.
+   - If no repo-level template exists, check the org's \`.github\` repo via \`gh api /repos/<owner>/.github/contents/.github/pull_request_template.md\` (and other common paths) and use that as a fallback.
+   - Search for matching open issues with \`gh issue list --state open --search '<keywords>'\` (derive keywords from the branch name, commits, and changed files; \`gh issue view <n>\` to confirm relevance). For every issue this PR would resolve, include a \`Closes #<n>\` line in the body so GitHub auto-links and auto-closes it on merge. For issues that are related but not fully resolved, use \`Refs #<n>\` instead.
+5. Create a draft pull request using \`gh pr create --draft${this.config.baseBranch ? ` --base ${this.config.baseBranch}` : ""}\` with a descriptive title and the body prepared above. Add the following footer at the end of the PR description:
 \`\`\`
 ---
 *Created with [PostHog Code](https://posthog.com/code?ref=pr)*