@posthog/agent 2.3.504 → 2.3.508

package/src/adapters/claude/session/settings.ts

@@ -196,6 +196,7 @@ export interface ClaudeCodeSettings {
   permissions?: PermissionSettings;
   env?: Record<string, string>;
   model?: string;
+  posthogApprovedExecTools?: string[];
 }
 
 export type PermissionDecision = "allow" | "deny" | "ask";
@@ -295,6 +296,7 @@ export class SettingsManager {
       ask: [],
     };
     const merged: ClaudeCodeSettings = { permissions };
+    const posthogApprovedExecTools = new Set<string>();
 
     for (const settings of allSettings) {
       if (settings.permissions) {
@@ -323,6 +325,15 @@ export class SettingsManager {
       if (settings.model) {
         merged.model = settings.model;
       }
+      if (settings.posthogApprovedExecTools) {
+        for (const tool of settings.posthogApprovedExecTools) {
+          posthogApprovedExecTools.add(tool);
+        }
+      }
+    }
+
+    if (posthogApprovedExecTools.size > 0) {
+      merged.posthogApprovedExecTools = Array.from(posthogApprovedExecTools);
     }
 
     this.mergedSettings = merged;
@@ -405,6 +416,43 @@ export class SettingsManager {
     }
   }
 
+  hasPostHogExecApproval(subTool: string): boolean {
+    return (
+      this.mergedSettings.posthogApprovedExecTools?.includes(subTool) ?? false
+    );
+  }
+
+  /**
+   * Persists an approved PostHog MCP `exec` sub-tool (e.g. `experiment-update`)
+   * to the local settings file so future calls skip the prompt. Mirrors
+   * `addAllowRules` — serialised via `writeMutex`, atomic temp-file + rename.
+   */
+  async addPostHogExecApproval(subTool: string): Promise<void> {
+    if (!subTool) return;
+    if (!this.initialized) await this.initialize();
+    await this.writeMutex.acquire();
+    try {
+      const filePath = this.getLocalSettingsPath();
+      const existing = await readSettingsFileForUpdate(filePath);
+      const current = new Set(existing.posthogApprovedExecTools ?? []);
+      if (current.has(subTool)) {
+        return;
+      }
+      current.add(subTool);
+      const next: ClaudeCodeSettings = {
+        ...existing,
+        posthogApprovedExecTools: Array.from(current),
+      };
+      await fs.promises.mkdir(path.dirname(filePath), { recursive: true });
+      await writeFileAtomic(filePath, `${JSON.stringify(next, null, 2)}\n`);
+
+      this.localSettings = next;
+      this.mergeAllSettings();
+    } finally {
+      this.writeMutex.release();
+    }
+  }
+
   async setCwd(cwd: string): Promise<void> {
     if (this.cwd === cwd) return;
     if (this.initPromise) await this.initPromise;

package/src/server/agent-server.test.ts

@@ -639,6 +639,49 @@ describe("AgentServer HTTP Mode", () => {
       expect(prompt).toContain("stop with local changes ready for review");
     });
 
+    it.each([
+      {
+        label: "createPr unset",
+        config: { repositoryPath: undefined },
+        shouldContain: [
+          "Cloud Task Execution — No Repository Mode",
+          "Clone the repository into /tmp/workspace/repos/<owner>/<repo>",
+          "gh repo clone <owner>/<repo> /tmp/workspace/repos/<owner>/<repo>",
+          "If the user explicitly asks you to open or update a pull request",
+          "open a draft pull request",
+          "unless the user explicitly asks",
+          "Generated-By: PostHog Code",
+          "Task-Id: test-task-id",
+        ],
+        shouldNotContain: [],
+      },
+      {
+        label: "createPr false",
+        config: { repositoryPath: undefined, createPr: false },
+        shouldContain: [
+          "Cloud Task Execution — No Repository Mode",
+          "You may clone a repository and make local edits in that clone",
+          "Do NOT create branches, commits, push changes, or open pull requests in this run",
+        ],
+        shouldNotContain: ["open a draft pull request", "gh pr create --draft"],
+      },
+    ])(
+      "returns no-repository prompt for $label",
+      ({ config, shouldContain, shouldNotContain }) => {
+        const s = createServer(config);
+        const prompt = (
+          s as unknown as TestableServer
+        ).buildCloudSystemPrompt();
+
+        for (const text of shouldContain) {
+          expect(prompt).toContain(text);
+        }
+        for (const text of shouldNotContain) {
+          expect(prompt).not.toContain(text);
+        }
+      },
+    );
+
     it("returns auto-PR prompt for Slack-origin runs", () => {
       process.env.POSTHOG_CODE_INTERACTION_ORIGIN = "slack";
       const s = createServer();

package/src/server/agent-server.ts

@@ -1605,6 +1605,19 @@ ${attributionInstructions}
     }
 
     if (!this.config.repositoryPath) {
+      const publishInstructions =
+        this.config.createPr === false
+          ? `
+When the user asks for code changes:
+- You may clone a repository and make local edits in that clone
+- Do NOT create branches, commits, push changes, or open pull requests in this run`
+          : `
+When the user explicitly asks to clone or work in a GitHub repository:
+- Clone the repository into /tmp/workspace/repos/<owner>/<repo> using \`gh repo clone <owner>/<repo> /tmp/workspace/repos/<owner>/<repo>\`
+- Work from inside that cloned repository for follow-up code changes
+- If the user explicitly asks you to open or update a pull request, create a branch, commit the requested changes, push it, and open a draft pull request from inside the clone
+- Do NOT create branches, commits, push changes, or open pull requests unless the user explicitly asks for that`;
+
       return `
 # Cloud Task Execution — No Repository Mode
 
@@ -1617,11 +1630,12 @@ When the user asks about analytics, data, metrics, events, funnels, dashboards,
 
 When the user asks for code changes or software engineering tasks:
 - Let them know you can help but don't have a repository connected for this session
-- Offer to write code snippets, scripts, or provide guidance
+- If they have not specified a repository to clone, offer to write code snippets, scripts, or provide guidance
+${publishInstructions}
 
 Important:
-- Do NOT create branches, commits, or pull requests in this mode.
 - Prefer using MCP tools to answer questions with real data over giving generic advice.
+${attributionInstructions}
 `;
     }