@posthog/agent 2.3.351 → 2.3.354

package/src/server/question-relay.test.ts

@@ -1,5 +1,6 @@
 import { type SetupServerApi, setupServer } from "msw/node";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+import { classifyAgentError } from "../adapters/claude/conversion/sdk-to-acp";
 import type { PostHogAPIClient } from "../posthog-api";
 import { createTestRepo, type TestRepo } from "../test/fixtures/api";
 import { createPostHogHandlers } from "../test/mocks/msw-handlers";
@@ -49,7 +50,42 @@ const QUESTION_META = {
   ],
 };
 
+function createTransientPromptError(): Error & {
+  data: { classification: string; result: string };
+} {
+  const error = new Error("API Error: terminated") as Error & {
+    data: { classification: string; result: string };
+  };
+  error.data = {
+    classification: "upstream_stream_terminated",
+    result: "API Error: terminated",
+  };
+  return error;
+}
+
+function createTransientConnectionError(): Error & {
+  data: { classification: string; result: string };
+} {
+  const error = new Error("fetch failed") as Error & {
+    data: { classification: string; result: string };
+  };
+  error.data = {
+    classification: "upstream_connection_error",
+    result: "fetch failed",
+  };
+  return error;
+}
+
 describe("Question relay", () => {
+  it.each([
+    ["API Error: terminated", "upstream_stream_terminated"],
+    ["API Error: Connection error", "upstream_connection_error"],
+    ["something else", "agent_error"],
+    [undefined, "agent_error"],
+  ])("classifies %p as %s", (message, expected) => {
+    expect(classifyAgentError(message)).toBe(expected);
+  });
+
   let repo: TestRepo;
   let server: TestableAgentServer;
   let mswServer: SetupServerApi;
@@ -514,5 +550,93 @@ describe("Question relay", () => {
         prompt: [{ type: "text", text: "original task description" }],
       });
     });
+
+    it("does not replay a transient upstream termination before any session activity", async () => {
+      vi.spyOn(server.posthogAPI, "getTask").mockResolvedValue({
+        id: "test-task-id",
+        title: "t",
+        description: "original task description",
+      } as unknown as Task);
+      vi.spyOn(server.posthogAPI, "getTaskRun").mockResolvedValue({
+        id: "test-run-id",
+        task: "test-task-id",
+        state: {},
+      } as unknown as TaskRun);
+
+      const promptSpy = vi
+        .fn()
+        .mockRejectedValueOnce(createTransientPromptError());
+      const updateTaskRunSpy = vi
+        .spyOn(server.posthogAPI, "updateTaskRun")
+        .mockResolvedValue({} as TaskRun);
+      server.session = {
+        payload: TEST_PAYLOAD,
+        acpSessionId: "acp-session",
+        clientConnection: { prompt: promptSpy },
+        logWriter: {
+          flushAll: vi.fn().mockResolvedValue(undefined),
+          getFullAgentResponse: vi.fn().mockReturnValue(null),
+          resetTurnMessages: vi.fn(),
+          flush: vi.fn().mockResolvedValue(undefined),
+          isRegistered: vi.fn().mockReturnValue(true),
+        },
+      };
+
+      await server.sendInitialTaskMessage(TEST_PAYLOAD);
+
+      expect(promptSpy).toHaveBeenCalledTimes(1);
+      expect(updateTaskRunSpy).toHaveBeenCalledWith(
+        "test-task-id",
+        "test-run-id",
+        {
+          status: "failed",
+          error_message: "Upstream LLM stream terminated",
+        },
+      );
+    });
+
+    it("surfaces upstream connection errors with the connection-specific message", async () => {
+      vi.spyOn(server.posthogAPI, "getTask").mockResolvedValue({
+        id: "test-task-id",
+        title: "t",
+        description: "original task description",
+      } as unknown as Task);
+      vi.spyOn(server.posthogAPI, "getTaskRun").mockResolvedValue({
+        id: "test-run-id",
+        task: "test-task-id",
+        state: {},
+      } as unknown as TaskRun);
+
+      const promptSpy = vi.fn().mockImplementationOnce(async () => {
+        throw createTransientConnectionError();
+      });
+      const updateTaskRunSpy = vi
+        .spyOn(server.posthogAPI, "updateTaskRun")
+        .mockResolvedValue({} as TaskRun);
+      server.session = {
+        payload: TEST_PAYLOAD,
+        acpSessionId: "acp-session",
+        clientConnection: { prompt: promptSpy },
+        logWriter: {
+          flushAll: vi.fn().mockResolvedValue(undefined),
+          getFullAgentResponse: vi.fn().mockReturnValue(null),
+          resetTurnMessages: vi.fn(),
+          flush: vi.fn().mockResolvedValue(undefined),
+          isRegistered: vi.fn().mockReturnValue(true),
+        },
+      };
+
+      await server.sendInitialTaskMessage(TEST_PAYLOAD);
+
+      expect(promptSpy).toHaveBeenCalledTimes(1);
+      expect(updateTaskRunSpy).toHaveBeenCalledWith(
+        "test-task-id",
+        "test-run-id",
+        {
+          status: "failed",
+          error_message: "Upstream LLM connection error",
+        },
+      );
+    });
   });
 });