@posthog/agent 2.1.45 → 2.1.48

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@posthog/agent",
-  "version": "2.1.45",
+  "version": "2.1.48",
   "repository": "https://github.com/PostHog/twig",
   "description": "TypeScript agent framework wrapping Claude Agent SDK with Git-based task execution for PostHog",
   "exports": {
@@ -72,8 +72,8 @@
     "tsx": "^4.20.6",
     "typescript": "^5.5.0",
     "vitest": "^2.1.8",
-    "@twig/git": "1.0.0",
-    "@posthog/shared": "1.0.0"
+    "@posthog/shared": "1.0.0",
+    "@twig/git": "1.0.0"
   },
   "dependencies": {
     "@agentclientprotocol/sdk": "^0.14.0",

package/src/adapters/claude/claude-agent.ts

@@ -78,17 +78,17 @@ export class ClaudeAcpAgent extends BaseAcpAgent {
   backgroundTerminals: { [key: string]: BackgroundTerminal } = {};
   clientCapabilities?: ClientCapabilities;
   private logWriter?: SessionLogWriter;
-  private processCallbacks?: ClaudeAcpAgentOptions;
+  private options?: ClaudeAcpAgentOptions;
   private lastSentConfigOptions?: SessionConfigOption[];
 
   constructor(
     client: AgentSideConnection,
     logWriter?: SessionLogWriter,
-    processCallbacks?: ClaudeAcpAgentOptions,
+    options?: ClaudeAcpAgentOptions,
   ) {
     super(client);
     this.logWriter = logWriter;
-    this.processCallbacks = processCallbacks;
+    this.options = options;
     this.toolUseCache = {};
     this.logger = new Logger({ debug: true, prefix: "[ClaudeAcpAgent]" });
   }
@@ -146,10 +146,6 @@ export class ClaudeAcpAgent extends BaseAcpAgent {
 
     const mcpServers = parseMcpServers(params);
 
-    // Fire off MCP metadata fetch early — it populates a module-level cache
-    // used later during permission checks, not needed by buildSessionOptions or query()
-    const mcpMetadataPromise = fetchMcpToolMetadata(mcpServers, this.logger);
-
     const options = buildSessionOptions({
       cwd: params.cwd,
       mcpServers,
@@ -161,8 +157,8 @@ export class ClaudeAcpAgent extends BaseAcpAgent {
       sessionId,
       isResume: false,
       onModeChange: this.createOnModeChange(sessionId),
-      onProcessSpawned: this.processCallbacks?.onProcessSpawned,
-      onProcessExited: this.processCallbacks?.onProcessExited,
+      onProcessSpawned: this.options?.onProcessSpawned,
+      onProcessExited: this.options?.onProcessExited,
     });
 
     const input = new Pushable<SDKUserMessage>();
@@ -181,27 +177,27 @@ export class ClaudeAcpAgent extends BaseAcpAgent {
 
     if (meta?.taskRunId) {
       await this.client.extNotification("_posthog/sdk_session", {
-        taskRunId: meta.taskRunId,
+        taskRunId: meta.taskRunId!,
         sessionId,
         adapter: "claude",
       });
     }
 
-    // Run model config, slash commands, and MCP metadata fetch in parallel
-    const [modelOptions, slashCommands] = await Promise.all([
-      this.getModelConfigOptions(),
-      getAvailableSlashCommands(q),
-      mcpMetadataPromise,
-    ]);
+    // Only await model config — slash commands and MCP metadata are deferred
+    // since they're not needed to return configOptions to the client.
+    const modelOptions = await this.getModelConfigOptions();
+
+    // Deferred: slash commands + MCP metadata (not needed to return configOptions)
+    this.deferBackgroundFetches(q, sessionId, mcpServers);
 
     session.modelId = modelOptions.currentModelId;
     await this.trySetModel(q, modelOptions.currentModelId);
 
-    this.sendAvailableCommandsUpdate(sessionId, slashCommands);
+    const configOptions = await this.buildConfigOptions(modelOptions);
 
     return {
       sessionId,
-      configOptions: await this.buildConfigOptions(modelOptions),
+      configOptions,
     };
   }
 
@@ -223,9 +219,6 @@ export class ClaudeAcpAgent extends BaseAcpAgent {
 
     const mcpServers = parseMcpServers(params);
 
-    // Fire off MCP metadata fetch early — populates cache for permission checks
-    const mcpMetadataPromise = fetchMcpToolMetadata(mcpServers, this.logger);
-
     const permissionMode: TwigExecutionMode =
       meta?.permissionMode &&
       TWIG_EXECUTION_MODES.includes(meta.permissionMode as TwigExecutionMode)
@@ -247,17 +240,12 @@ export class ClaudeAcpAgent extends BaseAcpAgent {
 
     this.registerPersistence(sessionId, meta as Record<string, unknown>);
 
-    // Run slash commands fetch and MCP metadata in parallel
-    const [slashCommands] = await Promise.all([
-      getAvailableSlashCommands(q),
-      mcpMetadataPromise,
-    ]);
+    // Deferred: slash commands + MCP metadata (not needed to return configOptions)
+    this.deferBackgroundFetches(q, sessionId, mcpServers);
 
-    this.sendAvailableCommandsUpdate(sessionId, slashCommands);
+    const configOptions = await this.buildConfigOptions();
 
-    return {
-      configOptions: await this.buildConfigOptions(),
-    };
+    return { configOptions };
   }
 
   async prompt(params: PromptRequest): Promise<PromptResponse> {
@@ -366,8 +354,8 @@ export class ClaudeAcpAgent extends BaseAcpAgent {
       isResume: config.isResume,
       additionalDirectories: config.additionalDirectories,
       onModeChange: this.createOnModeChange(config.sessionId),
-      onProcessSpawned: this.processCallbacks?.onProcessSpawned,
-      onProcessExited: this.processCallbacks?.onProcessExited,
+      onProcessSpawned: this.options?.onProcessSpawned,
+      onProcessExited: this.options?.onProcessExited,
     });
 
     const q = query({ prompt: input, options });
@@ -503,6 +491,27 @@ export class ClaudeAcpAgent extends BaseAcpAgent {
     }
   }
 
+  /**
+   * Fire-and-forget: fetch slash commands and MCP tool metadata in parallel.
+   * Both populate caches used later — neither is needed to return configOptions.
+   */
+  private deferBackgroundFetches(
+    q: Query,
+    sessionId: string,
+    mcpServers: ReturnType<typeof parseMcpServers>,
+  ): void {
+    Promise.all([
+      getAvailableSlashCommands(q),
+      fetchMcpToolMetadata(mcpServers, this.logger),
+    ])
+      .then(([slashCommands]) => {
+        this.sendAvailableCommandsUpdate(sessionId, slashCommands);
+      })
+      .catch((err) => {
+        this.logger.warn("Failed to fetch deferred session data", { err });
+      });
+  }
+
   private registerPersistence(
     sessionId: string,
     meta: Record<string, unknown> | undefined,