@possumtech/rummy 2.1.0 → 2.2.1

package/biome/no-fallbacks.grit

@@ -1,4 +1,4 @@
-// No silent fallbacks outside hedberg.
+// No silent fallbacks outside src/lib/hedberg/ + src/agent/XmlParser.js.
 // Rule: interiors crash on contract violation, boundaries validate.
 // Patterns like `|| 0`, `?? ""` silently mask missing data.
 // hedberg is the stochastic-interpretation boundary — fallbacks
@@ -39,7 +39,7 @@ or {
   `Number.parseFloat(process.env.$_) || $_`,
   `Number.parseFloat(process.env.$_) ?? $_`
 } as $match where {
-  $filename <: not includes "src/plugins/hedberg/",
+  $filename <: not includes "src/lib/hedberg/",
   $filename <: not includes "src/agent/XmlParser.js",
   $filename <: not includes "/test/",
   $filename <: not includes ".test.js",

package/gemini.key

@@ -0,0 +1 @@
+AIzaSyD4VBYwfo5wiVp0IIy368rlbEhJTnL2k2c

package/lang/en.json

@@ -30,5 +30,14 @@
 	"error.xai_base_url_missing": "xai/ model requested but XAI_BASE_URL is not set.",
 	"error.xai_api_key_missing": "xai/ model requested but XAI_API_KEY is not set.",
 	"error.xai_auth": "xAI Authentication Error: {status}. Please check your XAI_API_KEY.",
-	"error.xai_api": "xAI API error: {status}"
+	"error.xai_api": "xAI API error: {status}",
+	"error.google_auth": "Google AI Studio authentication error: {status}. Check the gemini.key file in repo root.",
+	"error.google_api": "Google AI Studio API error: {status}",
+	"error.google_models_failed": "Google AI Studio /v1beta/models/{model} failed: {status}",
+	"error.google_no_context_length": "Google AI Studio model '{model}' returned no inputTokenLimit.",
+	"error.cloudflare_auth": "Cloudflare Workers AI authentication error: {status}. Check cloudflare.key and CLOUDFLARE_ACCOUNT_ID.",
+	"error.cloudflare_api": "Cloudflare Workers AI API error: {status}",
+	"error.cloudflare_models_failed": "Cloudflare /ai/models/search for '{model}' failed: {status}",
+	"error.cloudflare_model_not_found": "Cloudflare Workers AI model '{model}' not found in models-search results.",
+	"error.cloudflare_no_context_length": "Cloudflare Workers AI model '{model}' returned no context_window or max_input_tokens property."
 }

package/migrations/001_initial_schema.sql

@@ -99,6 +99,13 @@ CREATE TABLE IF NOT EXISTS turns (
 	, reasoning_tokens INTEGER NOT NULL DEFAULT 0 CHECK (reasoning_tokens >= 0)
 	, total_tokens INTEGER NOT NULL DEFAULT 0 CHECK (total_tokens >= 0)
 	, cost REAL NOT NULL DEFAULT 0 CHECK (cost >= 0)
+	-- Full response metadata from the provider — everything except
+	-- content/reasoning_content (those live on the assistant://N entry
+	-- and turns.reasoning_content respectively). Catches finish_reason,
+	-- system_fingerprint, response id, service_tier, raw usage object,
+	-- and whatever provider-specific fields land on the response. Kept
+	-- as opaque JSON so provider shape drift doesn't bite us.
+	, response_metadata JSON NOT NULL DEFAULT '{}' CHECK (json_valid(response_metadata))
 	, created_at DATETIME DEFAULT CURRENT_TIMESTAMP
 );
 CREATE INDEX IF NOT EXISTS idx_turns_run_seq ON turns (run_id, sequence);
@@ -109,7 +116,7 @@ CREATE TABLE IF NOT EXISTS file_constraints (
 	id INTEGER PRIMARY KEY AUTOINCREMENT
 	, project_id INTEGER NOT NULL REFERENCES projects (id) ON DELETE CASCADE
 	, pattern TEXT NOT NULL
-	, visibility TEXT NOT NULL CHECK (visibility IN ('active', 'readonly', 'ignore'))
+	, visibility TEXT NOT NULL CHECK (visibility IN ('add', 'readonly', 'ignore'))
 	, created_at DATETIME DEFAULT CURRENT_TIMESTAMP
 	, UNIQUE (project_id, pattern)
 );
@@ -125,7 +132,7 @@ CREATE TABLE IF NOT EXISTS entries (
 	, scope TEXT NOT NULL
 	, path TEXT NOT NULL CHECK (length(path) <= 2048)
 	, scheme TEXT GENERATED ALWAYS AS (schemeOf(path)) STORED
-	, body TEXT NOT NULL DEFAULT ''
+	, body TEXT NOT NULL DEFAULT '' CHECK (length(body) <= $entry_size_max)
 	, attributes JSON NOT NULL DEFAULT '{}' CHECK (json_valid(attributes))
 	, hash TEXT
 	, created_at DATETIME DEFAULT CURRENT_TIMESTAMP

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@possumtech/rummy",
-	"version": "2.1.0",
+	"version": "2.2.1",
 	"description": "Relational Unknowns Memory Management Yoke",
 	"keywords": [
 		"llm"
@@ -40,24 +40,34 @@
 		"test:all": "npm run lint && npm run test:unit && npm run test:intg && npm run test:e2e",
 		"test:unit": "node --env-file-if-exists=.env.example --env-file-if-exists=.env.test --experimental-test-coverage --test-coverage-lines=50 --test-coverage-branches=50 --test-coverage-functions=50 --test-concurrency=1 --test-force-exit --test $(find src -name '*.test.js')",
 		"test:intg": "node --env-file-if-exists=.env.example --env-file-if-exists=.env --env-file-if-exists=.env.test --test-concurrency=1 --test-force-exit --test $(find test/integration -name '*.test.js')",
-		"test:e2e": "mkdir -p /tmp/rummy_test_diag && node --env-file-if-exists=.env.example --env-file-if-exists=.env --env-file-if-exists=.env.test --test-concurrency=1 --test-force-exit --test-reporter=spec --test $(find test/e2e -name '*.test.js') 2>&1 | tee /tmp/rummy_test_diag/e2e_$(date +%Y%m%dT%H%M%S).log",
-		"test:live": "mkdir -p /tmp/rummy_test_diag && node --env-file-if-exists=.env.example --env-file-if-exists=.env --env-file-if-exists=.env.test --test-concurrency=1 --test-force-exit --test-reporter=spec --test $(find test/live -name '*.test.js') 2>&1 | tee /tmp/rummy_test_diag/live_$(date +%Y%m%dT%H%M%S).log",
+		"test:e2e": "bash -c 'set -o pipefail; mkdir -p /tmp/rummy_test_diag && node --env-file-if-exists=.env.example --env-file-if-exists=.env --env-file-if-exists=.env.test --test-concurrency=1 --test-force-exit --test-reporter=spec --test $(find test/e2e -name \"*.test.js\") 2>&1 | tee /tmp/rummy_test_diag/e2e_$(date +%Y%m%dT%H%M%S).log; status=$?; node bin/digest.js /tmp/rummy_test_diag/ 2>&1 | tail -3; exit $status'",
+		"test:live": "bash -c 'set -o pipefail; mkdir -p /tmp/rummy_test_diag && node --env-file-if-exists=.env.example --env-file-if-exists=.env --env-file-if-exists=.env.test --test-concurrency=1 --test-force-exit --test-reporter=spec --test $(find test/live -name \"*.test.js\") 2>&1 | tee /tmp/rummy_test_diag/live_$(date +%Y%m%dT%H%M%S).log'",
 		"test:clean": "rm -rf test/lme/results test/swe/results test/swe/repos test/tmp /tmp/rummy_test_diag /tmp/rummy_test_*.db /tmp/rummy_test_*.db-shm /tmp/rummy_test_*.db-wal && echo 'Test artifacts cleaned.'",
 		"test:lme:get": "node --env-file-if-exists=.env.example --env-file-if-exists=.env --env-file-if-exists=.env.test test/lme/download.js",
-		"test:lme": "bash -c 'mkdir -p /tmp/rummy_test_diag && node --env-file-if-exists=.env.example --env-file-if-exists=.env --env-file-if-exists=.env.test test/lme/runner.js \"$@\" 2>&1 | tee /tmp/rummy_test_diag/lme_$(date +%Y%m%dT%H%M%S).log' --",
+		"test:lme": "bash -c 'set -o pipefail; mkdir -p /tmp/rummy_test_diag && node --env-file-if-exists=.env.example --env-file-if-exists=.env --env-file-if-exists=.env.test test/lme/runner.js \"$@\" 2>&1 | tee /tmp/rummy_test_diag/lme_$(date +%Y%m%dT%H%M%S).log' --",
 		"test:swe:setup": "bash test/swe/setup.sh",
 		"test:swe:get": "node --env-file-if-exists=.env.example --env-file-if-exists=.env --env-file-if-exists=.env.test test/swe/download.js",
-		"test:swe": "bash -c 'mkdir -p /tmp/rummy_test_diag && node --env-file-if-exists=.env.example --env-file-if-exists=.env --env-file-if-exists=.env.test test/swe/runner.js \"$@\" 2>&1 | tee /tmp/rummy_test_diag/swe_$(date +%Y%m%dT%H%M%S).log' --",
+		"test:swe": "bash -c 'set -o pipefail; mkdir -p /tmp/rummy_test_diag && node --env-file-if-exists=.env.example --env-file-if-exists=.env --env-file-if-exists=.env.test test/swe/runner.js \"$@\" 2>&1 | tee /tmp/rummy_test_diag/swe_$(date +%Y%m%dT%H%M%S).log' --",
 		"test:swe:eval": "bash -c 'cd test/swe && source .venv/bin/activate && python evaluate.py \"$@\"' --",
 		"test:swe:baseline": "bash -c 'cd test/swe && source .venv/bin/activate && python baseline.py \"$@\"' --",
 		"test:lme:clean": "rm -rf test/lme/results/*/",
 		"test:swe:clean": "rm -rf test/swe/results/*/ test/swe/repos/",
 		"test:tbench:setup": "bash -c 'set -a; source .env.tbench; set +a; bash test/tbench/setup.sh'",
-		"test:tbench": "bash -c 'mkdir -p /tmp/rummy_test_diag && node --env-file-if-exists=.env.example --env-file-if-exists=.env --env-file-if-exists=.env.tbench test/tbench/runner.js \"$@\" 2>&1 | tee /tmp/rummy_test_diag/tbench_$(date +%Y%m%dT%H%M%S).log' --",
+		"test:tbench": "bash -c 'echo \"Specify a profile: test:tbench:xfast | :gemma | :xfast_or\" >&2 && exit 64'",
+		"test:tbench:xfast": "bash -c 'set -o pipefail; mkdir -p /tmp/rummy_test_diag && node --env-file-if-exists=.env.example --env-file-if-exists=.env --env-file-if-exists=.env.tbench --env-file-if-exists=.env.tbench.xfast test/tbench/runner.js \"$@\" 2>&1 | tee /tmp/rummy_test_diag/tbench_xfast_$(date +%Y%m%dT%H%M%S).log' --",
+		"test:tbench:gemma": "bash -c 'set -o pipefail; mkdir -p /tmp/rummy_test_diag && node --env-file-if-exists=.env.example --env-file-if-exists=.env --env-file-if-exists=.env.tbench --env-file-if-exists=.env.tbench.gemma test/tbench/runner.js \"$@\" 2>&1 | tee /tmp/rummy_test_diag/tbench_gemma_$(date +%Y%m%dT%H%M%S).log' --",
+		"test:tbench:xfast_or": "bash -c 'set -o pipefail; mkdir -p /tmp/rummy_test_diag && node --env-file-if-exists=.env.example --env-file-if-exists=.env --env-file-if-exists=.env.tbench --env-file-if-exists=.env.tbench.xfast_or test/tbench/runner.js \"$@\" 2>&1 | tee /tmp/rummy_test_diag/tbench_xfast_or_$(date +%Y%m%dT%H%M%S).log' --",
+		"test:tbench:g43": "bash -c 'set -o pipefail; mkdir -p /tmp/rummy_test_diag && node --env-file-if-exists=.env.example --env-file-if-exists=.env --env-file-if-exists=.env.tbench --env-file-if-exists=.env.tbench.g43 test/tbench/runner.js \"$@\" 2>&1 | tee /tmp/rummy_test_diag/tbench_g43_$(date +%Y%m%dT%H%M%S).log' --",
 		"test:tbench:clean": "rm -rf test/tbench/results/*/",
+		"test:tbench:summary": "node --env-file-if-exists=.env.example --env-file-if-exists=.env --env-file-if-exists=.env.tbench test/tbench/summarize.js",
+		"test:programbench:setup": "bash test/programbench/setup.sh",
+		"test:programbench": "bash -c 'set -o pipefail; mkdir -p /tmp/rummy_test_diag && node --env-file-if-exists=.env.example --env-file-if-exists=.env --env-file-if-exists=.env.tbench --env-file-if-exists=.env.tbench.gemma test/programbench/runner.js \"$@\" 2>&1 | tee /tmp/rummy_test_diag/programbench_$(date +%Y%m%dT%H%M%S).log' --",
+		"test:programbench:eval": "bash -c 'cd test/programbench && . .venv/bin/activate && programbench eval \"$@\"' --",
+		"test:programbench:clean": "rm -rf test/programbench/results/*/",
 		"test:clear": "rm -rf /tmp/rummy_test_diag /tmp/rummy_test_*.db /tmp/rummy_test_*.db-shm /tmp/rummy_test_*.db-wal /tmp/rummy-stories-*",
 		"test:demo": "node --env-file-if-exists=.env.example --env-file-if-exists=.env bin/demo.js",
-		"test:spec": "node test/spec-coverage.js"
+		"test:spec": "node test/spec-coverage.js",
+		"dev:digest": "bash -c 'DB=\"${1:-rummy_dev.db}\"; NAME=$(basename \"$DB\"); TMP=$(mktemp -d); sqlite3 \"$DB\" \".backup $TMP/$NAME\" && node bin/digest.js \"$TMP/$NAME\"; rm -rf \"$TMP\"' --"
 	},
 	"devDependencies": {
 		"@biomejs/biome": "^2.4.6"
@@ -69,6 +79,7 @@
 		"htmlparser2": "^12.0.0",
 		"picomatch": "^4.0.4",
 		"ws": "^8.19.0",
-		"xpath": "^0.0.34"
+		"xpath": "^0.0.34",
+		"yauzl-promise": "^4.0.0"
 	}
 }

package/service.js

@@ -105,6 +105,7 @@ async function main() {
 		functions: sqlFunctions,
 		params: {
 			mmap_size: Number(process.env.RUMMY_MMAP_MB) * 1024 * 1024,
+			entry_size_max: Number(process.env.RUMMY_ENTRY_SIZE_MAX),
 		},
 	});
 

package/src/agent/AgentLoop.js

@@ -1,5 +1,20 @@
+import { readFile } from "node:fs/promises";
+import { dirname, join } from "node:path";
+import { fileURLToPath } from "node:url";
 import msg from "./messages.js";
 
+const DEFAULT_PERSONA_PATH = join(
+	dirname(fileURLToPath(import.meta.url)),
+	"../plugins/persona/default.md",
+);
+let cachedDefaultPersona = null;
+async function loadDefaultPersona() {
+	if (cachedDefaultPersona == null) {
+		cachedDefaultPersona = await readFile(DEFAULT_PERSONA_PATH, "utf8");
+	}
+	return cachedDefaultPersona;
+}
+
 const HTTP_TO_RUN_STATE = {
 	100: "proposed",
 	102: "streaming",
@@ -23,6 +38,11 @@ export default class AgentLoop {
 		this.#hooks = hooks;
 		this.#turnExecutor = turnExecutor;
 		this.#entries = entries;
+		hooks.run.wake.on(this.#onWake.bind(this));
+	}
+
+	async #onWake({ runAlias, body, mode }) {
+		await this.inject(runAlias, body, mode);
 	}
 
 	abort(runId) {
@@ -52,6 +72,7 @@ export default class AgentLoop {
 		const s = await this.#db.get_run_summary.get({ id: runId });
 		await hook.completed.emit({
 			projectId,
+			runId,
 			...out,
 			model: s.model,
 			turns: s.turns,
@@ -113,10 +134,12 @@ export default class AgentLoop {
 		const {
 			fork: isFork = false,
 			temperature = null,
-			persona = null,
+			persona: personaOpt = null,
 			contextLimit = null,
 		} = options;
 		const requestedModel = model;
+		let persona = personaOpt;
+		if (!persona) persona = await loadDefaultPersona();
 
 		if (run && isFork) {
 			const existingRun = await this.#db.get_run_by_alias.get({ alias: run });
@@ -133,6 +156,12 @@ export default class AgentLoop {
 				context_limit: contextLimit,
 			});
 			await this.#entries.forkEntries(existingRun.id, runRow.id);
+			// Absolute turn numbering across the lineage; SPEC
+			// §budget_enforcement. Without this, the fork's first
+			// dispatch lands at turn 1 while inherited run_views carry
+			// parent-side turn values, and the budget grinder's
+			// `current_turn − 1` rule sees nothing meaningful.
+			await this.#entries.setNextTurn(runRow.id, existingRun.next_turn);
 			await this.#writeRunEntry(runRow.id, alias, prompt, {
 				projectId,
 				parentRunId: existingRun.id,
@@ -468,14 +497,17 @@ export default class AgentLoop {
 					`[LOOP] ${currentAlias} iter=${loopIteration} turn done: status=${result.status} turn=${result.turn}`,
 				);
 
-				const verdict = await this.#hooks.error.verdict({
-					store: this.#entries,
-					runId: currentRunId,
-					loopId: currentLoopId,
-					turn: result.turn,
-					recorded: result.recorded,
-					summaryText: result.summaryText,
-				});
+				const verdict = await this.#hooks.turn.verdict.filter(
+					{ continue: true },
+					{
+						store: this.#entries,
+						runId: currentRunId,
+						loopId: currentLoopId,
+						turn: result.turn,
+						recorded: result.recorded,
+						summaryText: result.summaryText,
+					},
+				);
 				const vStatus = verdict.status === undefined ? "-" : verdict.status;
 				const vReason = verdict.reason ? verdict.reason : "-";
 				console.error(
@@ -661,6 +693,40 @@ export default class AgentLoop {
 
 		const nextTurn = runRow.next_turn;
 
+		// Resolve the owning loop_id BEFORE writing the prompt entry so
+		// it lands with correct loop scope. Active run → reuse the
+		// running loop; otherwise enqueue the next loop and write the
+		// prompt with the new loop's id.
+		let loopId;
+		if (this.#activeRuns.has(runRow.id)) {
+			// Active runs have exactly one loop at status=102 by the
+			// loops table invariant — trust the contract.
+			const currentLoop = await this.#db.get_current_loop.get({
+				run_id: runRow.id,
+			});
+			loopId = currentLoop.id;
+		} else {
+			const injectLoopSeq = await this.#db.next_loop.get({
+				run_id: runRow.id,
+			});
+			const enqueued = await this.#db.enqueue_loop.get({
+				run_id: runRow.id,
+				sequence: injectLoopSeq.sequence,
+				mode,
+				model: runRow.model,
+				prompt: message,
+				config: JSON.stringify({
+					noRepo,
+					noInteraction,
+					noWeb,
+					noProposals,
+					yolo,
+					temperature: options?.temperature,
+				}),
+			});
+			loopId = enqueued.id;
+		}
+
 		await this.#entries.set({
 			runId: runRow.id,
 			turn: nextTurn,
@@ -668,6 +734,7 @@ export default class AgentLoop {
 			body: message,
 			state: "resolved",
 			attributes: { mode },
+			loopId,
 			writer: "plugin",
 		});
 
@@ -675,23 +742,6 @@ export default class AgentLoop {
 			return { run: runAlias, status: runRow.status, injected: "next_turn" };
 		}
 
-		const injectLoopSeq = await this.#db.next_loop.get({ run_id: runRow.id });
-		await this.#db.enqueue_loop.get({
-			run_id: runRow.id,
-			sequence: injectLoopSeq.sequence,
-			mode,
-			model: runRow.model,
-			prompt: message,
-			config: JSON.stringify({
-				noRepo,
-				noInteraction,
-				noWeb,
-				noProposals,
-				yolo,
-				temperature: options?.temperature,
-			}),
-		});
-
 		const projectId = runRow.project_id;
 		const project = await this.#db.get_project_by_id.get({ id: projectId });
 		const controller = new AbortController();

package/src/agent/ContextAssembler.js

@@ -9,6 +9,7 @@ export default class ContextAssembler {
 			toolSet = null,
 			lastContextTokens = 0,
 			turn = 1,
+			persona = "",
 		} = {},
 		hooks,
 	) {
@@ -27,6 +28,7 @@ export default class ContextAssembler {
 			lastContextTokens,
 			toolSet,
 			turn,
+			persona,
 		};
 
 		const system = await hooks.assembly.system.filter(systemPrompt, ctx);