@portabletext/editor 1.1.3 → 1.1.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@portabletext/editor",
-  "version": "1.1.3",
+  "version": "1.1.5",
   "description": "Portable Text Editor made in React",
   "keywords": [
     "sanity",
@@ -46,8 +46,8 @@
     "debug": "^4.3.4",
     "is-hotkey-esm": "^1.0.0",
     "lodash": "^4.17.21",
-    "slate": "0.103.0",
-    "slate-react": "0.110.1",
+    "slate": "0.110.2",
+    "slate-react": "0.110.2",
     "xstate": "^5.18.2"
   },
   "devDependencies": {
@@ -55,28 +55,31 @@
     "@babel/preset-react": "^7.24.7",
     "@jest/globals": "^29.7.0",
     "@jest/types": "^29.6.3",
-    "@playwright/test": "1.47.2",
+    "@playwright/test": "1.48.1",
     "@portabletext/toolkit": "^2.0.15",
-    "@sanity/block-tools": "^3.55.0",
+    "@sanity/block-tools": "^3.61.0",
     "@sanity/diff-match-patch": "^3.1.1",
     "@sanity/pkg-utils": "^6.11.2",
-    "@sanity/schema": "^3.55.0",
-    "@sanity/types": "^3.55.0",
+    "@sanity/schema": "^3.61.0",
+    "@sanity/types": "^3.61.0",
     "@sanity/ui": "^2.8.9",
-    "@sanity/util": "^3.55.0",
+    "@sanity/util": "^3.61.0",
     "@testing-library/dom": "^10.4.0",
-    "@testing-library/jest-dom": "^6.5.0",
+    "@testing-library/jest-dom": "^6.6.2",
     "@testing-library/react": "^16.0.1",
+    "@testing-library/user-event": "^14.5.2",
     "@types/debug": "^4.1.5",
     "@types/express": "^4.17.21",
     "@types/express-ws": "^3.0.5",
     "@types/lodash": "^4.17.7",
     "@types/node": "^18.19.8",
     "@types/node-ipc": "^9.2.3",
-    "@types/react": "^18.3.3",
-    "@types/react-dom": "^18.3.0",
+    "@types/react": "^18.3.11",
+    "@types/react-dom": "^18.3.1",
     "@types/ws": "~8.5.12",
-    "@vitejs/plugin-react": "^4.3.1",
+    "@vitejs/plugin-react": "^4.3.3",
+    "@vitest/browser": "^2.1.3",
+    "@xstate/react": "^4.1.3",
     "dotenv": "^16.4.5",
     "express": "^4.19.2",
     "express-ws": "^5.0.2",
@@ -85,21 +88,23 @@
     "jest-environment-node": "^29.7.0",
     "jsdom": "^25.0.1",
     "node-ipc": "npm:@node-ipc/compat@9.2.5",
+    "playwright": "^1.48.1",
     "react": "^18.3.1",
     "react-dom": "^18.3.1",
     "rxjs": "^7.8.1",
     "styled-components": "^6.1.13",
     "ts-node": "^10.9.2",
-    "typescript": "5.6.2",
-    "vite": "^5.4.2",
-    "vitest": "^2.1.1",
+    "typescript": "5.6.3",
+    "vite": "^5.4.9",
+    "vitest": "^2.1.3",
+    "vitest-browser-react": "^0.0.1",
     "@sanity/gherkin-driver": "^0.0.1"
   },
   "peerDependencies": {
-    "@sanity/block-tools": "^3.47.1",
-    "@sanity/schema": "^3.47.1",
-    "@sanity/types": "^3.47.1",
-    "@sanity/util": "^3.47.1",
+    "@sanity/block-tools": "^3.61.0",
+    "@sanity/schema": "^3.61.0",
+    "@sanity/types": "^3.61.0",
+    "@sanity/util": "^3.61.0",
     "react": "^16.9 || ^17 || ^18",
     "rxjs": "^7.8.1",
     "styled-components": "^6.1.13"

package/src/editor/Editable.tsx

@@ -11,8 +11,6 @@ import {
   type ClipboardEvent,
   type CSSProperties,
   type FocusEventHandler,
-  type ForwardedRef,
-  type HTMLProps,
   type KeyboardEvent,
   type MutableRefObject,
   type TextareaHTMLAttributes,
@@ -66,7 +64,6 @@ import {
 import {Element} from './components/Element'
 import {Leaf} from './components/Leaf'
 import {usePortableTextEditor} from './hooks/usePortableTextEditor'
-import {usePortableTextEditorKeyGenerator} from './hooks/usePortableTextEditorKeyGenerator'
 import {usePortableTextEditorReadOnlyStatus} from './hooks/usePortableTextReadOnly'
 import {createWithHotkeys, createWithInsertData} from './plugins'
 import {PortableTextEditor} from './PortableTextEditor'
@@ -113,11 +110,10 @@ export type PortableTextEditableProps = Omit<
 /**
  * @public
  */
-export const PortableTextEditable = forwardRef(function PortableTextEditable(
-  props: PortableTextEditableProps &
-    Omit<HTMLProps<HTMLDivElement>, 'as' | 'onPaste' | 'onBeforeInput'>,
-  forwardedRef: ForwardedRef<HTMLDivElement>,
-) {
+export const PortableTextEditable = forwardRef<
+  Omit<HTMLDivElement, 'as' | 'onPaste' | 'onBeforeInput'>,
+  PortableTextEditableProps
+>(function PortableTextEditable(props, forwardedRef) {
   const {
     hotkeys,
     onBlur,
@@ -142,7 +138,6 @@ export const PortableTextEditable = forwardRef(function PortableTextEditable(
 
   const portableTextEditor = usePortableTextEditor()
   const readOnly = usePortableTextEditorReadOnlyStatus()
-  const keyGenerator = usePortableTextEditorKeyGenerator()
   const ref = useRef<HTMLDivElement | null>(null)
   const [editableElement, setEditableElement] = useState<HTMLDivElement | null>(
     null,
@@ -167,8 +162,8 @@ export const PortableTextEditable = forwardRef(function PortableTextEditable(
 
   // React/UI-specific plugins
   const withInsertData = useMemo(
-    () => createWithInsertData(editorActor, schemaTypes, keyGenerator),
-    [editorActor, keyGenerator, schemaTypes],
+    () => createWithInsertData(editorActor, schemaTypes),
+    [editorActor, schemaTypes],
   )
   const withHotKeys = useMemo(
     () => createWithHotkeys(schemaTypes, portableTextEditor, hotkeys),

package/src/editor/PortableTextEditor.tsx

@@ -28,12 +28,9 @@ import {SlateContainer} from './components/SlateContainer'
 import {Synchronizer} from './components/Synchronizer'
 import {editorMachine, type EditorActor} from './editor-machine'
 import {PortableTextEditorContext} from './hooks/usePortableTextEditor'
-import {
-  defaultKeyGenerator,
-  PortableTextEditorKeyGeneratorContext,
-} from './hooks/usePortableTextEditorKeyGenerator'
 import {PortableTextEditorSelectionProvider} from './hooks/usePortableTextEditorSelection'
 import {PortableTextEditorReadOnlyContext} from './hooks/usePortableTextReadOnly'
+import {defaultKeyGenerator} from './key-generator'
 
 const debug = debugWithName('component:PortableTextEditor')
 
@@ -125,7 +122,11 @@ export class PortableTextEditor extends Component<PortableTextEditorProps> {
       )
     }
 
-    this.editorActor = createActor(editorMachine)
+    this.editorActor = createActor(editorMachine, {
+      input: {
+        keyGenerator: props.keyGenerator || defaultKeyGenerator,
+      },
+    })
     this.editorActor.start()
 
     this.schemaTypes = getPortableTextMemberSchemaTypes(
@@ -171,39 +172,34 @@ export class PortableTextEditor extends Component<PortableTextEditorProps> {
         : Number.parseInt(this.props.maxBlocks.toString(), 10) || undefined
 
     const readOnly = Boolean(this.props.readOnly)
-    const keyGenerator = this.props.keyGenerator || defaultKeyGenerator
+
     return (
       <SlateContainer
-        keyGenerator={keyGenerator}
         maxBlocks={maxBlocks}
         patches$={_patches$}
         portableTextEditor={this}
         readOnly={readOnly}
       >
-        <PortableTextEditorKeyGeneratorContext.Provider value={keyGenerator}>
-          <PortableTextEditorContext.Provider value={this}>
-            <PortableTextEditorReadOnlyContext.Provider value={readOnly}>
-              <PortableTextEditorSelectionProvider
+        <PortableTextEditorContext.Provider value={this}>
+          <PortableTextEditorReadOnlyContext.Provider value={readOnly}>
+            <PortableTextEditorSelectionProvider editorActor={this.editorActor}>
+              <Synchronizer
                 editorActor={this.editorActor}
-              >
-                <Synchronizer
-                  editorActor={this.editorActor}
-                  getValue={this.getValue}
-                  onChange={(change) => {
-                    this.props.onChange(change)
-                    /**
-                     * For backwards compatibility, we relay all changes to the
-                     * `change$` Subject as well.
-                     */
-                    this.change$.next(change)
-                  }}
-                  value={value}
-                />
-                {children}
-              </PortableTextEditorSelectionProvider>
-            </PortableTextEditorReadOnlyContext.Provider>
-          </PortableTextEditorContext.Provider>
-        </PortableTextEditorKeyGeneratorContext.Provider>
+                getValue={this.getValue}
+                onChange={(change) => {
+                  this.props.onChange(change)
+                  /**
+                   * For backwards compatibility, we relay all changes to the
+                   * `change$` Subject as well.
+                   */
+                  this.change$.next(change)
+                }}
+                value={value}
+              />
+              {children}
+            </PortableTextEditorSelectionProvider>
+          </PortableTextEditorReadOnlyContext.Provider>
+        </PortableTextEditorContext.Provider>
       </SlateContainer>
     )
   }

package/src/editor/__tests__/self-solving.test.tsx

@@ -4,7 +4,7 @@ import type {PortableTextBlock, PortableTextSpan} from '@sanity/types'
 import {render, waitFor} from '@testing-library/react'
 import {createRef, type ComponentProps, type RefObject} from 'react'
 import {describe, expect, it, vi} from 'vitest'
-import {getTextSelection} from '../../../e2e-tests/__tests__/gherkin-step-helpers'
+import {getTextSelection} from '../../../gherkin-spec/gherkin-step-helpers'
 import {PortableTextEditable} from '../Editable'
 import {PortableTextEditor} from '../PortableTextEditor'
 

package/src/editor/components/SlateContainer.tsx

@@ -13,7 +13,6 @@ const debug = debugWithName('component:PortableTextEditor:SlateContainer')
  * @internal
  */
 export interface SlateContainerProps extends PropsWithChildren {
-  keyGenerator: () => string
   maxBlocks: number | undefined
   patches$?: PatchObservable
   portableTextEditor: PortableTextEditor
@@ -25,14 +24,12 @@ export interface SlateContainerProps extends PropsWithChildren {
  * @internal
  */
 export function SlateContainer(props: SlateContainerProps) {
-  const {patches$, portableTextEditor, readOnly, maxBlocks, keyGenerator} =
-    props
+  const {patches$, portableTextEditor, readOnly, maxBlocks} = props
 
   // Create the slate instance, using `useState` ensures setup is only run once, initially
   const [[slateEditor, subscribe]] = useState(() => {
     debug('Creating new Slate editor instance')
     const {editor, subscribe: _sub} = withPlugins(withReact(createEditor()), {
-      keyGenerator,
       maxBlocks,
       patches$,
       portableTextEditor,
@@ -54,20 +51,12 @@ export function SlateContainer(props: SlateContainerProps) {
   useEffect(() => {
     debug('Re-initializing plugin chain')
     withPlugins(slateEditor, {
-      keyGenerator,
       maxBlocks,
       patches$,
       portableTextEditor,
       readOnly,
     })
-  }, [
-    keyGenerator,
-    portableTextEditor,
-    maxBlocks,
-    readOnly,
-    patches$,
-    slateEditor,
-  ])
+  }, [portableTextEditor, maxBlocks, readOnly, patches$, slateEditor])
 
   const initialValue = useMemo(() => {
     return [slateEditor.pteCreateTextBlock({decorators: []})]

package/src/editor/components/Synchronizer.tsx

@@ -9,7 +9,6 @@ import {debugWithName} from '../../utils/debug'
 import {IS_PROCESSING_LOCAL_CHANGES} from '../../utils/weakMaps'
 import type {EditorActor} from '../editor-machine'
 import {usePortableTextEditor} from '../hooks/usePortableTextEditor'
-import {usePortableTextEditorKeyGenerator} from '../hooks/usePortableTextEditorKeyGenerator'
 import {usePortableTextEditorReadOnlyStatus} from '../hooks/usePortableTextReadOnly'
 import {useSyncValue} from '../hooks/useSyncValue'
 
@@ -36,14 +35,12 @@ export interface SynchronizerProps {
  */
 export function Synchronizer(props: SynchronizerProps) {
   const portableTextEditor = usePortableTextEditor()
-  const keyGenerator = usePortableTextEditorKeyGenerator()
   const readOnly = usePortableTextEditorReadOnlyStatus()
   const {editorActor, getValue, onChange, value} = props
   const pendingPatches = useRef<Patch[]>([])
 
   const syncValue = useSyncValue({
     editorActor,
-    keyGenerator,
     portableTextEditor,
     readOnly,
   })

package/src/editor/editor-machine.ts

@@ -90,10 +90,14 @@ type EditorEmittedEvent =
 export const editorMachine = setup({
   types: {
     context: {} as {
+      keyGenerator: () => string
       pendingEvents: Array<PatchEvent | MutationEvent>
     },
     events: {} as EditorEvent,
     emitted: {} as EditorEmittedEvent,
+    input: {} as {
+      keyGenerator: () => string
+    },
   },
   actions: {
     'emit patch event': emit(({event}) => {
@@ -124,9 +128,10 @@ export const editorMachine = setup({
   },
 }).createMachine({
   id: 'editor',
-  context: {
+  context: ({input}) => ({
+    keyGenerator: input.keyGenerator,
     pendingEvents: [],
-  },
+  }),
   invoke: {
     id: 'networkLogic',
     src: 'networkLogic',

package/src/editor/hooks/useSyncValue.ts

@@ -24,7 +24,6 @@ const debug = debugWithName('hook:useSyncValue')
  */
 export interface UseSyncValueProps {
   editorActor: EditorActor
-  keyGenerator: () => string
   portableTextEditor: PortableTextEditor
   readOnly: boolean
 }
@@ -52,7 +51,7 @@ export function useSyncValue(
   value: PortableTextBlock[] | undefined,
   userCallbackFn?: () => void,
 ) => void {
-  const {editorActor, portableTextEditor, readOnly, keyGenerator} = props
+  const {editorActor, portableTextEditor, readOnly} = props
   const {schemaTypes} = portableTextEditor
   const previousValue = useRef<PortableTextBlock[] | undefined>()
   const slateEditor = useSlate()
@@ -162,7 +161,7 @@ export function useSyncValue(
                       const validation = validateValue(
                         validationValue,
                         schemaTypes,
-                        keyGenerator,
+                        editorActor.getSnapshot().context.keyGenerator,
                       )
                       // Resolve validations that can be resolved automatically, without involving the user (but only if the value was changed)
                       if (
@@ -222,7 +221,7 @@ export function useSyncValue(
                       const validation = validateValue(
                         validationValue,
                         schemaTypes,
-                        keyGenerator,
+                        editorActor.getSnapshot().context.keyGenerator,
                       )
                       if (debug.enabled)
                         debug(
@@ -288,7 +287,6 @@ export function useSyncValue(
     return updateFunction
   }, [
     editorActor,
-    keyGenerator,
     portableTextEditor,
     readOnly,
     schemaTypes,

package/src/editor/key-generator.ts

@@ -0,0 +1,6 @@
+import {randomKey} from '@sanity/util/content'
+
+/**
+ * @public
+ */
+export const defaultKeyGenerator = (): string => randomKey(12)

package/src/editor/plugins/createWithEditableAPI.ts

@@ -38,14 +38,15 @@ import {
   KEY_TO_VALUE_ELEMENT,
   SLATE_TO_PORTABLE_TEXT_RANGE,
 } from '../../utils/weakMaps'
+import type {EditorActor} from '../editor-machine'
 import type {PortableTextEditor} from '../PortableTextEditor'
 
 const debug = debugWithName('API:editable')
 
 export function createWithEditableAPI(
+  editorActor: EditorActor,
   portableTextEditor: PortableTextEditor,
   types: PortableTextMemberSchemaTypes,
-  keyGenerator: () => string,
 ) {
   return function withEditableAPI(
     editor: PortableTextSlateEditor,
@@ -151,11 +152,11 @@ export function createWithEditableAPI(
         const block = toSlateValue(
           [
             {
-              _key: keyGenerator(),
+              _key: editorActor.getSnapshot().context.keyGenerator(),
               _type: types.block.name,
               children: [
                 {
-                  _key: keyGenerator(),
+                  _key: editorActor.getSnapshot().context.keyGenerator(),
                   _type: type.name,
                   ...(value ? value : {}),
                 },
@@ -199,7 +200,7 @@ export function createWithEditableAPI(
         const block = toSlateValue(
           [
             {
-              _key: keyGenerator(),
+              _key: editorActor.getSnapshot().context.keyGenerator(),
               _type: type.name,
               ...(value ? value : {}),
             },
@@ -469,7 +470,9 @@ export function createWithEditableAPI(
                   continue
                 }
 
-                const annotationKey = keyGenerator()
+                const annotationKey = editorActor
+                  .getSnapshot()
+                  .context.keyGenerator()
                 const markDefs = block.markDefs ?? []
                 const existingMarkDef = markDefs.find(
                   (markDef) =>

package/src/editor/plugins/createWithHotKeys.ts

@@ -96,6 +96,7 @@ export function createWithHotkeys(
                 at: nextPath,
               },
             )
+            Transforms.select(editor, {path: [...nextPath, 0], offset: 0})
             editor.onChange()
             return
           }

package/src/editor/plugins/createWithInsertBreak.ts

@@ -5,10 +5,11 @@ import type {
   PortableTextSlateEditor,
 } from '../../types/editor'
 import type {SlateTextBlock, VoidElement} from '../../types/slate'
+import type {EditorActor} from '../editor-machine'
 
 export function createWithInsertBreak(
+  editorActor: EditorActor,
   types: PortableTextMemberSchemaTypes,
-  keyGenerator: () => string,
 ): (editor: PortableTextSlateEditor) => PortableTextSlateEditor {
   return function withInsertBreak(
     editor: PortableTextSlateEditor,
@@ -21,6 +22,24 @@ export function createWithInsertBreak(
         return
       }
 
+      const [focusSpan] = Array.from(
+        Editor.nodes(editor, {
+          mode: 'lowest',
+          at: editor.selection.focus,
+          match: (n) => editor.isTextSpan(n),
+          voids: false,
+        }),
+      )[0] ?? [undefined]
+      const focusDecorators =
+        focusSpan.marks?.filter((mark) =>
+          types.decorators.some((decorator) => decorator.value === mark),
+        ) ?? []
+      const focusAnnotations =
+        focusSpan.marks?.filter(
+          (mark) =>
+            !types.decorators.some((decorator) => decorator.value === mark),
+        ) ?? []
+
       const focusBlockPath = editor.selection.focus.path.slice(0, 1)
       const focusBlock = Node.descendant(editor, focusBlockPath) as
         | SlateTextBlock
@@ -34,15 +53,11 @@ export function createWithInsertBreak(
         })
 
         if (isEndAtStartOfBlock && Range.isCollapsed(editor.selection)) {
-          const focusDecorators = editor.isTextSpan(focusBlock.children[0])
-            ? (focusBlock.children[0].marks ?? []).filter((mark) =>
-                types.decorators.some((decorator) => decorator.value === mark),
-              )
-            : []
-
           Editor.insertNode(
             editor,
-            editor.pteCreateTextBlock({decorators: focusDecorators}),
+            editor.pteCreateTextBlock({
+              decorators: focusAnnotations.length === 0 ? focusDecorators : [],
+            }),
           )
 
           const [nextBlockPath] = Path.next(focusBlockPath)
@@ -64,6 +79,36 @@ export function createWithInsertBreak(
             ? lastFocusBlockChild.text.length
             : 0,
         })
+
+        if (
+          isStartAtEndOfBlock &&
+          Range.isCollapsed(editor.selection) &&
+          focusDecorators.length > 0 &&
+          focusAnnotations.length > 0
+        ) {
+          Editor.withoutNormalizing(editor, () => {
+            if (!editor.selection) {
+              return
+            }
+
+            Editor.insertNode(
+              editor,
+              editor.pteCreateTextBlock({
+                decorators: [],
+              }),
+            )
+
+            const [nextBlockPath] = Path.next(focusBlockPath)
+
+            Transforms.setSelection(editor, {
+              anchor: {path: [nextBlockPath, 0], offset: 0},
+              focus: {path: [nextBlockPath, 0], offset: 0},
+            })
+          })
+          editor.onChange()
+          return
+        }
+
         const isInTheMiddleOfNode = !isEndAtStartOfBlock && !isStartAtEndOfBlock
 
         if (isInTheMiddleOfNode) {
@@ -131,7 +176,10 @@ export function createWithInsertBreak(
                   ) {
                     // This annotation is both present in the previous block
                     // and this block, so let's assign a new key to it
-                    newMarkDefKeys.set(mark, keyGenerator())
+                    newMarkDefKeys.set(
+                      mark,
+                      editorActor.getSnapshot().context.keyGenerator(),
+                    )
                   }
                 }
 

package/src/editor/plugins/createWithInsertData.ts

@@ -25,7 +25,6 @@ const debug = debugWithName('plugin:withInsertData')
 export function createWithInsertData(
   editorActor: EditorActor,
   schemaTypes: PortableTextMemberSchemaTypes,
-  keyGenerator: () => string,
 ) {
   return function withInsertData(
     editor: PortableTextSlateEditor,
@@ -149,12 +148,16 @@ export function createWithInsertData(
           const slateValue = _regenerateKeys(
             editor,
             toSlateValue(parsed, {schemaTypes}),
-            keyGenerator,
+            editorActor.getSnapshot().context.keyGenerator,
             spanTypeName,
             schemaTypes,
           )
           // Validate the result
-          const validation = validateValue(parsed, schemaTypes, keyGenerator)
+          const validation = validateValue(
+            parsed,
+            schemaTypes,
+            editorActor.getSnapshot().context.keyGenerator,
+          )
           // Bail out if it's not valid
           if (!validation.valid && !validation.resolution?.autoResolve) {
             const errorDescription = `${validation.resolution?.description}`
@@ -224,7 +227,7 @@ export function createWithInsertData(
         const validation = validateValue(
           portableText,
           schemaTypes,
-          keyGenerator,
+          editorActor.getSnapshot().context.keyGenerator,
         )
 
         // Bail out if it's not valid

package/src/editor/plugins/createWithObjectKeys.ts

@@ -14,7 +14,6 @@ import type {EditorActor} from '../editor-machine'
 export function createWithObjectKeys(
   editorActor: EditorActor,
   schemaTypes: PortableTextMemberSchemaTypes,
-  keyGenerator: () => string,
 ) {
   return function withKeys(
     editor: PortableTextSlateEditor,
@@ -48,7 +47,7 @@ export function createWithObjectKeys(
           ...operation,
           properties: {
             ...operation.properties,
-            _key: keyGenerator(),
+            _key: editorActor.getSnapshot().context.keyGenerator(),
           },
         })
 
@@ -61,7 +60,7 @@ export function createWithObjectKeys(
             ...operation,
             node: {
               ...operation.node,
-              _key: keyGenerator(),
+              _key: editorActor.getSnapshot().context.keyGenerator(),
             },
           })
 
@@ -78,7 +77,11 @@ export function createWithObjectKeys(
         // Set key on block itself
         if (!node._key) {
           editorActor.send({type: 'normalizing'})
-          Transforms.setNodes(editor, {_key: keyGenerator()}, {at: path})
+          Transforms.setNodes(
+            editor,
+            {_key: editorActor.getSnapshot().context.keyGenerator()},
+            {at: path},
+          )
           editorActor.send({type: 'done normalizing'})
           return
         }
@@ -86,7 +89,11 @@ export function createWithObjectKeys(
         for (const [child, childPath] of Node.children(editor, path)) {
           if (!child._key) {
             editorActor.send({type: 'normalizing'})
-            Transforms.setNodes(editor, {_key: keyGenerator()}, {at: childPath})
+            Transforms.setNodes(
+              editor,
+              {_key: editorActor.getSnapshot().context.keyGenerator()},
+              {at: childPath},
+            )
             editorActor.send({type: 'done normalizing'})
             return
           }

package/src/editor/plugins/createWithPatches.ts

@@ -81,7 +81,6 @@ export interface PatchFunctions {
 
 interface Options {
   editorActor: EditorActor
-  keyGenerator: () => string
   patches$?: PatchObservable
   patchFunctions: PatchFunctions
   readOnly: boolean