@portabletext/editor 1.0.17 → 1.0.19

package/lib/index.esm.js

@@ -122,7 +122,7 @@ function normalizeSelection(selection, value) {
   const { anchor, focus } = selection;
   return anchor && value.find((blk) => isEqual({ _key: blk._key }, anchor.path[0])) && (newAnchor = normalizePoint(anchor, value)), focus && value.find((blk) => isEqual({ _key: blk._key }, focus.path[0])) && (newFocus = normalizePoint(focus, value)), newAnchor && newFocus ? { anchor: newAnchor, focus: newFocus, backward: selection.backward } : null;
 }
-const EMPTY_MARKDEFS = [], EMPTY_MARKS$1 = [], VOID_CHILD_KEY = "void-child";
+const EMPTY_MARKDEFS = [], VOID_CHILD_KEY = "void-child";
 function keepObjectEquality(object, keyMap) {
   const value = keyMap[object._key];
   return value && isEqual(object, value) ? value : (keyMap[object._key] = object, object);
@@ -870,24 +870,38 @@ function createOperationToPatches(types) {
         return [unset([{ _key: block._key }])];
       throw new Error("Block not found");
     } else if (editor.isTextBlock(block) && operation.path.length === 2) {
-      const spanToRemove = editor.isTextBlock(block) && block.children && block.children[operation.path[1]];
-      return spanToRemove ? [unset([{ _key: block._key }, "children", { _key: spanToRemove._key }])] : (debug$k("Span not found in editor trying to remove node"), []);
+      const spanToRemove = block.children[operation.path[1]];
+      return spanToRemove ? block.children.filter((span) => span._key === operation.node._key).length > 1 ? (console.warn(
+        `Multiple spans have \`_key\` ${operation.node._key}. It's ambiguous which one to remove.`,
+        JSON.stringify(block, null, 2)
+      ), []) : [unset([{ _key: block._key }, "children", { _key: spanToRemove._key }])] : (debug$k("Span not found in editor trying to remove node"), []);
     } else
       return debug$k("Not creating patch inside object block"), [];
   }
   function mergeNodePatch(editor, operation, beforeValue) {
-    const patches = [], block = beforeValue[operation.path[0]], targetBlock = editor.children[operation.path[0]];
+    const patches = [], block = beforeValue[operation.path[0]], updatedBlock = editor.children[operation.path[0]];
     if (operation.path.length === 1)
       if (block?._key) {
         const newBlock = fromSlateValue([editor.children[operation.path[0] - 1]], textBlockName)[0];
         patches.push(set(newBlock, [{ _key: newBlock._key }])), patches.push(unset([{ _key: block._key }]));
       } else
         throw new Error("Target key not found!");
-    else if (operation.path.length === 2 && editor.isTextBlock(targetBlock)) {
-      const mergedSpan = editor.isTextBlock(block) && block.children[operation.path[1]] || void 0, targetSpan = targetBlock.children[operation.path[1] - 1];
-      editor.isTextSpan(targetSpan) && (patches.push(
-        set(targetSpan.text, [{ _key: block._key }, "children", { _key: targetSpan._key }, "text"])
-      ), mergedSpan && patches.push(unset([{ _key: block._key }, "children", { _key: mergedSpan._key }])));
+    else if (editor.isTextBlock(block) && editor.isTextBlock(updatedBlock) && operation.path.length === 2) {
+      const updatedSpan = updatedBlock.children[operation.path[1] - 1] && editor.isTextSpan(updatedBlock.children[operation.path[1] - 1]) ? updatedBlock.children[operation.path[1] - 1] : void 0, removedSpan = block.children[operation.path[1]] && editor.isTextSpan(block.children[operation.path[1]]) ? block.children[operation.path[1]] : void 0;
+      updatedSpan && (block.children.filter((span) => span._key === updatedSpan._key).length === 1 ? patches.push(
+        set(updatedSpan.text, [
+          { _key: block._key },
+          "children",
+          { _key: updatedSpan._key },
+          "text"
+        ])
+      ) : console.warn(
+        `Multiple spans have \`_key\` ${updatedSpan._key}. It's ambiguous which one to update.`,
+        JSON.stringify(block, null, 2)
+      )), removedSpan && (block.children.filter((span) => span._key === removedSpan._key).length === 1 ? patches.push(unset([{ _key: block._key }, "children", { _key: removedSpan._key }])) : console.warn(
+        `Multiple spans have \`_key\` ${removedSpan._key}. It's ambiguous which one to remove.`,
+        JSON.stringify(block, null, 2)
+      ));
     } else
       debug$k("Void nodes can't be merged, not creating any patches");
     return patches;
@@ -1154,9 +1168,10 @@ function createWithEditableAPI(portableTextEditor, types, keyGenerator) {
           const [block] = Editor.node(editor, originalSelection.focus, { depth: 1 });
           if (!editor.isTextBlock(block))
             return;
-          Range.isCollapsed(originalSelection) && (editor.pteExpandToWord(), editor.onChange());
           const [textNode] = Editor.node(editor, originalSelection.focus, { depth: 2 });
-          editor.selection && (Editor.withoutNormalizing(editor, () => {
+          if (!isPortableTextSpan$1(textNode) || textNode.text === "")
+            return;
+          Range.isCollapsed(originalSelection) && (editor.pteExpandToWord(), editor.onChange()), editor.selection && (Editor.withoutNormalizing(editor, () => {
             const annotationKey = keyGenerator();
             Transforms.setNodes(
               editor,
@@ -2772,7 +2787,7 @@ function createWithPortableTextMarkModel(types, change$, keyGenerator) {
       change$.next({ type: "selection", selection: ptRange });
     };
     return editor.normalizeNode = (nodeEntry) => {
-      const [node, path] = nodeEntry, isSpan = Text.isText(node) && node._type === types.span.name, isTextBlock = editor.isTextBlock(node);
+      const [node, path] = nodeEntry;
       if (editor.isTextBlock(node)) {
         const children = Node.children(editor, path);
         for (const [child, childPath] of children) {
@@ -2787,65 +2802,47 @@ function createWithPortableTextMarkModel(types, change$, keyGenerator) {
           }
         }
       }
-      if (isSpan || isTextBlock) {
-        if (isSpan && !Array.isArray(node.marks)) {
-          debug$c("Adding .marks to span node"), Transforms.setNodes(editor, { marks: [] }, { at: path });
-          return;
-        }
-        if (isSpan && (node.marks || []).length > 0) {
-          const spanMarks = node.marks || EMPTY_MARKS$1, annotationMarks = spanMarks.filter(
-            (mark) => !types.decorators.map((dec) => dec.value).includes(mark)
+      if (editor.isTextSpan(node) && !Array.isArray(node.marks)) {
+        debug$c("Adding .marks to span node"), Transforms.setNodes(editor, { marks: [] }, { at: path });
+        return;
+      }
+      if (editor.isTextSpan(node)) {
+        const blockPath = Path.parent(path), [block] = Editor.node(editor, blockPath), decorators2 = types.decorators.map((decorator) => decorator.value), annotations = node.marks?.filter((mark) => !decorators2.includes(mark));
+        if (editor.isTextBlock(block) && node.text === "" && annotations && annotations.length > 0) {
+          debug$c("Removing annotations from empty span node"), Transforms.setNodes(
+            editor,
+            { marks: node.marks?.filter((mark) => decorators2.includes(mark)) },
+            { at: path }
           );
-          if (annotationMarks.length > 0) {
-            const [block] = Editor.node(editor, Path.parent(path)), orphanedMarks = editor.isTextBlock(block) && annotationMarks.filter(
-              (mark) => !block.markDefs?.find((def) => def._key === mark)
-            ) || [];
-            if (orphanedMarks.length > 0) {
-              debug$c("Removing orphaned .marks from span node"), Transforms.setNodes(
-                editor,
-                { marks: spanMarks.filter((mark) => !orphanedMarks.includes(mark)) },
-                { at: path }
-              );
-              return;
-            }
-          }
+          return;
         }
-        for (const op of editor.operations) {
-          if (op.type === "merge_node" && op.path.length === 1 && "markDefs" in op.properties && op.properties._type === types.block.name && Array.isArray(op.properties.markDefs) && op.properties.markDefs.length > 0 && op.path[0] - 1 >= 0) {
-            const [targetBlock, targetPath] = Editor.node(editor, [op.path[0] - 1]);
-            if (debug$c("Copying markDefs over to merged block", op), editor.isTextBlock(targetBlock)) {
-              const oldDefs = Array.isArray(targetBlock.markDefs) && targetBlock.markDefs || [], newMarkDefs = uniq([...oldDefs, ...op.properties.markDefs]);
-              if (!isEqual(newMarkDefs, targetBlock.markDefs)) {
-                Transforms.setNodes(editor, { markDefs: newMarkDefs }, { at: targetPath, voids: !1 });
-                return;
-              }
-            }
-          }
-          if (op.type === "split_node" && op.path.length === 1 && Element$1.isElementProps(op.properties) && op.properties._type === types.block.name && "markDefs" in op.properties && Array.isArray(op.properties.markDefs) && op.properties.markDefs.length > 0 && op.path[0] + 1 < editor.children.length) {
-            const [targetBlock, targetPath] = Editor.node(editor, [op.path[0] + 1]);
-            if (debug$c("Copying markDefs over to split block", op), editor.isTextBlock(targetBlock)) {
-              const oldDefs = Array.isArray(targetBlock.markDefs) && targetBlock.markDefs || [];
-              Transforms.setNodes(
+      }
+      if (editor.isTextBlock(node)) {
+        const decorators2 = types.decorators.map((decorator) => decorator.value);
+        for (const [child, childPath] of Node.children(editor, path))
+          if (editor.isTextSpan(child)) {
+            const marks = child.marks ?? [], orphanedAnnotations = marks.filter((mark) => !decorators2.includes(mark) && !node.markDefs?.find((def) => def._key === mark));
+            if (orphanedAnnotations.length > 0) {
+              debug$c("Removing orphaned annotations from span node"), Transforms.setNodes(
                 editor,
-                { markDefs: uniq([...oldDefs, ...op.properties.markDefs]) },
-                { at: targetPath, voids: !1 }
+                { marks: marks.filter((mark) => !orphanedAnnotations.includes(mark)) },
+                { at: childPath }
               );
               return;
             }
           }
-          if (op.type === "split_node" && op.path.length === 2 && op.properties._type === types.span.name && "marks" in op.properties && Array.isArray(op.properties.marks) && op.properties.marks.length > 0 && op.path[0] + 1 < editor.children.length) {
-            const [child, childPath] = Editor.node(editor, [op.path[0] + 1, 0]);
-            if (Text.isText(child) && child.text === "" && Array.isArray(child.marks) && child.marks.length > 0) {
-              Transforms.setNodes(editor, { marks: [] }, { at: childPath, voids: !1 });
-              return;
-            }
-          }
-          if (op.type === "split_node" && op.path.length === 1 && op.properties._type === types.block.name && "markDefs" in op.properties && Array.isArray(op.properties.markDefs) && op.properties.markDefs.length > 0) {
-            const [block, blockPath] = Editor.node(editor, [op.path[0]]);
-            if (editor.isTextBlock(block) && block.children.length === 1 && block.markDefs && block.markDefs.length > 0 && Text.isText(block.children[0]) && block.children[0].text === "" && (!block.children[0].marks || block.children[0].marks.length === 0)) {
-              Transforms.setNodes(editor, { markDefs: [] }, { at: blockPath });
-              return;
-            }
+      }
+      if (editor.isTextSpan(node)) {
+        const blockPath = Path.parent(path), [block] = Editor.node(editor, blockPath);
+        if (editor.isTextBlock(block)) {
+          const decorators2 = types.decorators.map((decorator) => decorator.value), marks = node.marks ?? [], orphanedAnnotations = marks.filter((mark) => !decorators2.includes(mark) && !block.markDefs?.find((def) => def._key === mark));
+          if (orphanedAnnotations.length > 0) {
+            debug$c("Removing orphaned annotations from span node"), Transforms.setNodes(
+              editor,
+              { marks: marks.filter((mark) => !orphanedAnnotations.includes(mark)) },
+              { at: path }
+            );
+            return;
           }
         }
       }
@@ -2939,6 +2936,14 @@ function createWithPortableTextMarkModel(types, change$, keyGenerator) {
           }
         }
       }
+      if (op.type === "merge_node" && op.path.length === 1 && "markDefs" in op.properties && op.properties._type === types.block.name && Array.isArray(op.properties.markDefs) && op.properties.markDefs.length > 0 && op.path[0] - 1 >= 0) {
+        const [targetBlock, targetPath] = Editor.node(editor, [op.path[0] - 1]);
+        if (editor.isTextBlock(targetBlock)) {
+          const oldDefs = Array.isArray(targetBlock.markDefs) && targetBlock.markDefs || [], newMarkDefs = uniq([...oldDefs, ...op.properties.markDefs]);
+          debug$c("Copying markDefs over to merged block", op), Transforms.setNodes(editor, { markDefs: newMarkDefs }, { at: targetPath, voids: !1 }), apply2(op);
+          return;
+        }
+      }
       apply2(op);
     }, editor.addMark = (mark) => {
       if (editor.selection) {