@portabletext/editor 1.0.16 → 1.0.18

package/lib/index.esm.js

@@ -870,24 +870,38 @@ function createOperationToPatches(types) {
         return [unset([{ _key: block._key }])];
       throw new Error("Block not found");
     } else if (editor.isTextBlock(block) && operation.path.length === 2) {
-      const spanToRemove = editor.isTextBlock(block) && block.children && block.children[operation.path[1]];
-      return spanToRemove ? [unset([{ _key: block._key }, "children", { _key: spanToRemove._key }])] : (debug$k("Span not found in editor trying to remove node"), []);
+      const spanToRemove = block.children[operation.path[1]];
+      return spanToRemove ? block.children.filter((span) => span._key === operation.node._key).length > 1 ? (console.warn(
+        `Multiple spans have \`_key\` ${operation.node._key}. It's ambiguous which one to remove.`,
+        JSON.stringify(block, null, 2)
+      ), []) : [unset([{ _key: block._key }, "children", { _key: spanToRemove._key }])] : (debug$k("Span not found in editor trying to remove node"), []);
     } else
       return debug$k("Not creating patch inside object block"), [];
   }
   function mergeNodePatch(editor, operation, beforeValue) {
-    const patches = [], block = beforeValue[operation.path[0]], targetBlock = editor.children[operation.path[0]];
+    const patches = [], block = beforeValue[operation.path[0]], updatedBlock = editor.children[operation.path[0]];
     if (operation.path.length === 1)
       if (block?._key) {
         const newBlock = fromSlateValue([editor.children[operation.path[0] - 1]], textBlockName)[0];
         patches.push(set(newBlock, [{ _key: newBlock._key }])), patches.push(unset([{ _key: block._key }]));
       } else
         throw new Error("Target key not found!");
-    else if (operation.path.length === 2 && editor.isTextBlock(targetBlock)) {
-      const mergedSpan = editor.isTextBlock(block) && block.children[operation.path[1]] || void 0, targetSpan = targetBlock.children[operation.path[1] - 1];
-      editor.isTextSpan(targetSpan) && (patches.push(
-        set(targetSpan.text, [{ _key: block._key }, "children", { _key: targetSpan._key }, "text"])
-      ), mergedSpan && patches.push(unset([{ _key: block._key }, "children", { _key: mergedSpan._key }])));
+    else if (editor.isTextBlock(block) && editor.isTextBlock(updatedBlock) && operation.path.length === 2) {
+      const updatedSpan = updatedBlock.children[operation.path[1] - 1] && editor.isTextSpan(updatedBlock.children[operation.path[1] - 1]) ? updatedBlock.children[operation.path[1] - 1] : void 0, removedSpan = block.children[operation.path[1]] && editor.isTextSpan(block.children[operation.path[1]]) ? block.children[operation.path[1]] : void 0;
+      updatedSpan && (block.children.filter((span) => span._key === updatedSpan._key).length === 1 ? patches.push(
+        set(updatedSpan.text, [
+          { _key: block._key },
+          "children",
+          { _key: updatedSpan._key },
+          "text"
+        ])
+      ) : console.warn(
+        `Multiple spans have \`_key\` ${updatedSpan._key}. It's ambiguous which one to update.`,
+        JSON.stringify(block, null, 2)
+      )), removedSpan && (block.children.filter((span) => span._key === removedSpan._key).length === 1 ? patches.push(unset([{ _key: block._key }, "children", { _key: removedSpan._key }])) : console.warn(
+        `Multiple spans have \`_key\` ${removedSpan._key}. It's ambiguous which one to remove.`,
+        JSON.stringify(block, null, 2)
+      ));
     } else
       debug$k("Void nodes can't be merged, not creating any patches");
     return patches;
@@ -1176,13 +1190,7 @@ function createWithEditableAPI(portableTextEditor, types, keyGenerator) {
                 at: editor.selection,
                 match: (n) => n._type === types.span.name
               }
-            ), editor.onChange(), editor.selection && Transforms.insertNodes(
-              editor,
-              [{ _type: "span", text: "", marks: [], _key: keyGenerator() }],
-              {
-                at: Range.end(editor.selection)
-              }
-            );
+            ), editor.onChange();
             const newPortableTextEditorSelection = toPortableTextRange(
               fromSlateValue(editor.children, types.block.name, KEY_TO_VALUE_ELEMENT.get(editor)),
               editor.selection,