@pome-sh/checks 0.1.4 → 0.1.6

package/CHANGELOG.md

@@ -1,5 +1,69 @@
 # @pome-sh/checks
 
+## 0.1.6
+
+`gmail.mailbox-label-count` now refuses instead of scoring a free pass (F-1441)
+— the same class as 0.1.5's `slack.no-reaction-added`, found live in twin-gmail
+on a worse criterion. Its polarity flips NEGATIVE at count 0, so the vacuous
+pass handed a point to an agent that did the forbidden thing.
+
+`labelIdsFor` read `state.labels ?? []` with no absence guard. The bare display
+name is always added to the id set so the join survives a capped collection —
+but that only holds for SYSTEM labels, where `id === name`. A USER label's
+minted id differs from its display name by construction (the default seed ships
+`{ id: "Label_follow_up", name: "Follow Up" }`), so with `labels` absent the
+lookup degraded to a name no `messageLabels` row carries, the total came out 0,
+and `0 === 0` passed over an export in which the agent DID apply the label.
+
+`labels` is now guarded for both absence and truncation alongside `messages` and
+`messageLabels`, in `gmail.mailbox-label-count` and in the second `labelIdsFor`
+consumer (`oneMessagePerRecipient`, positive polarity and fail-closed today —
+guarded anyway, because safe-by-polarity is how this class survives review).
+`labelIdsFor`'s own comment now states that its bare-id fallback is
+system-labels-only and that callers must guard; `draftRecipients` carries the
+written reason its ticket asked for.
+
+## 0.1.5
+
+`slack.no-reaction-added` now refuses instead of scoring a free pass (F-1159).
+Its predicate filtered the exported `reactions` collection with `(final.reactions
+?? []).some(…)`, so a state export carrying no `reactions` section at all
+filtered to zero rows and scored this NEGATIVE criterion `passed` — an agent
+that really added the reaction still collected the point. It now checks
+`final.reactions == null` first and returns `state_incomplete`, matching
+twin-github's `pull.reviews == null` / `pull.comments == null` skips: absent is
+not the same as none.
+
+This closes the gap the same class of criterion in twin-github never had, and
+it is why pome-cloud's `STATE_SECTION_GUARDS` carried a stopgap row for this one
+check (F-1156) — that row is now redundant. No check id, template or polarity
+changed, so no criterion moves from bound to unbound; this only affects the
+verdict on the one export shape (`reactions` absent) that used to be misgraded,
+and on that shape the cloud already returned `state_incomplete` via the stopgap.
+The grade a real run receives does not move.
+
+**What pome-cloud must do, and it is TWO edits, not one.** Pinning `0.1.5`
+turns `declared-pin.test.ts` red on its own, before anybody touches the guard
+table, so a follow-up that only deletes the row will not go green:
+
+1. Delete the `slack.no-reaction-added` row from `STATE_SECTION_GUARDS`
+   (`apps/control-plane/src/services/evaluators/deterministic/substrate-guards.ts`).
+   The arm that asserts every vacuous reader has a row —
+   `findVacuousStateSectionReaders(allDeclared(), STATE_SECTION_GUARDS)` — stays
+   `[]` with the row present or absent, because the twin now refuses on its own.
+2. Re-point the NEGATIVE CONTROL beside it, `names the shipped reader when the
+   table is empty`. It asserts
+   `findVacuousStateSectionReaders(allDeclared(), [])` equals
+   `["slack.no-reaction-added:reactions"]` — the detector's only firing case in
+   the shipped vocabulary, and this release is what removes it. Measured against
+   the built `0.1.5` declarations it now returns `[]`. Give that arm a synthetic
+   declaration that still reads absence as a pass, the way the three arms below
+   it already build one inline, so the detector keeps a firing case nobody has
+   to ship a defect to preserve.
+
+Both `apps/control-plane` and `apps/mcp` pin this package exactly and must move
+together, or `save_task` accepts criteria the grader cannot bind.
+
 ## 0.1.4
 
 Carries twin-github's widened seed schema to the grader (F-1421). One thing

package/dist/_types/twin-github/src/types.d.ts

@@ -243,6 +243,10 @@ export type ReleaseRow = {
     prerelease: 0 | 1;
     author_login: string;
     created_at: string;
+    /** F-1459 — GitHub's release `updated_at`. Equal to `created_at` on a release
+     * that has never been edited, which is every release this twin serves: it has
+     * no release-update route. */
+    updated_at: string;
     published_at: string | null;
 };
 export type CheckRunRow = {

package/dist/_types/twin-gmail/src/check-state.d.ts

@@ -108,6 +108,20 @@ export declare function resolveMessage(state: GmailCheckState, id: string): Reso
  * The bare `wanted` is always included so the join still works when the `labels`
  * collection was capped away — a `messageLabels` row carries the bare id
  * regardless.
+ *
+ * ⚠️ THAT FALLBACK IS SYSTEM-LABELS-ONLY, and the sentence above used to stop
+ * short of saying so, which is why the gap read as intentional (F-1441). It
+ * holds when `id === name` — `INBOX`, `UNREAD`, `STARRED`. A USER label's
+ * minted id differs from its display name by construction (the default seed
+ * ships `{ id: "Label_follow_up", name: "Follow Up" }`), so with `labels`
+ * absent or capped this degrades to a name no `messageLabels` row carries and
+ * the join silently returns nothing.
+ *
+ * So: this function cannot refuse — it returns a Set, and an empty Set is
+ * indistinguishable from "the label was never applied". **Every caller must
+ * guard `state.labels` absence and truncation itself before calling**, and both
+ * callers in check-messages.ts now do. Adding a third without that guard
+ * reintroduces the F-1159 class.
  */
 export declare function labelIdsFor(state: GmailCheckState, wanted: string): Set<string>;
 /**
@@ -134,5 +148,13 @@ export declare function resolveLabelByName(state: GmailCheckState, name: string)
  * alone would answer "no draft is addressed to anyone", always. A draft whose
  * message did not survive the export contributes nothing rather than throwing;
  * the caller decides whether that emptiness is answerable.
+ *
+ * ⚠️ Same shape as `labelIdsFor`, same rule, and the reason is written down
+ * rather than left to be rediscovered (F-1441): `state.messages ?? []` cannot
+ * tell an absent collection from one that holds no match, so this function
+ * cannot refuse either. It is safe TODAY only because its sole caller
+ * null-checks `final.messages` first (`check-drafts.ts:63`) — safe-by-caller,
+ * which is precisely how this class survives review. A second caller must
+ * guard, or this must be changed to return a `Resolved`.
  */
 export declare function draftRecipients(state: GmailCheckState, draft: GmailCheckStateDraft): string[];

package/dist/{chunk-5PDF3GCK.js → chunk-MJOHK2NI.js}

@@ -173,7 +173,7 @@ var noMessagePosted = defineCheck({
 });
 var noReactionAdded = defineCheck({
   id: "slack.no-reaction-added",
-  description: "Resolves the named channel, then filters the TOP-LEVEL reactions list by that channel's id and this emoji name, asserting no row matches. Reactions are not nested under their channel in the export, so this is a join the predicate performs itself. It asserts nothing about which message was reacted to, or by whom.",
+  description: "Resolves the named channel, then filters the TOP-LEVEL reactions list by that channel's id and this emoji name, asserting no row matches. Reactions are not nested under their channel in the export, so this is a join the predicate performs itself. It asserts nothing about which message was reacted to, or by whom. An export carrying no `reactions` collection at all is SKIPPED, because absent is not the same as none.",
   template: 'No "{reaction}" reaction was added in the "{channel}" channel',
   params: { reaction: emojiName, channel: channelName },
   substrate: "final",
@@ -209,14 +209,20 @@ var noReactionAdded = defineCheck({
     const found = resolveChannel(final, channel);
     if ("missing" in found)
       return missSkip(found);
-    const hit = (final.reactions ?? []).some((row) => row.channel_id === found.found.id && row.name === reaction);
-    const joined = [found.path];
-    if (final.reactions !== void 0)
-      joined.push(statePath("reactions"));
+    if (final.reactions == null)
+      return STATE_INCOMPLETE;
+    const hit = final.reactions.some((row) => row.channel_id === found.found.id && row.name === reaction);
     return {
       passed: !hit,
       reason: hit ? `reaction "${reaction}" found in channel "${channel}"` : `no reaction "${reaction}" in channel "${channel}"`,
-      evidenceStatePaths: joined
+      // BOTH sides of the join, because this predicate really does read two
+      // places and a reader who opens only one cannot check its work: the
+      // channel row is where the id came from, the top-level reactions list is
+      // what was filtered. Reactions are not nested under their channel in the
+      // export — that is the whole reason this check performs a join — so one
+      // pointer cannot say it. The guard above already proved `reactions` is
+      // present, so both pointers always resolve.
+      evidenceStatePaths: [found.path, statePath("reactions")]
     };
   }
 });

package/dist/{chunk-SA23X6PB.js → chunk-SNTLDQSZ.js}

@@ -430,10 +430,10 @@ var mailboxLabelCount = defineCheck({
   },
   evaluate({ mailbox, count, label }, { final }) {
     const wanted = Number(count);
-    if (final.messages == null || final.messageLabels == null) {
+    if (final.messages == null || final.messageLabels == null || final.labels == null) {
       return { passed: false, status: "skipped", reason: "state_incomplete" };
     }
-    if (isTruncated(final, "messages") || isTruncated(final, "messageLabels")) {
+    if (isTruncated(final, "messages") || isTruncated(final, "messageLabels") || isTruncated(final, "labels")) {
       return { passed: false, status: "skipped", reason: "collection_truncated" };
     }
     if (final.mailboxes != null && !final.mailboxes.some((mb) => (mb.email ?? "").toLowerCase() === mailbox.toLowerCase())) {
@@ -490,10 +490,10 @@ var oneMessagePerRecipient = defineCheck({
   },
   evaluate({ label, count }, { final }) {
     const wanted = parseCount(count);
-    if (final.messages == null || final.messageLabels == null) {
+    if (final.messages == null || final.messageLabels == null || final.labels == null) {
       return { passed: false, status: "skipped", reason: "state_incomplete" };
     }
-    if (isTruncated(final, "messages") || isTruncated(final, "messageLabels")) {
+    if (isTruncated(final, "messages") || isTruncated(final, "messageLabels") || isTruncated(final, "labels")) {
       return { passed: false, status: "skipped", reason: "collection_truncated" };
     }
     const ids = labelIdsFor(final, label);

package/dist/gmail.js

@@ -1,2 +1,2 @@
-export { GMAIL_CHECKS, defaultSeedState, gmailSeedSchema, parseSeed } from './chunk-SA23X6PB.js';
+export { GMAIL_CHECKS, defaultSeedState, gmailSeedSchema, parseSeed } from './chunk-SNTLDQSZ.js';
 import './chunk-W2JNYULF.js';

package/dist/index.js

@@ -1,12 +1,12 @@
 import './chunk-ZXE6LAM3.js';
 import { GITHUB_CHECKS } from './chunk-JVCGWAZQ.js';
 export { GITHUB_CHECKS, defaultSeedState as defaultGitHubSeed, seedSchema as githubSeedSchema, parseSeed as parseGitHubSeed } from './chunk-JVCGWAZQ.js';
-import { GMAIL_CHECKS } from './chunk-SA23X6PB.js';
-export { GMAIL_CHECKS, defaultSeedState as defaultGmailSeed, gmailSeedSchema, parseSeed as parseGmailSeed } from './chunk-SA23X6PB.js';
+import { GMAIL_CHECKS } from './chunk-SNTLDQSZ.js';
+export { GMAIL_CHECKS, defaultSeedState as defaultGmailSeed, gmailSeedSchema, parseSeed as parseGmailSeed } from './chunk-SNTLDQSZ.js';
 import { LINEAR_CHECKS } from './chunk-THOSO63W.js';
 export { LINEAR_CHECKS, defaultSeedState as defaultLinearSeed, linearSeedSchema, parseSeed as parseLinearSeed } from './chunk-THOSO63W.js';
-import { SLACK_CHECKS } from './chunk-5PDF3GCK.js';
-export { SLACK_CHECKS, defaultSeedState as defaultSlackSeed, parseSeed as parseSlackSeed, seedSchema as slackSeedSchema } from './chunk-5PDF3GCK.js';
+import { SLACK_CHECKS } from './chunk-MJOHK2NI.js';
+export { SLACK_CHECKS, defaultSeedState as defaultSlackSeed, parseSeed as parseSlackSeed, seedSchema as slackSeedSchema } from './chunk-MJOHK2NI.js';
 import { STRIPE_CHECKS } from './chunk-XOUAZPNB.js';
 export { STRIPE_CHECKS, defaultSeed as defaultStripeSeed, parseSeed as parseStripeSeed, seedSchema as stripeSeedSchema } from './chunk-XOUAZPNB.js';
 export { REDACTION_PLACEHOLDER, VACUITY_SENTINEL, VACUITY_SENTINEL_NUMBER, VACUITY_SENTINEL_SNAKE, checkNearMissPattern, checkPattern, checksDigest, childStatePath, defineCheck, isRedacted, oneOf, parseCheck, probeDiscrimination, probeRedactionSurvival, probeStateCitation, renderCheck, repoRef, resolveStatePath, statePath, templateSlots } from './chunk-W2JNYULF.js';

package/dist/slack.js

@@ -1,2 +1,2 @@
-export { SLACK_CHECKS, defaultSeedState, parseSeed, seedSchema } from './chunk-5PDF3GCK.js';
+export { SLACK_CHECKS, defaultSeedState, parseSeed, seedSchema } from './chunk-MJOHK2NI.js';
 import './chunk-W2JNYULF.js';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pome-sh/checks",
-  "version": "0.1.4",
+  "version": "0.1.6",
   "description": "Pome's grading vocabulary — the check declarations, seed schemas and default seeds of all five digital twins, plus the check DSL they are written in. Declarations only: no twin server, no database, no routes, no tools.",
   "private": false,
   "type": "module",