@polymorphism-tech/morph-spec 9.1.0 → 9.3.0

package/src/lib/validators/code-budget/code-budget-validator.js

@@ -9,7 +9,7 @@ import { isTestFile } from '../reuse/symbol-scanner.js';
 import { isGenerated, isProjectSource } from '../../../../framework/hooks/shared/source-files.js';
 import { citesProcess, commentLines } from '../../../../framework/hooks/shared/comment-scanner.js';
 
-export const MAX_TEST_RATIO = 1.5;
+export const MAX_TEST_RATIO = 1;
 
 /** Abaixo disto a razão não é julgada: a regressão de um bug de 2 linhas cabe aqui. */
 export const MIN_TEST_LINES = 40;

package/src/lib/validators/validation-runner.js

@@ -3,11 +3,6 @@ import chalk from 'chalk';
 import { getAbsoluteOutputPath, resolveContractsOutputType } from '../../core/paths/output-schema.js';
 import { getStackProfile } from '../stack/stack-profile.js';
 
-// Skipped in 'light' mode (checkpoint-only); light keeps `nextjs-component`.
-const HEAVY_VALIDATORS = new Set([
-  'packages', 'contract-compliance', 'reuse', 'code-budget'
-]);
-
 /**
  * @param {string[]} [options.validators] - overrides stack-based detection
  * @returns {Object} { passed, errors, warnings, issues, summary, results, skipped, _skipReason? }
@@ -24,36 +19,11 @@ export async function runValidation(projectPath, featureName, options = {}) {
 
   // A copy: filtering in place would empty the caller's own `options.validators`.
   const detected = options.validators || detectValidators(projectPath);
-  let validatorIds = [...detected];
-
-  const mode = options.mode || 'full';
-  const droppedByMode = [];
-  if (mode === 'light') {
-    validatorIds = validatorIds.filter(id => {
-      if (HEAVY_VALIDATORS.has(id)) { droppedByMode.push(id); return false; }
-      return true;
-    });
-  }
-
-  // Stack-agnostic validators join here, before the "no validators" early return:
-  // on an `empty`/`nodejs-cli` stack they are the only check. Not in `droppedByMode`,
-  // which only lists what light mode removed from the stack's own list.
-  if (!options.skipReuse && mode !== 'light') {
-    validatorIds.push('reuse');
-  }
-  if (mode !== 'light') {
-    validatorIds.push('code-budget');
-  }
+  const validatorIds = [...detected];
 
-  if (validatorIds.length === 0) {
-    result.summary = droppedByMode.length > 0
-      ? `No validators ran — light mode skipped ${droppedByMode.length} heavy validator(s): ${droppedByMode.join(', ')}`
-      : 'No validators ran — no validators configured for this stack';
-    console.log(chalk.gray(`\n  ℹ️  ${result.summary.replace('No validators ran — ', '')}`));
-    result._skipReason = result.summary;
-    result._droppedByMode = droppedByMode;
-    return result;
-  }
+  // Stack-agnostic: on an `empty`/`nodejs-cli` stack they are the only check.
+  if (!options.skipReuse) validatorIds.push('reuse');
+  validatorIds.push('code-budget');
 
   console.log(chalk.gray(`\n  Running ${validatorIds.length} validator(s): ${validatorIds.join(', ')}`));
 
@@ -61,10 +31,8 @@ export async function runValidation(projectPath, featureName, options = {}) {
     const _profileForContracts = getStackProfile(projectPath);
     const contractsType = resolveContractsOutputType(_profileForContracts.stack);
     const contractsPath = getAbsoluteOutputPath(projectPath, featureName, contractsType);
-    // Positive `isDotnet`, not `!isNextjs`: a "dotnet-nextjs" stack is both. This push
-    // sits after the mode filter, so light mode has to be honored again here.
-    const contractsIsHeavyAndSkipped = mode === 'light' && HEAVY_VALIDATORS.has('contract-compliance');
-    if (existsSync(contractsPath) && _profileForContracts.isDotnet && !contractsIsHeavyAndSkipped) {
+    // Positive `isDotnet`, not `!isNextjs`: a "dotnet-nextjs" stack is both.
+    if (existsSync(contractsPath) && _profileForContracts.isDotnet) {
       validatorIds.push('contract-compliance');
     }
   }

package/src/lib/validators/verify-runner.js

@@ -5,6 +5,7 @@ import { join, resolve } from 'path';
 import { runBuildCheck, getBuildSteps, isDotnetStack } from '../../../framework/hooks/shared/build-check.js';
 import { composeProjectName, runE2eCheck } from '../../../framework/hooks/shared/e2e-check.js';
 import { buildComposeEnv } from '../e2e/compose-env.js';
+import { e2eApplicability } from '../e2e/applicability.js';
 import {
   runTestSuite, parseTestCount, compareTestCount, resolveTestTimeout, discoverDotnetSolution,
 } from '../tasks/test-runner.js';
@@ -21,7 +22,7 @@ import { runValidation } from './validation-runner.js';
 import { checkOutputsTraceability } from './traceability-check.js';
 import { createHeavyGate } from '../heavy/gate.js';
 
-// A dotnet cold build is slow; the Stop-hook default of 30s is too short.
+// A cold dotnet build takes minutes, not seconds.
 const DEFAULT_BUILD_TIMEOUT = 120_000;
 
 const VALIDATOR_FEEDBACK_LIMIT = 10;
@@ -67,6 +68,7 @@ async function runVerifyGated(projectPath, featureName, options, gate) {
     _runTestSuite = runTestSuite,
     _runValidation = runValidation,
     _runE2eCheck = runE2eCheck,
+    _e2eApplicability = e2eApplicability,
     _checkOutputsTraceability = checkOutputsTraceability,
   } = options;
 
@@ -150,8 +152,11 @@ async function runVerifyGated(projectPath, featureName, options, gate) {
     skipE2e,
     freshE2e,
     buildNode: nodes.build,
+    testsNode: nodes.tests,
+    hasStackNodes: stackNodes.length > 0,
     gate,
     _runE2eCheck,
+    _e2eApplicability,
   });
   nodes.e2e = e2e.node;
   appendE2eFeedback(feedback, nodes.e2e);
@@ -168,12 +173,17 @@ async function runVerifyGated(projectPath, featureName, options, gate) {
   // warning never turns red.
   const traceability = _checkOutputsTraceability(projectPath, featureName);
 
-  const status = Object.values(nodes).some((n) => n.status === 'fail') ? 'fail' : 'pass';
-
   const baseline = recordBaseline ? recordBaselineFrom(projectPath, nodes.tests) : null;
   if (baseline && !baseline.recorded) {
     feedback.push(`[baseline] não gravada: ${baseline.reason}`);
   }
+  const lowered = baseline?.recorded ? baseline.updates.filter((u) => u.from !== null && u.to < u.from) : [];
+  if (lowered.length > 0) {
+    feedback.push(`[baseline] rebaixada: ${lowered.map((u) => `${u.id} (${u.from} → ${u.to})`).join(', ')}`);
+    nodes.tests = acceptRecordedDrops(nodes.tests);
+  }
+
+  const status = Object.values(nodes).some((n) => n.status === 'fail') ? 'fail' : 'pass';
 
   return {
     version: 1,
@@ -401,7 +411,7 @@ function judgeEvalRun(entry, node, summaryPath) {
   }
 
   if (entry.status === 'pass' && verdict.verdict === 'drop') {
-    return { ...withNames, status: 'fail', count, warnings, reason: verdict.reason };
+    return { ...withNames, status: 'fail', count, warnings, reason: verdict.reason, countDrop: true };
   }
   if (verdict.verdict === 'drop') warnings.push(verdict.reason);
 
@@ -481,7 +491,7 @@ function judgeRun({ node, result, durationMs }) {
 
   // Only a drop fails a node; a rise never does, or failing on growth teaches deleting tests.
   if (verdict.verdict === 'drop' && result.passed) {
-    return { ...entry, status: 'fail', durationMs, count, warnings, reason: verdict.reason, output: '' };
+    return { ...entry, status: 'fail', durationMs, count, warnings, reason: verdict.reason, output: '', countDrop: true };
   }
   if (verdict.verdict === 'drop') warnings.push(verdict.reason);
 
@@ -497,6 +507,11 @@ function judgeRun({ node, result, durationMs }) {
   };
 }
 
+function acceptRecordedDrops(testsNode) {
+  const runs = testsNode.runs.map(({ countDrop, ...run }) => (countDrop ? { ...run, status: 'pass', reason: null } : run));
+  return rollUpTestRuns(runs, { command: testsNode.command, source: testsNode.source, environment: testsNode.environment });
+}
+
 // Any red run reddens the rollup; one green run among skips is a pass.
 function rollUpTestRuns(runs, { command, source, environment = null }) {
   const failed = runs.filter((r) => r.status === 'fail');
@@ -580,14 +595,15 @@ function baselineTargetProblem(projectPath, testPlan, { skipTests }) {
 }
 
 // Only a run with EVERY node green records: a red run would freeze the regression,
-// a partial one would claim counts for nodes nobody measured.
+// a partial one would claim counts for nodes nobody measured. A count drop on a run that
+// exited 0 is the one red it accepts: lowering the number is how deleting tests passes.
 function recordBaselineFrom(projectPath, testsNode) {
   const runs = testsNode.runs || [];
   const refuse = (reason) => ({ recorded: false, reason, updates: [] });
 
   if (runs.length === 0) return refuse('nenhum nó de teste executou');
 
-  const notGreen = runs.filter((r) => r.status !== 'pass');
+  const notGreen = runs.filter((r) => r.status !== 'pass' && !r.countDrop);
   if (notGreen.length > 0) {
     const named = notGreen.map((r) => `${r.id} (${r.status}${r.reason ? `: ${r.reason}` : ''})`).join('; ');
     return refuse(
@@ -609,7 +625,7 @@ async function runValidatorsNode({ projectPath, featureName, _runValidation }) {
   try {
     console.log = () => {};
     console.warn = () => {};
-    validationResult = await _runValidation(projectPath, featureName, { mode: 'full' });
+    validationResult = await _runValidation(projectPath, featureName);
   } finally {
     console.log = originalLog;
     console.warn = originalWarn;
@@ -658,21 +674,20 @@ function appendValidatorsFeedback(feedback, validatorsNode) {
   }
 }
 
-async function runE2eNode({ projectPath, featureName, skipE2e, freshE2e, buildNode, gate, _runE2eCheck }) {
-  if (buildNode.status === 'fail') {
-    return {
-      node: {
-        status: 'skip',
-        command: null,
-        durationMs: 0,
-        reason: 'build failed — the stack could not come up anyway',
-        output: '',
-      },
-      stackEnv: null,
-    };
-  }
+const skippedE2e = (reason) => ({ node: { status: 'skip', command: null, durationMs: 0, reason, output: '' }, stackEnv: null });
+
+async function runE2eNode({
+  projectPath, featureName, skipE2e, freshE2e, buildNode, testsNode, hasStackNodes, gate, _runE2eCheck, _e2eApplicability,
+}) {
+  if (buildNode.status === 'fail') return skippedE2e('build failed — the stack could not come up anyway');
+  if (testsNode?.status === 'fail') return skippedE2e('tests failed — the e2e does not run over a red suite');
 
   const config = readConfig(projectPath);
+  // An `e2e: true` test node is the backend's proof against the stack: it always brings the stack up.
+  if (!skipE2e && !hasStackNodes) {
+    const applicability = _e2eApplicability(projectPath, featureName, config);
+    if (!applicability.applicable) return skippedE2e(applicability.reason);
+  }
   const gitCommonDir = resolveGitCommonDir(projectPath);
   // Without the port block, two worktrees verifying at once collide on host ports.
   const env = buildComposeEnv({ cwd: projectPath, config, featureName, gitCommonDir });
@@ -698,7 +713,7 @@ async function runE2eNode({ projectPath, featureName, skipE2e, freshE2e, buildNo
       command: result.command ?? null,
       durationMs,
       reason: result.reason ?? null,
-      output: result.output || '',
+      output: tailLines(result.output || '', OUTPUT_TAIL_LINES),
       count: Number.isInteger(result.count) ? result.count : null,
       warnings: Array.isArray(result.warnings) ? result.warnings : [],
     },

package/src/utils/agents-installer.js

@@ -2,6 +2,7 @@ import { readFileSync, existsSync, readdirSync } from 'node:fs';
 import { join } from 'path';
 import { shouldInstall } from '../lib/stack-filter.js';
 import { realEffects } from '../lib/installers/effects.js';
+import { REVIEW_ROLES, VERDICT_TOKEN, REVIEWED_SHA_TOKEN, VERDICTS } from '../lib/review-reports.js';
 
 export const DEFAULT_AGENT_TOOLS = 'Read, Write, Edit, Bash, Glob, Grep';
 
@@ -283,7 +284,7 @@ export const DISPATCH_CONTRACT = [
     'ANTES de encerrar — é o retorno autoritativo, não a sua mensagem final. `SendMessage` não é substituto do relatório e não deve ser chamado.',
   '2. ESTADO: NÃO toque em `plan.md`, `checks.json`, `feature.json`, `state.json` nem no board de sessão — todo estado é gravado exclusivamente pelo orquestrador.',
   '3. TESTE: a prova é do orquestrador (`morph-spec verify {feature}`, depois do seu retorno), não sua. Escreva os testes pelo orçamento: ' +
-    'um por pós-condição, um de regressão por bug, variantes numa tabela (`[Theory]`/`it.each`). NÃO rode teste a cada marco nem faça ciclo red→green: ' +
+    'um por Cn `prova: teste`, variantes em tabela (`[Theory]`/`it.each`); `leitura` sem teste. NÃO rode teste a cada marco nem faça ciclo red→green: ' +
     'escreva código e testes, compile, e rode SÓ o filtro dos seus testes UMA vez, em primeiro plano, antes do relatório; se falhar, corrija e rode só os que falharam. ' +
     'Grave a saída em arquivo (`… > .morph/logs/test-last.log 2>&1`, sem nada depois) e leia o arquivo — um pipe troca o exit do teste pelo do último comando. ' +
     'Em batch paralelo SEM isolamento, só compile. Com `isolation: "worktree"`, o mesmo vale no seu worktree, e o último ato é o commit na branch dele.',
@@ -300,6 +301,8 @@ export const DISPATCH_CONTRACT = [
     '`git checkout --`). A prova de que o teste morde é do verificador (Gate 3).',
   '9. ESCRITA: código e teste do projeto só por Write/Edit, nunca pelo Bash — heredoc, redirecionamento, `sed -i` ou script python/node que grava (`cat > X.cs <<EOF`, `sed -i … X.cs`): ' +
     'os guards de escrita só enxergam Write/Edit.',
+  '10. BLOQUEIO: decisão que não é sua (requisito contra o plano ou um ADR, escolha deixada ao humano) → `BLOQUEADO` na 1ª linha, ' +
+    'com a pergunta e as opções. Dificuldade técnica não é bloqueio.',
   '',
   'Formato do relatório (o `report-check` lê estas marcas):',
   '',
@@ -317,6 +320,25 @@ export const DISPATCH_CONTRACT = [
     'Problemas e como foram resolvidos vão em prosa depois.',
 ];
 
+export const REVIEW_REPORT_CONTRACT = [
+  '## Relatório do Gate 3',
+  '',
+  'Grave o relatório que o dispatch nomeia ANTES de encerrar — o arquivo é o retorno, não a mensagem final. ' +
+    'Se ele já existir quando você começar, é resíduo de outra rodada: não o leia antes de escrever o seu (ancoragem no veredito alheio), ' +
+    'e não leia os relatórios dos outros papéis.',
+  '',
+  `Primeira linha \`${VERDICT_TOKEN} ${VERDICTS.join('|')}\`, depois \`${REVIEWED_SHA_TOKEN} {sha}\`, ` +
+    'tabela `## Bloqueadores` (`| id | tipo | onde | evidência |`; vazia = `Nenhum.`) e `## Notas`. ' +
+    'Bloqueador só com evidência e tipo; o resto é nota, e nota nunca pede rodada nova.',
+  '',
+  'Numa confirmação (o orquestrador te retoma depois da correção, com o `sha` novo) acrescente ao fim uma seção nova com ' +
+    `\`${VERDICT_TOKEN}\` e \`${REVIEWED_SHA_TOKEN} {sha novo}\`: se você abriu bloqueadores, julgue só eles; ` +
+    'se não abriu, julgue só o delta `{sha anterior}..{sha novo}` — o que a correção abriu. ' +
+    'O relatório é append-only: vale o último veredito e, na `## Checks`, a última linha de cada Cn.',
+  '',
+  'Um comando por chamada de Bash, sem encadear (`;`, `&&`, pipe): o composto é negado e custa a rodada.',
+];
+
 function buildBody(agent, maxTurns) {
   const lines = [
     `# ${agent.title ?? agent.id}`,
@@ -374,6 +396,7 @@ function buildBody(agent, maxTurns) {
         'O entregável é o arquivo de relatório que o dispatch nomeia; sem arquivo nomeado, é a sua mensagem final (no scout, o mapa).',
       '',
     );
+    if (Object.hasOwn(REVIEW_ROLES, agent.id)) lines.push(...REVIEW_REPORT_CONTRACT, '');
   }
 
   lines.push(

package/framework/hooks/git/commit-msg/conventional-commits.sh

@@ -1,33 +0,0 @@
-#!/usr/bin/env bash
-# Scope: universal | Validates commit message format (Conventional Commits)
-# MORPH-SPEC Commit Message Hook
-# Enforces Conventional Commits specification
-
-COMMIT_MSG_FILE="$1"
-COMMIT_MSG=$(cat "$COMMIT_MSG_FILE")
-
-# Conventional Commits pattern: type(scope): description
-# Types: feat, fix, docs, style, refactor, perf, test, chore, build, ci, revert
-PATTERN="^(feat|fix|docs|style|refactor|perf|test|chore|build|ci|revert)(\(.+\))?: .{1,100}"
-
-if ! echo "$COMMIT_MSG" | grep -qE "$PATTERN"; then
-  echo "❌ Invalid commit message format!"
-  echo ""
-  echo "Required format: <type>(<scope>): <description>"
-  echo ""
-  echo "Types: feat, fix, docs, style, refactor, perf, test, chore, build, ci, revert"
-  echo ""
-  echo "Examples:"
-  echo "  feat(auth): add JWT refresh token rotation"
-  echo "  fix(api): resolve null reference in UserService"
-  echo "  docs(readme): update installation instructions"
-  echo ""
-  echo "Your message:"
-  echo "  $COMMIT_MSG"
-  echo ""
-  echo "Override with: git commit --no-verify"
-  exit 1
-fi
-
-echo "✅ Commit message format valid"
-exit 0

package/framework/hooks/git/pre-commit/agents.sh

@@ -1,25 +0,0 @@
-#!/bin/bash
-# Scope: universal | Validates agents.json Schema
-# MORPH-SPEC Pre-Commit Hook: Agent Configuration Validation
-# Uses validate-agents.js to check agents.json
-
-echo "🤖 Validating agent configuration..."
-
-# Check if agents.json is being modified
-if git diff --cached --name-only | grep -q 'agents\.json$'; then
-  echo "Detected changes to agents.json"
-
-  # Run validator
-  if ! morph-spec validate-agents-skills; then
-    echo ""
-    echo "❌ COMMIT BLOCKED: agents.json validation failed"
-    echo "   Fix errors above before committing"
-    exit 1
-  fi
-
-  echo "✓ agents.json is valid"
-else
-  echo "✓ No changes to agents.json"
-fi
-
-exit 0

package/framework/hooks/git/pre-commit/orchestrator.sh

@@ -1,64 +0,0 @@
-#!/usr/bin/env bash
-# Scope: universal | Orchestrates framework + stack-specific pre-commit hooks
-# MORPH-SPEC Master Pre-Commit Hook
-# Runs universal framework hooks + stack-specific hooks in sequence
-
-echo "╔════════════════════════════════════════════════╗"
-echo "║     MORPH-SPEC PRE-COMMIT VALIDATION           ║"
-echo "╚════════════════════════════════════════════════╝"
-echo ""
-
-FRAMEWORK_HOOKS_DIR="$(dirname "$0")"
-STACK_HOOKS_DIR=".morph/hooks/pre-commit"
-
-HAS_FAILURES=false
-
-# Run framework hooks (universal - all stacks)
-echo "📦 Running framework hooks (universal)..."
-for hook in "$FRAMEWORK_HOOKS_DIR"/*.sh; do
-  # Skip orchestrator itself
-  if [[ "$hook" == */orchestrator.sh ]]; then
-    continue
-  fi
-
-  if [[ -f "$hook" ]]; then
-    hook_name=$(basename "$hook")
-    echo "─────────────────────────────────────────────────"
-    if ! bash "$hook"; then
-      HAS_FAILURES=true
-      echo "❌ Framework hook failed: $hook_name"
-    fi
-    echo ""
-  fi
-done
-
-# Run stack-specific hooks (if exist)
-if [[ -d "$STACK_HOOKS_DIR" ]]; then
-  echo "🎯 Running stack-specific hooks..."
-  for hook in "$STACK_HOOKS_DIR"/*.sh; do
-    if [[ -f "$hook" ]]; then
-      hook_name=$(basename "$hook")
-      echo "─────────────────────────────────────────────────"
-      if ! bash "$hook"; then
-        HAS_FAILURES=true
-        echo "❌ Stack hook failed: $hook_name"
-      fi
-      echo ""
-    fi
-  done
-else
-  echo "ℹ️  No stack-specific hooks found (optional)"
-  echo ""
-fi
-
-echo "═════════════════════════════════════════════════"
-
-if [[ "$HAS_FAILURES" == "true" ]]; then
-  echo "❌ PRE-COMMIT VALIDATION FAILED"
-  echo "   Fix errors above before committing"
-  echo "   Or use: git commit --no-verify to skip"
-  exit 1
-fi
-
-echo "✅ ALL PRE-COMMIT VALIDATIONS PASSED"
-exit 0

package/framework/hooks/git/pre-push/run-tests.sh

@@ -1,44 +0,0 @@
-#!/usr/bin/env bash
-# Scope: universal | Runs test suite before push
-# MORPH-SPEC Pre-Push Hook
-# Ensures all tests pass before pushing to remote
-
-echo "🧪 Running test suite before push..."
-echo ""
-
-# Detect project type and run appropriate tests
-if [[ -f *.csproj ]] || find . -maxdepth 2 -name "*.csproj" 2>/dev/null | grep -q .; then
-  # .NET project detected
-  echo "📦 Detected .NET project"
-
-  if ! dotnet test --verbosity minimal --no-build --no-restore 2>/dev/null; then
-    echo ""
-    echo "❌ .NET tests failed!"
-    echo ""
-    echo "Fix failing tests before pushing."
-    echo "Override with: git push --no-verify"
-    exit 1
-  fi
-
-elif [[ -f package.json ]]; then
-  # Node.js project detected
-  echo "📦 Detected Node.js project"
-
-  if ! npm test 2>/dev/null; then
-    echo ""
-    echo "❌ Node.js tests failed!"
-    echo ""
-    echo "Fix failing tests before pushing."
-    echo "Override with: git push --no-verify"
-    exit 1
-  fi
-
-else
-  echo "⚠️  No recognized test framework found"
-  echo "   Skipping test execution"
-  exit 0
-fi
-
-echo ""
-echo "✅ All tests passed - safe to push"
-exit 0