@polymorphism-tech/morph-spec 8.47.0 → 9.1.0

package/src/commands/state/list.js

@@ -4,40 +4,16 @@ import { basename, join } from 'path';
 import { derivePhase } from '../../core/state/state-manager.js';
 import { gateOrderViolations } from '../../core/state/gate-order.js';
 import { missingIdentity } from '../../core/state/feature-identity.js';
-import { derivePhaseFrom } from '../../../framework/hooks/shared/state-reader.js';
+import { derivePhaseFrom, fileSetArtifactProbe } from '../../../framework/hooks/shared/state-reader.js';
 import { isGitRepo } from '../project/worktree.js';
 import { morphBranches, currentBranch, branchView } from '../../lib/worktree/feature-truth.js';
 import { buildPrIndex } from '../../lib/git/pr-index.js';
 import { pendingPrFeatures, prForFeature } from '../../lib/git/pending-prs.js';
 
-/**
- * `morph-spec list [--all] [--json] [--no-branch]` — the feature audit board.
- *
- * One row per feature: slug × workType × status × phase × gates (G1/G2/G3) ×
- * description, plus a flags column for anomalies (missing description, gate
- * order, dangling worktree pointer). Complements `delete`: see what's dead
- * before removing it. Replaces the ad-hoc "loop over every feature.json in
- * python" audit.
- *
- * Read-only by construction — reads feature.json straight off disk (never
- * `loadState`, which mutates), so listing can never resurrect or prune state.
- * Always exits 0 (fail-open — an empty board is an answer).
- *
- * WORKTREE TRUTH: `create --worktree` writes a COMPLETE feature.json into the
- * primary root, then the branch-committed copy (`morph/{f}`) becomes the
- * truth and the root's copy never changes again. By default this command
- * reads that branch when it disagrees with the disk — same mechanism fleet
- * already uses (`branchToReadFrom`/`branchView`, moved to feature-truth.js so
- * both consumers share the one place this condition lives). `--no-branch`
- * turns that off for a faster, disk-only read.
- *
- * NOT AN OBJECTIVE: this command only enumerates what exists IN THIS TREE.
- * A feature that lives solely on a branch with no local `.morph/features/`
- * copy in any tree never appears here — aggregating across trees is
- * `morph-spec fleet`'s job, not this one's.
- */
+// Read-only: feature.json straight off disk, never `loadState` (which mutates). By default the
+// branch `morph/{f}` wins over a stale root copy; `--no-branch` reads only the disk.
 
-const G = ['proposal', 'uiux', 'plan', 'review'];
+const G = ['plan', 'uiux', 'review'];
 
 function readFeaturesIn(baseDir, subdir, location) {
   const root = join(baseDir, '.morph', subdir);
@@ -59,34 +35,23 @@ function readFeaturesIn(baseDir, subdir, location) {
   return rows;
 }
 
-/** The feature's `worktree` pointer, normalized with a computed `exists`. */
 function readWorktreePointer(fj) {
   const w = fj?.worktree;
   if (!w?.path) return null;
   return { path: w.path, branch: w.branch || null, exists: existsSync(w.path) };
 }
 
-/**
- * Build a row's flags/gates/identity shape from a `feature.json` object, given
- * an already-resolved phase and provenance. Shared by the disk read
- * (`buildRow`) and the branch read (`resolveBranchTruth`) so the two never
- * drift on what counts as an anomaly.
- */
+// Shared by the disk and branch reads so the two never drift on what counts as an anomaly.
 function shapeRow(name, fj, location, phase, { corruptDisk = false, worktree = null, source = 'disk', branch = null } = {}) {
   const gates = {};
   for (const g of G) gates[g] = fj.approvalGates?.[g]?.approved === true;
 
-  // Gate 3 approved WITHOUT the independent evaluator (`approve --self-assessed`).
-  // A recorded degradation is only worth recording if it is visible — this is
-  // the surface that makes it so (D2).
+  // Review approved via `--self-assessed`: a recorded degradation is only worth it if visible.
   const selfAssessed = fj.approvalGates?.review?.selfAssessed === true;
 
   const flags = [];
   if (corruptDisk) flags.push('corrupt');
   if (selfAssessed) flags.push('self-assessed-g3');
-  // Identity + gate-order anomalies come from the shared rules
-  // (core/state/feature-identity.js, core/state/gate-order.js) — same source
-  // doctor reports from.
   for (const field of missingIdentity(fj)) flags.push(`missing-${field}`);
   for (const v of gateOrderViolations(fj.approvalGates)) flags.push(`gate-order:${v.gate}`);
   if (worktree && !worktree.exists) flags.push('worktree-missing');
@@ -104,10 +69,7 @@ function shapeRow(name, fj, location, phase, { corruptDisk = false, worktree = n
     location,
     createdAt: fj.createdAt || null,
     updatedAt: fj.updatedAt || null,
-    // Provenance — added for worktree-truth awareness. `worktree` is always
-    // read from the LOCAL disk copy (root-owned bookkeeping, stripped from
-    // branch-committed copies at birth) regardless of where `source` reads
-    // status/phase/gates from.
+    // `worktree` always comes from the local disk copy, whatever `source` reads the rest from.
     source,
     branch,
     worktree,
@@ -124,14 +86,7 @@ function buildRow(name, fj, fdir, location) {
   });
 }
 
-/**
- * Refresh active rows from the branch that owns their truth, when the disk
- * copy in THIS tree is not that owner. Never throws — a git hiccup or a
- * corrupt blob just leaves the disk-read row in place.
- *
- * @param {string} cwd
- * @param {object[]} rows - mutated in place (active rows only)
- */
+// Never throws: a git hiccup or a corrupt blob leaves the disk-read row in place.
 function resolveBranchTruth(cwd, rows) {
   if (!isGitRepo(cwd)) return;
   let head;
@@ -150,7 +105,7 @@ function resolveBranchTruth(cwd, rows) {
     if (head === featureBranch) continue; // cwd IS the checkout — disk is freshest, never go backwards
     const view = branchView(cwd, row.feature, featureBranch);
     if (!view?.fj) continue;
-    const phase = derivePhaseFrom(view.fj, (rel) => view.files.has(rel));
+    const phase = derivePhaseFrom(view.fj, fileSetArtifactProbe(view.files));
     rows[i] = shapeRow(row.feature, view.fj, row.location, phase, {
       corruptDisk: row.flags.includes('corrupt'),
       worktree: row.worktree, // root-owned — never trust the branch copy for this
@@ -160,15 +115,8 @@ function resolveBranchTruth(cwd, rows) {
   }
 }
 
-/**
- * Flag an active row whose feature ALSO has an archived copy in this tree —
- * the signature left behind when a feature is merged and archived on its
- * branch (or via GitHub) without `morph-spec finish` ever running here:
- * the untracked root skeleton from `create` survives `git pull` (it was
- * never tracked, so pull has nothing to remove) while `.morph/archive/{f}`
- * arrives for real. Flagging beats suppressing the row — a read-only board
- * that resurrects or prunes nothing must not silently hide the anomaly either.
- */
+// The untracked root skeleton survives a `git pull` that brings `.morph/archive/{f}`. Flagged,
+// never hidden: a read-only board must not silently suppress the anomaly.
 function flagArchivedElsewhere(cwd, rows) {
   for (const row of rows) {
     if (row.location !== 'active') continue;
@@ -178,13 +126,8 @@ function flagArchivedElsewhere(cwd, rows) {
   }
 }
 
-/**
- * A linha de uma feature que existe SÓ como PR aberto — sem pasta ativa nem
- * arquivada nesta árvore. É o estado que o `finish --pr` deixa: o scaffold do
- * root foi apagado pelo shed e o archive viaja no diff do PR, chegando na
- * default apenas no merge. Sem esta linha o trabalho fica sem dono no quadro,
- * e uma branch sem dono é candidata a poda.
- */
+// O estado que o `finish --pr` deixa: sem esta linha o trabalho fica sem dono no quadro, e
+// uma branch sem dono é candidata a poda.
 function pendingRow(p) {
   return {
     feature: p.feature,
@@ -193,7 +136,7 @@ function pendingRow(p) {
     workType: null,
     status: 'in_progress',
     phase: 'aguardando-merge',
-    gates: { proposal: false, uiux: false, plan: false, review: false },
+    gates: { plan: false, uiux: false, review: false },
     selfAssessed: false,
     flags: ['pr-pending'],
     location: 'pr-pending',
@@ -232,15 +175,8 @@ export function listCommand(options = {}) {
   // Commander's `--no-branch` sets options.branch = false; anything else (undefined/true) reads the branch.
   if (options.branch !== false) resolveBranchTruth(cwd, rows);
 
-  // Estado do PR — uma consulta ao `gh` por invocação, compartilhada pela
-  // coluna e pela síntese. `--no-branch` (o modo offline rápido) pula as duas.
-  //
-  // `prIndex` continua `null` quando a pergunta não pôde ser feita (sem `gh`,
-  // sem auth, remoto não-GitHub, ou `--no-branch`). É o mesmo sinal que
-  // `--json` já expõe como `pr: null` por linha — a tabela texto usa o mesmo
-  // fato para decidir se a coluna PR sequer aparece (achado #2): índice `null`
-  // degrada para o comportamento de antes, sem coluna e sem `-` que afirme
-  // ausência.
+  // Uma consulta ao `gh` por invocação. `prIndex` `null` = a pergunta não pôde ser feita: sem
+  // coluna PR, e sem `-` que afirme "sem PR" para o que é "não sabemos".
   let prIndex = null;
   if (options.branch !== false) {
     prIndex = buildPrIndex(cwd);
@@ -249,8 +185,7 @@ export function listCommand(options = {}) {
       row.pr = pr ? { number: pr.number, state: pr.state, url: pr.url, ageDays: null } : null;
     }
     const known = new Set(rows.map((r) => r.feature));
-    // `null` propaga desconhecido: nenhuma linha sintetizada, e nenhuma
-    // afirmação de que não há pendência.
+    // `null` propaga desconhecido: nenhuma linha sintetizada.
     for (const p of pendingPrFeatures(cwd, { index: prIndex }) || []) {
       if (!known.has(p.feature)) rows.push(pendingRow(p));
     }
@@ -271,17 +206,12 @@ export function listCommand(options = {}) {
   }
 
   const col = (s, w) => String(s ?? '-').padEnd(w);
-  // A coluna PR só aparece quando o índice foi construído com sucesso (achado
-  // #2) — um índice `null` não vira uma coluna cheia de `-`, que afirmaria
-  // "sem PR" para algo que na verdade é "não sabemos".
   const showPr = Boolean(prIndex);
-  // `pr-pending` é estado normal de trabalho em voo, não inconsistência —
-  // não deve marcar `⚠` nem contar no rodapé (achado #6). Continua em
-  // `flags` no `--json`: é metadado real, só não é anomalia.
+  // `pr-pending` é trabalho em voo, não anomalia: segue em `flags` no `--json`, sem `⚠`.
   const warnFlags = (r) => r.flags.filter((f) => f !== 'pr-pending');
   console.log(chalk.white.bold(
     col('FEATURE', 22) + col('TYPE', 9) + col('STATUS', 13) + col('PHASE', 17) + col('WHERE', 22) + (showPr ? col('PR', 12) : '')
-    + col('G1', 4) + col('G2', 4) + col('G3', 4) + col('', 3) + 'DESCRIPTION',
+    + col('G1', 4) + col('Gd', 4) + col('G3', 4) + col('', 3) + 'DESCRIPTION',
   ));
   for (const r of rows) {
     const flag = warnFlags(r).length ? chalk.yellow('⚠') : ' ';
@@ -292,7 +222,7 @@ export function listCommand(options = {}) {
     // padEnd counts the invisible color codes; pad the plain marks manually.
     console.log(
       col(r.feature, 22) + col(r.workType, 9) + col(r.status, 13) + col(r.phase, 17) + col(whereLabel(r), 22) + (showPr ? col(prCell(r.pr), 12) : '')
-      + mark(r.gates.proposal) + '   ' + mark(r.gates.plan) + '   ' + mark(r.gates.review) + '   '
+      + mark(r.gates.plan) + '   ' + mark(r.gates.uiux) + '   ' + mark(r.gates.review) + '   '
       + flag + ' ' + desc,
     );
   }
@@ -300,6 +230,6 @@ export function listCommand(options = {}) {
   if (flagged.length) {
     console.log(chalk.gray(`\n⚠ ${flagged.length} com inconsistência — rode 'morph-spec doctor' para detalhes.`));
   }
-  console.log(chalk.gray(`\nG1=proposal · G2=plan · G3=review${options.all || options.archived ? ' · inclui arquivadas' : ''}`));
+  console.log(chalk.gray(`\nG1=plan · Gd=uiux (design) · G3=review${options.all || options.archived ? ' · inclui arquivadas' : ''}`));
   process.exit(0);
 }