@polymorphism-tech/morph-spec 8.46.0 → 9.0.0

package/src/lib/validators/design-system/design-system-validator.js

@@ -1,237 +0,0 @@
-/**
- * Design System Validator
- *
- * Validates that CSS and Razor files only use design system tokens
- * instead of hardcoded colors, fonts, or spacing values.
- *
- * MORPH-SPEC 3.0 - Phase 3: Design System Enforcement
- */
-
-import { existsSync, readFileSync, readdirSync, statSync } from 'fs';
-import { join, extname } from 'path';
-import { parseColors, parseTypography, parseSpacing } from '../../generators/design-system-generator.js';
-import { detectDesignSystem } from '../../detectors/design-system-detector.js';
-
-/**
- * Validate design system compliance
- * @param {string} projectPath - Root path of the project
- * @param {string} featureName - Feature name (optional)
- * @param {Object} options - Validation options
- * @returns {Object} { errors, warnings, issues }
- */
-export async function validateDesignSystem(projectPath, featureName = null, options = {}) {
-  const result = {
-    errors: 0,
-    warnings: 0,
-    issues: []
-  };
-
-  // Detect design system
-  const dsDetection = detectDesignSystem(projectPath, featureName);
-
-  if (!dsDetection.hasDesignSystem) {
-    result.errors++;
-    result.issues.push({
-      level: 'error',
-      message: 'No design system found',
-      solution: 'Create a design system at .morph/context/design-system.md or run design system generator'
-    });
-    return result;
-  }
-
-  // Parse design system
-  let designSystem;
-  try {
-    const markdown = readFileSync(dsDetection.path, 'utf8');
-    designSystem = {
-      colors: parseColors(markdown),
-      typography: parseTypography(markdown),
-      spacing: parseSpacing(markdown)
-    };
-  } catch (err) {
-    result.errors++;
-    result.issues.push({
-      level: 'error',
-      message: `Failed to parse design system: ${err.message}`,
-      file: dsDetection.path
-    });
-    return result;
-  }
-
-  // Build allowed color set — iterate all color categories
-  const allowedColors = new Set();
-  const colorCategories = ['primary', 'accent', 'secondary', 'neutral', 'semantic', 'surface', 'text', 'other'];
-  for (const category of colorCategories) {
-    const catColors = designSystem.colors[category] || {};
-    Object.values(catColors).forEach(val => {
-      // Only add hex-like values (skip rgb tuples, rgba, var() references, etc.)
-      if (typeof val === 'string' && val.startsWith('#')) {
-        allowedColors.add(val.toLowerCase());
-      }
-    });
-  }
-
-  // Common system colors (allowed)
-  const systemColors = new Set([
-    '#ffffff', '#fff', '#000000', '#000', 'transparent', 'inherit', 'currentcolor'
-  ]);
-
-  // Scan CSS files
-  const cssFiles = findFiles(projectPath, ['.css'], options.scanPaths || ['wwwroot/css', 'styles']);
-  for (const cssFile of cssFiles) {
-    const cssResult = validateCSSFile(cssFile, allowedColors, systemColors);
-    result.warnings += cssResult.warnings;
-    result.issues.push(...cssResult.issues);
-  }
-
-  // Scan Razor files
-  const razorFiles = findFiles(projectPath, ['.razor'], options.scanPaths || ['Components', 'Pages']);
-  for (const razorFile of razorFiles) {
-    const razorResult = validateRazorFile(razorFile, allowedColors, systemColors);
-    result.warnings += razorResult.warnings;
-    result.issues.push(...razorResult.issues);
-  }
-
-  return result;
-}
-
-/**
- * Find files with specific extensions in directories
- */
-function findFiles(projectPath, extensions, scanPaths) {
-  const files = [];
-
-  for (const scanPath of scanPaths) {
-    const fullPath = join(projectPath, scanPath);
-    if (!existsSync(fullPath)) continue;
-
-    try {
-      walkDirectory(fullPath, extensions, files);
-    } catch (err) {
-      // Ignore permission errors
-    }
-  }
-
-  return files;
-}
-
-/**
- * Recursively walk directory
- */
-function walkDirectory(dir, extensions, files) {
-  const items = readdirSync(dir);
-
-  for (const item of items) {
-    const fullPath = join(dir, item);
-    const stat = statSync(fullPath);
-
-    if (stat.isDirectory()) {
-      walkDirectory(fullPath, extensions, files);
-    } else if (stat.isFile()) {
-      const ext = extname(fullPath);
-      if (extensions.includes(ext)) {
-        files.push(fullPath);
-      }
-    }
-  }
-}
-
-/**
- * Validate CSS file for hardcoded colors
- */
-function validateCSSFile(filePath, allowedColors, systemColors) {
-  const result = {
-    warnings: 0,
-    issues: []
-  };
-
-  try {
-    const content = readFileSync(filePath, 'utf8');
-
-    // Match hex colors: #RGB or #RRGGBB
-    const hexRegex = /#([0-9A-Fa-f]{3}|[0-9A-Fa-f]{6})\b/g;
-
-    let match;
-    let lineNumber = 1;
-    let lastIndex = 0;
-
-    while ((match = hexRegex.exec(content)) !== null) {
-      const hex = match[0].toLowerCase();
-
-      // Count line number
-      const upToMatch = content.substring(lastIndex, match.index);
-      lineNumber += (upToMatch.match(/\n/g) || []).length;
-      lastIndex = match.index;
-
-      // Skip if in allowed or system colors
-      if (allowedColors.has(hex) || systemColors.has(hex)) {
-        continue;
-      }
-
-      result.warnings++;
-      result.issues.push({
-        level: 'warning',
-        message: `Hardcoded color ${hex} not in design system palette`,
-        file: filePath,
-        line: lineNumber,
-        solution: 'Use CSS variable like var(--color-primary-500) instead'
-      });
-    }
-  } catch (err) {
-    // Ignore read errors
-  }
-
-  return result;
-}
-
-/**
- * Validate Razor file for inline styles with hardcoded colors
- */
-function validateRazorFile(filePath, allowedColors, systemColors) {
-  const result = {
-    warnings: 0,
-    issues: []
-  };
-
-  try {
-    const content = readFileSync(filePath, 'utf8');
-
-    // Match style="" attributes with hex colors
-    const styleRegex = /style\s*=\s*"([^"]*)"/gi;
-
-    let match;
-    while ((match = styleRegex.exec(content)) !== null) {
-      const styleContent = match[1];
-
-      // Find hex colors in style attribute
-      const hexRegex = /#([0-9A-Fa-f]{3}|[0-9A-Fa-f]{6})\b/g;
-      let hexMatch;
-
-      while ((hexMatch = hexRegex.exec(styleContent)) !== null) {
-        const hex = hexMatch[0].toLowerCase();
-
-        // Skip if in allowed or system colors
-        if (allowedColors.has(hex) || systemColors.has(hex)) {
-          continue;
-        }
-
-        // Count line number
-        const upToMatch = content.substring(0, match.index);
-        const lineNumber = (upToMatch.match(/\n/g) || []).length + 1;
-
-        result.warnings++;
-        result.issues.push({
-          level: 'warning',
-          message: `Inline style with hardcoded color ${hex} not in design system`,
-          file: filePath,
-          line: lineNumber,
-          solution: 'Use CSS class with design system variables or component props instead of inline styles'
-        });
-      }
-    }
-  } catch (err) {
-    // Ignore read errors
-  }
-
-  return result;
-}

package/src/lib/validators/design-system/index.js

@@ -1,7 +0,0 @@
-/**
- * Design System Validators
- *
- * Design system compliance validation.
- */
-
-export * from './design-system-validator.js';

package/src/lib/validators/score-aggregator.js

@@ -1,244 +0,0 @@
-/**
- * MORPH-SPEC Score Aggregator
- *
- * Converts pass/fail validator results into weighted scores using rubric definitions.
- * Produces prioritized feedback for the retry loop.
- *
- * @module score-aggregator
- */
-
-import { existsSync, readFileSync } from 'fs';
-import { join, dirname } from 'path';
-import { fileURLToPath } from 'url';
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-
-/** Fallback rubric when none is configured or found. */
-const FALLBACK_RUBRIC = {
-  id: 'fallback',
-  version: '1.0.0',
-  categories: {
-    general: {
-      weight: 1.0,
-      validators: [],
-      description: 'All validators (fallback — no rubric configured)'
-    }
-  },
-  thresholds: { approve: 9.0, retry: 6.0 }
-};
-
-/**
- * Load a rubric by ID from the project or framework directory.
- *
- * Search order:
- *   1. .morph/framework/rubrics/{rubricId}.json  (installed in project)
- *   2. npm package path  (node_modules/@polymorphism-tech/morph-spec/framework/rubrics/)
- *   3. Local dev path  (framework/rubrics/ relative to this module)
- *
- * @param {string} projectPath - Project root
- * @param {string} rubricId - Rubric identifier (e.g. 'default', 'frontend', 'backend')
- * @returns {Object} Parsed rubric object
- */
-export function loadRubric(projectPath, rubricId = 'default') {
-  const filename = `${rubricId}.json`;
-
-  const candidates = [
-    join(projectPath, '.morph', 'framework', 'rubrics', filename),
-    join(projectPath, 'node_modules', '@polymorphism-tech', 'morph-spec', 'framework', 'rubrics', filename),
-    join(__dirname, '..', '..', '..', 'framework', 'rubrics', filename)
-  ];
-
-  for (const candidate of candidates) {
-    if (existsSync(candidate)) {
-      try {
-        return JSON.parse(readFileSync(candidate, 'utf8'));
-      } catch {
-        // Corrupted file — try next candidate
-      }
-    }
-  }
-
-  return FALLBACK_RUBRIC;
-}
-
-/**
- * Score a single validator result.
- *
- * Scoring formula:
- *   - Base score: 10
- *   - Each error:   -2  (min 0)
- *   - Each warning: -1  (min 0)
- *
- * @param {Object} validatorResult - { passed: boolean, issues?: Array, error?: string }
- * @returns {number} Score 0–10
- */
-export function scoreValidator(validatorResult) {
-  if (!validatorResult) return 10; // Validator didn't run — assume clean
-
-  // Validator threw an error — can't assess
-  if (validatorResult.error) return 5;
-
-  const errors = (validatorResult.issues || []).filter(i => i.level === 'error').length;
-  const warnings = (validatorResult.issues || []).filter(i => i.level === 'warning').length;
-
-  return Math.max(0, 10 - (errors * 2) - (warnings * 1));
-}
-
-/**
- * Build a reverse map: validatorId → category name.
- * Validators not mapped to any category go into '_unmapped'.
- *
- * @param {Object} rubric
- * @returns {Map<string, string>}
- */
-function buildValidatorCategoryMap(rubric) {
-  const map = new Map();
-  for (const [categoryName, category] of Object.entries(rubric.categories)) {
-    for (const validatorId of category.validators || []) {
-      map.set(validatorId, categoryName);
-    }
-  }
-  return map;
-}
-
-/**
- * Aggregate validator results into weighted scores using a rubric.
- *
- * @param {Object} validationResult - From validation-runner.js: { passed, errors, warnings, issues, results }
- * @param {Object} rubric - Loaded rubric object
- * @param {Object} [configOverrides] - Optional threshold overrides from config.json
- * @param {number} [configOverrides.approve] - Override approve threshold
- * @param {number} [configOverrides.retry] - Override retry threshold
- * @returns {{
- *   score: number,
- *   action: 'approve' | 'retry' | 'escalate',
- *   breakdown: Object,
- *   priorityFixes: Array<{ category: string, score: number, weight: number, deficit: number, issues: Array }>
- * }}
- */
-export function aggregateScores(validationResult, rubric, configOverrides = {}) {
-  const results = validationResult.results || {};
-  const validatorCategoryMap = buildValidatorCategoryMap(rubric);
-
-  // Collect scores per category
-  const breakdown = {};
-  const unmappedScores = [];
-
-  for (const [categoryName, category] of Object.entries(rubric.categories)) {
-    const mappedValidators = (category.validators || []).filter(v => results[v] !== undefined);
-    const scores = mappedValidators.map(v => scoreValidator(results[v]));
-
-    breakdown[categoryName] = {
-      score: scores.length > 0 ? scores.reduce((a, b) => a + b, 0) / scores.length : 10,
-      weight: category.weight,
-      validators: mappedValidators,
-      issues: mappedValidators.flatMap(v => (results[v]?.issues || []))
-    };
-  }
-
-  // Handle validators not mapped to any rubric category
-  for (const [validatorId, result] of Object.entries(results)) {
-    if (!validatorCategoryMap.has(validatorId)) {
-      unmappedScores.push(scoreValidator(result));
-    }
-  }
-
-  // Handle unmapped validators
-  if (unmappedScores.length > 0) {
-    const unmappedIds = Object.keys(results).filter(id => !validatorCategoryMap.has(id));
-    if (Object.keys(breakdown).length === 0) {
-      // No categories at all — put everything in 'general'
-      breakdown.general = {
-        score: unmappedScores.reduce((a, b) => a + b, 0) / unmappedScores.length,
-        weight: 1.0,
-        validators: unmappedIds,
-        issues: unmappedIds.flatMap(id => results[id]?.issues || [])
-      };
-    } else {
-      // Categories exist but some validators aren't mapped — add as low-weight 'other'
-      const unmappedAvg = unmappedScores.reduce((a, b) => a + b, 0) / unmappedScores.length;
-      breakdown._unmapped = {
-        score: unmappedAvg,
-        weight: 0.05,
-        validators: unmappedIds,
-        issues: unmappedIds.flatMap(id => results[id]?.issues || [])
-      };
-    }
-  }
-
-  // Calculate weighted final score
-  const totalWeight = Object.values(breakdown).reduce((sum, cat) => sum + cat.weight, 0);
-  const weightedScore = totalWeight > 0
-    ? Object.values(breakdown).reduce((sum, cat) => sum + (cat.score * cat.weight), 0) / totalWeight
-    : 10;
-
-  // Round to 1 decimal
-  const score = Math.round(weightedScore * 10) / 10;
-
-  // Determine action
-  const approveThreshold = configOverrides.approve ?? rubric.thresholds?.approve ?? 9.0;
-  const retryThreshold = configOverrides.retry ?? rubric.thresholds?.retry ?? 6.0;
-
-  let action;
-  if (score >= approveThreshold) {
-    action = 'approve';
-  } else if (score >= retryThreshold) {
-    action = 'retry';
-  } else {
-    action = 'escalate';
-  }
-
-  // Build priority fixes — sorted by impact (weight * deficit from 10)
-  const priorityFixes = Object.entries(breakdown)
-    .filter(([, cat]) => cat.issues.length > 0)
-    .map(([categoryName, cat]) => ({
-      category: categoryName,
-      score: Math.round(cat.score * 10) / 10,
-      weight: cat.weight,
-      deficit: Math.round((10 - cat.score) * cat.weight * 10) / 10,
-      issues: cat.issues
-    }))
-    .sort((a, b) => b.deficit - a.deficit);
-
-  return { score, action, breakdown, priorityFixes, approveThreshold };
-}
-
-/**
- * Format score breakdown as a human-readable string for hook injection.
- *
- * @param {Object} scoreResult - From aggregateScores()
- * @param {number} [approveThreshold] - For display
- * @returns {string}
- */
-export function formatScoreBreakdown(scoreResult, approveThreshold = 9.0) {
-  const lines = [];
-
-  lines.push(`Score: ${scoreResult.score}/10 (threshold: ${approveThreshold})`);
-  lines.push('');
-
-  if (scoreResult.priorityFixes.length > 0) {
-    lines.push('Priority fixes (by impact):');
-    for (let i = 0; i < scoreResult.priorityFixes.length; i++) {
-      const fix = scoreResult.priorityFixes[i];
-      const topIssue = fix.issues[0];
-      const issueText = topIssue
-        ? `${topIssue.message}${topIssue.file ? ` (${topIssue.file}${topIssue.line ? ':' + topIssue.line : ''})` : ''}`
-        : 'Issues detected';
-      lines.push(`${i + 1}. [${fix.category}: ${fix.score}/10] ${issueText}`);
-      // Show additional issues count if more than 1
-      if (fix.issues.length > 1) {
-        lines.push(`   ... and ${fix.issues.length - 1} more issue(s) in this category`);
-      }
-    }
-    lines.push('');
-  }
-
-  lines.push('Score breakdown:');
-  for (const [category, data] of Object.entries(scoreResult.breakdown)) {
-    const pct = Math.round(data.weight * 100);
-    const indicator = data.score >= approveThreshold ? '\u2713' : data.score >= 6 ? '\u2193 needs work' : '\u2193\u2193 critical';
-    lines.push(`  ${category}: ${Math.round(data.score * 10) / 10}/10 (weight ${pct}%) ${indicator}`);
-  }
-
-  return lines.join('\n');
-}

package/src/lib/validators/ui/index.js

@@ -1,7 +0,0 @@
-/**
- * UI Validators
- *
- * UI contrast and accessibility validation.
- */
-
-export * from './ui-contrast-validator.js';