@polymorphism-tech/morph-spec 8.45.0 → 8.47.0

package/src/lib/validators/validation-runner.js

@@ -7,24 +7,14 @@
  * MORPH-SPEC 3.0 - Phase A: Active Validation Pipeline
  */
 
-import { existsSync, readFileSync } from 'fs';
-import { join } from 'path';
+import { existsSync } from 'fs';
 import chalk from 'chalk';
 import { getAbsoluteOutputPath, resolveContractsOutputType } from '../../core/paths/output-schema.js';
 import { getStackProfile } from '../stack/stack-profile.js';
-import { aggregateScores, loadRubric } from './score-aggregator.js';
 
-/**
- * Heavy validators skipped in 'light' mode (checkpoint-only).
- *
- * What light mode actually leaves behind is whatever the stack contributes that
- * is NOT in this set — in practice `contrast` and `nextjs-component`. There are
- * no `spec` or `content` validators; the switch in runSingleValidator has no
- * case for either, and the old comment here promised both.
- */
+// Skipped in 'light' mode (checkpoint-only); light keeps `nextjs-component`.
 const HEAVY_VALIDATORS = new Set([
-  'architecture', 'packages', 'contract-compliance',
-  'css', 'design-system', 'reuse', 'code-budget'
+  'packages', 'contract-compliance', 'reuse', 'code-budget'
 ]);
 
 /**
@@ -167,17 +157,12 @@ export async function runValidation(projectPath, featureName, options = {}) {
         result.issues.push(...issues);
 
         // A validator that skipped itself checked nothing: in `results` it would
-        // be scored as a clean 10 and dilute the ones that ran.
+        // read as a validator that ran clean.
         if (!validatorResult._skipReason) result.results[validatorId] = { passed: errors === 0, issues };
       }
     } catch (err) {
-      // A validator that throws is a FAILED validation, not a silent skip.
-      // This used to record `passed: false` in `results` and stop there —
-      // `result.errors` never moved, so `result.passed = errors === 0` stayed
-      // true and the run reported "✅ All validations passed". The only trace
-      // was a console line, and `verify` silences stdout. That is how a broken
-      // import (`css`) and a path bug (`packages` under a different cwd) went
-      // unnoticed: both threw, both read as clean.
+      // A validator that throws is a FAILED validation, not a silent skip:
+      // `verify` silences stdout, so a console line alone would read as clean.
       if (options.verbose) {
         console.log(chalk.yellow(`  ⚠ Validator '${validatorId}' failed: ${err.message}`));
       }
@@ -208,17 +193,6 @@ export async function runValidation(projectPath, featureName, options = {}) {
     ? `✅ All validations passed (${result.warnings} warnings)`
     : `❌ ${result.errors} error(s), ${result.warnings} warning(s)`;
 
-  // Score aggregation — layered on top of pass/fail
-  try {
-    const rubricId = readRubricConfig(projectPath);
-    const rubric = loadRubric(projectPath, rubricId);
-    const thresholdOverrides = readThresholdConfig(projectPath);
-    result.scores = aggregateScores(result, rubric, thresholdOverrides);
-  } catch {
-    // Score aggregation is non-blocking — if it fails, pass/fail still works
-    result.scores = null;
-  }
-
   return result;
 }
 
@@ -243,7 +217,7 @@ function detectValidators(projectPath = '.') {
  * seven validators only two returned all three keys. `packages` — one of the
  * two defaults for the `dotnet` stack — returned
  * `{status, totalFiles, filesWithIssues, results}` and had every NuGet
- * incompatibility it found thrown away, while `verify` reported 10/10.
+ * incompatibility it found thrown away, while `verify` reported green.
  *
  * Reading the nested `results` shape here keeps that contract in ONE place
  * instead of asking every validator to remember it.
@@ -257,7 +231,7 @@ export function normalizeValidatorResult(validatorId, raw) {
 
   // Issues can be top-level, or nested one level under `results` — either as
   // an array of `{issues}` (packages: one entry per .csproj) or an object of
-  // them (architecture: keyed by check name). The nested read is a FALLBACK,
+  // them keyed by check name. The nested read is a FALLBACK,
   // never additive: validators that expose both would otherwise report every
   // finding twice.
   const topLevel = Array.isArray(raw.issues) ? raw.issues : [];
@@ -299,38 +273,16 @@ export function normalizeValidatorResult(validatorId, raw) {
  */
 async function runSingleValidator(validatorId, projectPath, featureName, options) {
   switch (validatorId) {
-    case 'architecture': {
-      const { validateArchitecture } = await import('./architecture/architecture-validator.js');
-      return await validateArchitecture(projectPath, options);
-    }
-
     case 'packages': {
       const { validatePackages } = await import('./packages/package-validator.js');
       return await validatePackages(projectPath, options);
     }
 
-    case 'contrast': {
-      const { validateContrast } = await import('./ui/ui-contrast-validator.js');
-      return await validateContrast(projectPath, options);
-    }
-
-    case 'css': {
-      // The module exports `validateCssClasses`; this asked for `validateCss`,
-      // which is undefined — the call threw on every invocation.
-      const { validateCssClasses } = await import('./css/css-validator.js');
-      return await validateCssClasses(projectPath, options);
-    }
-
     case 'contract-compliance': {
       const { validateContracts } = await import('./contracts/contract-compliance-validator.js');
       return await validateContracts(projectPath, featureName, options);
     }
 
-    case 'design-system': {
-      const { validateDesignSystem } = await import('./design-system/design-system-validator.js');
-      return await validateDesignSystem(projectPath, featureName, options);
-    }
-
     case 'reuse': {
       const { validateReuse } = await import('./reuse/reuse-validator.js');
       return await validateReuse(projectPath, featureName, options);
@@ -414,35 +366,3 @@ export function formatValidationResults(result) {
 
   console.log('');
 }
-
-/**
- * Read rubric ID from project config.
- * @param {string} projectPath
- * @returns {string}
- */
-function readRubricConfig(projectPath) {
-  try {
-    const configPath = join(projectPath, '.morph', 'config', 'config.json');
-    if (!existsSync(configPath)) return 'default';
-    const config = JSON.parse(readFileSync(configPath, 'utf8'));
-    return config.validation?.rubric ?? 'default';
-  } catch {
-    return 'default';
-  }
-}
-
-/**
- * Read threshold overrides from project config.
- * @param {string} projectPath
- * @returns {Object} { approve?: number, retry?: number }
- */
-function readThresholdConfig(projectPath) {
-  try {
-    const configPath = join(projectPath, '.morph', 'config', 'config.json');
-    if (!existsSync(configPath)) return {};
-    const config = JSON.parse(readFileSync(configPath, 'utf8'));
-    return config.validation?.thresholds ?? {};
-  } catch {
-    return {};
-  }
-}

package/src/lib/validators/verify-runner.js

@@ -18,7 +18,6 @@
  *   - applyTaskScope()    from src/lib/tasks/test-scope.js (the task-scoped cut, #87)
  *   - runValidation()  from ./validation-runner.js
  *   - runE2eCheck()    from framework/hooks/shared/e2e-check.js
- *   - loadRubric() + aggregateScores() from ./score-aggregator.js
  *
  * @module verify-runner
  */
@@ -44,7 +43,6 @@ import {
   evalEmptyRunProblem, evalColdCacheWarning,
 } from '../tasks/eval-node.js';
 import { runValidation } from './validation-runner.js';
-import { loadRubric, aggregateScores } from './score-aggregator.js';
 import { checkOutputsTraceability } from './traceability-check.js';
 import { getAbsoluteOutputPath } from '../../core/paths/output-schema.js';
 import { createHeavyGate } from '../heavy/gate.js';
@@ -52,6 +50,9 @@ import { createHeavyGate } from '../heavy/gate.js';
 /** Default build timeout — dotnet cold build is slow; 30s (the Stop-hook default) is too short. */
 const DEFAULT_BUILD_TIMEOUT = 120_000;
 
+// Validator issues surfaced in `feedback`, errors first; the full list stays on the node.
+const VALIDATOR_FEEDBACK_LIMIT = 10;
+
 /** Number of trailing output lines kept for feedback/reporting. */
 const OUTPUT_TAIL_LINES = 20;
 
@@ -87,7 +88,6 @@ export class VerifyUsageError extends Error {
  * @param {string} featureName - Feature name
  * @param {string|null} [taskId] - Task ID for task-scoped verify, or null/undefined for feature scope
  * @param {Object} [options]
- * @param {string} [options.rubric] - Force a rubric id (highest precedence)
  * @param {number} [options.timeout] - Timeout in ms for the build AND tests nodes
  *   (default: 120000 for build; for tests, see resolveTestTimeout())
  * @param {boolean} [options.skipTests] - Skip the tests node
@@ -121,7 +121,6 @@ export async function runVerify(projectPath, featureName, taskId, options = {})
 
 async function runVerifyGated(projectPath, featureName, taskId, options, gate) {
   const {
-    rubric: rubricOverride,
     timeout = DEFAULT_BUILD_TIMEOUT,
     skipTests = false,
     skipBuild = false,
@@ -157,9 +156,9 @@ async function runVerifyGated(projectPath, featureName, taskId, options, gate) {
     );
   }
 
-  // The task is read ONCE: its group picks the rubric and the e2e
-  // applicability and, with its outputs, the test scope (#87). One reader of
-  // tasks.json for verify, so the three can never disagree about the task.
+  // The task is read ONCE: its group picks the e2e applicability and, with its
+  // outputs, the test scope. One reader of tasks.json for verify, so the two
+  // can never disagree about the task.
   const task = taskId ? readTask(projectPath, featureName, taskId) : null;
 
   // `--record-baseline` is judged in the same breath, and for the same reason:
@@ -253,8 +252,7 @@ async function runVerifyGated(projectPath, featureName, taskId, options, gate) {
   appendTestsFeedback(feedback, nodes.tests);
 
   // 3. validators — ALWAYS runs, even on a red build (free static feedback).
-  const rubricId = resolveRubricId({ task, rubricOverride, projectPath });
-  nodes.validators = await runValidatorsNode({ projectPath, featureName, rubricId, _runValidation });
+  nodes.validators = await runValidatorsNode({ projectPath, featureName, _runValidation });
   appendValidatorsFeedback(feedback, nodes.validators);
 
   // 4. e2e — the only node that runs the application. Like tests, it is not
@@ -298,7 +296,6 @@ async function runVerifyGated(projectPath, featureName, taskId, options, gate) {
     task: taskId || null,
     scope: taskId ? 'task' : 'feature',
     stack,
-    rubric: rubricId,
     status,
     nodes,
     feedback,
@@ -972,7 +969,7 @@ function recordBaselineFrom(projectPath, testsNode) {
 // Validators node
 // ============================================================================
 
-async function runValidatorsNode({ projectPath, featureName, rubricId, _runValidation }) {
+async function runValidatorsNode({ projectPath, featureName, _runValidation }) {
   const start = Date.now();
 
   // runValidation() prints chalk-formatted progress to stdout. verify emits
@@ -997,46 +994,40 @@ async function runValidatorsNode({ projectPath, featureName, rubricId, _runValid
   if (validationResult && validationResult._skipReason) {
     return {
       status: 'skip',
-      score: null,
-      action: null,
       ran: [],
       skipped,
       reason: validationResult._skipReason,
-      priorityFixes: [],
+      issues: [],
       durationMs,
     };
   }
 
-  const rubric = loadRubric(projectPath, rubricId);
-  const scoreResult = aggregateScores(validationResult, rubric);
-
   return {
     status: validationResult.passed === false ? 'fail' : 'pass',
-    score: scoreResult.score,
-    action: scoreResult.action,
     ran: Object.keys(validationResult.results || {}),
     skipped,
     reason: null,
-    priorityFixes: scoreResult.priorityFixes || [],
+    issues: validationResult.issues || [],
     durationMs,
   };
 }
 
 function appendValidatorsFeedback(feedback, validatorsNode) {
   // A validator that could not check (reuse without a graph) is invisible in a
-  // green score; when the whole node skipped, its own line already says why.
+  // green node; when the whole node skipped, its own line already says why.
   if (validatorsNode.status !== 'skip') {
     for (const s of validatorsNode.skipped || []) {
       if (s.unavailable) feedback.push(`[validators/${s.validator}] não rodou: ${s.reason}`);
     }
   }
-  for (const fix of validatorsNode.priorityFixes || []) {
-    const topIssue = fix.issues && fix.issues[0];
-    if (!topIssue) continue;
-    const location = topIssue.file
-      ? ` (${topIssue.file}${topIssue.line ? ':' + topIssue.line : ''})`
-      : '';
-    feedback.push(`[validators/${fix.category} ${fix.score}/10] ${topIssue.message}${location}`);
+  const issues = validatorsNode.issues || [];
+  const ordered = [
+    ...issues.filter((i) => i.level === 'error'),
+    ...issues.filter((i) => i.level !== 'error'),
+  ].slice(0, VALIDATOR_FEEDBACK_LIMIT);
+  for (const issue of ordered) {
+    const location = issue.file ? ` (${issue.file}${issue.line ? ':' + issue.line : ''})` : '';
+    feedback.push(`[validators/${issue.validator ?? 'unknown'}] ${issue.message}${location}`);
   }
 }
 
@@ -1105,42 +1096,12 @@ function appendE2eFeedback(feedback, e2eNode) {
   }
 }
 
-// ============================================================================
-// Rubric selection — flag > task group > config > default
-// ============================================================================
-
-function resolveRubricId({ projectPath, task, rubricOverride }) {
-  if (rubricOverride) return rubricOverride;
-
-  const mapped = mapGroupToRubric(task?.group);
-  if (mapped) return mapped;
-
-  const configRubric = readConfigRubric(projectPath);
-  if (configRubric) return configRubric;
-
-  return 'default';
-}
-
-/**
- * Map a task's `group` field to a rubric id.
- * backend|infra → 'backend', frontend → 'frontend', tests|docs|absent → null
- * (falls through to config/default).
- */
-function mapGroupToRubric(group) {
-  if (!group) return null;
-  const g = String(group).toLowerCase();
-  if (g === 'backend' || g === 'infra') return 'backend';
-  if (g === 'frontend') return 'frontend';
-  return null;
-}
-
 /**
  * The task as verify needs it, or null when tasks.json or the task is missing.
  *
- * The ONE reader of tasks.json for verify (#87): the group picks the rubric and
- * the e2e applicability, group + outputs pick the test scope, and the command
- * uses the null to refuse an unknown task id. Two readers is how a rubric and
- * a scope start disagreeing about the same task.
+ * The ONE reader of tasks.json for verify: the group picks the e2e
+ * applicability, group + outputs pick the test scope, and the command uses the
+ * null to refuse an unknown task id.
  *
  * @param {string} projectPath
  * @param {string} featureName
@@ -1163,17 +1124,6 @@ export function readTask(projectPath, featureName, taskId) {
   }
 }
 
-function readConfigRubric(projectPath) {
-  try {
-    const configPath = join(projectPath, '.morph', 'config', 'config.json');
-    if (!existsSync(configPath)) return null;
-    const config = JSON.parse(readFileSync(configPath, 'utf8'));
-    return config?.validation?.rubric ?? null;
-  } catch {
-    return null;
-  }
-}
-
 // ============================================================================
 // Shared helpers
 // ============================================================================

package/src/scripts/setup-infra.js

@@ -13,7 +13,7 @@
 import { join, dirname, resolve } from 'path';
 import { fileURLToPath } from 'url';
 import { execSync } from 'child_process';
-import { readFileSync, readdirSync } from 'fs';
+import { readFileSync, readdirSync, existsSync } from 'fs';
 import {
   copyDirectory,
   copyFile,
@@ -89,7 +89,27 @@ export function installRulesForStack(rulesSrc, rulesDest, projectTags, fx = real
 }
 
 /**
- * Re-install only stack-aware assets (rules, skills, agents) using current config.json.
+ * Slash commands filtered by `stacks:` frontmatter. Clean-slate like the
+ * skills: removes only a framework command that the stack filtered out, never
+ * a command the user wrote into `.claude/commands/`.
+ */
+export function installCommandsForStack(commandsSrc, commandsDest, projectTags, fx = realEffects()) {
+  const sourceFiles = readdirSync(commandsSrc).filter(f => f.endsWith('.md'));
+  let installed = 0;
+  for (const file of sourceFiles) {
+    const dest = join(commandsDest, file);
+    if (shouldInstall(parseStacks(readFileSync(join(commandsSrc, file), 'utf-8')), projectTags)) {
+      fx.copyFile(join(commandsSrc, file), dest);
+      installed++;
+    } else if (!fx.dryRun && existsSync(dest)) {
+      fx.remove(dest);
+    }
+  }
+  return { installed };
+}
+
+/**
+ * Re-install only stack-aware assets (commands, rules, skills, agents) using current config.json.
  * Skips infrastructure steps (dirs, framework copy, hooks).
  *
  * @param {string} targetPath - Absolute path to the target project directory
@@ -109,8 +129,16 @@ async function installStackAwareAssets(targetPath, log) {
     } catch { /* ignore malformed config */ }
   }
 
-  log('Installing stack-filtered rules...');
   const claudeDest = join(targetPath, '.claude');
+  log('Installing stack-filtered commands...');
+  const commandsSrc = join(FRAMEWORK_DIR, 'commands');
+  const commandsDest = join(claudeDest, 'commands');
+  if (await pathExists(commandsSrc)) {
+    await ensureDir(commandsDest);
+    installCommandsForStack(commandsSrc, commandsDest, projectTags);
+  }
+
+  log('Installing stack-filtered rules...');
   const rulesSrc = join(FRAMEWORK_DIR, 'rules');
   const rulesDest = join(claudeDest, 'rules');
   if (await pathExists(rulesSrc)) {
@@ -336,18 +364,8 @@ export async function setupInfra(targetPath, {
     await copyDirectory(hooksSrc, hooksDest);
   }
 
-  // --- 7b. Copy framework/rubrics → .morph/framework/rubrics ---
-  log('Step 7b: Copying rubrics...');
-  const rubricsSrc = join(FRAMEWORK_DIR, 'rubrics');
-  const rubricsDest = join(frameworkDestDir, 'rubrics');
-  if (await pathExists(rubricsSrc)) {
-    await copyDirectory(rubricsSrc, rubricsDest);
-  }
-
   // --- 7c. Copy framework/evals → .morph/framework/evals ---
-  // Rubricas .md (bandas 0-10) + trace-schema.md — referenciadas por
-  // morph-review/agents.json via .morph/framework/evals/.
-  log('Step 7c: Copying evals (rubrics .md + trace schema)...');
+  log('Step 7c: Copying evals (review checklist + trace schema)...');
   const evalsSrc = join(FRAMEWORK_DIR, 'evals');
   const evalsDest = join(frameworkDestDir, 'evals');
   if (await pathExists(evalsSrc)) {
@@ -396,16 +414,9 @@ export async function setupInfra(targetPath, {
     await copyDirectory(schemasSrc, schemasDest);
   }
 
-  // --- 9. Copy framework/commands → .claude/commands ---
-  log('Step 9: Setting up Claude Code integration...');
   const claudeDest = join(targetPath, '.claude');
-  const commandsSrc = join(FRAMEWORK_DIR, 'commands');
-  const commandsDest = join(claudeDest, 'commands');
-  if (await pathExists(commandsSrc)) {
-    await copyDirectory(commandsSrc, commandsDest);
-  }
 
-  // --- 10-13. Install stack-aware assets (rules, skills, agents) ---
+  // --- 9-13. Install stack-aware assets (commands, rules, skills, agents) ---
   log('Steps 10-13: Installing stack-aware assets...');
   const { agentCounts, domainCounts, projectTags } = await installStackAwareAssets(targetPath, log);
 

package/src/utils/agents-installer.js

@@ -431,10 +431,8 @@ function buildFrontmatter(agent, description, knownMcpIds, maxTurns) {
     // Canonical 1:1 naming: frontmatter name === filename === subagent_type.
     `name: morph-${agent.id}`,
     `description: ${description}`,
-    // model is dimensioned per stage/criticality in agents.json (v5.2.0):
-    // evaluator (quality multiplier) → opus, domain implementers → sonnet,
-    // scout → sonnet (measured: same cost as haiku, fewer rejected maps). Falls back to `inherit` only for
-    // personas that omit the field.
+    // The evaluator is sonnet here; the dispatch routes it to opus when the risk
+    // detector flags the diff. A persona without the field inherits the session model.
     `model: ${agent.model ?? 'inherit'}`,
     `tools: ${buildToolsLine(agent, knownMcpIds)}`,
     // Per persona in agents.json (ADR-004); absent → DEFAULT_MAX_TURNS. The
@@ -487,11 +485,25 @@ function buildBody(agent, maxTurns) {
     }
   }
 
+  if (isImplementer(agent)) {
+    lines.push(
+      '## How you operate',
+      '',
+      'You are a domain persona dispatched per task. Read the spec/tasks/standards passed to you, do the work, and report each doneCriteria with its evidence. Refer to MORPH.md section 6 for the dispatch contract.',
+      '',
+    );
+  } else {
+    // A read-only persona has no task to do nor doneCriteria to report.
+    lines.push(
+      '## Como você opera',
+      '',
+      'Você é read-only: nunca escreva, edite nem reverta código, testes, `tasks.json` ou `feature.json` (nada de `git checkout --`). ' +
+        'O entregável é o arquivo de relatório que o dispatch nomeia; sem arquivo nomeado, é a sua mensagem final (no scout, o mapa).',
+      '',
+    );
+  }
+
   lines.push(
-    '## How you operate',
-    '',
-    'You are a domain persona dispatched per task. Read the spec/tasks/standards passed to you, do the work, and report each doneCriteria with its evidence. Refer to MORPH.md section 6 for the dispatch contract.',
-    '',
     // `PARCIAL` on line 1 is what report-check reads; "no verdict" keeps an
     // evaluator partial from carrying a Verdict the gate would read as final.
     '## Turn budget',

package/src/utils/file-copier.js

@@ -199,10 +199,12 @@ export async function updateGitignore(projectPath, fx = realEffects()) {
     content = await readFile(gitignorePath);
     hasMorphSection = content.includes('# MORPH-SPEC');
   }
+  const original = content;
+  const eol = content.includes('\r\n') ? '\r\n' : '\n';
 
   // If MORPH section already exists, check if rules are up to date
   if (hasMorphSection) {
-    const lines = content.split('\n');
+    const lines = content.split(/\r?\n/);
     const morphStartIndex = lines.findIndex(line => line.trim() === '# MORPH-SPEC');
 
     // Find the end of MORPH section (next empty line or section header)
@@ -225,17 +227,17 @@ export async function updateGitignore(projectPath, fx = realEffects()) {
     if (missingRules.length > 0) {
       // Update the section with all rules
       lines.splice(morphStartIndex, morphEndIndex - morphStartIndex, ...morphRules.slice(1, -1));
-      content = lines.join('\n');
+      content = lines.join(eol);
     }
   } else {
     // Add MORPH section
     if (content && !content.endsWith('\n')) {
-      content += '\n';
+      content += eol;
     }
-    content += morphRules.join('\n');
+    content += morphRules.join(eol);
   }
 
-  fx.writeFile(gitignorePath, content);
+  if (content !== original) fx.writeFile(gitignorePath, content);
 }
 
 /**