@polymorphism-tech/morph-spec 8.1.0 → 8.1.2

package/src/lib/validators/architecture/architecture-validator.js

@@ -1,259 +1,259 @@
-/**
- * Architecture Pattern Validator
- *
- * Validates architectural patterns and detects anti-patterns in .NET apps.
- * Checks Program.cs configuration, middleware order, and common DI issues.
- *
- * MORPH-SPEC 3.0 - Sprint 4
- */
-
-import { readFileSync } from 'fs';
-import chalk from 'chalk';
-
-/**
- * Architecture Validation Rules
- */
-const VALIDATION_RULES = {
-  // Program.cs Issues
-  missingHttpClient: {
-    pattern: /AddHttpClient\(\)/,
-    inverse: true, // Rule triggers if pattern NOT found
-    level: 'error',
-    message: 'AddHttpClient() missing in Program.cs',
-    reference: 'framework/standards/program-cs-checklist.md',
-    solution: 'Add builder.Services.AddHttpClient() before builder.Build()'
-  },
-
-  missingHttpContextAccessor: {
-    pattern: /AddHttpContextAccessor\(\)/,
-    inverse: true,
-    level: 'warning',
-    message: 'AddHttpContextAccessor() missing (needed for auth contexts)',
-    reference: 'framework/standards/program-cs-checklist.md',
-    solution: 'Add builder.Services.AddHttpContextAccessor()'
-  },
-
-  missingStaticFiles: {
-    pattern: /app\.UseStaticFiles\(\)/,
-    inverse: true,
-    level: 'error',
-    message: 'app.UseStaticFiles() missing (CSS/JS won\'t load)',
-    reference: 'framework/standards/program-cs-checklist.md',
-    solution: 'Add app.UseStaticFiles() before app.UseAntiforgery()'
-  },
-
-  wrongMiddlewareOrder: {
-    // Custom validator (checked in validateProgramCs)
-    level: 'error',
-    message: 'app.UseStaticFiles() must come BEFORE app.UseAntiforgery()',
-    reference: 'framework/standards/program-cs-checklist.md',
-    solution: 'Reorder: UseStaticFiles() → UseAntiforgery() → UseAuthorization()'
-  }
-};
-
-/**
- * Architecture Validator Class
- */
-export class ArchitectureValidator {
-  constructor(projectPath = '.') {
-    this.projectPath = projectPath;
-  }
-
-  /**
-   * Validate all architecture rules
-   */
-  async validateAll() {
-    const results = {
-      programCs: await this.validateProgramCs()
-    };
-
-    const allIssues = [
-      ...results.programCs.issues
-    ];
-
-    return {
-      status: allIssues.length === 0 ? 'ok' : 'error',
-      totalIssues: allIssues.length,
-      errors: allIssues.filter(i => i.level === 'error').length,
-      warnings: allIssues.filter(i => i.level === 'warning').length,
-      results
-    };
-  }
-
-  /**
-   * Validate Program.cs
-   */
-  async validateProgramCs() {
-    const programCsPath = 'Program.cs';
-
-    try {
-      const content = readFileSync(programCsPath, 'utf-8');
-      return this.validateProgramCsContent(content);
-    } catch (error) {
-      // No Program.cs found (not a .NET project)
-      return {
-        exists: false,
-        issues: []
-      };
-    }
-  }
-
-  /**
-   * Validate Program.cs content
-   */
-  validateProgramCsContent(content) {
-    const issues = [];
-
-    // Check missing patterns (inverse rules)
-    const inverseRules = ['missingHttpClient', 'missingHttpContextAccessor', 'missingStaticFiles'];
-
-    for (const ruleId of inverseRules) {
-      const rule = VALIDATION_RULES[ruleId];
-      const found = rule.pattern.test(content);
-
-      if (!found) {
-        issues.push({
-          file: 'Program.cs',
-          rule: ruleId,
-          level: rule.level,
-          message: rule.message,
-          reference: rule.reference,
-          solution: rule.solution
-        });
-      }
-    }
-
-    // Check middleware order
-    const staticFilesIndex = content.indexOf('UseStaticFiles');
-    const antiforgeryIndex = content.indexOf('UseAntiforgery');
-
-    if (staticFilesIndex > 0 && antiforgeryIndex > 0 && staticFilesIndex > antiforgeryIndex) {
-      const rule = VALIDATION_RULES.wrongMiddlewareOrder;
-      issues.push({
-        file: 'Program.cs',
-        rule: 'wrongMiddlewareOrder',
-        level: rule.level,
-        message: rule.message,
-        reference: rule.reference,
-        solution: rule.solution,
-        lineNumber: this.findLineNumber(content, /UseStaticFiles/)
-      });
-    }
-
-    return {
-      exists: true,
-      issues
-    };
-  }
-
-  /**
-   * Find line number of pattern match
-   */
-  findLineNumber(content, pattern) {
-    const lines = content.split('\n');
-    for (let i = 0; i < lines.length; i++) {
-      if (pattern.test(lines[i])) {
-        return i + 1;
-      }
-    }
-    return null;
-  }
-
-  /**
-   * Format validation results for console output
-   */
-  formatResults(results) {
-    if (results.status === 'ok') {
-      console.log(chalk.green('✅ No architecture issues found'));
-      return;
-    }
-
-    console.log(chalk.yellow(`\n⚠️  Found ${results.totalIssues} architecture issue(s):\n`));
-
-    // Group by file
-    const issuesByFile = new Map();
-    const allIssues = [
-      ...results.results.programCs.issues
-    ];
-
-    for (const issue of allIssues) {
-      if (!issuesByFile.has(issue.file)) {
-        issuesByFile.set(issue.file, []);
-      }
-      issuesByFile.get(issue.file).push(issue);
-    }
-
-    // Display by file
-    for (const [file, issues] of issuesByFile) {
-      console.log(chalk.cyan(`\n📄 ${file}`));
-
-      const errors = issues.filter(i => i.level === 'error');
-      const warnings = issues.filter(i => i.level === 'warning');
-
-      if (errors.length > 0) {
-        console.log(chalk.red(`  ❌ ${errors.length} error(s):`));
-        errors.forEach(e => {
-          const location = e.lineNumber ? `:${e.lineNumber}` : '';
-          console.log(chalk.red(`    ${file}${location}`));
-          console.log(chalk.red(`    - ${e.message}`));
-          console.log(chalk.gray(`      Solution: ${e.solution}`));
-          console.log(chalk.blue(`      Reference: ${e.reference}`));
-        });
-      }
-
-      if (warnings.length > 0) {
-        console.log(chalk.yellow(`  ⚠️  ${warnings.length} warning(s):`));
-        warnings.forEach(w => {
-          const location = w.lineNumber ? `:${w.lineNumber}` : '';
-          console.log(chalk.yellow(`    ${file}${location}`));
-          console.log(chalk.yellow(`    - ${w.message}`));
-          console.log(chalk.gray(`      Solution: ${w.solution}`));
-        });
-      }
-    }
-
-    console.log('');
-  }
-
-  /**
-   * Get suggested fixes
-   */
-  getSuggestedFixes(results) {
-    const fixes = [];
-    const allIssues = [
-      ...results.results.programCs.issues
-    ];
-
-    for (const issue of allIssues) {
-      fixes.push({
-        file: issue.file,
-        line: issue.lineNumber,
-        issue: issue.message,
-        solution: issue.solution,
-        reference: issue.reference,
-        severity: issue.level
-      });
-    }
-
-    return fixes;
-  }
-}
-
-/**
- * Quick validation function (for imports)
- */
-export async function validateArchitecture(projectPath = '.', options = {}) {
-  const validator = new ArchitectureValidator(projectPath);
-  const results = await validator.validateAll();
-
-  if (options.verbose) {
-    validator.formatResults(results);
-  }
-
-  if (options.fixes) {
-    const fixes = validator.getSuggestedFixes(results);
-    return { ...results, fixes };
-  }
-
-  return results;
-}
+/**
+ * Architecture Pattern Validator
+ *
+ * Validates architectural patterns and detects anti-patterns in .NET apps.
+ * Checks Program.cs configuration, middleware order, and common DI issues.
+ *
+ * MORPH-SPEC 3.0 - Sprint 4
+ */
+
+import { readFileSync } from 'fs';
+import chalk from 'chalk';
+
+/**
+ * Architecture Validation Rules
+ */
+const VALIDATION_RULES = {
+  // Program.cs Issues
+  missingHttpClient: {
+    pattern: /AddHttpClient\(\)/,
+    inverse: true, // Rule triggers if pattern NOT found
+    level: 'error',
+    message: 'AddHttpClient() missing in Program.cs',
+    reference: 'framework/standards/program-cs-checklist.md',
+    solution: 'Add builder.Services.AddHttpClient() before builder.Build()'
+  },
+
+  missingHttpContextAccessor: {
+    pattern: /AddHttpContextAccessor\(\)/,
+    inverse: true,
+    level: 'warning',
+    message: 'AddHttpContextAccessor() missing (needed for auth contexts)',
+    reference: 'framework/standards/program-cs-checklist.md',
+    solution: 'Add builder.Services.AddHttpContextAccessor()'
+  },
+
+  missingStaticFiles: {
+    pattern: /app\.UseStaticFiles\(\)/,
+    inverse: true,
+    level: 'error',
+    message: 'app.UseStaticFiles() missing (CSS/JS won\'t load)',
+    reference: 'framework/standards/program-cs-checklist.md',
+    solution: 'Add app.UseStaticFiles() before app.UseAntiforgery()'
+  },
+
+  wrongMiddlewareOrder: {
+    // Custom validator (checked in validateProgramCs)
+    level: 'error',
+    message: 'app.UseStaticFiles() must come BEFORE app.UseAntiforgery()',
+    reference: 'framework/standards/program-cs-checklist.md',
+    solution: 'Reorder: UseStaticFiles() → UseAntiforgery() → UseAuthorization()'
+  }
+};
+
+/**
+ * Architecture Validator Class
+ */
+export class ArchitectureValidator {
+  constructor(projectPath = '.') {
+    this.projectPath = projectPath;
+  }
+
+  /**
+   * Validate all architecture rules
+   */
+  async validateAll() {
+    const results = {
+      programCs: await this.validateProgramCs()
+    };
+
+    const allIssues = [
+      ...results.programCs.issues
+    ];
+
+    return {
+      status: allIssues.length === 0 ? 'ok' : 'error',
+      totalIssues: allIssues.length,
+      errors: allIssues.filter(i => i.level === 'error').length,
+      warnings: allIssues.filter(i => i.level === 'warning').length,
+      results
+    };
+  }
+
+  /**
+   * Validate Program.cs
+   */
+  async validateProgramCs() {
+    const programCsPath = 'Program.cs';
+
+    try {
+      const content = readFileSync(programCsPath, 'utf-8');
+      return this.validateProgramCsContent(content);
+    } catch (error) {
+      // No Program.cs found (not a .NET project)
+      return {
+        exists: false,
+        issues: []
+      };
+    }
+  }
+
+  /**
+   * Validate Program.cs content
+   */
+  validateProgramCsContent(content) {
+    const issues = [];
+
+    // Check missing patterns (inverse rules)
+    const inverseRules = ['missingHttpClient', 'missingHttpContextAccessor', 'missingStaticFiles'];
+
+    for (const ruleId of inverseRules) {
+      const rule = VALIDATION_RULES[ruleId];
+      const found = rule.pattern.test(content);
+
+      if (!found) {
+        issues.push({
+          file: 'Program.cs',
+          rule: ruleId,
+          level: rule.level,
+          message: rule.message,
+          reference: rule.reference,
+          solution: rule.solution
+        });
+      }
+    }
+
+    // Check middleware order
+    const staticFilesIndex = content.indexOf('UseStaticFiles');
+    const antiforgeryIndex = content.indexOf('UseAntiforgery');
+
+    if (staticFilesIndex > 0 && antiforgeryIndex > 0 && staticFilesIndex > antiforgeryIndex) {
+      const rule = VALIDATION_RULES.wrongMiddlewareOrder;
+      issues.push({
+        file: 'Program.cs',
+        rule: 'wrongMiddlewareOrder',
+        level: rule.level,
+        message: rule.message,
+        reference: rule.reference,
+        solution: rule.solution,
+        lineNumber: this.findLineNumber(content, /UseStaticFiles/)
+      });
+    }
+
+    return {
+      exists: true,
+      issues
+    };
+  }
+
+  /**
+   * Find line number of pattern match
+   */
+  findLineNumber(content, pattern) {
+    const lines = content.split('\n');
+    for (let i = 0; i < lines.length; i++) {
+      if (pattern.test(lines[i])) {
+        return i + 1;
+      }
+    }
+    return null;
+  }
+
+  /**
+   * Format validation results for console output
+   */
+  formatResults(results) {
+    if (results.status === 'ok') {
+      console.log(chalk.green('✅ No architecture issues found'));
+      return;
+    }
+
+    console.log(chalk.yellow(`\n⚠️  Found ${results.totalIssues} architecture issue(s):\n`));
+
+    // Group by file
+    const issuesByFile = new Map();
+    const allIssues = [
+      ...results.results.programCs.issues
+    ];
+
+    for (const issue of allIssues) {
+      if (!issuesByFile.has(issue.file)) {
+        issuesByFile.set(issue.file, []);
+      }
+      issuesByFile.get(issue.file).push(issue);
+    }
+
+    // Display by file
+    for (const [file, issues] of issuesByFile) {
+      console.log(chalk.cyan(`\n📄 ${file}`));
+
+      const errors = issues.filter(i => i.level === 'error');
+      const warnings = issues.filter(i => i.level === 'warning');
+
+      if (errors.length > 0) {
+        console.log(chalk.red(`  ❌ ${errors.length} error(s):`));
+        errors.forEach(e => {
+          const location = e.lineNumber ? `:${e.lineNumber}` : '';
+          console.log(chalk.red(`    ${file}${location}`));
+          console.log(chalk.red(`    - ${e.message}`));
+          console.log(chalk.gray(`      Solution: ${e.solution}`));
+          console.log(chalk.blue(`      Reference: ${e.reference}`));
+        });
+      }
+
+      if (warnings.length > 0) {
+        console.log(chalk.yellow(`  ⚠️  ${warnings.length} warning(s):`));
+        warnings.forEach(w => {
+          const location = w.lineNumber ? `:${w.lineNumber}` : '';
+          console.log(chalk.yellow(`    ${file}${location}`));
+          console.log(chalk.yellow(`    - ${w.message}`));
+          console.log(chalk.gray(`      Solution: ${w.solution}`));
+        });
+      }
+    }
+
+    console.log('');
+  }
+
+  /**
+   * Get suggested fixes
+   */
+  getSuggestedFixes(results) {
+    const fixes = [];
+    const allIssues = [
+      ...results.results.programCs.issues
+    ];
+
+    for (const issue of allIssues) {
+      fixes.push({
+        file: issue.file,
+        line: issue.lineNumber,
+        issue: issue.message,
+        solution: issue.solution,
+        reference: issue.reference,
+        severity: issue.level
+      });
+    }
+
+    return fixes;
+  }
+}
+
+/**
+ * Quick validation function (for imports)
+ */
+export async function validateArchitecture(projectPath = '.', options = {}) {
+  const validator = new ArchitectureValidator(projectPath);
+  const results = await validator.validateAll();
+
+  if (options.verbose) {
+    validator.formatResults(results);
+  }
+
+  if (options.fixes) {
+    const fixes = validator.getSuggestedFixes(results);
+    return { ...results, fixes };
+  }
+
+  return results;
+}

package/src/lib/validators/checkpoint-persistence.js

@@ -1,39 +1,39 @@
-/**
- * Checkpoint Validation Persistence
- *
- * Persists checkpoint validation results to disk for traceability.
- * Each checkpoint writes a JSON file to:
- *   .morph/features/{feature}/3-implement/validations/checkpoint-{N}.json
- */
-
-import { mkdirSync, writeFileSync } from 'fs';
-import { join } from 'path';
-
-/**
- * Persist a checkpoint validation result to disk.
- *
- * @param {string} projectPath - Project root
- * @param {string} featureName - Feature name
- * @param {{ checkpointNum: number, timestamp: string, passed: boolean, validators: Object, summary: string, feature?: string, phase?: string }} result - Validation result
- * @returns {string} Path to the saved JSON file
- */
-export function persistCheckpointValidation(projectPath, featureName, result) {
-  const dir = join(projectPath, `.morph/features/${featureName}/3-implement/validations`);
-  mkdirSync(dir, { recursive: true });
-
-  const filename = `checkpoint-${result.checkpointNum}.json`;
-  const filePath = join(dir, filename);
-
-  const output = {
-    checkpointNum: result.checkpointNum,
-    timestamp: result.timestamp || new Date().toISOString(),
-    passed: result.passed,
-    validators: result.validators || {},
-    summary: result.summary || '',
-    feature: result.feature || featureName,
-    phase: result.phase || 'implement',
-  };
-
-  writeFileSync(filePath, JSON.stringify(output, null, 2), 'utf8');
-  return filePath;
-}
+/**
+ * Checkpoint Validation Persistence
+ *
+ * Persists checkpoint validation results to disk for traceability.
+ * Each checkpoint writes a JSON file to:
+ *   .morph/features/{feature}/3-implement/validations/checkpoint-{N}.json
+ */
+
+import { mkdirSync, writeFileSync } from 'fs';
+import { join } from 'path';
+
+/**
+ * Persist a checkpoint validation result to disk.
+ *
+ * @param {string} projectPath - Project root
+ * @param {string} featureName - Feature name
+ * @param {{ checkpointNum: number, timestamp: string, passed: boolean, validators: Object, summary: string, feature?: string, phase?: string }} result - Validation result
+ * @returns {string} Path to the saved JSON file
+ */
+export function persistCheckpointValidation(projectPath, featureName, result) {
+  const dir = join(projectPath, `.morph/features/${featureName}/3-implement/validations`);
+  mkdirSync(dir, { recursive: true });
+
+  const filename = `checkpoint-${result.checkpointNum}.json`;
+  const filePath = join(dir, filename);
+
+  const output = {
+    checkpointNum: result.checkpointNum,
+    timestamp: result.timestamp || new Date().toISOString(),
+    passed: result.passed,
+    validators: result.validators || {},
+    summary: result.summary || '',
+    feature: result.feature || featureName,
+    phase: result.phase || 'implement',
+  };
+
+  writeFileSync(filePath, JSON.stringify(output, null, 2), 'utf8');
+  return filePath;
+}