@polymorphism-tech/morph-spec 4.12.0 → 4.13.0

package/src/lib/validators/content/content-validator.js

@@ -1,287 +1,287 @@
-import { readFileSync, existsSync } from 'fs';
-
-/**
- * Content Validator - Validates structure and content of output files
- *
- * Ensures spec.md, tasks.json, and other outputs have required sections
- * and proper structure before allowing phase transitions.
- */
-
-/**
- * Validate spec.md structure
- * @param {string} specPath - Path to spec.md file
- * @returns {Object} Validation result
- */
-export function validateSpecContent(specPath) {
-  if (!existsSync(specPath)) {
-    return {
-      valid: false,
-      missing: ['File does not exist'],
-      errors: ['Spec file not found at: ' + specPath]
-    };
-  }
-
-  const content = readFileSync(specPath, 'utf8');
-
-  // Required sections for a complete spec (prefix-match to handle variants like
-  // "## Functional Requirements" and "## Technical Architecture")
-  const requiredSections = [
-    '## Overview',
-    '## Functional Requirements',
-    '## Technical',
-    '## Data Model',
-  ];
-
-  const lines = content.split('\n');
-  const missing = requiredSections.filter(section =>
-    !lines.some(line => line.startsWith(section))
-  );
-
-  // Additional quality checks
-  const errors = [];
-  const warnings = [];
-
-  // Missing sections are warnings, not errors — not every spec needs all sections
-  // (e.g., frontend-only features may not have Data Model, CLI tools may not have Technical Architecture)
-  if (missing.length > 0) {
-    missing.forEach(section => {
-      warnings.push(`Missing recommended section: ${section}`);
-    });
-  }
-
-  // Check minimum content length
-  if (content.length < 500) {
-    warnings.push('Spec seems very short (< 500 characters). Consider adding more detail.');
-  }
-
-  // Check for placeholder text that should be replaced
-  const placeholders = ['TODO', 'TBD', 'PLACEHOLDER', '{{'];
-  placeholders.forEach(placeholder => {
-    if (content.includes(placeholder)) {
-      warnings.push(`Spec contains "${placeholder}" - ensure all placeholders are replaced`);
-    }
-  });
-
-  // Check for anti-patterns mentioned in the plan
-  if (content.toLowerCase().includes('manual azure portal')) {
-    errors.push(
-      'Spec mentions manual Azure portal creation. ' +
-      'All infrastructure must be defined in Bicep (Infrastructure as Code).'
-    );
-  }
-
-  if (content.toLowerCase().includes('create resource manually')) {
-    errors.push(
-      'Spec mentions manual resource creation. ' +
-      'Use IaC (Bicep) for all infrastructure resources.'
-    );
-  }
-
-  return {
-    valid: errors.length === 0,
-    missing,
-    errors,
-    warnings,
-    sections: {
-      required: requiredSections.length,
-      found: requiredSections.length - missing.length
-    }
-  };
-}
-
-/**
- * Validate tasks.md structure
- * @param {string} tasksPath - Path to tasks.md file
- * @returns {Object} Validation result
- */
-export function validateTasksContent(tasksPath) {
-  if (!existsSync(tasksPath)) {
-    return {
-      valid: false,
-      errors: ['Tasks file not found at: ' + tasksPath]
-    };
-  }
-
-  const content = readFileSync(tasksPath, 'utf8');
-  const errors = [];
-  const warnings = [];
-
-  // Extract task IDs from headings: ### T001 — title OR ### T001: title
-  const taskRe = /^###\s+(T\d{3})\s*[—–:\-]\s*(.+)$/gm;
-  const checkpointRe = /^###\s+(CHECKPOINT[_-]\d+)\s*[—–:\-]\s*(.+)$/gm;
-
-  const tasks = [...content.matchAll(taskRe)];
-  const checkpoints = [...content.matchAll(checkpointRe)];
-
-  if (tasks.length === 0) {
-    errors.push('No tasks found in tasks.md — expected headings like "### T001 — Title" or "### T001: Title"');
-    return { valid: false, errors, warnings };
-  }
-
-  // Validate no duplicate IDs
-  const ids = tasks.map(m => m[1]);
-  const dupes = ids.filter((id, i) => ids.indexOf(id) !== i);
-  dupes.forEach(id => errors.push(`Duplicate task ID: ${id}`));
-
-  // Check for dependency references (look for "Dependencies: T###")
-  const depRe = /\*\*Dependenc(?:y|ies):\*\*\s*([T\d, ]+)/gi;
-  const allDepRefs = [...content.matchAll(depRe)]
-    .flatMap(m => m[1].split(/[,\s]+/).filter(s => /^T\d{3}$/.test(s)));
-
-  const idSet = new Set(ids);
-  allDepRefs.forEach(depId => {
-    if (!idSet.has(depId)) {
-      warnings.push(`Dependency reference "${depId}" not found in task list`);
-    }
-  });
-
-  return {
-    valid: errors.length === 0,
-    errors,
-    warnings,
-    stats: {
-      totalTasks: tasks.length + checkpoints.length,
-      regularTasks: tasks.length,
-      checkpoints: checkpoints.length,
-    },
-  };
-}
-
-/**
- * Validate contracts file structure (C# contracts)
- * @param {string} contractsPath - Path to contracts file
- * @returns {Object} Validation result
- */
-export function validateContractsContent(contractsPath) {
-  if (!existsSync(contractsPath)) {
-    return {
-      valid: false,
-      errors: ['Contracts file not found at: ' + contractsPath]
-    };
-  }
-
-  const content = readFileSync(contractsPath, 'utf8');
-  const errors = [];
-  const warnings = [];
-
-  // Check for basic C# structure
-  if (!content.includes('namespace')) {
-    errors.push('Contracts file missing namespace declaration');
-  }
-
-  // Check for at least one interface or record
-  const hasInterface = /interface\s+\w+/.test(content);
-  const hasRecord = /record\s+\w+/.test(content);
-  const hasClass = /class\s+\w+/.test(content);
-
-  if (!hasInterface && !hasRecord && !hasClass) {
-    errors.push('Contracts file should define at least one interface, record, or class');
-  }
-
-  // Check for common anti-patterns
-  if (content.includes('// TODO') || content.includes('// PLACEHOLDER')) {
-    warnings.push('Contracts contain TODO/PLACEHOLDER comments - ensure they are completed');
-  }
-
-  return {
-    valid: errors.length === 0,
-    errors,
-    warnings,
-    found: {
-      hasNamespace: content.includes('namespace'),
-      hasInterfaces: hasInterface,
-      hasRecords: hasRecord,
-      hasClasses: hasClass
-    }
-  };
-}
-
-/**
- * Validate proposal.md structure
- * @param {string} proposalPath - Path to proposal.md file
- * @returns {Object} Validation result
- */
-export function validateProposalContent(proposalPath) {
-  if (!existsSync(proposalPath)) {
-    return {
-      valid: false,
-      errors: ['Proposal file not found at: ' + proposalPath]
-    };
-  }
-
-  const content = readFileSync(proposalPath, 'utf8');
-  const errors = [];
-  const warnings = [];
-
-  // Required sections
-  const requiredSections = [
-    '## Problem Statement',
-    '## Proposed Solution'
-  ];
-
-  const missing = requiredSections.filter(section => !content.includes(section));
-  missing.forEach(section => errors.push(`Missing required section: ${section}`));
-
-  // Check for minimum content
-  if (content.length < 300) {
-    warnings.push('Proposal seems very brief (< 300 characters)');
-  }
-
-  return {
-    valid: errors.length === 0,
-    errors,
-    warnings,
-    sections: {
-      required: requiredSections.length,
-      found: requiredSections.length - missing.length
-    }
-  };
-}
-
-/**
- * Validate all outputs for a feature comprehensively
- * @param {Object} featureState - Feature state object
- * @param {string} targetPhase - Target phase for validation
- * @returns {Object} Comprehensive validation result
- */
-export function validateFeatureOutputs(featureState, targetPhase) {
-  const results = {
-    valid: true,
-    validations: []
-  };
-
-  // Validate based on target phase
-  if (targetPhase === 'clarify' || targetPhase === 'tasks' || targetPhase === 'implement') {
-    // Spec is required
-    if (featureState.outputs?.spec?.created) {
-      const specResult = validateSpecContent(featureState.outputs.spec.path);
-      results.validations.push({ type: 'spec', ...specResult });
-      if (!specResult.valid) results.valid = false;
-    } else {
-      results.valid = false;
-      results.validations.push({
-        type: 'spec',
-        valid: false,
-        errors: ['Spec file not created']
-      });
-    }
-  }
-
-  if (targetPhase === 'implement') {
-    // Tasks are required
-    if (featureState.outputs?.tasks?.created) {
-      const tasksResult = validateTasksContent(featureState.outputs.tasks.path);
-      results.validations.push({ type: 'tasks', ...tasksResult });
-      if (!tasksResult.valid) results.valid = false;
-    } else {
-      results.valid = false;
-      results.validations.push({
-        type: 'tasks',
-        valid: false,
-        errors: ['Tasks file not created']
-      });
-    }
-  }
-
-  return results;
-}
+import { readFileSync, existsSync } from 'fs';
+
+/**
+ * Content Validator - Validates structure and content of output files
+ *
+ * Ensures spec.md, tasks.json, and other outputs have required sections
+ * and proper structure before allowing phase transitions.
+ */
+
+/**
+ * Validate spec.md structure
+ * @param {string} specPath - Path to spec.md file
+ * @returns {Object} Validation result
+ */
+export function validateSpecContent(specPath) {
+  if (!existsSync(specPath)) {
+    return {
+      valid: false,
+      missing: ['File does not exist'],
+      errors: ['Spec file not found at: ' + specPath]
+    };
+  }
+
+  const content = readFileSync(specPath, 'utf8');
+
+  // Required sections for a complete spec (prefix-match to handle variants like
+  // "## Functional Requirements" and "## Technical Architecture")
+  const requiredSections = [
+    '## Overview',
+    '## Functional Requirements',
+    '## Technical',
+    '## Data Model',
+  ];
+
+  const lines = content.split('\n');
+  const missing = requiredSections.filter(section =>
+    !lines.some(line => line.startsWith(section))
+  );
+
+  // Additional quality checks
+  const errors = [];
+  const warnings = [];
+
+  // Missing sections are warnings, not errors — not every spec needs all sections
+  // (e.g., frontend-only features may not have Data Model, CLI tools may not have Technical Architecture)
+  if (missing.length > 0) {
+    missing.forEach(section => {
+      warnings.push(`Missing recommended section: ${section}`);
+    });
+  }
+
+  // Check minimum content length
+  if (content.length < 500) {
+    warnings.push('Spec seems very short (< 500 characters). Consider adding more detail.');
+  }
+
+  // Check for placeholder text that should be replaced
+  const placeholders = ['TODO', 'TBD', 'PLACEHOLDER', '{{'];
+  placeholders.forEach(placeholder => {
+    if (content.includes(placeholder)) {
+      warnings.push(`Spec contains "${placeholder}" - ensure all placeholders are replaced`);
+    }
+  });
+
+  // Check for anti-patterns mentioned in the plan
+  if (content.toLowerCase().includes('manual azure portal')) {
+    errors.push(
+      'Spec mentions manual Azure portal creation. ' +
+      'All infrastructure must be defined in Bicep (Infrastructure as Code).'
+    );
+  }
+
+  if (content.toLowerCase().includes('create resource manually')) {
+    errors.push(
+      'Spec mentions manual resource creation. ' +
+      'Use IaC (Bicep) for all infrastructure resources.'
+    );
+  }
+
+  return {
+    valid: errors.length === 0,
+    missing,
+    errors,
+    warnings,
+    sections: {
+      required: requiredSections.length,
+      found: requiredSections.length - missing.length
+    }
+  };
+}
+
+/**
+ * Validate tasks.md structure
+ * @param {string} tasksPath - Path to tasks.md file
+ * @returns {Object} Validation result
+ */
+export function validateTasksContent(tasksPath) {
+  if (!existsSync(tasksPath)) {
+    return {
+      valid: false,
+      errors: ['Tasks file not found at: ' + tasksPath]
+    };
+  }
+
+  const content = readFileSync(tasksPath, 'utf8');
+  const errors = [];
+  const warnings = [];
+
+  // Extract task IDs from headings: ### T001 — title OR ### T001: title
+  const taskRe = /^###\s+(T\d{3})\s*[—–:\-]\s*(.+)$/gm;
+  const checkpointRe = /^###\s+(CHECKPOINT[_-]\d+)\s*[—–:\-]\s*(.+)$/gm;
+
+  const tasks = [...content.matchAll(taskRe)];
+  const checkpoints = [...content.matchAll(checkpointRe)];
+
+  if (tasks.length === 0) {
+    errors.push('No tasks found in tasks.md — expected headings like "### T001 — Title" or "### T001: Title"');
+    return { valid: false, errors, warnings };
+  }
+
+  // Validate no duplicate IDs
+  const ids = tasks.map(m => m[1]);
+  const dupes = ids.filter((id, i) => ids.indexOf(id) !== i);
+  dupes.forEach(id => errors.push(`Duplicate task ID: ${id}`));
+
+  // Check for dependency references (look for "Dependencies: T###")
+  const depRe = /\*\*Dependenc(?:y|ies):\*\*\s*([T\d, ]+)/gi;
+  const allDepRefs = [...content.matchAll(depRe)]
+    .flatMap(m => m[1].split(/[,\s]+/).filter(s => /^T\d{3}$/.test(s)));
+
+  const idSet = new Set(ids);
+  allDepRefs.forEach(depId => {
+    if (!idSet.has(depId)) {
+      warnings.push(`Dependency reference "${depId}" not found in task list`);
+    }
+  });
+
+  return {
+    valid: errors.length === 0,
+    errors,
+    warnings,
+    stats: {
+      totalTasks: tasks.length + checkpoints.length,
+      regularTasks: tasks.length,
+      checkpoints: checkpoints.length,
+    },
+  };
+}
+
+/**
+ * Validate contracts file structure (C# contracts)
+ * @param {string} contractsPath - Path to contracts file
+ * @returns {Object} Validation result
+ */
+export function validateContractsContent(contractsPath) {
+  if (!existsSync(contractsPath)) {
+    return {
+      valid: false,
+      errors: ['Contracts file not found at: ' + contractsPath]
+    };
+  }
+
+  const content = readFileSync(contractsPath, 'utf8');
+  const errors = [];
+  const warnings = [];
+
+  // Check for basic C# structure
+  if (!content.includes('namespace')) {
+    errors.push('Contracts file missing namespace declaration');
+  }
+
+  // Check for at least one interface or record
+  const hasInterface = /interface\s+\w+/.test(content);
+  const hasRecord = /record\s+\w+/.test(content);
+  const hasClass = /class\s+\w+/.test(content);
+
+  if (!hasInterface && !hasRecord && !hasClass) {
+    errors.push('Contracts file should define at least one interface, record, or class');
+  }
+
+  // Check for common anti-patterns
+  if (content.includes('// TODO') || content.includes('// PLACEHOLDER')) {
+    warnings.push('Contracts contain TODO/PLACEHOLDER comments - ensure they are completed');
+  }
+
+  return {
+    valid: errors.length === 0,
+    errors,
+    warnings,
+    found: {
+      hasNamespace: content.includes('namespace'),
+      hasInterfaces: hasInterface,
+      hasRecords: hasRecord,
+      hasClasses: hasClass
+    }
+  };
+}
+
+/**
+ * Validate proposal.md structure
+ * @param {string} proposalPath - Path to proposal.md file
+ * @returns {Object} Validation result
+ */
+export function validateProposalContent(proposalPath) {
+  if (!existsSync(proposalPath)) {
+    return {
+      valid: false,
+      errors: ['Proposal file not found at: ' + proposalPath]
+    };
+  }
+
+  const content = readFileSync(proposalPath, 'utf8');
+  const errors = [];
+  const warnings = [];
+
+  // Required sections
+  const requiredSections = [
+    '## Problem Statement',
+    '## Proposed Solution'
+  ];
+
+  const missing = requiredSections.filter(section => !content.includes(section));
+  missing.forEach(section => errors.push(`Missing required section: ${section}`));
+
+  // Check for minimum content
+  if (content.length < 300) {
+    warnings.push('Proposal seems very brief (< 300 characters)');
+  }
+
+  return {
+    valid: errors.length === 0,
+    errors,
+    warnings,
+    sections: {
+      required: requiredSections.length,
+      found: requiredSections.length - missing.length
+    }
+  };
+}
+
+/**
+ * Validate all outputs for a feature comprehensively
+ * @param {Object} featureState - Feature state object
+ * @param {string} targetPhase - Target phase for validation
+ * @returns {Object} Comprehensive validation result
+ */
+export function validateFeatureOutputs(featureState, targetPhase) {
+  const results = {
+    valid: true,
+    validations: []
+  };
+
+  // Validate based on target phase
+  if (targetPhase === 'tasks' || targetPhase === 'implement') {
+    // Spec is required
+    if (featureState.outputs?.spec?.created) {
+      const specResult = validateSpecContent(featureState.outputs.spec.path);
+      results.validations.push({ type: 'spec', ...specResult });
+      if (!specResult.valid) results.valid = false;
+    } else {
+      results.valid = false;
+      results.validations.push({
+        type: 'spec',
+        valid: false,
+        errors: ['Spec file not created']
+      });
+    }
+  }
+
+  if (targetPhase === 'implement') {
+    // Tasks are required
+    if (featureState.outputs?.tasks?.created) {
+      const tasksResult = validateTasksContent(featureState.outputs.tasks.path);
+      results.validations.push({ type: 'tasks', ...tasksResult });
+      if (!tasksResult.valid) results.valid = false;
+    } else {
+      results.valid = false;
+      results.validations.push({
+        type: 'tasks',
+        valid: false,
+        errors: ['Tasks file not created']
+      });
+    }
+  }
+
+  return results;
+}