@polymorphism-tech/morph-spec 4.10.0 → 4.10.2

package/framework/skills/level-0-meta/morph-post-implementation/SKILL.md

@@ -1,31 +1,31 @@
 ---
 name: morph:post-implementation
-description: Orquestra o fluxo completo pós-implementação: detecção de stack,
-  scans automáticos (C#/Next.js), testes, validate-feature, smoke test via
-  Playwright (obrigatório se dev server ativo), checklist de code review por
-  stack, checkpoint e geração de recap. Use após concluir todas as tasks.
+description: Orchestrates the complete post-implementation flow: stack detection,
+  automated scans (C#/Next.js), tests, validate-feature, smoke test via Playwright
+  (mandatory if dev server active), code review checklist by stack, checkpoint, and
+  recap generation. Use after completing all tasks.
 argument-hint: "[feature-name]"
 user-invocable: true
-allowed-tools: Read, Write, Edit, Bash, Glob, Grep, Task,
+allowed-tools: Read, Write, Edit, Bash, Glob, Grep, Task, AskUserQuestion,
   mcp__playwright__browser_navigate, mcp__playwright__browser_snapshot,
   mcp__playwright__browser_take_screenshot, mcp__playwright__browser_console_messages
 ---
 
 # Post-Implementation Review
 
-> Orquestrador pós-implementação: executa todos os checks em sequência lógica e bloqueia em caso de falha.
-> Use após completar todas as tasks de implementação, antes de criar o PR.
+> Post-implementation orchestrator: runs all checks in logical sequence and blocks on failure.
+> Use after completing all implementation tasks, before creating the PR.
 
 ---
 
-## Pré-requisitos
+## Prerequisites
 
-- Todas as tasks marcadas como done (`morph-spec task done`)
-- Build do projeto compilando sem erros
+- All tasks marked as done (`morph-spec task done`)
+- Project build compiling without errors
 
 ---
 
-## Step 1 — Detectar Stack
+## Step 1 — Detect Stack
 
 ```bash
 node .claude/skills/morph-post-implementation/scripts/detect-stack.mjs
@@ -33,34 +33,34 @@ node .claude/skills/morph-post-implementation/scripts/detect-stack.mjs
 
 Output JSON: `{ stack: "DOTNET" | "NEXTJS" | "FULLSTACK" | "UNKNOWN", frontendPath, backendPath, startCommand }`
 
-Ordem de prioridade (mais confiável primeiro):
+Priority order (most reliable first):
 1. `.morph/config/config.json` → `config.project.stack` + `frontendPath`/`backendPath`
-2. `.morph/context/README.md` → seção `## Tech Stack`
-3. Fallback: Glob por `*.csproj` e `package.json` com dep `"next"`
+2. `.morph/context/README.md` → section `## Tech Stack`
+3. Fallback: Glob for `*.csproj` and `package.json` with dep `"next"`
 
-Guarde o resultado — todos os passos seguintes dependem do `stack` detectado.
+Store the result — all following steps depend on the detected `stack`.
 
 ---
 
 ## Step 2 — Automated Scans
 
-Execute os scans automáticos conforme o stack detectado.
+Run automated scans based on detected stack.
 
-### Se DOTNET ou FULLSTACK:
+### If DOTNET or FULLSTACK:
 
 ```bash
 node .claude/skills/morph-code-review/scripts/scan-csharp.mjs --diff
 ```
 
-### Se NEXTJS ou FULLSTACK:
+### If NEXTJS or FULLSTACK:
 
 ```bash
 node .claude/skills/morph-code-review-nextjs/scripts/scan-nextjs.mjs --diff
 ```
 
-**🚫 BLOCK se qualquer finding CRITICAL encontrado.**
+**🚫 BLOCK if any CRITICAL finding found.**
 
-Corrija todos os CRITICALs antes de continuar. Para revisar a lista completa de checks:
+Fix all CRITICALs before continuing. To review the full checklist:
 - .NET: `/morph:code-review`
 - Next.js: `/morph:code-review-nextjs`
 
@@ -68,7 +68,7 @@ Corrija todos os CRITICALs antes de continuar. Para revisar a lista completa de
 
 ## Step 3 — Test Suite
 
-Execute os testes conforme o stack.
+Run tests based on stack.
 
 ### DOTNET:
 
@@ -84,176 +84,176 @@ npm test -- --watchAll=false
 
 ### FULLSTACK:
 
-Execute ambos em paralelo (use Task tool com dois subagents independentes).
+Run both in parallel (use Task tool with two independent subagents).
 
-**🚫 BLOCK se testes falharem.**
+**🚫 BLOCK if tests fail.**
 
-Não prossiga enquanto houver testes falhando. Corrija as falhas e re-execute antes de continuar.
+Do not proceed while tests are failing. Fix failures and re-run before continuing.
 
 ---
 
 ## Step 4 — Framework Validation
 
 ```bash
-npx morph-spec validate-feature $ARGUMENTS --phase implement
+npx morph-spec validate-feature $ARGUMENTS
 ```
 
-**🚫 BLOCK se falhar.**
+**🚫 BLOCK if it fails.**
 
-Leia o output de validação, corrija os issues reportados e re-execute até passar.
+Read validation output, fix reported issues, and re-run until it passes.
 
 ---
 
 ## Step 5 — Smoke Test (Playwright MCP)
 
-### 5a. Detectar Dev Server
+### 5a. Detect Dev Server
 
 ```bash
 node .claude/skills/morph-post-implementation/scripts/detect-dev-server.mjs "<startCommand>"
 ```
 
-Passe o `startCommand` retornado pelo detect-stack no Step 1.
+Pass the `startCommand` returned by detect-stack in Step 1.
 
-O script:
-1. Varre portas `[3000, 3001, 4200, 5000, 5001, 7000, 8000, 8080]` com `fetch()` timeout 500ms
-2. Se encontrar um servidor ativo → retorna `{ found: true, url }`
-3. Se não encontrar e `startCommand` fornecido → tenta iniciar automaticamente e aguarda 30s
-4. Retorna exit code 0 (server disponível) ou 1 (não disponível após tentativa)
+The script:
+1. Scans ports `[3000, 3001, 4200, 5000, 5001, 7000, 8000, 8080]` with `fetch()` timeout 500ms
+2. If it finds an active server → returns `{ found: true, url }`
+3. If not found and `startCommand` provided → tries to start automatically and waits 30s
+4. Returns exit code 0 (server available) or 1 (not available after attempt)
 
-### 5b. Se dev server disponível (exit 0):
+### 5b. If dev server available (exit 0):
 
-**O smoke test é OBRIGATÓRIO.**
+**Smoke test is MANDATORY.**
 
-1. Leia `spec.md` da feature para identificar os happy paths críticos (máximo 3 flows, seção Functional Requirements)
-2. Execute o smoke test via Playwright MCP:
+1. Read feature `spec.md` to identify critical happy paths (maximum 3 flows, section Functional Requirements)
+2. Run the smoke test via Playwright MCP:
 
 ```javascript
-// Navegar para a feature
-await mcp__playwright__browser_navigate({ url: '<url-detectada>' });
+// Navigate to the feature
+await mcp__playwright__browser_navigate({ url: '<detected-url>' });
 
-// Capturar estado da página
+// Capture page state
 await mcp__playwright__browser_snapshot();
 
-// Verificar erros críticos de console
+// Check for critical console errors
 await mcp__playwright__browser_console_messages({ level: 'error' });
 
-// Screenshot para documentação
+// Screenshot for documentation
 await mcp__playwright__browser_take_screenshot({
   type: 'png',
   filename: '.morph/features/$ARGUMENTS/5-implement/smoke-screenshots/smoke-<timestamp>.png'
 });
 ```
 
-Para cada happy path crítico da spec:
-- Navegue até o flow
-- Verifique elementos-chave visíveis (`browser_snapshot`)
-- Confirme ausência de erros de console críticos
-- Capture screenshot do estado final
+For each critical happy path from the spec:
+- Navigate to the flow
+- Verify key elements are visible (`browser_snapshot`)
+- Confirm absence of critical console errors
+- Capture screenshot of final state
 
-**Verificações obrigatórias:**
-- [ ] Página carrega sem erro 404/500
-- [ ] Elementos principais da feature visíveis (conforme spec)
-- [ ] Console sem erros críticos (level: error)
-- [ ] Happy path principal funcional
+**Mandatory checks:**
+- [ ] Page loads without 404/500 error
+- [ ] Main feature elements visible (per spec)
+- [ ] Console without critical errors (level: error)
+- [ ] Main happy path functional
 
-**🚫 BLOCK se qualquer verificação falhar.** Não crie PR com smoke test falhando.
+**🚫 BLOCK if any check fails.** Do not create PR with failing smoke test.
 
-### 5c. Se dev server NÃO disponível (exit 1):
+### 5c. If dev server NOT available (exit 1):
 
-**⚠️ ATENÇÃO: Dev server não encontrado após tentativa de iniciar.**
+**⚠️ WARNING: Dev server not found after attempt to start.**
 
-Solicite confirmação explícita ao usuário antes de pular o smoke test:
+Request explicit user confirmation before skipping smoke test:
 
 ```
-Dev server não detectado na porta esperada. O smoke test via Playwright é obrigatório
-para garantir que o código funciona no browser antes de criar o PR.
+Dev server not detected on expected port. Smoke test via Playwright is mandatory
+to ensure the code works in the browser before creating the PR.
 
-Opções:
-1. Inicie manualmente o servidor (`npm run dev` / `dotnet run`) e re-execute /post-implementation
-2. Confirme explicitamente que deseja pular o smoke test e por quê
+Options:
+1. Start the server manually (`npm run dev` / `dotnet run`) and re-run /post-implementation
+2. Explicitly confirm you want to skip the smoke test and why
 
-Não é possível prosseguir para criação de PR sem smoke test ou confirmação explícita.
+Cannot proceed to PR creation without smoke test or explicit confirmation.
 ```
 
-**Aguarde resposta antes de continuar.**
+**Wait for response before continuing.**
 
 ---
 
 ## Step 6 — Code Review Checklist (CRITICAL + HIGH)
 
-> Antes de revisar, leia: `.claude/skills/morph-code-review/references/review-guidelines.md` — aplique confidence ≥ 75, ignore violações pré-existentes, inclua file:line em cada finding.
+> Before reviewing, read: `.claude/skills/morph-code-review/references/review-guidelines.md` — apply confidence ≥ 75, ignore pre-existing violations, include file:line in each finding.
 
-Revise os itens mais importantes por stack. Para review completo, use os skills dedicados.
+Review the most important items by stack. For complete review, use the dedicated skills.
 
-### Se FULLSTACK:
+### If FULLSTACK:
 
-Dispatch dois subagents em paralelo (Task tool):
+Dispatch two subagents in parallel (Task tool):
 
 **Subagent 1 — Backend Review:**
-> Revisor .NET focado. Escopo: APENAS arquivos .cs alterados (git diff main...HEAD).
+> .NET focused reviewer. Scope: ONLY changed .cs files (git diff main...HEAD).
 > Run: `node .claude/skills/morph-code-review/scripts/scan-csharp.mjs --diff`
-> Depois revisar manualmente itens CRITICAL+HIGH do checklist .NET.
-> Aplicar review-guidelines.md: confidence ≥ 75, skip pré-existentes.
-> Output: findings com file:line, ou "✅ Sem CRITICAL/HIGH em backend alterado."
+> Then manually review CRITICAL+HIGH checklist items for .NET.
+> Apply review-guidelines.md: confidence ≥ 75, skip pre-existing.
+> Output: findings with file:line, or "✅ No CRITICAL/HIGH in changed backend."
 
 **Subagent 2 — Frontend Review:**
-> Revisor Next.js focado. Escopo: APENAS arquivos .tsx/.ts alterados (git diff main...HEAD).
+> Next.js focused reviewer. Scope: ONLY changed .tsx/.ts files (git diff main...HEAD).
 > Run: `node .claude/skills/morph-code-review-nextjs/scripts/scan-nextjs.mjs --diff`
-> Depois revisar manualmente itens CRITICAL+HIGH do checklist Next.js.
-> Aplicar review-guidelines.md: confidence ≥ 75, skip pré-existentes.
-> Output: findings com file:line, ou "✅ Sem CRITICAL/HIGH em frontend alterado."
+> Then manually review CRITICAL+HIGH checklist items for Next.js.
+> Apply review-guidelines.md: confidence ≥ 75, skip pre-existing.
+> Output: findings with file:line, or "✅ No CRITICAL/HIGH in changed frontend."
 
-Aguardar ambos. **🚫 BLOCK se algum retornar CRITICAL não resolvido.**
+Wait for both. **🚫 BLOCK if either returns unresolved CRITICAL.**
 
-### Se DOTNET:
+### If DOTNET:
 
-**Itens CRITICAL e HIGH — .NET:**
+**CRITICAL and HIGH items — .NET:**
 
 ```
-[ ] CancellationToken propagado em toda a chain async
-[ ] Sem .Result / .Wait() (deadlock risk)
-[ ] Domain tem zero refs para Infrastructure ou Web
-[ ] Sem circular dependencies
-[ ] Sem empty catch blocks
-[ ] Background ops usam IDbContextFactory + await using
-[ ] Métodos async têm sufixo Async
-[ ] Interfaces prefixadas com I
-[ ] Sem classes > 300 linhas
-[ ] DTOs com nomes descritivos + tipos corretos
+[ ] CancellationToken propagated through the entire async chain
+[ ] No .Result / .Wait() (deadlock risk)
+[ ] Domain has zero refs to Infrastructure or Web
+[ ] No circular dependencies
+[ ] No empty catch blocks
+[ ] Background ops use IDbContextFactory + await using
+[ ] Async methods have Async suffix
+[ ] Interfaces prefixed with I
+[ ] No classes > 300 lines
+[ ] DTOs with descriptive names + correct types
 ```
 
-> Para lista completa: `/morph:code-review`
+> For full list: `/morph:code-review`
 
-### Se NEXTJS:
+### If NEXTJS:
 
-**Itens CRITICAL e HIGH — Next.js:**
+**CRITICAL and HIGH items — Next.js:**
 
 ```
 [ ] node .claude/skills/morph-code-review-nextjs/scripts/scan-nextjs.mjs --diff → 0 CRITICAL
-[ ] File names em kebab-case (user-card.tsx, não UserCard.tsx)
-[ ] 'use client' apenas em componentes com hooks/event handlers
-[ ] Sem useEffect para data fetching → Server Component ou useQuery
-[ ] Zod schema definido primeiro, type derivado com z.infer<>
-[ ] zodResolver conectado ao useForm, useMutation para submit
-[ ] Query key factory usado (userKeys.lists(), não ['users'])
+[ ] File names in kebab-case (user-card.tsx, not UserCard.tsx)
+[ ] 'use client' only in components with hooks/event handlers
+[ ] No useEffect for data fetching → Server Component or useQuery
+[ ] Zod schema defined first, type derived with z.infer<>
+[ ] zodResolver connected to useForm, useMutation for submit
+[ ] Query key factory used (userKeys.lists(), not ['users'])
 [ ] Feature public API via features/{name}/index.ts
-[ ] components/ui/ intocados (shadcn CLI only)
-[ ] Sem any type annotation
+[ ] components/ui/ untouched (shadcn CLI only)
+[ ] No any type annotation
 ```
 
-> Para lista completa: `/morph:code-review-nextjs`
+> For full list: `/morph:code-review-nextjs`
 
-**🚫 BLOCK se qualquer item CRITICAL não estiver resolvido.**
+**🚫 BLOCK if any CRITICAL item is unresolved.**
 
 ---
 
 ## Step 7 — Checkpoint + Recap
 
 ```bash
-# Salvar checkpoint pós-review
+# Save post-review checkpoint
 npx morph-spec checkpoint-save $ARGUMENTS --note "post-implementation review"
 
-# Gerar recap final
+# Generate final recap
 npx morph-spec generate recap $ARGUMENTS
 ```
 
@@ -293,69 +293,69 @@ This skill will:
 
 ## Step 9 — Pre-PR Compliance Checklist
 
-Antes de criar o PR, invoque o checklist de compliance:
+Before creating the PR, invoke the compliance checklist:
 
 ```
 Skill(morph:checklist)
 ```
 
-Este skill verifica: segurança, SEO, performance, acessibilidade e conformidade LGPD.
-**🚫 BLOCK se qualquer item CRITICAL não estiver resolvido.**
+This skill checks: security, SEO, performance, accessibility, and LGPD compliance.
+**🚫 BLOCK if any CRITICAL item is unresolved.**
 
 ---
 
 ## Step 10 — PR Suggestion
 
-Quando todos os steps passarem, sugira o PR:
+When all steps pass, suggest the PR:
 
 ```bash
 gh pr create \
-  --title "feat($ARGUMENTS): <descrição concisa da feature>" \
+  --title "feat($ARGUMENTS): <concise feature description>" \
   --body "$(cat <<'EOF'
 ## Summary
 
-- <principais mudanças implementadas>
-- <tasks concluídas>
+- <main implemented changes>
+- <completed tasks>
 
 ## Test Results
 
-- Build: ✅ passou
-- Tests: ✅ X testes passando
-- Smoke Test: ✅ happy path verificado via Playwright
+- Build: ✅ passed
+- Tests: ✅ X tests passing
+- Smoke Test: ✅ happy path verified via Playwright
 
 ## Screenshots
 
-<!-- Cole os paths dos screenshots salvos em smoke-screenshots/ -->
+<!-- Paste screenshot paths saved in smoke-screenshots/ -->
 
 ## Checklist
 
 - [ ] Automated scans: 0 CRITICAL findings
 - [ ] All tests passing
 - [ ] Smoke test via Playwright: ✅
-- [ ] Code review checklist: CRITICAL + HIGH itens verificados
-- [ ] validate-feature: ✅ passou
-- [ ] Checkpoint salvo
-- [ ] recap.md gerado
+- [ ] Code review checklist: CRITICAL + HIGH items verified
+- [ ] validate-feature: ✅ passed
+- [ ] Checkpoint saved
+- [ ] recap.md generated
 EOF
 )"
 ```
 
 ---
 
-## Resumo dos BLOCKs
+## Block Summary
 
-| Step | Condição de BLOCK |
-|------|-------------------|
-| Step 2 | Qualquer finding CRITICAL nos scans automáticos |
-| Step 3 | Qualquer teste falhando |
-| Step 4 | `validate-feature` falhando |
-| Step 5 | Dev server ativo + smoke test com falha |
-| Step 5 | Dev server não detectado sem confirmação explícita do usuário |
-| Step 6 | Qualquer item CRITICAL não resolvido no checklist manual |
+| Step | Block Condition |
+|------|-----------------|
+| Step 2 | Any CRITICAL finding in automated scans |
+| Step 3 | Any test failing |
+| Step 4 | `validate-feature` failing |
+| Step 5 | Dev server active + smoke test failing |
+| Step 5 | Dev server not detected without explicit user confirmation |
+| Step 6 | Any unresolved CRITICAL item in manual checklist |
 | Step 8 | Tests failing in worktree before merge/PR |
-| Step 9 | Item CRITICAL no `morph:checklist` não resolvido |
+| Step 9 | Unresolved CRITICAL item in `morph:checklist` |
 
-**Todos os BLOCKs devem ser resolvidos antes de criar o PR.**
+**All BLOCKs must be resolved before creating the PR.**
 
 ---