@polymorphism-tech/morph-spec 3.0.1 → 3.2.0

package/src/commands/advance-phase.js

@@ -10,10 +10,12 @@
  */
 
 import chalk from 'chalk';
-import { loadState, saveState, getFeature } from '../lib/state-manager.js';
+import { loadState, saveState, getFeature, getApprovalGate } from '../lib/state-manager.js';
 import { PHASES, validatePhase } from './validate-phase.js';
 import { detectDesignSystem, hasUIAgentsActive } from '../lib/design-system-detector.js';
 import { validateSpec } from '../lib/spec-validator.js';
+import { validateTransition, getPhaseDisplayName } from '../lib/phase-state-machine.js';
+import { validateSpecContent, validateTasksContent, validateFeatureOutputs } from '../lib/validators/content-validator.js';
 
 // Phase order for advancing (skips optional phases unless active)
 const PHASE_ORDER = ['proposal', 'setup', 'uiux', 'design', 'clarify', 'tasks', 'implement', 'sync'];
@@ -96,6 +98,42 @@ export async function advancePhaseCommand(feature, options = {}) {
   const nextPhaseDef = PHASES[nextPhase];
   console.log(chalk.gray('Next Phase:'), nextPhaseDef.name);
 
+  // === GATE 1: State Machine Validation ===
+  // Ensure phase transition is valid (no skipping required phases)
+  if (!options.force) {
+    try {
+      validateTransition(currentPhase, nextPhase);
+    } catch (error) {
+      console.log(chalk.red('\n✗ Invalid phase transition'));
+      console.log(chalk.yellow(error.message));
+      console.log(chalk.gray('\nUse --force to override (not recommended)\n'));
+      process.exit(1);
+    }
+  }
+
+  // === GATE 2: Approval Gate Check ===
+  // Check if current phase requires approval before advancing
+  const approvalGateMap = {
+    'design': 'design',
+    'tasks': 'tasks',
+    'uiux': 'uiux'
+  };
+
+  const requiredGate = approvalGateMap[currentPhase];
+  if (requiredGate && !options.skipApproval) {
+    const gateStatus = getApprovalGate(feature, requiredGate);
+
+    if (!gateStatus || !gateStatus.approved) {
+      console.log(chalk.red(`\n✗ Phase "${currentPhase}" requires approval before advancing`));
+      console.log(chalk.yellow(`\nRun: morph-spec approve ${feature} ${requiredGate}`));
+      console.log(chalk.gray('Or use --skip-approval to bypass (not recommended)\n'));
+      process.exit(1);
+    }
+
+    console.log(chalk.green(`✓ Approval gate "${requiredGate}" passed`));
+  }
+
+  // === GATE 3: Output Requirements ===
   // Validate that current phase requirements are met before advancing
   const validation = validatePhase(feature, nextPhase);
 
@@ -112,8 +150,34 @@ export async function advancePhaseCommand(feature, options = {}) {
     console.log(chalk.yellow(`\n⚠️  ${validation.stateWarning}`));
   }
 
-  // Gate: Validate spec.md and contracts.cs when advancing from design phase
+  // === GATE 4: Content Validation ===
+  // Validate spec.md and contracts.cs when advancing from design phase
   if (currentPhase === 'design' && (nextPhase === 'clarify' || nextPhase === 'tasks')) {
+    // Check spec.md structure and content
+    if (featureData.outputs?.spec?.created) {
+      const specContentValidation = validateSpecContent(featureData.outputs.spec.path);
+
+      if (!specContentValidation.valid) {
+        console.log(chalk.red('\n✗ Spec content validation failed:'));
+        specContentValidation.missing.forEach(section => {
+          console.log(chalk.red(`  - Missing section: ${section}`));
+        });
+        specContentValidation.errors.forEach(error => {
+          console.log(chalk.red(`  - ${error}`));
+        });
+        console.log('');
+        process.exit(1);
+      }
+
+      if (specContentValidation.warnings?.length > 0 && !options.skipWarnings) {
+        console.log(chalk.yellow('\n⚠️  Spec content warnings:'));
+        specContentValidation.warnings.forEach(warning => {
+          console.log(chalk.yellow(`  - ${warning}`));
+        });
+      }
+    }
+
+    // Run existing spec validator (anti-patterns, IaC checks)
     const specValidation = await validateSpec('.', feature);
 
     if (specValidation.errors > 0) {
@@ -135,6 +199,33 @@ export async function advancePhaseCommand(feature, options = {}) {
     }
   }
 
+  // === GATE 5: Tasks Content Validation ===
+  // Validate tasks.json structure when advancing to implement
+  if (currentPhase === 'tasks' && nextPhase === 'implement') {
+    if (featureData.outputs?.tasks?.created) {
+      const tasksContentValidation = validateTasksContent(featureData.outputs.tasks.path);
+
+      if (!tasksContentValidation.valid) {
+        console.log(chalk.red('\n✗ Tasks content validation failed:'));
+        tasksContentValidation.errors.forEach(error => {
+          console.log(chalk.red(`  - ${error}`));
+        });
+        console.log('');
+        process.exit(1);
+      }
+
+      if (tasksContentValidation.warnings?.length > 0 && !options.skipWarnings) {
+        console.log(chalk.yellow('\n⚠️  Tasks content warnings:'));
+        tasksContentValidation.warnings.forEach(warning => {
+          console.log(chalk.yellow(`  - ${warning}`));
+        });
+      }
+
+      // Show tasks stats
+      console.log(chalk.green(`\n✓ Tasks validated: ${tasksContentValidation.stats.totalTasks} total (${tasksContentValidation.stats.regularTasks} tasks + ${tasksContentValidation.stats.checkpoints} checkpoints)`));
+    }
+  }
+
   // Gate: Check design system when advancing to implement with UI agents
   if (nextPhase === 'implement') {
     const gateResult = designSystemGate(feature);

package/src/commands/analyze-blazor-concurrency.js

@@ -1,193 +1,193 @@
-/**
- * analyze-blazor-concurrency command
- *
- * Analyzes Blazor Server code for DbContext concurrency issues.
- *
- * Usage:
- *   morph-spec analyze-blazor-concurrency [path]
- *   morph-spec analyze-blazor-concurrency src/Services --verbose
- */
-
-import { glob } from 'glob';
-import { readFileSync, existsSync, statSync } from 'fs';
-import { join, resolve } from 'path';
-import chalk from 'chalk';
-import ora from 'ora';
-
-import {
-  analyzeConcurrency,
-  countIssues,
-} from '../lib/blazor-concurrency-analyzer.js';
-
-/**
- * Main command handler for analyze-blazor-concurrency.
- *
- * @param {string} [targetPath] - Path to analyze (file or directory)
- * @param {Object} options - Command options
- * @param {boolean} [options.verbose] - Show detailed output
- */
-export async function analyzeBlazorConcurrencyCommand(targetPath, options = {}) {
-  const { verbose = false } = options;
-
-  console.log('');
-  console.log(
-    chalk.cyan('\uD83D\uDD0D Analisando concorrencia DbContext em Blazor Server...')
-  );
-  console.log('');
-
-  // Determine target path
-  const basePath = targetPath ? resolve(targetPath) : process.cwd();
-
-  if (!existsSync(basePath)) {
-    console.log(chalk.red(`\u274C Path not found: ${basePath}`));
-    process.exit(1);
-  }
-
-  const spinner = ora('Scanning for C# files...').start();
-
-  let files = [];
-
-  try {
-    const stats = statSync(basePath);
-
-    if (stats.isFile()) {
-      if (basePath.endsWith('.cs')) {
-        files = [basePath];
-      } else {
-        spinner.fail('File must be .cs');
-        process.exit(1);
-      }
-    } else {
-      // Find all C# files (services, repositories, handlers)
-      const pattern = join(basePath, '**/*.cs');
-      files = await glob(pattern, {
-        ignore: [
-          '**/node_modules/**',
-          '**/bin/**',
-          '**/obj/**',
-          '**/Migrations/**',
-        ],
-        windowsPathsNoEscape: true,
-      });
-    }
-
-    spinner.succeed(`Found ${files.length} C# file(s)`);
-  } catch (error) {
-    spinner.fail(`Error scanning files: ${error.message}`);
-    process.exit(1);
-  }
-
-  if (files.length === 0) {
-    console.log(chalk.yellow('\n\u26A0\uFE0F No C# files found to analyze'));
-    return;
-  }
-
-  // Analyze each file
-  const allIssues = [];
-  const fileResults = [];
-
-  for (const file of files) {
-    try {
-      const content = readFileSync(file, 'utf-8');
-      const issues = analyzeConcurrency(content, file);
-
-      if (issues.length > 0) {
-        allIssues.push(...issues);
-        fileResults.push({ file, issues });
-      }
-    } catch (error) {
-      if (verbose) {
-        console.log(chalk.red(`\u274C Error reading ${file}: ${error.message}`));
-      }
-    }
-  }
-
-  // Output results
-  console.log('');
-
-  if (allIssues.length === 0) {
-    console.log(
-      chalk.green(
-        '\u2705 Nenhum problema de concorrencia detectado!'
-      )
-    );
-    console.log(
-      chalk.gray(
-        '   Dica: Certifique-se de usar IDbContextFactory para operacoes background.'
-      )
-    );
-    console.log('');
-    return;
-  }
-
-  // Display issues
-  if (verbose) {
-    fileResults.forEach(({ file, issues }) => {
-      console.log(chalk.white.bold(`\n${file}`));
-      console.log(chalk.gray('-'.repeat(60)));
-
-      issues.forEach((issue) => {
-        const icon =
-          issue.type === 'error'
-            ? '\u274C'
-            : issue.type === 'warning'
-            ? '\u26A0\uFE0F'
-            : '\u2139\uFE0F';
-
-        console.log(`${icon} ${issue.message}`);
-        if (issue.suggestion) {
-          console.log(chalk.gray(`   \u2192 ${issue.suggestion}`));
-        }
-        if (issue.line) {
-          console.log(chalk.dim(`   Linha: ${issue.line}`));
-        }
-        if (issue.code) {
-          console.log(chalk.dim(`   Codigo: ${issue.code}`));
-        }
-        console.log('');
-      });
-    });
-  } else {
-    allIssues.forEach((issue) => {
-      const icon =
-        issue.type === 'error'
-          ? '\u274C'
-          : issue.type === 'warning'
-          ? '\u26A0\uFE0F'
-          : '\u2139\uFE0F';
-
-      const location = issue.line ? `${issue.file}:${issue.line}` : issue.file;
-
-      console.log(`${icon} ${issue.message}`);
-      if (issue.suggestion) {
-        console.log(chalk.gray(`   \u2192 ${issue.suggestion}`));
-      }
-      console.log(chalk.dim(`   ${location}`));
-      console.log('');
-    });
-  }
-
-  // Summary
-  const { errors, warnings, infos } = countIssues(allIssues);
-  const summaryColor = errors > 0 ? chalk.red : chalk.yellow;
-
-  console.log(chalk.gray('-'.repeat(60)));
-  console.log(
-    summaryColor(
-      `\n${files.length} arquivo(s) analisado(s) | ${errors} erro(s) | ${warnings} warning(s) | ${infos} info(s)\n`
-    )
-  );
-
-  // Recommendation
-  if (errors > 0) {
-    console.log(
-      chalk.cyan(
-        '\uD83D\uDCD6 Consulte: framework/standards/blazor-efcore.md para padroes corretos'
-      )
-    );
-    console.log('');
-    process.exit(1);
-  }
-}
-
-export default analyzeBlazorConcurrencyCommand;
+/**
+ * analyze-blazor-concurrency command
+ *
+ * Analyzes Blazor Server code for DbContext concurrency issues.
+ *
+ * Usage:
+ *   morph-spec analyze-blazor-concurrency [path]
+ *   morph-spec analyze-blazor-concurrency src/Services --verbose
+ */
+
+import { glob } from 'glob';
+import { readFileSync, existsSync, statSync } from 'fs';
+import { join, resolve } from 'path';
+import chalk from 'chalk';
+import ora from 'ora';
+
+import {
+  analyzeConcurrency,
+  countIssues,
+} from '../lib/blazor-concurrency-analyzer.js';
+
+/**
+ * Main command handler for analyze-blazor-concurrency.
+ *
+ * @param {string} [targetPath] - Path to analyze (file or directory)
+ * @param {Object} options - Command options
+ * @param {boolean} [options.verbose] - Show detailed output
+ */
+export async function analyzeBlazorConcurrencyCommand(targetPath, options = {}) {
+  const { verbose = false } = options;
+
+  console.log('');
+  console.log(
+    chalk.cyan('\uD83D\uDD0D Analisando concorrencia DbContext em Blazor Server...')
+  );
+  console.log('');
+
+  // Determine target path
+  const basePath = targetPath ? resolve(targetPath) : process.cwd();
+
+  if (!existsSync(basePath)) {
+    console.log(chalk.red(`\u274C Path not found: ${basePath}`));
+    process.exit(1);
+  }
+
+  const spinner = ora('Scanning for C# files...').start();
+
+  let files = [];
+
+  try {
+    const stats = statSync(basePath);
+
+    if (stats.isFile()) {
+      if (basePath.endsWith('.cs')) {
+        files = [basePath];
+      } else {
+        spinner.fail('File must be .cs');
+        process.exit(1);
+      }
+    } else {
+      // Find all C# files (services, repositories, handlers)
+      const pattern = join(basePath, '**/*.cs');
+      files = await glob(pattern, {
+        ignore: [
+          '**/node_modules/**',
+          '**/bin/**',
+          '**/obj/**',
+          '**/Migrations/**',
+        ],
+        windowsPathsNoEscape: true,
+      });
+    }
+
+    spinner.succeed(`Found ${files.length} C# file(s)`);
+  } catch (error) {
+    spinner.fail(`Error scanning files: ${error.message}`);
+    process.exit(1);
+  }
+
+  if (files.length === 0) {
+    console.log(chalk.yellow('\n\u26A0\uFE0F No C# files found to analyze'));
+    return;
+  }
+
+  // Analyze each file
+  const allIssues = [];
+  const fileResults = [];
+
+  for (const file of files) {
+    try {
+      const content = readFileSync(file, 'utf-8');
+      const issues = analyzeConcurrency(content, file);
+
+      if (issues.length > 0) {
+        allIssues.push(...issues);
+        fileResults.push({ file, issues });
+      }
+    } catch (error) {
+      if (verbose) {
+        console.log(chalk.red(`\u274C Error reading ${file}: ${error.message}`));
+      }
+    }
+  }
+
+  // Output results
+  console.log('');
+
+  if (allIssues.length === 0) {
+    console.log(
+      chalk.green(
+        '\u2705 Nenhum problema de concorrencia detectado!'
+      )
+    );
+    console.log(
+      chalk.gray(
+        '   Dica: Certifique-se de usar IDbContextFactory para operacoes background.'
+      )
+    );
+    console.log('');
+    return;
+  }
+
+  // Display issues
+  if (verbose) {
+    fileResults.forEach(({ file, issues }) => {
+      console.log(chalk.white.bold(`\n${file}`));
+      console.log(chalk.gray('-'.repeat(60)));
+
+      issues.forEach((issue) => {
+        const icon =
+          issue.type === 'error'
+            ? '\u274C'
+            : issue.type === 'warning'
+            ? '\u26A0\uFE0F'
+            : '\u2139\uFE0F';
+
+        console.log(`${icon} ${issue.message}`);
+        if (issue.suggestion) {
+          console.log(chalk.gray(`   \u2192 ${issue.suggestion}`));
+        }
+        if (issue.line) {
+          console.log(chalk.dim(`   Linha: ${issue.line}`));
+        }
+        if (issue.code) {
+          console.log(chalk.dim(`   Codigo: ${issue.code}`));
+        }
+        console.log('');
+      });
+    });
+  } else {
+    allIssues.forEach((issue) => {
+      const icon =
+        issue.type === 'error'
+          ? '\u274C'
+          : issue.type === 'warning'
+          ? '\u26A0\uFE0F'
+          : '\u2139\uFE0F';
+
+      const location = issue.line ? `${issue.file}:${issue.line}` : issue.file;
+
+      console.log(`${icon} ${issue.message}`);
+      if (issue.suggestion) {
+        console.log(chalk.gray(`   \u2192 ${issue.suggestion}`));
+      }
+      console.log(chalk.dim(`   ${location}`));
+      console.log('');
+    });
+  }
+
+  // Summary
+  const { errors, warnings, infos } = countIssues(allIssues);
+  const summaryColor = errors > 0 ? chalk.red : chalk.yellow;
+
+  console.log(chalk.gray('-'.repeat(60)));
+  console.log(
+    summaryColor(
+      `\n${files.length} arquivo(s) analisado(s) | ${errors} erro(s) | ${warnings} warning(s) | ${infos} info(s)\n`
+    )
+  );
+
+  // Recommendation
+  if (errors > 0) {
+    console.log(
+      chalk.cyan(
+        '\uD83D\uDCD6 Consulte: framework/standards/blazor-efcore.md para padroes corretos'
+      )
+    );
+    console.log('');
+    process.exit(1);
+  }
+}
+
+export default analyzeBlazorConcurrencyCommand;