@polka-codes/core 0.9.3 → 0.9.5

package/dist/_tsup-dts-rollup.d.ts

@@ -628,6 +628,7 @@ declare const _default_7: {
             path: z.ZodString;
             maxCount: z.ZodDefault<z.ZodOptional<z.ZodCoercedNumber<unknown>>>;
             recursive: z.ZodPipe<z.ZodTransform<unknown, unknown>, z.ZodDefault<z.ZodOptional<z.ZodBoolean>>>;
+            includeIgnored: z.ZodPipe<z.ZodTransform<unknown, unknown>, z.ZodDefault<z.ZodOptional<z.ZodBoolean>>>;
         }, z.core.$strip>;
         readonly permissionLevel: PermissionLevel.Read;
     }, FilesystemProvider>;
@@ -638,6 +639,7 @@ declare const _default_7: {
         path: z.ZodString;
         maxCount: z.ZodDefault<z.ZodOptional<z.ZodCoercedNumber<unknown>>>;
         recursive: z.ZodPipe<z.ZodTransform<unknown, unknown>, z.ZodDefault<z.ZodOptional<z.ZodBoolean>>>;
+        includeIgnored: z.ZodPipe<z.ZodTransform<unknown, unknown>, z.ZodDefault<z.ZodOptional<z.ZodBoolean>>>;
     }, z.core.$strip>;
     permissionLevel: PermissionLevel.Read;
 };
@@ -652,6 +654,7 @@ declare const _default_8: {
         readonly description: "Request to read the contents of one or multiple files at the specified paths. Use comma separated paths to read multiple files. Use this when you need to examine the contents of an existing file you do not know the contents of, for example to analyze code, review text files, or extract information from configuration files. May not be suitable for other types of binary files, as it returns the raw content as a string. Try to list all the potential files are relevent to the task, and then use this tool to read all the relevant files.";
         readonly parameters: z.ZodObject<{
             path: z.ZodPipe<z.ZodTransform<string[], unknown>, z.ZodArray<z.ZodString>>;
+            includeIgnored: z.ZodPipe<z.ZodTransform<unknown, unknown>, z.ZodDefault<z.ZodOptional<z.ZodBoolean>>>;
         }, z.core.$strip>;
         readonly permissionLevel: PermissionLevel.Read;
     }, FilesystemProvider>;
@@ -660,6 +663,7 @@ declare const _default_8: {
     description: "Request to read the contents of one or multiple files at the specified paths. Use comma separated paths to read multiple files. Use this when you need to examine the contents of an existing file you do not know the contents of, for example to analyze code, review text files, or extract information from configuration files. May not be suitable for other types of binary files, as it returns the raw content as a string. Try to list all the potential files are relevent to the task, and then use this tool to read all the relevant files.";
     parameters: z.ZodObject<{
         path: z.ZodPipe<z.ZodTransform<string[], unknown>, z.ZodArray<z.ZodString>>;
+        includeIgnored: z.ZodPipe<z.ZodTransform<unknown, unknown>, z.ZodDefault<z.ZodOptional<z.ZodBoolean>>>;
     }, z.core.$strip>;
     permissionLevel: PermissionLevel.Read;
 };
@@ -738,7 +742,7 @@ export declare const default_alias_3: {
 export declare const default_alias_4: {
     readonly name: "reviewDiff";
     readonly description: "Reviews a git diff";
-    readonly prompt: "\n# Code Review Prompt\n\nYou are a senior software engineer reviewing code changes.\n\n## Viewing Changes\n- Use **git_diff** to inspect code.\n  - **Pull request**: use the provided commit range.\n  - **Local changes**: diff staged or unstaged files.\n- If a pull request is present you may receive:\n  - <pr_title>\n  - <pr_description>\n  - <commit_messages>\n- A <review_instructions> tag tells you the focus of the review.\n\n## Focus Areas\n- Readability and maintainability\n- Correctness, edge cases, potential bugs\n- Performance implications\n- Clarity of intent\n- Best-practice adherence\n\n## Output Format\nDo **not** include praise or positive feedback. Ignore generated files such as lock files.\n\nReturn your review as a JSON object inside a ```json block, wrapped like:\n<tool_attempt_completion>\n<tool_parameter_result>\n```json\n{\n  \"overview\": \"Summary of overall concerns.\",\n  \"specificReviews\": [\n    {\n      \"file\": \"path/filename.ext\",\n      \"lines\": \"N or N-M\",\n      \"review\": \"Describe the issue and actionable fix or improvement.\"\n    }\n  ]\n}\n```\n</tool_parameter_result>\n</tool_attempt_completion>\n";
+    readonly prompt: "\n# Code Review Prompt\n\nYou are a senior software engineer reviewing code changes.\n\n## Critical Instructions\n**ONLY review the actual changes shown in the diff.** Do not comment on existing code that wasn't modified.\n\n## Viewing Changes\n- **Use git_diff** to inspect the actual code changes for each relevant file.\n  - **Pull request**: use the provided commit range for the git_diff tool.\n  - **Local changes**: diff staged or unstaged files using the git_diff tool.\n- If a pull request is present you may receive:\n  - <pr_title>\n  - <pr_description>\n  - <commit_messages>\n- A <review_instructions> tag tells you the focus of the review.\n- File status information is provided in <file_status> - use this to understand which files were modified, added, deleted, or renamed.\n\n## Review Guidelines\nFocus exclusively on the changed lines (+ additions, - deletions, modified lines):\n- **Specific issues**: Point to exact problems in the changed code with line references\n- **Actionable fixes**: Provide concrete solutions, not vague suggestions\n- **Clear reasoning**: Explain why each issue matters and how to fix it\n- **Avoid generic advice**: No generic suggestions like \"add more tests\", \"improve documentation\", or \"follow best practices\" unless directly related to a specific problem in the diff\n\n## What NOT to review\n- Existing unchanged code\n- Overall project structure or architecture (unless directly impacted by changes)\n- Generic best practices unrelated to the specific changes\n- Missing features or functionality not part of this diff\n\n## Output Format\nDo **not** include praise or positive feedback. Ignore generated files such as lock files.\nOnly include reviews for actual issues found in the changed code.\n\nReturn your review as a JSON object inside a ```json block, wrapped like:\n<tool_attempt_completion>\n<tool_parameter_result>\n```json\n{\n  \"overview\": \"Summary of specific issues found in the diff changes, or 'No issues found' if the changes look good.\",\n  \"specificReviews\": [\n    {\n      \"file\": \"path/filename.ext\",\n      \"lines\": \"N or N-M\",\n      \"review\": \"Specific issue with the changed code and exact actionable fix.\"\n    }\n  ]\n}\n```\n</tool_parameter_result>\n</tool_attempt_completion>\n";
     readonly formatInput: (params: Input_2) => string;
     readonly parseOutput: (output: string) => Output_2;
     readonly agent: (options: SharedAgentOptions) => AnalyzerAgent;
@@ -807,11 +811,11 @@ export { ExitReason as ExitReason_alias_1 }
 export { ExitReason as ExitReason_alias_2 }
 
 declare type FilesystemProvider = {
-    readFile?: (path: string) => Promise<string | undefined>;
+    readFile?: (path: string, includeIgnored: boolean) => Promise<string | undefined>;
     writeFile?: (path: string, content: string) => Promise<void>;
     removeFile?: (path: string) => Promise<void>;
     renameFile?: (sourcePath: string, targetPath: string) => Promise<void>;
-    listFiles?: (path: string, recursive: boolean, maxCount: number) => Promise<[string[], boolean]>;
+    listFiles?: (path: string, recursive: boolean, maxCount: number, includeIgnored: boolean) => Promise<[string[], boolean]>;
     searchFiles?: (path: string, regex: string, filePattern: string) => Promise<string[]>;
 };
 export { FilesystemProvider }
@@ -963,6 +967,10 @@ declare type Input_2 = {
     commitMessages?: string;
     commitRange?: string;
     staged?: boolean;
+    changedFiles?: Array<{
+        path: string;
+        status: string;
+    }>;
 };
 
 declare type InteractionProvider = {
@@ -1019,11 +1027,11 @@ export { makeTool }
 export { makeTool as makeTool_alias_1 }
 
 declare class MockProvider implements ToolProvider {
-    readFile(_path: string): Promise<string>;
+    readFile(_path: string, _includeIgnored?: boolean): Promise<string>;
     writeFile(_path: string, _content: string): Promise<void>;
     removeFile(_path: string): Promise<void>;
     renameFile(_sourcePath: string, _targetPath: string): Promise<void>;
-    listFiles(_path: string, _recursive: boolean, _maxCount: number): Promise<[string[], boolean]>;
+    listFiles(_path: string, _recursive: boolean, _maxCount: number, _includeIgnored?: boolean): Promise<[string[], boolean]>;
     searchFiles(_path: string, _regex: string, _filePattern: string): Promise<string[]>;
     executeCommand(_command: string, _needApprove: boolean): Promise<{
         stdout: string;
@@ -1197,6 +1205,10 @@ declare const reviewDiff: (options: SharedAgentOptions, params: {
     commitMessages?: string;
     commitRange?: string;
     staged?: boolean;
+    changedFiles?: Array<{
+        path: string;
+        status: string;
+    }>;
 }) => Promise<{
     overview: string;
     specificReviews: {
@@ -1563,6 +1575,7 @@ export declare const toolInfo_alias_7: {
         path: z.ZodString;
         maxCount: z.ZodDefault<z.ZodOptional<z.ZodCoercedNumber<unknown>>>;
         recursive: z.ZodPipe<z.ZodTransform<unknown, unknown>, z.ZodDefault<z.ZodOptional<z.ZodBoolean>>>;
+        includeIgnored: z.ZodPipe<z.ZodTransform<unknown, unknown>, z.ZodDefault<z.ZodOptional<z.ZodBoolean>>>;
     }, z.core.$strip>;
     readonly permissionLevel: PermissionLevel.Read;
 };
@@ -1572,6 +1585,7 @@ export declare const toolInfo_alias_8: {
     readonly description: "Request to read the contents of one or multiple files at the specified paths. Use comma separated paths to read multiple files. Use this when you need to examine the contents of an existing file you do not know the contents of, for example to analyze code, review text files, or extract information from configuration files. May not be suitable for other types of binary files, as it returns the raw content as a string. Try to list all the potential files are relevent to the task, and then use this tool to read all the relevant files.";
     readonly parameters: z.ZodObject<{
         path: z.ZodPipe<z.ZodTransform<string[], unknown>, z.ZodArray<z.ZodString>>;
+        includeIgnored: z.ZodPipe<z.ZodTransform<unknown, unknown>, z.ZodDefault<z.ZodOptional<z.ZodBoolean>>>;
     }, z.core.$strip>;
     readonly permissionLevel: PermissionLevel.Read;
 };

package/dist/index.js

@@ -458,7 +458,15 @@ var toolInfo7 = {
         if (lower === "true") return true;
       }
       return val;
-    }, z7.boolean().optional().default(true)).describe("Whether to list files recursively. Use true for recursive listing, false or omit for top-level only.").meta({ usageValue: "true or false (optional)" })
+    }, z7.boolean().optional().default(true)).describe("Whether to list files recursively. Use true for recursive listing, false or omit for top-level only.").meta({ usageValue: "true or false (optional)" }),
+    includeIgnored: z7.preprocess((val) => {
+      if (typeof val === "string") {
+        const lower = val.toLowerCase();
+        if (lower === "false") return false;
+        if (lower === "true") return true;
+      }
+      return val;
+    }, z7.boolean().optional().default(false)).describe("Whether to include ignored files. Use true to include files ignored by .gitignore.").meta({ usageValue: "true or false (optional)" })
   }).meta({
     examples: [
       {
@@ -479,8 +487,8 @@ var handler7 = async (provider, args) => {
       message: "Not possible to list files. Abort."
     };
   }
-  const { path, maxCount, recursive } = toolInfo7.parameters.parse(args);
-  const [files, limitReached] = await provider.listFiles(path, recursive, maxCount);
+  const { path, maxCount, recursive, includeIgnored } = toolInfo7.parameters.parse(args);
+  const [files, limitReached] = await provider.listFiles(path, recursive, maxCount, includeIgnored);
   return {
     type: "Reply" /* Reply */,
     message: `<list_files_path>${path}</list_files_path>
@@ -509,7 +517,15 @@ var toolInfo8 = {
       if (!val) return [];
       const values = Array.isArray(val) ? val : [val];
       return values.flatMap((i) => typeof i === "string" ? i.split(",") : []).filter((s) => s.length > 0);
-    }, z8.array(z8.string())).describe("The path of the file to read").meta({ usageValue: "Comma separated paths here" })
+    }, z8.array(z8.string())).describe("The path of the file to read").meta({ usageValue: "Comma separated paths here" }),
+    includeIgnored: z8.preprocess((val) => {
+      if (typeof val === "string") {
+        const lower = val.toLowerCase();
+        if (lower === "false") return false;
+        if (lower === "true") return true;
+      }
+      return val;
+    }, z8.boolean().optional().default(false)).describe("Whether to include ignored files. Use true to include files ignored by .gitignore.").meta({ usageValue: "true or false (optional)" })
   }).meta({
     examples: [
       {
@@ -535,10 +551,10 @@ var handler8 = async (provider, args) => {
       message: "Not possible to read file. Abort."
     };
   }
-  const { path: paths } = toolInfo8.parameters.parse(args);
+  const { path: paths, includeIgnored } = toolInfo8.parameters.parse(args);
   const resp = [];
   for (const path of paths) {
-    const fileContent = await provider.readFile(path);
+    const fileContent = await provider.readFile(path, includeIgnored);
     if (!fileContent) {
       resp.push(`<read_file_file_content path="${path}" file_not_found="true" />`);
     } else {
@@ -857,7 +873,7 @@ var handler11 = async (provider, args) => {
   }
   try {
     const { path, diff } = toolInfo11.parameters.parse(args);
-    const fileContent = await provider.readFile(path);
+    const fileContent = await provider.readFile(path, false);
     if (fileContent == null) {
       return {
         type: "Error" /* Error */,
@@ -1037,7 +1053,7 @@ var writeToFile_default = {
 
 // src/tools/provider.ts
 var MockProvider = class {
-  async readFile(_path) {
+  async readFile(_path, _includeIgnored) {
     return "mock content";
   }
   async writeFile(_path, _content) {
@@ -1049,7 +1065,7 @@ var MockProvider = class {
   async renameFile(_sourcePath, _targetPath) {
     return;
   }
-  async listFiles(_path, _recursive, _maxCount) {
+  async listFiles(_path, _recursive, _maxCount, _includeIgnored) {
     return [["mock-file.txt"], false];
   }
   async searchFiles(_path, _regex, _filePattern) {
@@ -1811,23 +1827,32 @@ ${instance.prompt}`;
     const requestTimeoutSeconds = this.config.requestTimeoutSeconds ?? 90;
     let respMessages = [];
     for (let i = 0; i < retryCount; i++) {
+      if (this.#aborted) {
+        break;
+      }
       respMessages = [];
       let timeout;
+      let requestAbortController;
+      requestAbortController = new AbortController();
+      this.#abortController = requestAbortController;
       const resetTimeout = () => {
         if (timeout) {
           clearTimeout(timeout);
         }
-        if (requestTimeoutSeconds > 0) {
+        if (requestTimeoutSeconds > 0 && requestAbortController) {
           timeout = setTimeout(() => {
-            console.debug(`No data received for ${requestTimeoutSeconds} seconds. Aborting request.`);
-            this.abort();
+            console.debug(
+              `Request timeout after ${requestTimeoutSeconds} seconds. Canceling current request attempt ${i + 1}/${retryCount}.`
+            );
+            requestAbortController?.abort();
           }, requestTimeoutSeconds * 1e3);
         }
       };
-      this.#abortController = new AbortController();
       try {
+        resetTimeout();
         const streamTextOptions = {
           model: this.ai,
+          temperature: 0,
           messages,
           providerOptions: this.config.parameters?.providerOptions,
           onChunk: async ({ chunk }) => {
@@ -1847,7 +1872,7 @@ ${instance.prompt}`;
           onError: async (error) => {
             console.error("Error in stream:", error);
           },
-          abortSignal: this.#abortController.signal
+          abortSignal: requestAbortController.signal
         };
         if (this.config.toolFormat === "native") {
           streamTextOptions.tools = this.#toolSet;
@@ -1860,11 +1885,19 @@ ${instance.prompt}`;
         });
         const resp = await stream.response;
         respMessages = resp.messages;
+        if (timeout) {
+          clearTimeout(timeout);
+          timeout = void 0;
+        }
       } catch (error) {
         if (error instanceof Error && error.name === "AbortError") {
-          break;
+          if (this.#aborted) {
+            break;
+          }
+          console.debug(`Request attempt ${i + 1} timed out, will retry`);
+        } else {
+          console.error("Error in stream:", error);
         }
-        console.error("Error in stream:", error);
       } finally {
         if (timeout) {
           clearTimeout(timeout);
@@ -1876,16 +1909,25 @@ ${instance.prompt}`;
       if (this.#aborted) {
         break;
       }
-      console.debug(`Retrying request ${i + 1} of ${retryCount}`);
+      if (i < retryCount - 1) {
+        console.debug(`Retrying request ${i + 2} of ${retryCount}`);
+      }
     }
     if (respMessages.length === 0) {
       if (this.#aborted) {
         return [];
       }
-      throw new Error("No assistant message received");
+      throw new Error("No assistant message received after all retry attempts");
     }
     this.#messages.push(...respMessages);
     if (this.config.toolFormat === "native") {
+      const assistantText = respMessages.map((msg) => {
+        if (typeof msg.content === "string") {
+          return msg.content;
+        }
+        return msg.content.map((part) => part.type === "text" || part.type === "reasoning" ? part.text : "").join("");
+      }).join("\n");
+      await this.#callback({ kind: "EndRequest" /* EndRequest */, agent: this, message: assistantText });
       return respMessages.flatMap((msg) => {
         if (msg.role === "assistant") {
           const content = msg.content;
@@ -1893,7 +1935,7 @@ ${instance.prompt}`;
             return [{ type: "text", content }];
           }
           return content.flatMap((part) => {
-            if (part.type === "text") {
+            if (part.type === "text" || part.type === "reasoning") {
               return [{ type: "text", content: part.text }];
             }
             if (part.type === "tool-call") {
@@ -3360,37 +3402,48 @@ var prompt5 = `
 
 You are a senior software engineer reviewing code changes.
 
+## Critical Instructions
+**ONLY review the actual changes shown in the diff.** Do not comment on existing code that wasn't modified.
+
 ## Viewing Changes
-- Use **git_diff** to inspect code.
-  - **Pull request**: use the provided commit range.
-  - **Local changes**: diff staged or unstaged files.
+- **Use git_diff** to inspect the actual code changes for each relevant file.
+  - **Pull request**: use the provided commit range for the git_diff tool.
+  - **Local changes**: diff staged or unstaged files using the git_diff tool.
 - If a pull request is present you may receive:
   - <pr_title>
   - <pr_description>
   - <commit_messages>
 - A <review_instructions> tag tells you the focus of the review.
+- File status information is provided in <file_status> - use this to understand which files were modified, added, deleted, or renamed.
+
+## Review Guidelines
+Focus exclusively on the changed lines (+ additions, - deletions, modified lines):
+- **Specific issues**: Point to exact problems in the changed code with line references
+- **Actionable fixes**: Provide concrete solutions, not vague suggestions
+- **Clear reasoning**: Explain why each issue matters and how to fix it
+- **Avoid generic advice**: No generic suggestions like "add more tests", "improve documentation", or "follow best practices" unless directly related to a specific problem in the diff
 
-## Focus Areas
-- Readability and maintainability
-- Correctness, edge cases, potential bugs
-- Performance implications
-- Clarity of intent
-- Best-practice adherence
+## What NOT to review
+- Existing unchanged code
+- Overall project structure or architecture (unless directly impacted by changes)
+- Generic best practices unrelated to the specific changes
+- Missing features or functionality not part of this diff
 
 ## Output Format
 Do **not** include praise or positive feedback. Ignore generated files such as lock files.
+Only include reviews for actual issues found in the changed code.
 
 Return your review as a JSON object inside a \`\`\`json block, wrapped like:
 <tool_attempt_completion>
 <tool_parameter_result>
 \`\`\`json
 {
-  "overview": "Summary of overall concerns.",
+  "overview": "Summary of specific issues found in the diff changes, or 'No issues found' if the changes look good.",
   "specificReviews": [
     {
       "file": "path/filename.ext",
       "lines": "N or N-M",
-      "review": "Describe the issue and actionable fix or improvement."
+      "review": "Specific issue with the changed code and exact actionable fix."
     }
   ]
 }
@@ -3418,14 +3471,20 @@ ${params.pullRequestDescription}
       parts.push(`<commit_messages>
 ${params.commitMessages}
 </commit_messages>`);
+    }
+    if (params.changedFiles && params.changedFiles.length > 0) {
+      const fileList = params.changedFiles.map((file) => `${file.status}: ${file.path}`).join("\n");
+      parts.push(`<file_status>
+${fileList}
+</file_status>`);
     }
     let instructions = "";
     if (params.commitRange) {
-      instructions = `Review the pull request. Get the diff using the git_diff tool with the commit range '${params.commitRange}'.`;
+      instructions = `Review the pull request. Use the git_diff tool with commit range '${params.commitRange}' to inspect the actual code changes. File status information is already provided above.`;
     } else if (params.staged) {
-      instructions = "Review the staged changes. Get the diff using the git_diff tool with staged: true.";
+      instructions = "Review the staged changes. Use the git_diff tool with staged: true to inspect the actual code changes. File status information is already provided above.";
     } else {
-      instructions = "Review the unstaged changes. Get the diff using the git_diff tool.";
+      instructions = "Review the unstaged changes. Use the git_diff tool to inspect the actual code changes. File status information is already provided above.";
     }
     parts.push(`<review_instructions>
 ${instructions}
@@ -3459,6 +3518,7 @@ ${output}`,
 var executeTool = async (definition, ai, params, usageMeter) => {
   const resp = await generateText({
     model: ai,
+    temperature: 0,
     system: definition.prompt,
     messages: [
       {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@polka-codes/core",
-  "version": "0.9.3",
+  "version": "0.9.5",
   "license": "AGPL-3.0",
   "author": "github@polka.codes",
   "type": "module",