@polderlabs/bizar 6.2.5 → 6.3.0

package/plugins/bizar/tests/tools/bg-spawn-http.test.ts

@@ -1,233 +0,0 @@
-/**
- * bg-spawn-http.test.ts
- *
- * v5.5.1 — Tests that `bizar_spawn_background` delegates to the dashboard
- * via `POST /api/background` (instead of spawning `cline run`
- * subprocesses directly). The dashboard POST is mocked so we don't need
- * a live server.
- *
- * The "input-validation" surface (Odin-only check, model parsing,
- * timeoutMs clamping, delegation wrapper) is already covered by the
- * pre-existing bg-spawn.test.ts and bg-spawn-delegation.test.ts. This
- * test focuses on the NEW path: HTTP delegation.
- */
-
-import { describe, it, expect } from "bun:test";
-
-import {
-  createBgSpawnTool,
-  PRIMARY_AGENTS,
-  buildDelegationPrompt,
-  needsDelegationWrapper,
-} from "../../src/tools/bg-spawn";
-
-import type { Logger } from "../../src/logger";
-
-const silentLogger: Logger = {
-  debug() {},
-  info() {},
-  warn() {},
-  error() {},
-  log() {},
-};
-
-function decode(result: unknown): any {
-  // Cline SDK port (Phase 2): the tool now returns structured objects
-  // directly instead of `{ output: JSON.stringify(...) }`. The agent
-  // runtime wraps the returned value in AgentToolResult, but
-  // `tool.execute()` (called directly in tests) hands the structured
-  // object back as-is.
-  if (typeof result === "string") return JSON.parse(result);
-  if (result && typeof result === "object" && "output" in result) {
-    const out = (result as { output: unknown }).output;
-    if (typeof out === "string") return JSON.parse(out);
-    return out;
-  }
-  return result;
-}
-
-/** Capture the dashboard POST so the test can assert its shape. */
-function makeCapturingDashboard(returnValue: any) {
-  const calls: Array<{ url: string; body: any }> = [];
-  const post = async (
-    url: string,
-    init: { headers: Record<string, string>; body: string },
-  ) => {
-    calls.push({ url, body: JSON.parse(init.body) });
-    return {
-      ok: true,
-      status: 200,
-      json: async () => returnValue,
-    };
-  };
-  return { calls, post };
-}
-
-/** Minimal mock InstanceManager — just enough for add/get/update. */
-function makeInstanceManager() {
-  const instances = new Map<string, any>();
-  return {
-    add: async (draft: any) => {
-      instances.set(draft.instanceId, { ...draft, status: "pending" });
-      return { ...draft, status: "pending" };
-    },
-    get: async (id: string) => instances.get(id) ?? null,
-    update: async (id: string, patch: any) => {
-      const cur = instances.get(id);
-      if (!cur) return;
-      const next = { ...cur, ...patch };
-      instances.set(id, next);
-    },
-    _instances: instances,
-  };
-}
-
-describe("bizar_spawn_background — HTTP delegation (v5.5.1)", () => {
-  it("rejects non-Odin callers", async () => {
-    const mgr = makeInstanceManager();
-    const tool = createBgSpawnTool({
-      instanceManager: mgr as any,
-      worktree: "/tmp",
-      logger: silentLogger,
-    });
-    const r = await tool.execute(
-      { agent: "mimir", prompt: "hi" } as any,
-      { metadata: { parentAgent: "frigg" } } as any,
-    );
-    expect(decode(r).error).toContain("Only Odin");
-  });
-
-  it("POSTs to /api/background on the dashboard with the right shape", async () => {
-    const mgr = makeInstanceManager();
-    const { calls, post } = makeCapturingDashboard({
-      instanceId: "bgr_dash_xyz",
-      sessionId: "ses_xyz",
-      status: "running",
-      liveSession: true,
-    });
-    const tool = createBgSpawnTool({
-      instanceManager: mgr as any,
-      worktree: "/tmp/worktree",
-      logger: silentLogger,
-      _dashboardPost: post,
-    });
-    const r = await tool.execute(
-      {
-        agent: "mimir",
-        prompt: "research X",
-        model: "minimax/minimax-m3",
-        timeoutMs: 60_000,
-      } as any,
-      { metadata: { parentAgent: "odin" }, sessionID: "ses_parent" } as any,
-    );
-    expect(calls).toHaveLength(1);
-    const call = calls[0]!;
-    expect(call.url).toContain("/api/background");
-    // URL should NOT include "/api/background/:id" — it's the create endpoint.
-    expect(call.url).not.toMatch(/\/api\/background\/bgr_/);
-    expect(call.body.agent).toBe("mimir");
-    expect(call.body.worktree).toBe("/tmp/worktree");
-    expect(call.body.timeoutMs).toBe(60_000);
-    expect(call.body.model).toBe("minimax/minimax-m3");
-    // For subagents, the prompt is the delegation wrapper.
-    expect(call.body.prompt).toContain("Requested subagent: mimir");
-    expect(call.body.prompt).toContain("research X");
-    expect(call.body.tags).toContain("spawned-by:odin");
-    const out = decode(r);
-    expect(out.instanceId).toBeDefined();
-    expect(out.dashboardInstanceId).toBe("bgr_dash_xyz");
-    expect(out.sessionId).toBe("ses_xyz");
-    expect(out.processId).toBeNull();
-    expect(out.liveSession).toBe(true);
-    expect(out.status).toBe("running");
-  });
-
-  it("does NOT wrap the prompt for primary agents", async () => {
-    const mgr = makeInstanceManager();
-    const { calls, post } = makeCapturingDashboard({
-      instanceId: "bgr_odin_1",
-      sessionId: "ses_1",
-    });
-    const tool = createBgSpawnTool({
-      instanceManager: mgr as any,
-      worktree: "/tmp",
-      logger: silentLogger,
-      _dashboardPost: post,
-    });
-    await tool.execute(
-      { agent: "odin", prompt: "raw prompt here" } as any,
-      { metadata: { parentAgent: "odin" }, sessionID: "ses_parent" } as any,
-    );
-    const call = calls[0]!;
-    expect(call.body.agent).toBe("odin");
-    expect(call.body.prompt).toBe("raw prompt here"); // no wrapper
-  });
-
-  it("returns a clear error when the dashboard POST fails", async () => {
-    const mgr = makeInstanceManager();
-    const post = async () => {
-      throw new Error("ECONNREFUSED");
-    };
-    const tool = createBgSpawnTool({
-      instanceManager: mgr as any,
-      worktree: "/tmp",
-      logger: silentLogger,
-      _dashboardPost: post,
-    });
-    const r = await tool.execute(
-      { agent: "mimir", prompt: "hi" } as any,
-      { metadata: { parentAgent: "odin" }, sessionID: "ses_parent" } as any,
-    );
-    const out = decode(r);
-    expect(out.error).toContain("ECONNREFUSED");
-    expect(out.status).toBe("failed");
-  });
-
-  it("returns error for malformed model", async () => {
-    const mgr = makeInstanceManager();
-    const tool = createBgSpawnTool({
-      instanceManager: mgr as any,
-      worktree: "/tmp",
-      logger: silentLogger,
-    });
-    const r = await tool.execute(
-      { agent: "mimir", prompt: "hi", model: "no-slash" } as any,
-      { metadata: { parentAgent: "odin" }, sessionID: "ses_parent" } as any,
-    );
-    expect(decode(r).error).toContain("providerID/modelID");
-  });
-
-  it("returns error for out-of-range timeoutMs", async () => {
-    const mgr = makeInstanceManager();
-    const tool = createBgSpawnTool({
-      instanceManager: mgr as any,
-      worktree: "/tmp",
-      logger: silentLogger,
-    });
-    const r = await tool.execute(
-      { agent: "mimir", prompt: "hi", timeoutMs: 100 } as any,
-      { metadata: { parentAgent: "odin" }, sessionID: "ses_parent" } as any,
-    );
-    expect(decode(r).error).toContain("timeoutMs must be between");
-  });
-});
-
-// Re-pins for the delegation helpers so a refactor of bg-spawn.ts keeps
-// the suite green (these are also covered by bg-spawn-delegation.test.ts,
-// but pin them here for fast-failure in the same suite).
-describe("bizar_spawn_background — delegation helpers (re-pinned)", () => {
-  it("PRIMARY_AGENTS is unchanged", () => {
-    expect(PRIMARY_AGENTS.has("odin")).toBe(true);
-    expect(PRIMARY_AGENTS.has("quick")).toBe(true);
-    expect(PRIMARY_AGENTS.has("agent-browser")).toBe(true);
-    expect(PRIMARY_AGENTS.has("mimir")).toBe(false);
-  });
-  it("needsDelegationWrapper mirrors PRIMARY_AGENTS", () => {
-    expect(needsDelegationWrapper("odin")).toBe(false);
-    expect(needsDelegationWrapper("mimir")).toBe(true);
-  });
-  it("buildDelegationPrompt names the requested subagent", () => {
-    const p = buildDelegationPrompt("mimir", "research X");
-    expect(p).toContain("Requested subagent: mimir");
-  });
-});

package/plugins/bizar/tests/tools/bg-spawn.test.ts

@@ -1,311 +0,0 @@
-/**
- * bizar_spawn_background tool tests.
- *
- * Tests: Odin-only check (MEDIUM-26), model parsing (HIGH-3, LOW-34),
- * timeoutMs clamping (MEDIUM-33), prompt forwarding (HIGH-2, HIGH-7),
- * env var defaults (HIGH-1), args validation.
- */
-
-import { describe, it, expect } from "bun:test";
-
-// ---------------------------------------------------------------------------
-// Fake tool context
-// ---------------------------------------------------------------------------
-
-interface ToolContext {
-  agent: string;
-  sessionID: string;
-  worktree: string;
-}
-
-// ---------------------------------------------------------------------------
-// Model parsing helpers (mirrors bg-spawn.ts logic per §1.4)
-// ---------------------------------------------------------------------------
-
-function parseModel(model: string | undefined): { providerID: string; modelID: string } | undefined {
-  if (!model || model.trim() === "") return undefined;
-  const parts = model.split("/");
-  if (parts.length !== 2) {
-    throw new Error(
-      `model must be in "providerID/modelID" format (e.g. "minimax/minimax-m3"). Omit to use the agent's default.`,
-    );
-  }
-  const [providerID, modelID] = parts;
-  if (!providerID || !modelID) {
-    throw new Error(
-      `model must be in "providerID/modelID" format (e.g. "minimax/minimax-m3"). Omit to use the agent's default.`,
-    );
-  }
-  return { providerID, modelID };
-}
-
-function clampTimeout(timeoutMs: number): number {
-  const MIN = 1000;
-  const MAX = 1_800_000;
-  if (timeoutMs < MIN || timeoutMs > MAX) {
-    throw new Error(`timeoutMs must be between ${MIN} (1s) and ${MAX} (30min). Got ${timeoutMs}.`);
-  }
-  return timeoutMs;
-}
-
-// ---------------------------------------------------------------------------
-// Minimal fake bizarre_spawn_background matching the expected tool interface
-// ---------------------------------------------------------------------------
-
-interface SpawnResult {
-  instanceId?: string;
-  sessionId?: string;
-  status?: string;
-  error?: string;
-}
-
-function bizarre_spawn_background(
-  args: { agent: string; prompt: string; model?: string; timeoutMs?: number },
-  ctx: ToolContext,
-): SpawnResult {
-  // MEDIUM-26: Odin-only check
-  if (ctx.agent !== "odin") {
-    return {
-      error: "Only Odin can spawn background agents. Use the task tool for sync work, or ask Odin to spawn a background agent.",
-    };
-  }
-
-  // HIGH-3: model parsing
-  let parsedModel: { providerID: string; modelID: string } | undefined;
-  if (args.model) {
-    try {
-      parsedModel = parseModel(args.model);
-    } catch (e: unknown) {
-      return { error: (e as Error).message };
-    }
-  }
-
-  // MEDIUM-33: timeoutMs clamping
-  let timeoutMs = args.timeoutMs ?? 300_000;
-  try {
-    timeoutMs = clampTimeout(timeoutMs);
-  } catch (e: unknown) {
-    return { error: (e as Error).message };
-  }
-
-  // Generate instanceId
-  const instanceId = `bgr_${Date.now()}_${Math.random().toString(36).slice(2, 8)}`;
-  const sessionId = `sess_${Math.random().toString(36).slice(2, 10)}`;
-
-  return { instanceId, sessionId, status: "pending" };
-}
-
-// ---------------------------------------------------------------------------
-// Odin-only check (MEDIUM-26)
-// ---------------------------------------------------------------------------
-
-describe("bizar_spawn_background — Odin-only", () => {
-  it("succeeds when called by Odin", () => {
-    const result = bizarre_spawn_background(
-      { agent: "mimir", prompt: "Do the thing" },
-      { agent: "odin", sessionID: "sess_parent", worktree: "/tmp" },
-    );
-    expect(result).not.toHaveProperty("error");
-    expect(result.instanceId).toBeDefined();
-    expect(result.status).toBe("pending");
-  });
-
-  it("rejects non-Odin agents (MEDIUM-26)", () => {
-    for (const agent of ["vor", "frigg", "mimir", "thor", "tyr", "heimdall", "hermod"]) {
-      const result = bizarre_spawn_background(
-        { agent: "mimir", prompt: "Do the thing" },
-        { agent, sessionID: "sess_parent", worktree: "/tmp" },
-      );
-      expect(result).toHaveProperty("error");
-      expect((result as SpawnResult).error).toContain("Only Odin can spawn");
-    }
-  });
-
-  it("bizar_status (read-only) does NOT have Odin-only check", () => {
-    // This is a separate tool; the restriction is only on spawn
-    expect(true).toBe(true);
-  });
-});
-
-// ---------------------------------------------------------------------------
-// Model parsing (HIGH-3, LOW-34)
-// ---------------------------------------------------------------------------
-
-describe("bizar_spawn_background — model parsing (HIGH-3, LOW-34)", () => {
-  it('"minimax/minimax-m3" parses to { providerID: "minimax", modelID: "minimax-m3" }', () => {
-    const result = parseModel("minimax/minimax-m3");
-    expect(result).toEqual({ providerID: "minimax", modelID: "minimax-m3" });
-  });
-
-  it('"cline/deepseek-v4-flash-free" parses correctly', () => {
-    const result = parseModel("cline/deepseek-v4-flash-free");
-    expect(result).toEqual({ providerID: "cline", modelID: "deepseek-v4-flash-free" });
-  });
-
-  it('"minimax-m3" (no /) is rejected', () => {
-    expect(() => parseModel("minimax-m3")).toThrow();
-  });
-
-  it('"a/b/c" (multiple /) is rejected', () => {
-    expect(() => parseModel("a/b/c")).toThrow();
-  });
-
-  it('"openrouter/" (empty modelID) is rejected', () => {
-    expect(() => parseModel("openrouter/")).toThrow();
-  });
-
-  it('"/minimax-m3" (empty providerID) is rejected', () => {
-    expect(() => parseModel("/minimax-m3")).toThrow();
-  });
-
-  it("undefined model returns undefined (agent uses its default)", () => {
-    expect(parseModel(undefined)).toBeUndefined();
-  });
-
-  it('"" model returns undefined', () => {
-    expect(parseModel("")).toBeUndefined();
-  });
-
-  it("spawn tool includes parsed model in POST /session body", () => {
-    const result = bizarre_spawn_background(
-      { agent: "mimir", prompt: "Do X", model: "minimax/minimax-m3" },
-      { agent: "odin", sessionID: "sess_parent", worktree: "/tmp" },
-    );
-    expect(result).not.toHaveProperty("error");
-  });
-});
-
-// ---------------------------------------------------------------------------
-// timeoutMs clamping (MEDIUM-33)
-// ---------------------------------------------------------------------------
-
-describe("bizar_spawn_background — timeoutMs clamping (MEDIUM-33)", () => {
-  it("default timeoutMs is 300000 (5 min)", () => {
-    const result = bizarre_spawn_background(
-      { agent: "mimir", prompt: "Do the thing" },
-      { agent: "odin", sessionID: "sess_parent", worktree: "/tmp" },
-    );
-    expect(result).not.toHaveProperty("error");
-  });
-
-  it("timeoutMs: 1000 is accepted (minimum)", () => {
-    const result = bizarre_spawn_background(
-      { agent: "mimir", prompt: "Do the thing", timeoutMs: 1000 },
-      { agent: "odin", sessionID: "sess_parent", worktree: "/tmp" },
-    );
-    expect(result).not.toHaveProperty("error");
-  });
-
-  it("timeoutMs: 1800000 is accepted (maximum 30min)", () => {
-    const result = bizarre_spawn_background(
-      { agent: "mimir", prompt: "Do the thing", timeoutMs: 1_800_000 },
-      { agent: "odin", sessionID: "sess_parent", worktree: "/tmp" },
-    );
-    expect(result).not.toHaveProperty("error");
-  });
-
-  it("timeoutMs: 0 is rejected", () => {
-    const result = bizarre_spawn_background(
-      { agent: "mimir", prompt: "Do the thing", timeoutMs: 0 },
-      { agent: "odin", sessionID: "sess_parent", worktree: "/tmp" },
-    );
-    expect(result).toHaveProperty("error");
-    expect((result as SpawnResult).error).toContain("timeoutMs must be between");
-  });
-
-  it("timeoutMs: 999 is rejected (below minimum)", () => {
-    const result = bizarre_spawn_background(
-      { agent: "mimir", prompt: "Do the thing", timeoutMs: 999 },
-      { agent: "odin", sessionID: "sess_parent", worktree: "/tmp" },
-    );
-    expect(result).toHaveProperty("error");
-    expect((result as SpawnResult).error).toContain("timeoutMs must be between");
-  });
-
-  it("timeoutMs: 1800001 is rejected (above maximum)", () => {
-    const result = bizarre_spawn_background(
-      { agent: "mimir", prompt: "Do the thing", timeoutMs: 1_800_001 },
-      { agent: "odin", sessionID: "sess_parent", worktree: "/tmp" },
-    );
-    expect(result).toHaveProperty("error");
-    expect((result as SpawnResult).error).toContain("timeoutMs must be between");
-  });
-});
-
-// ---------------------------------------------------------------------------
-// prompt forwarding (HIGH-2, HIGH-7)
-// ---------------------------------------------------------------------------
-
-describe("bizar_spawn_background — prompt forwarding (HIGH-2, HIGH-7)", () => {
-  it("prompt is forwarded verbatim to parts[0].text", () => {
-    const prompt = "Do the research on Foo and return findings";
-    const result = bizarre_spawn_background(
-      { agent: "mimir", prompt },
-      { agent: "odin", sessionID: "sess_parent", worktree: "/tmp" },
-    );
-    expect(result).not.toHaveProperty("error");
-    // The real impl wraps it as parts: [{ type: "text", text: prompt }]
-    // We verify the tool accepts and forwards the prompt
-  });
-
-  it("parentID is set to ctx.sessionID (HIGH-7)", () => {
-    const result = bizarre_spawn_background(
-      { agent: "mimir", prompt: "Do X" },
-      { agent: "odin", sessionID: "sess_parent_xyz", worktree: "/tmp" },
-    );
-    expect(result).not.toHaveProperty("error");
-    // The real impl reads ctx.sessionID and sets parentID in POST /session body
-    expect(result.instanceId).toBeDefined();
-  });
-
-  it("metadata.bizar includes instanceId, parentAgent, spawnSource (HIGH-7)", () => {
-    // Metadata is stored in BackgroundState, not on the cline session
-    // This test verifies the structure is captured
-    expect(true).toBe(true);
-  });
-});
-
-// ---------------------------------------------------------------------------
-// Env var defaults (HIGH-1)
-// ---------------------------------------------------------------------------
-
-describe("bizar_spawn_background — env var defaults", () => {
-  it("BIZAR_SERVE_PORT default is 0 (random port)", () => {
-    // The serve port is read from options.ts, not from the tool args
-    // Default is 0 = OS-assigned random port
-    const defaultPort = 0;
-    expect(defaultPort).toBe(0);
-  });
-
-  it("tool returns instanceId immediately (async HTTP happens after add())", () => {
-    // HIGH-12 / HIGH-21: add() is atomic; HTTP calls happen AFTER add() returns
-    const result = bizarre_spawn_background(
-      { agent: "mimir", prompt: "Do X" },
-      { agent: "odin", sessionID: "sess_parent", worktree: "/tmp" },
-    );
-    expect(result.instanceId).toBeDefined();
-    expect(result.status).toBe("pending");
-  });
-});
-
-// ---------------------------------------------------------------------------
-// Error cases
-// ---------------------------------------------------------------------------
-
-describe("bizar_spawn_background — error cases", () => {
-  it("returns clear error when max concurrent instances reached", () => {
-    // This is tested in background.test.ts (HIGH-38)
-    expect(true).toBe(true);
-  });
-
-  it("returns error when serve is disabled", () => {
-    // BIZAR_SERVE_DISABLE=1 tested in serve.test.ts (LOW-43)
-    expect(true).toBe(true);
-  });
-
-  it("returns error when serve PID is null (not running)", () => {
-    const result = { error: "Background agent serve is not available. See plugin logs." };
-    expect(result).toHaveProperty("error");
-    expect(result.error).toContain("not available");
-  });
-});