@polderlabs/bizar 4.2.1 → 4.2.3

package/bizar-dash/tests/memory-cli.test.mjs

@@ -244,6 +244,60 @@ describe('bizar memory write CLI', () => {
     assert.strictEqual(r.code, 0, `expected exit 0, got ${r.code}; stderr=${r.stderr}`);
     assert.ok(existsSync(join(projectRoot, '.obsidian', 'med.md')), 'medium-severity note should be written');
   });
+
+  // ─── v4.2.2 — custom frontmatter flags ─────────────────────────────────
+  test('--memory-id flag sets a custom memory_id in frontmatter', () => {
+    const relPath = 'flags/custom-id.md';
+    const r = runBizarMemoryWrite(projectRoot, [
+      relPath,
+      '--type', 'coding_convention',
+      '--memory-id', 'mem_test_custom_id',
+      '--body', 'custom id test',
+    ]);
+    assert.strictEqual(r.code, 0, `expected exit 0, got ${r.code}; stderr=${r.stderr}; stdout=${r.stdout}`);
+    const filePath = join(projectRoot, '.obsidian', relPath);
+    assert.ok(existsSync(filePath), `note file should exist at ${filePath}`);
+    const raw = readFileSync(filePath, 'utf8');
+    assert.ok(/memory_id:\s*mem_test_custom_id\b/.test(raw),
+      `frontmatter should contain memory_id: mem_test_custom_id; got:\n${raw}`);
+  });
+
+  test('--scope and --source-agent flags pass through to frontmatter', () => {
+    const relPath = 'flags/scope-and-agent.md';
+    const r = runBizarMemoryWrite(projectRoot, [
+      relPath,
+      '--type', 'coding_convention',
+      '--scope', 'project',
+      '--source-agent', 'mimir',
+      '--body', 'scope/agent test',
+    ]);
+    assert.strictEqual(r.code, 0, `expected exit 0, got ${r.code}; stderr=${r.stderr}; stdout=${r.stdout}`);
+    const filePath = join(projectRoot, '.obsidian', relPath);
+    assert.ok(existsSync(filePath), `note file should exist at ${filePath}`);
+    const raw = readFileSync(filePath, 'utf8');
+    assert.ok(/scope:\s*project\b/.test(raw),
+      `frontmatter should contain scope: project; got:\n${raw}`);
+    assert.ok(/source_agent:\s*mimir\b/.test(raw),
+      `frontmatter should contain source_agent: mimir; got:\n${raw}`);
+  });
+
+  test('invalid --memory-id format is rejected with kebab/snake-case error', () => {
+    const r = runBizarMemoryWrite(projectRoot, [
+      'flags/bad-id.md',
+      '--type', 'coding_convention',
+      '--memory-id', 'has spaces and !@#',
+      '--body', 'should fail',
+    ]);
+    assert.strictEqual(r.code, 1, `expected exit 1, got ${r.code}; stderr=${r.stderr}`);
+    const out = `${r.stdout}\n${r.stderr}`;
+    assert.ok(/invalid --memory-id/i.test(out),
+      `expected invalid --memory-id error, got: ${out}`);
+    assert.ok(/kebab|snake/i.test(out),
+      `expected error to mention kebab/snake-case, got: ${out}`);
+    // File should NOT exist
+    assert.ok(!existsSync(join(projectRoot, '.obsidian', 'flags', 'bad-id.md')),
+      'note file must not be written when --memory-id is invalid');
+  });
 });
 
 // ─── bizar memory setup ──────────────────────────────────────────────────────

package/bizar-dash/tests/memory-install-bootstrap.test.mjs

@@ -0,0 +1,129 @@
+/**
+ * tests/memory-install-bootstrap.test.mjs
+ *
+ * Regression test for v4.2.2: the `bizar` CLI bootstrap path crashed with
+ * `ERR_AMBIGUOUS_MODULE_SYNTAX` on a fresh install because `promptAndInstallOptional`
+ * in `cli/install.mjs` referenced `__dirname` (a CommonJS global) without defining
+ * the ESM polyfill. This was only triggered by the bootstrap path, which the
+ * existing test suite never exercised.
+ *
+ * Test: spawn the CLI in a fresh temp project, with BIZAR_SKIP_INSTALL unset.
+ * The bootstrap should run and exit cleanly (rc 0 or rc 1 for missing auth, but
+ * NOT crash with ERR_AMBIGUOUS_MODULE_SYNTAX).
+ *
+ * Fix: move the `__dirname` polyfill to module scope in cli/install.mjs.
+ */
+
+import { describe, it, beforeEach, afterEach } from 'node:test';
+import assert from 'node:assert/strict';
+import { tmpdir } from 'node:os';
+import { join, dirname } from 'node:path';
+import { mkdirSync, rmSync } from 'node:fs';
+import { execFileSync } from 'node:child_process';
+import { fileURLToPath } from 'node:url';
+
+const __filename = fileURLToPath(import.meta.url);
+const CLI_BIN = join(dirname(__filename), '..', '..', 'cli', 'bin.mjs');
+
+const uid = () => `${Date.now()}-${Math.random().toString(36).slice(2)}`;
+
+/**
+ * Spawn `bizar <subcmd>` in the given cwd, with the given env vars.
+ * Returns { code, stdout, stderr }.
+ *
+ * The bootstrap path is checked by NOT setting BIZAR_SKIP_INSTALL.
+ */
+function runBizarWithoutSkip(args, cwd, extraEnv = {}) {
+  try {
+    const stdout = execFileSync('node', [CLI_BIN, ...args], {
+      cwd,
+      encoding: 'utf8',
+      stdio: 'pipe',
+      timeout: 30_000,
+      env: { ...process.env, ...extraEnv }, // no BIZAR_SKIP_INSTALL
+    });
+    return { code: 0, stdout, stderr: '' };
+  } catch (err) {
+    return {
+      code: err.status ?? 1,
+      stdout: err.stdout ? err.stdout.toString() : '',
+      stderr: err.stderr ? err.stderr.toString() : (err.message ?? ''),
+    };
+  }
+}
+
+describe('bizar CLI bootstrap (v4.2.3 regression)', () => {
+  let projectRoot;
+  let homeDir;
+
+  beforeEach(() => {
+    projectRoot = join(tmpdir(), `bizar-bootstrap-${uid()}`);
+    homeDir = join(tmpdir(), `bizar-bootstrap-home-${uid()}`);
+    mkdirSync(projectRoot, { recursive: true });
+    mkdirSync(homeDir, { recursive: true });
+  });
+
+  afterEach(() => {
+    try { rmSync(projectRoot, { recursive: true, force: true }); } catch { /* ignore */ }
+    try { rmSync(homeDir, { recursive: true, force: true }); } catch { /* ignore */ }
+  });
+
+  it('bizar --version does not crash with ERR_AMBIGUOUS_MODULE_SYNTAX', () => {
+    const r = runBizarWithoutSkip(['--version'], projectRoot, { HOME: homeDir });
+    // Whatever exit code, the key thing is the bootstrap doesn't crash
+    assert.ok(
+      !r.stderr.includes('ERR_AMBIGUOUS_MODULE_SYNTAX'),
+      `bootstrap crashed with ERR_AMBIGUOUS_MODULE_SYNTAX. stderr=${r.stderr}`,
+    );
+    assert.ok(
+      !r.stderr.includes('Cannot determine intended module format'),
+      `bootstrap module-format error. stderr=${r.stderr}`,
+    );
+  });
+
+  it('bizar memory status does not crash with ERR_AMBIGUOUS_MODULE_SYNTAX', () => {
+    const r = runBizarWithoutSkip(['memory', 'status'], projectRoot, { HOME: homeDir });
+    assert.ok(
+      !r.stderr.includes('ERR_AMBIGUOUS_MODULE_SYNTAX'),
+      `bootstrap crashed with ERR_AMBIGUOUS_MODULE_SYNTAX. stderr=${r.stderr}`,
+    );
+    assert.ok(
+      !r.stderr.includes('Cannot determine intended module format'),
+      `bootstrap module-format error. stderr=${r.stderr}`,
+    );
+  });
+
+  it('bizar memory doctor does not crash with ERR_AMBIGUOUS_MODULE_SYNTAX', () => {
+    const r = runBizarWithoutSkip(['memory', 'doctor'], projectRoot, { HOME: homeDir });
+    assert.ok(
+      !r.stderr.includes('ERR_AMBIGUOUS_MODULE_SYNTAX'),
+      `bootstrap crashed with ERR_AMBIGUOUS_MODULE_SYNTAX. stderr=${r.stderr}`,
+    );
+  });
+
+  it('install.mjs source defines __dirname at module scope (regression guard)', () => {
+    // Read the source of cli/install.mjs and check that __dirname is
+    // defined at module scope (not only inside runInstaller).
+    const installSrc = execFileSync('node', ['-e', `
+      const fs = require('fs');
+      const src = fs.readFileSync(${JSON.stringify(join(dirname(CLI_BIN), 'install.mjs'))}, 'utf8');
+      // Find first __dirname definition (should be at module scope, not inside a function)
+      const lines = src.split('\\n');
+      let firstDefine = -1;
+      for (let i = 0; i < lines.length; i++) {
+        if (lines[i].includes('__dirname = dirname(fileURLToPath')) {
+          firstDefine = i;
+          break;
+        }
+      }
+      // The first definition must be BEFORE any function definition that uses __dirname
+      // Simple heuristic: it must be within the first 20 lines
+      process.stdout.write(JSON.stringify({ firstDefine, totalLines: lines.length }));
+    `], { encoding: 'utf8' });
+    const { firstDefine, totalLines } = JSON.parse(installSrc);
+    assert.ok(
+      firstDefine >= 0 && firstDefine < 20,
+      `__dirname polyfill should be at module scope (first 20 lines). Found at line ${firstDefine + 1} of ${totalLines}.`,
+    );
+  });
+});

package/cli/install.mjs

@@ -1,7 +1,17 @@
 import chalk from 'chalk';
 import boxen from 'boxen';
 import { existsSync, lstatSync, rmSync } from 'node:fs';
-import { join } from 'node:path';
+import { join, dirname } from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+// ── ESM `__dirname` polyfill ────────────────────────────────────────────────
+// `__dirname` is a CommonJS global. ESM modules don't have it. We define it
+// at module scope so all functions in this file can use it without each
+// having to recreate the polyfill. (v4.2.3 — previously only `runInstaller`
+// had it, which caused `promptAndInstallOptional` to crash with
+// `ERR_AMBIGUOUS_MODULE_SYNTAX` when the bootstrap path fired on a fresh
+// install.)
+const __dirname = dirname(fileURLToPath(import.meta.url));
 
 import { showBanner, showPantheon, sectionHeading } from './banner.mjs';
 import { promptComponents, promptInstallMode, promptAgents, promptSkillPacks, promptApiKeys, promptConfirmInstall, promptRestartOpenCode } from './prompts.mjs';
@@ -232,11 +242,10 @@ export async function installPluginFromGlobal(opts = {}) {
  */
 export async function runInstaller() {
   const { existsSync } = await import('node:fs');
-  const { join, dirname } = await import('node:path');
-  const { fileURLToPath } = await import('node:url');
+  const { join } = await import('node:path');
   const { spawnSync } = await import('node:child_process');
 
-  const __dirname = dirname(fileURLToPath(import.meta.url));
+  // __dirname is defined at module scope (see top of file)
   // cli/install.mjs → ../install.sh
   const installSh = join(__dirname, '..', 'install.sh');
 

package/cli/memory.mjs

@@ -104,6 +104,10 @@ async function cmdWrite(args) {
                              (default: verified)
     --tag <tag>              Tag to attach (may be passed multiple times)
     --title <title>          Frontmatter title field
+    --memory-id <id>         Custom memory_id (default: <type>_<timestamp>)
+                             Must match [a-zA-Z0-9._-]+
+    --scope <scope>          Frontmatter scope field (e.g. project, team)
+    --source-agent <name>    Frontmatter source_agent field
     --body <text>            Note body as a string
     --body-file <path>       Path to a file containing the body
                              (exactly one of --body / --body-file is allowed)
@@ -177,6 +181,30 @@ async function cmdWrite(args) {
     process.exit(1);
   }
 
+  // --memory-id (kebab/snake-case only)
+  const memoryId = optVal('--memory-id');
+  if (memoryId !== undefined) {
+    if (!/^[a-zA-Z0-9._-]+$/.test(memoryId)) {
+      error(`invalid --memory-id: '${memoryId}' (must be kebab/snake-case)`);
+      info('expected pattern: mem_<path>, e.g. mem_api_memory_schema_md');
+      process.exit(1);
+    }
+  }
+
+  // --scope (free-form, but non-empty when provided)
+  const scope = optVal('--scope');
+  if (scope !== undefined && scope.length === 0) {
+    error('--scope must be a non-empty string');
+    process.exit(1);
+  }
+
+  // --source-agent (free-form, but non-empty when provided)
+  const sourceAgent = optVal('--source-agent');
+  if (sourceAgent !== undefined && sourceAgent.length === 0) {
+    error('--source-agent must be a non-empty string');
+    process.exit(1);
+  }
+
   let body = '';
   if (bodyFile) {
     try {
@@ -201,6 +229,9 @@ async function cmdWrite(args) {
     tags,
   });
   if (title) frontmatter.title = title;
+  if (memoryId) frontmatter.memory_id = memoryId;
+  if (scope) frontmatter.scope = scope;
+  if (sourceAgent) frontmatter.source_agent = sourceAgent;
 
   // ── Write ───────────────────────────────────────────────────────────────
   let result;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@polderlabs/bizar",
-  "version": "4.2.1",
+  "version": "4.2.3",
   "description": "Norse-pantheon multi-agent system for opencode — 13 agents across 4 cost tiers with cost-aware routing, plans, and a configurable agent harness. v4 ships as a single npm package bundling the dashboard server, opencode plugin, and typed SDK.",
   "type": "module",
   "bin": {