@pobammer-ts/eslint-cease-nonsense-rules 1.5.0 → 1.5.2

package/dist/build-metadata.json

@@ -1,5 +1,5 @@
 {
-  "commit": "94d6b486c572f905054ee7538b5df44541ad1eaa",
-  "time": "2025-12-11T01:19:08.613Z",
-  "version": "1.5.0"
+  "commit": "12c06ad5566d08fbf3f48f5203aff7fdc61a801f",
+  "time": "2025-12-11T22:26:23.456Z",
+  "version": "1.5.2"
 }

package/dist/configure-utilities.d.ts

@@ -2,7 +2,7 @@ import type { BanInstancesOptions } from "./rules/ban-instances";
 import type { ComplexityConfiguration } from "./rules/enforce-ianitor-check-type";
 import type { NoInstanceMethodsOptions } from "./rules/no-instance-methods-without-this";
 import type { NoShorthandOptions } from "./rules/no-shorthand-names";
-import type { NoUselessUseSpringOptions } from "./rules/no-useless-use-spring";
+import { type NoUselessUseSpringOptions } from "./rules/no-useless-use-spring";
 import type { EffectFunctionOptions, HookConfiguration } from "./rules/require-named-effect-functions";
 import type { PairConfiguration, RequirePairedCallsOptions } from "./rules/require-paired-calls";
 import type { ReactKeysOptions } from "./rules/require-react-component-keys";

package/dist/index.js

@@ -17705,8 +17705,35 @@ var no_shorthand_names_default = noShorthandNames;
 // src/rules/no-useless-use-spring.ts
 var import_scope_manager = __toESM(require_dist2(), 1);
 import { AST_NODE_TYPES as AST_NODE_TYPES3 } from "@typescript-eslint/utils";
+var DEFAULT_STATIC_GLOBAL_FACTORIES = [
+  "Axes",
+  "BrickColor",
+  "CFrame",
+  "Color3",
+  "ColorSequence",
+  "ColorSequenceKeypoint",
+  "DateTime",
+  "Faces",
+  "NumberRange",
+  "NumberSequence",
+  "NumberSequenceKeypoint",
+  "PathWaypoint",
+  "PhysicalProperties",
+  "Ray",
+  "Rect",
+  "Region3",
+  "Region3int16",
+  "TweenInfo",
+  "UDim",
+  "UDim2",
+  "Vector2",
+  "Vector3",
+  "Vector3int16",
+  "Vector3int32"
+];
 var DEFAULT_OPTION_VALUES = {
   springHooks: ["useSpring"],
+  staticGlobalFactories: DEFAULT_STATIC_GLOBAL_FACTORIES,
   treatEmptyDepsAsViolation: true
 };
 var STATIC_UNARY_OPERATORS = new Set(["-", "+", "!", "~", "typeof", "void", "delete"]);
@@ -17725,6 +17752,14 @@ function unwrapExpression(expression) {
       current = current.expression;
       continue;
     }
+    if (current.type === AST_NODE_TYPES3.TSSatisfiesExpression) {
+      current = current.expression;
+      continue;
+    }
+    if (current.type === AST_NODE_TYPES3.TSInstantiationExpression) {
+      current = current.expression;
+      continue;
+    }
     if (current.type === AST_NODE_TYPES3.ChainExpression) {
       current = current.expression;
       continue;
@@ -17764,10 +17799,10 @@ function getConstInitializer(definition) {
     return;
   return declarator.init ?? undefined;
 }
-function isStaticIdentifier(context, identifier3, seen) {
+function isStaticIdentifier(context, identifier3, seen, options3) {
   const variable = findVariable(context, identifier3);
   if (variable === undefined)
-    return false;
+    return options3.staticGlobalFactories.has(identifier3.name);
   if (!isModuleLevelScope(variable.scope))
     return false;
   if (isImport(variable))
@@ -17776,43 +17811,43 @@ function isStaticIdentifier(context, identifier3, seen) {
     const initializer = getConstInitializer(definition);
     if (initializer === undefined)
       continue;
-    if (isStaticExpression(context, initializer, seen))
+    if (isStaticExpression(context, initializer, seen, options3))
       return true;
   }
   return false;
 }
-function isStaticMemberProperty(property, seen) {
+function isStaticMemberProperty(property, seen, options3) {
   if (property.type === AST_NODE_TYPES3.PrivateIdentifier)
     return false;
   if (property.type === AST_NODE_TYPES3.Identifier)
     return true;
-  return isStaticExpressionInner(property, seen);
+  return isStaticExpressionInner(property, seen, options3);
 }
-function isStaticCallCallee(context, callee, seen) {
+function isStaticCallCallee(context, callee, seen, options3) {
   const unwrapped = unwrapExpression(callee);
   if (unwrapped.type === AST_NODE_TYPES3.Identifier)
-    return isStaticIdentifier(context, unwrapped, seen);
+    return isStaticIdentifier(context, unwrapped, seen, options3);
   if (unwrapped.type === AST_NODE_TYPES3.MemberExpression) {
-    if (!isStaticExpression(context, unwrapped.object, seen))
+    if (!isStaticExpression(context, unwrapped.object, seen, options3))
       return false;
     if (unwrapped.computed)
-      return isStaticMemberProperty(unwrapped.property, seen);
+      return isStaticMemberProperty(unwrapped.property, seen, options3);
     return unwrapped.property.type === AST_NODE_TYPES3.Identifier;
   }
   return false;
 }
-function isStaticObjectExpression(context, objectExpr, seen) {
+function isStaticObjectExpression(context, objectExpr, seen, options3) {
   for (const property of objectExpr.properties) {
     if (property.type !== AST_NODE_TYPES3.Property)
       return false;
     if (property.kind !== "init")
       return false;
-    if (property.computed && !isStaticExpressionInner(property.key, seen))
+    if (property.computed && !isStaticExpressionInner(property.key, seen, options3))
       return false;
     const value = property.value;
     if (!isNonPatternExpression(value))
       return false;
-    if (!isStaticExpression(context, value, seen))
+    if (!isStaticExpression(context, value, seen, options3))
       return false;
   }
   return true;
@@ -17823,10 +17858,10 @@ function isNonPatternExpression(value) {
 function isNonPrivateExpression(value) {
   return value.type !== AST_NODE_TYPES3.PrivateIdentifier;
 }
-function isStaticObjectLikeConfig(context, expression, seen) {
+function isStaticObjectLikeConfig(context, expression, seen, options3) {
   const unwrapped = unwrapExpression(expression);
   if (unwrapped.type === AST_NODE_TYPES3.ObjectExpression)
-    return isStaticObjectExpression(context, unwrapped, seen);
+    return isStaticObjectExpression(context, unwrapped, seen, options3);
   if (unwrapped.type === AST_NODE_TYPES3.Identifier) {
     const variable = findVariable(context, unwrapped);
     if (variable === undefined)
@@ -17842,27 +17877,27 @@ function isStaticObjectLikeConfig(context, expression, seen) {
       const normalizedInitializer = unwrapExpression(initializer);
       if (normalizedInitializer.type !== AST_NODE_TYPES3.ObjectExpression)
         continue;
-      if (isStaticObjectExpression(context, normalizedInitializer, seen))
+      if (isStaticObjectExpression(context, normalizedInitializer, seen, options3))
         return true;
     }
   }
   return false;
 }
-function isStaticArrayExpression(context, arrayExpr, seen) {
+function isStaticArrayExpression(context, arrayExpr, seen, options3) {
   for (const element of arrayExpr.elements) {
     if (!element)
       continue;
     if (element.type === AST_NODE_TYPES3.SpreadElement)
       return false;
-    if (!isStaticExpression(context, element, seen))
+    if (!isStaticExpression(context, element, seen, options3))
       return false;
   }
   return true;
 }
-function isStaticExpressionInner(node, seen) {
-  return isStaticExpression(undefined, node, seen);
+function isStaticExpressionInner(node, seen, options3) {
+  return isStaticExpression(undefined, node, seen, options3);
 }
-function isStaticExpression(context, expression, seen = new Set) {
+function isStaticExpression(context, expression, seen, options3) {
   const unwrapped = unwrapExpression(expression);
   if (seen.has(unwrapped))
     return true;
@@ -17873,37 +17908,37 @@ function isStaticExpression(context, expression, seen = new Set) {
     case AST_NODE_TYPES3.TemplateLiteral:
       return unwrapped.expressions.length === 0;
     case AST_NODE_TYPES3.UnaryExpression:
-      return STATIC_UNARY_OPERATORS.has(unwrapped.operator) && isStaticExpression(context, unwrapped.argument, seen);
+      return STATIC_UNARY_OPERATORS.has(unwrapped.operator) && isStaticExpression(context, unwrapped.argument, seen, options3);
     case AST_NODE_TYPES3.BinaryExpression:
     case AST_NODE_TYPES3.LogicalExpression:
       if (!isNonPrivateExpression(unwrapped.left) || !isNonPrivateExpression(unwrapped.right))
         return false;
-      return isStaticExpression(context, unwrapped.left, seen) && isStaticExpression(context, unwrapped.right, seen);
+      return isStaticExpression(context, unwrapped.left, seen, options3) && isStaticExpression(context, unwrapped.right, seen, options3);
     case AST_NODE_TYPES3.ConditionalExpression:
-      return isStaticExpression(context, unwrapped.test, seen) && isStaticExpression(context, unwrapped.consequent, seen) && isStaticExpression(context, unwrapped.alternate, seen);
+      return isStaticExpression(context, unwrapped.test, seen, options3) && isStaticExpression(context, unwrapped.consequent, seen, options3) && isStaticExpression(context, unwrapped.alternate, seen, options3);
     case AST_NODE_TYPES3.ArrayExpression:
-      return context !== undefined && isStaticArrayExpression(context, unwrapped, seen);
+      return context !== undefined && isStaticArrayExpression(context, unwrapped, seen, options3);
     case AST_NODE_TYPES3.ObjectExpression:
-      return context !== undefined && isStaticObjectExpression(context, unwrapped, seen);
+      return context !== undefined && isStaticObjectExpression(context, unwrapped, seen, options3);
     case AST_NODE_TYPES3.Identifier:
-      return context !== undefined && isStaticIdentifier(context, unwrapped, seen);
+      return context !== undefined && isStaticIdentifier(context, unwrapped, seen, options3);
     case AST_NODE_TYPES3.MemberExpression:
-      return isStaticExpression(context, unwrapped.object, seen) && (!unwrapped.computed || isStaticMemberProperty(unwrapped.property, seen));
+      return isStaticExpression(context, unwrapped.object, seen, options3) && (!unwrapped.computed || isStaticMemberProperty(unwrapped.property, seen, options3));
     case AST_NODE_TYPES3.ChainExpression:
-      return isStaticExpression(context, unwrapped.expression, seen);
+      return isStaticExpression(context, unwrapped.expression, seen, options3);
     case AST_NODE_TYPES3.CallExpression:
-      return context !== undefined && isStaticCallCallee(context, unwrapped.callee, seen) && unwrapped.arguments.every((arg) => arg.type !== AST_NODE_TYPES3.SpreadElement && isStaticExpression(context, arg, seen));
+      return context !== undefined && isStaticCallCallee(context, unwrapped.callee, seen, options3) && unwrapped.arguments.every((arg) => arg.type !== AST_NODE_TYPES3.SpreadElement && isStaticExpression(context, arg, seen, options3));
     case AST_NODE_TYPES3.NewExpression:
-      return context !== undefined && isStaticCallCallee(context, unwrapped.callee, seen) && (unwrapped.arguments ?? []).every((arg) => arg.type !== AST_NODE_TYPES3.SpreadElement && isStaticExpression(context, arg, seen));
+      return context !== undefined && isStaticCallCallee(context, unwrapped.callee, seen, options3) && (unwrapped.arguments ?? []).every((arg) => arg.type !== AST_NODE_TYPES3.SpreadElement && isStaticExpression(context, arg, seen, options3));
     case AST_NODE_TYPES3.SequenceExpression:
-      return unwrapped.expressions.length > 0 && unwrapped.expressions.every((expr) => isStaticExpression(context, expr, seen));
+      return unwrapped.expressions.length > 0 && unwrapped.expressions.every((expr) => isStaticExpression(context, expr, seen, options3));
     case AST_NODE_TYPES3.AssignmentExpression:
-      return isStaticExpression(context, unwrapped.right, seen);
+      return isStaticExpression(context, unwrapped.right, seen, options3);
     default:
       return false;
   }
 }
-function classifyDependencies(context, argument, seen) {
+function classifyDependencies(context, argument, seen, options3) {
   if (argument === undefined)
     return 0 /* MissingOrOmitted */;
   if (argument.type === AST_NODE_TYPES3.SpreadElement)
@@ -17913,7 +17948,7 @@ function classifyDependencies(context, argument, seen) {
     return 3 /* DynamicOrUnknown */;
   if (expr.elements.length === 0)
     return 1 /* EmptyArray */;
-  if (isStaticArrayExpression(context, expr, seen))
+  if (isStaticArrayExpression(context, expr, seen, options3))
     return 2 /* StaticArray */;
   return 3 /* DynamicOrUnknown */;
 }
@@ -17925,7 +17960,15 @@ function depsAreNonUpdating(kind, options3) {
   return false;
 }
 function isSpringHookCall(node, options3) {
-  return node.callee.type === AST_NODE_TYPES3.Identifier && options3.springHooks.has(node.callee.name);
+  const { callee } = node;
+  if (callee.type === AST_NODE_TYPES3.Identifier)
+    return options3.springHooks.has(callee.name);
+  if (callee.type === AST_NODE_TYPES3.MemberExpression && !callee.computed) {
+    const { property } = callee;
+    if (property.type === AST_NODE_TYPES3.Identifier)
+      return options3.springHooks.has(property.name);
+  }
+  return false;
 }
 var noUselessUseSpring = {
   create(context) {
@@ -17933,7 +17976,8 @@ var noUselessUseSpring = {
     const normalized = {
       ...DEFAULT_OPTION_VALUES,
       ...rawOptions,
-      springHooks: new Set(rawOptions?.springHooks ?? DEFAULT_OPTION_VALUES.springHooks)
+      springHooks: new Set(rawOptions?.springHooks ?? DEFAULT_OPTION_VALUES.springHooks),
+      staticGlobalFactories: new Set(rawOptions?.staticGlobalFactories ?? DEFAULT_OPTION_VALUES.staticGlobalFactories)
     };
     return {
       CallExpression(node) {
@@ -17947,9 +17991,9 @@ var noUselessUseSpring = {
         if (configArgument.type === AST_NODE_TYPES3.SpreadElement)
           return;
         const seen = new Set;
-        if (!isStaticObjectLikeConfig(context, configArgument, seen))
+        if (!isStaticObjectLikeConfig(context, configArgument, seen, normalized))
           return;
-        const depsKind = classifyDependencies(context, node.arguments[1], seen);
+        const depsKind = classifyDependencies(context, node.arguments[1], seen, normalized);
         if (!depsAreNonUpdating(depsKind, normalized))
           return;
         context.report({
@@ -17976,6 +18020,12 @@ var noUselessUseSpring = {
             items: { type: "string" },
             type: "array"
           },
+          staticGlobalFactories: {
+            default: [...DEFAULT_STATIC_GLOBAL_FACTORIES],
+            description: "Global factory identifiers that are treated as static constructors",
+            items: { type: "string" },
+            type: "array"
+          },
           treatEmptyDepsAsViolation: {
             default: true,
             description: "Treat static config with an empty dependency array as a violation",
@@ -20199,14 +20249,15 @@ function collectCaptures(node, sourceCode) {
 function parseDependencies(node, sourceCode) {
   const dependencies4 = new Array;
   for (const element of node.elements) {
-    if (!element || element.type === TSESTree9.AST_NODE_TYPES.SpreadElement)
+    if (!element)
       continue;
-    const name = nodeToDependencyString(element, sourceCode);
-    const depth = getMemberExpressionDepth(element);
+    const actualNode = element.type === TSESTree9.AST_NODE_TYPES.SpreadElement ? element.argument : element;
+    const name = nodeToDependencyString(actualNode, sourceCode);
+    const depth = getMemberExpressionDepth(actualNode);
     dependencies4.push({
       depth,
       name,
-      node: element
+      node: actualNode
     });
   }
   return dependencies4;
@@ -20939,6 +20990,7 @@ function createUseHookAtTopLevelOptions(options3 = {}) {
 function createNoUselessUseSpringOptions(options3 = {}) {
   return {
     springHooks: ["useSpring"],
+    staticGlobalFactories: DEFAULT_STATIC_GLOBAL_FACTORIES,
     treatEmptyDepsAsViolation: true,
     ...options3
   };
@@ -21010,4 +21062,4 @@ export {
   createBanInstancesOptions
 };
 
-//# debugId=5161D4E9740EB54264756E2164756E21
+//# debugId=EA151AE69FFBBA3C64756E2164756E21