@pobammer-ts/eslint-cease-nonsense-rules 1.15.0 → 1.16.0

package/README.md

@@ -64,6 +64,7 @@ export default [
 			"cease-nonsense/prefer-singular-enums": "error",
 			"cease-nonsense/prefer-udim2-shorthand": "error",
 			"cease-nonsense/react-hooks-strict-return": "error",
+			"cease-nonsense/require-module-level-instantiation": "error",
 			"cease-nonsense/require-named-effect-functions": "error",
 			"cease-nonsense/require-paired-calls": "error",
 			"cease-nonsense/require-react-component-keys": "error",
@@ -1408,6 +1409,48 @@ class MyClass {
 }
 ```
 
+#### `require-module-level-instantiation`
+
+Require certain classes to be instantiated at module level rather than inside functions.
+
+Classes like Log should be instantiated once at module scope, not recreated on every function call.
+
+**Configuration**
+
+```typescript
+{
+  "cease-nonsense/require-module-level-instantiation": ["error", {
+    "classes": {
+      "Log": "@rbxts/rbxts-sleitnick-log",
+      "Server": "@rbxts/net"
+    }
+  }]
+}
+```
+
+**❌ Bad**
+
+```typescript
+import Log from "@rbxts/rbxts-sleitnick-log";
+
+function useStoryModesState() {
+	const log = new Log(); // Recreated on every call!
+	log.Info("Create Match clicked");
+}
+```
+
+**✅ Good**
+
+```typescript
+import Log from "@rbxts/rbxts-sleitnick-log";
+
+const log = new Log(); // Module level - created once
+
+function useStoryModesState() {
+	log.Info("Create Match clicked");
+}
+```
+
 ### Module Boundaries
 
 #### `strict-component-boundaries`

package/dist/build-metadata.json

@@ -1,5 +1,5 @@
 {
-  "commit": "02202d06fed3e5ad1ec4ef66f32874643bcbaa18",
-  "time": "2026-01-11T20:59:08.304Z",
-  "version": "1.15.0"
+  "commit": "c91088ff8a466bdf3a9b204cd8b0b1cf001028a4",
+  "time": "2026-01-11T21:38:35.222Z",
+  "version": "1.16.0"
 }

package/dist/index.d.ts

@@ -9,13 +9,14 @@ export type { NoMemoChildrenOptions } from "./rules/no-memo-children";
 export type { NoShorthandOptions } from "./rules/no-shorthand-names";
 export type { NoUselessUseSpringOptions } from "./rules/no-useless-use-spring";
 export type { PreferEnumItemOptions } from "./rules/prefer-enum-item";
+export type { RequireModuleLevelInstantiationOptions } from "./rules/require-module-level-instantiation";
 export type { EffectFunctionOptions, HookConfiguration } from "./rules/require-named-effect-functions";
 export type { PairConfiguration, RequirePairedCallsOptions } from "./rules/require-paired-calls";
 export type { ReactKeysOptions } from "./rules/require-react-component-keys";
 export type { RequireReactDisplayNamesOptions } from "./rules/require-react-display-names";
 export type { HookEntry, UseExhaustiveDependenciesOptions } from "./rules/use-exhaustive-dependencies";
 export type { EnvironmentMode } from "./types/environment-mode";
-export { createBanInstancesOptions, createComplexityConfiguration, createEffectFunctionOptions, createHookConfiguration, createNoGodComponentsOptions, createNoInstanceMethodsOptions, createNoMemoChildrenOptions, createNoShorthandOptions, createNoUselessUseSpringOptions, createPairConfiguration, createPreferPatternReplacementsOptions, createReactKeysOptions, createRequirePairedCallsOptions, createRequireReactDisplayNamesOptions, createUseExhaustiveDependenciesOptions, createUseHookAtTopLevelOptions, defaultRobloxProfilePair, } from "./utilities/configure-utilities";
+export { createBanInstancesOptions, createComplexityConfiguration, createEffectFunctionOptions, createHookConfiguration, createNoGodComponentsOptions, createNoInstanceMethodsOptions, createNoMemoChildrenOptions, createNoShorthandOptions, createNoUselessUseSpringOptions, createPairConfiguration, createPreferEnumItemOptions, createPreferPatternReplacementsOptions, createReactKeysOptions, createRequireModuleLevelInstantiationOptions, createRequirePairedCallsOptions, createRequireReactDisplayNamesOptions, createUseExhaustiveDependenciesOptions, createUseHookAtTopLevelOptions, defaultRobloxProfilePair, } from "./utilities/configure-utilities";
 export type { Pattern, PreferPatternReplacementsOptions } from "./utilities/pattern-replacement";
 export { pattern } from "./utilities/pattern-replacement";
 /**

package/dist/index.js

@@ -22152,6 +22152,105 @@ var react_hooks_strict_return_default = createRule({
   name: "react-hooks-strict-return"
 });
 
+// src/rules/require-module-level-instantiation.ts
+var import_scope_manager4 = __toESM(require_dist2(), 1);
+import { AST_NODE_TYPES as AST_NODE_TYPES14 } from "@typescript-eslint/utils";
+var isOptionsObject2 = Compile(build_default.Object({
+  classes: build_default.Record(build_default.String(), build_default.String())
+}));
+function normalizeConfiguration(options3) {
+  if (!isOptionsObject2.Check(options3))
+    return { trackedImports: new Map };
+  const { classes } = options3;
+  const trackedImports = new Map;
+  for (const [className, source] of Object.entries(classes))
+    trackedImports.set(className, { className, source });
+  return { trackedImports };
+}
+function isTopScope2({ type: type3 }) {
+  return type3 === import_scope_manager4.ScopeType.module || type3 === import_scope_manager4.ScopeType.global;
+}
+var require_module_level_instantiation_default = createRule({
+  create(context) {
+    const { trackedImports } = normalizeConfiguration(context.options[0]);
+    if (trackedImports.size === 0)
+      return {};
+    const localBindings = new Map;
+    return {
+      ImportDeclaration(node) {
+        const source = node.source.value;
+        for (const specifier of node.specifiers) {
+          for (const [className, tracked] of trackedImports) {
+            if (tracked.source !== source)
+              continue;
+            if (specifier.type === AST_NODE_TYPES14.ImportDefaultSpecifier && specifier.local.name === className) {
+              localBindings.set(specifier.local.name, tracked);
+            }
+            if (specifier.type === AST_NODE_TYPES14.ImportSpecifier) {
+              const importedName = specifier.imported.type === AST_NODE_TYPES14.Identifier ? specifier.imported.name : specifier.imported.value;
+              if (importedName === className)
+                localBindings.set(specifier.local.name, tracked);
+            }
+          }
+        }
+      },
+      NewExpression(node) {
+        let trackedInfo;
+        let calleeName;
+        if (node.callee.type === AST_NODE_TYPES14.Identifier) {
+          calleeName = node.callee.name;
+          trackedInfo = localBindings.get(calleeName);
+        }
+        if (node.callee.type === AST_NODE_TYPES14.MemberExpression) {
+          const { property } = node.callee;
+          if (property.type === AST_NODE_TYPES14.Identifier) {
+            calleeName = property.name;
+            trackedInfo = trackedImports.get(calleeName);
+          }
+        }
+        if (!(trackedInfo && calleeName))
+          return;
+        const scope = context.sourceCode.getScope(node);
+        if (isTopScope2(scope))
+          return;
+        context.report({
+          data: {
+            className: trackedInfo.className,
+            source: trackedInfo.source
+          },
+          messageId: "mustBeModuleLevel",
+          node
+        });
+      }
+    };
+  },
+  defaultOptions: [{ classes: {} }],
+  meta: {
+    docs: {
+      description: "Require certain classes to be instantiated at module level rather than inside functions. Classes like Log should be instantiated once at module scope, not recreated on every function call."
+    },
+    messages: {
+      mustBeModuleLevel: "'{{className}}' from '{{source}}' must be instantiated at module level, not inside a function. Move `new {{className}}()` to the top of the file outside any function body. Instantiating inside functions recreates the object on every call, which wastes resources and may cause unexpected behavior."
+    },
+    schema: [
+      {
+        additionalProperties: false,
+        properties: {
+          classes: {
+            additionalProperties: { type: "string" },
+            description: "Map of class names to their import sources. Classes imported from these sources must be instantiated at module level.",
+            type: "object"
+          }
+        },
+        required: ["classes"],
+        type: "object"
+      }
+    ],
+    type: "problem"
+  },
+  name: "require-module-level-instantiation"
+});
+
 // src/rules/require-named-effect-functions.ts
 import { TSESTree as TSESTree9 } from "@typescript-eslint/types";
 
@@ -22511,7 +22610,7 @@ var requireNamedEffectFunctions = {
 var require_named_effect_functions_default = requireNamedEffectFunctions;
 
 // src/rules/require-paired-calls.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES14 } from "@typescript-eslint/types";
+import { AST_NODE_TYPES as AST_NODE_TYPES15 } from "@typescript-eslint/types";
 var isStringArray = Compile(build_default.Readonly(build_default.Array(build_default.String())));
 var isPairConfiguration = Compile(build_default.Readonly(build_default.Object({
   alternatives: build_default.Optional(isStringArray),
@@ -22529,20 +22628,20 @@ var isRuleOptions4 = Compile(build_default.Partial(build_default.Readonly(build_
   pairs: build_default.Readonly(build_default.Array(isPairConfiguration))
 }))));
 var LOOP_NODE_TYPES = new Set([
-  AST_NODE_TYPES14.DoWhileStatement,
-  AST_NODE_TYPES14.ForInStatement,
-  AST_NODE_TYPES14.ForOfStatement,
-  AST_NODE_TYPES14.ForStatement,
-  AST_NODE_TYPES14.WhileStatement
+  AST_NODE_TYPES15.DoWhileStatement,
+  AST_NODE_TYPES15.ForInStatement,
+  AST_NODE_TYPES15.ForOfStatement,
+  AST_NODE_TYPES15.ForStatement,
+  AST_NODE_TYPES15.WhileStatement
 ]);
 var DEFAULT_ROBLOX_YIELDING_FUNCTIONS = ["task.wait", "wait", "*.WaitForChild", "*.*Async"];
 function getCallName(node) {
   const { callee } = node;
-  if (callee.type === AST_NODE_TYPES14.Identifier)
+  if (callee.type === AST_NODE_TYPES15.Identifier)
     return callee.name;
-  if (callee.type === AST_NODE_TYPES14.MemberExpression) {
-    const object3 = callee.object.type === AST_NODE_TYPES14.Identifier ? callee.object.name : undefined;
-    const property = callee.property.type === AST_NODE_TYPES14.Identifier ? callee.property.name : undefined;
+  if (callee.type === AST_NODE_TYPES15.MemberExpression) {
+    const object3 = callee.object.type === AST_NODE_TYPES15.Identifier ? callee.object.name : undefined;
+    const property = callee.property.type === AST_NODE_TYPES15.Identifier ? callee.property.name : undefined;
     if (object3 !== undefined && property !== undefined)
       return `${object3}.${property}`;
   }
@@ -22578,12 +22677,12 @@ function isLoopLikeStatement(node) {
   return LOOP_NODE_TYPES.has(node.type);
 }
 function isSwitchStatement(node) {
-  return node?.type === AST_NODE_TYPES14.SwitchStatement;
+  return node?.type === AST_NODE_TYPES15.SwitchStatement;
 }
 function findLabeledStatementBody(label, startingNode) {
   let current = startingNode;
   while (current) {
-    if (current.type === AST_NODE_TYPES14.LabeledStatement && current.label.name === label.name)
+    if (current.type === AST_NODE_TYPES15.LabeledStatement && current.label.name === label.name)
       return current.body;
     current = current.parent ?? undefined;
   }
@@ -22845,7 +22944,7 @@ var rule = {
     function onIfConsequentExit(node) {
       const consequentNode = node;
       const { parent } = consequentNode;
-      if (parent?.type === AST_NODE_TYPES14.IfStatement) {
+      if (parent?.type === AST_NODE_TYPES15.IfStatement) {
         const branches = branchStacks.get(parent) ?? [];
         branches.push(cloneStack());
         branchStacks.set(parent, branches);
@@ -22860,7 +22959,7 @@ var rule = {
     function onIfAlternateExit(node) {
       const alternateNode = node;
       const { parent } = alternateNode;
-      if (parent?.type === AST_NODE_TYPES14.IfStatement) {
+      if (parent?.type === AST_NODE_TYPES15.IfStatement) {
         const branches = branchStacks.get(parent) ?? [];
         branches.push(cloneStack());
         branchStacks.set(parent, branches);
@@ -22909,7 +23008,7 @@ var rule = {
     function onTryBlockExit(node) {
       const blockNode = node;
       const { parent } = blockNode;
-      if (parent?.type === AST_NODE_TYPES14.TryStatement) {
+      if (parent?.type === AST_NODE_TYPES15.TryStatement) {
         const branches = branchStacks.get(parent) ?? [];
         branches.push(cloneStack());
         branchStacks.set(parent, branches);
@@ -22928,7 +23027,7 @@ var rule = {
     function onCatchClauseExit(node) {
       const catchNode = node;
       const { parent } = catchNode;
-      if (parent?.type === AST_NODE_TYPES14.TryStatement) {
+      if (parent?.type === AST_NODE_TYPES15.TryStatement) {
         const branches = branchStacks.get(parent) ?? [];
         branches.push(cloneStack());
         branchStacks.set(parent, branches);
@@ -22991,7 +23090,7 @@ var rule = {
     function onSwitchCaseExit(node) {
       const caseNode = node;
       const { parent } = caseNode;
-      if (parent?.type === AST_NODE_TYPES14.SwitchStatement) {
+      if (parent?.type === AST_NODE_TYPES15.SwitchStatement) {
         const branches = branchStacks.get(parent) ?? [];
         branches.push(cloneStack());
         branchStacks.set(parent, branches);
@@ -23022,7 +23121,7 @@ var rule = {
       for (const { opener, config, node: node2 } of openerStack) {
         const validClosers = getValidClosers(config);
         const closer = validClosers.length === 1 ? validClosers[0] ?? "closer" : validClosers.join("' or '");
-        const statementType = statementNode.type === AST_NODE_TYPES14.ReturnStatement ? "return" : "throw";
+        const statementType = statementNode.type === AST_NODE_TYPES15.ReturnStatement ? "return" : "throw";
         const lineNumber = statementNode.loc?.start.line ?? 0;
         context.report({
           data: {
@@ -23039,7 +23138,7 @@ var rule = {
       const statementNode = node;
       if (openerStack.length === 0)
         return;
-      const targetLoop = statementNode.type === AST_NODE_TYPES14.ContinueStatement ? resolveContinueTargetLoop(statementNode) : resolveBreakTargetLoop(statementNode);
+      const targetLoop = statementNode.type === AST_NODE_TYPES15.ContinueStatement ? resolveContinueTargetLoop(statementNode) : resolveBreakTargetLoop(statementNode);
       if (!targetLoop)
         return;
       for (const { node: openerNode, config, opener, loopAncestors } of openerStack) {
@@ -23047,7 +23146,7 @@ var rule = {
           continue;
         const validClosers = getValidClosers(config);
         const closer = validClosers.length === 1 ? validClosers[0] ?? "closer" : validClosers.join("' or '");
-        const statementType = statementNode.type === AST_NODE_TYPES14.BreakStatement ? "break" : "continue";
+        const statementType = statementNode.type === AST_NODE_TYPES15.BreakStatement ? "break" : "continue";
         const lineNumber = statementNode.loc?.start.line ?? 0;
         context.report({
           data: {
@@ -23185,7 +23284,7 @@ var rule = {
           continue;
         const validClosers = getValidClosers(config);
         const closer = validClosers.length === 1 ? validClosers[0] ?? "closer" : validClosers.join("' or '");
-        const asyncType = asyncNode.type === AST_NODE_TYPES14.AwaitExpression ? "await" : "yield";
+        const asyncType = asyncNode.type === AST_NODE_TYPES15.AwaitExpression ? "await" : "yield";
         context.report({
           data: { asyncType, closer, opener },
           messageId: "asyncViolation",
@@ -25186,9 +25285,15 @@ function createNoUselessUseSpringOptions(options3 = {}) {
 function createPreferPatternReplacementsOptions(patterns2 = []) {
   return { patterns: patterns2 };
 }
+function createPreferEnumItemOptions(options3 = {}) {
+  return { fixNumericToValue: false, performanceMode: false, ...options3 };
+}
 function createRequireReactDisplayNamesOptions(options3 = {}) {
   return { environment: "roblox-ts", ...options3 };
 }
+function createRequireModuleLevelInstantiationOptions(options3 = {}) {
+  return { classes: {}, ...options3 };
+}
 
 // src/index.ts
 var rules = {
@@ -25217,6 +25322,7 @@ var rules = {
   "prefer-singular-enums": prefer_singular_enums_default,
   "prefer-udim2-shorthand": prefer_udim2_shorthand_default,
   "react-hooks-strict-return": react_hooks_strict_return_default,
+  "require-module-level-instantiation": require_module_level_instantiation_default,
   "require-named-effect-functions": require_named_effect_functions_default,
   "require-paired-calls": require_paired_calls_default,
   "require-react-component-keys": require_react_component_keys_default,
@@ -25264,8 +25370,10 @@ export {
   createUseExhaustiveDependenciesOptions,
   createRequireReactDisplayNamesOptions,
   createRequirePairedCallsOptions,
+  createRequireModuleLevelInstantiationOptions,
   createReactKeysOptions,
   createPreferPatternReplacementsOptions,
+  createPreferEnumItemOptions,
   createPairConfiguration,
   createNoUselessUseSpringOptions,
   createNoShorthandOptions,

package/dist/rules/require-module-level-instantiation.d.ts

@@ -0,0 +1,25 @@
+import type { TSESLint } from "@typescript-eslint/utils";
+import type { ReadonlyRecord } from "../types/utility-types";
+/**
+ * Configuration for classes that must be instantiated at module level.
+ *
+ * Maps class names to their expected import sources.
+ *
+ * @example
+ * ```typescript
+ * {
+ *   classes: {
+ *     "Log": "@rbxts/rbxts-sleitnick-log",
+ *     "Server": "@rbxts/net"
+ *   }
+ * }
+ * ```
+ */
+export interface RequireModuleLevelInstantiationOptions {
+    readonly classes: ReadonlyRecord<string, string>;
+}
+type Options = [RequireModuleLevelInstantiationOptions?];
+declare const _default: TSESLint.RuleModule<"mustBeModuleLevel", Options, unknown, TSESLint.RuleListener> & {
+    name: string;
+};
+export default _default;

package/dist/utilities/configure-utilities.d.ts

@@ -6,6 +6,7 @@ import type { NoMemoChildrenOptions } from "../rules/no-memo-children";
 import type { NoShorthandOptions } from "../rules/no-shorthand-names";
 import type { NoUselessUseSpringOptions } from "../rules/no-useless-use-spring";
 import type { PreferEnumItemOptions } from "../rules/prefer-enum-item";
+import type { RequireModuleLevelInstantiationOptions } from "../rules/require-module-level-instantiation";
 import type { EffectFunctionOptions, HookConfiguration } from "../rules/require-named-effect-functions";
 import type { PairConfiguration, RequirePairedCallsOptions } from "../rules/require-paired-calls";
 import type { ReactKeysOptions } from "../rules/require-react-component-keys";
@@ -122,3 +123,9 @@ export declare function createPreferEnumItemOptions(options?: Partial<PreferEnum
  * @returns The full options
  */
 export declare function createRequireReactDisplayNamesOptions(options?: Partial<RequireReactDisplayNamesOptions>): RequireReactDisplayNamesOptions;
+/**
+ * Creates options for require-module-level-instantiation rule
+ * @param options - Partial configuration options
+ * @returns The full options
+ */
+export declare function createRequireModuleLevelInstantiationOptions(options?: Partial<RequireModuleLevelInstantiationOptions>): RequireModuleLevelInstantiationOptions;

package/package.json

@@ -85,24 +85,24 @@
 		"url": "git+https://github.com/howmanysmall/eslint-cease-nonsense-rules.git"
 	},
 	"scripts": {
-		"biome:ci": "bun x --bun biome ci",
+		"biome:ci": "biome ci",
 		"build": "./scripts/build.ts",
-		"build:legacy": "bun x --bun tsgo -p tsconfig.json",
-		"dev": "bun x --bun tsgo -w",
-		"format": "bun x oxfmt",
-		"knip": "bun x --bun knip-bun",
-		"lint": "bun run oxc . && bun x --bun biome lint .",
-		"lint:fix": "bun run oxc . --fix && bun x --bun biome lint . --fix",
-		"oxc": "bun x oxlint --type-aware",
-		"prepare": "bun x --bun simple-git-hooks",
+		"build:legacy": "tsgo -p tsconfig.json",
+		"dev": "tsgo -w",
+		"format": "oxfmt",
+		"knip": "knip-bun",
+		"lint": "bun run oxc . && bun x --bun biome check .",
+		"lint:fix": "bun run oxc . --fix && bun x --bun biome check . --fix",
+		"oxc": "oxlint --type-aware",
+		"prepare": "simple-git-hooks",
 		"prepublishOnly": "bun run build",
 		"release": "bumpp",
 		"test": "bun test",
-		"type-check": "bun x --bun tsgo --noEmit",
-		"type-check:safe": "bun x --bun tsc --noEmit"
+		"type-check": "tsgo --noEmit",
+		"type-check:safe": "tsc --noEmit"
 	},
 	"sideEffects": false,
 	"type": "module",
 	"types": "./dist/index.d.ts",
-	"version": "1.15.0"
+	"version": "1.16.0"
 }