@pobammer-ts/eslint-cease-nonsense-rules 1.14.1 → 1.16.0

package/README.md

@@ -49,6 +49,7 @@ export default [
 			"cease-nonsense/no-god-components": "error",
 			"cease-nonsense/no-identity-map": "error",
 			"cease-nonsense/no-instance-methods-without-this": "error",
+			"cease-nonsense/no-memo-children": "error",
 			"cease-nonsense/no-print": "error",
 			"cease-nonsense/prefer-enum-item": "error",
 			"cease-nonsense/no-shorthand-names": "error",
@@ -63,6 +64,7 @@ export default [
 			"cease-nonsense/prefer-singular-enums": "error",
 			"cease-nonsense/prefer-udim2-shorthand": "error",
 			"cease-nonsense/react-hooks-strict-return": "error",
+			"cease-nonsense/require-module-level-instantiation": "error",
 			"cease-nonsense/require-named-effect-functions": "error",
 			"cease-nonsense/require-paired-calls": "error",
 			"cease-nonsense/require-react-component-keys": "error",
@@ -215,6 +217,77 @@ function Input() {
 }
 ```
 
+#### `no-memo-children`
+
+Disallow `React.memo` on components that accept a `children` prop, since children typically change on every render and defeat memoization.
+
+**Why**
+
+`React.memo` performs a shallow comparison of props. When a component accepts `children`, the `children` prop is typically a new JSX element on every parent render. This causes the shallow comparison to fail every time, making `memo` useless while adding overhead.
+
+**Configuration**
+
+```typescript
+{
+  "cease-nonsense/no-memo-children": ["error", {
+    "allowedComponents": ["Modal", "Drawer"],  // Allow specific components
+    "environment": "roblox-ts"                  // or "standard"
+  }]
+}
+```
+
+**❌ Bad**
+
+```typescript
+import { memo, ReactNode } from "@rbxts/react";
+
+interface CardProps {
+	readonly title: string;
+	readonly children?: ReactNode;
+}
+
+// memo is useless - children change every render
+const Card = memo<CardProps>(({ title, children }) => {
+	return (
+		<frame>
+			<textlabel Text={title} />
+			{children}
+		</frame>
+	);
+});
+```
+
+**✅ Good**
+
+```typescript
+import { memo, ReactNode } from "@rbxts/react";
+
+// Option 1: Remove memo if you need children
+interface CardProps {
+	readonly title: string;
+	readonly children?: ReactNode;
+}
+
+function Card({ title, children }: CardProps) {
+	return (
+		<frame>
+			<textlabel Text={title} />
+			{children}
+		</frame>
+	);
+}
+
+// Option 2: Use render prop instead of children
+interface ListProps<T> {
+	readonly items: ReadonlyArray<T>;
+	readonly renderItem: (item: T) => ReactNode;
+}
+
+const List = memo(<T,>({ items, renderItem }: ListProps<T>) => {
+	return <frame>{items.map(renderItem)}</frame>;
+});
+```
+
 #### `no-god-components`
 
 Flags React components that are too large or doing too much, encouraging better separation of concerns.
@@ -1336,6 +1409,48 @@ class MyClass {
 }
 ```
 
+#### `require-module-level-instantiation`
+
+Require certain classes to be instantiated at module level rather than inside functions.
+
+Classes like Log should be instantiated once at module scope, not recreated on every function call.
+
+**Configuration**
+
+```typescript
+{
+  "cease-nonsense/require-module-level-instantiation": ["error", {
+    "classes": {
+      "Log": "@rbxts/rbxts-sleitnick-log",
+      "Server": "@rbxts/net"
+    }
+  }]
+}
+```
+
+**❌ Bad**
+
+```typescript
+import Log from "@rbxts/rbxts-sleitnick-log";
+
+function useStoryModesState() {
+	const log = new Log(); // Recreated on every call!
+	log.Info("Create Match clicked");
+}
+```
+
+**✅ Good**
+
+```typescript
+import Log from "@rbxts/rbxts-sleitnick-log";
+
+const log = new Log(); // Module level - created once
+
+function useStoryModesState() {
+	log.Info("Create Match clicked");
+}
+```
+
 ### Module Boundaries
 
 #### `strict-component-boundaries`

package/dist/build-metadata.json

@@ -1,5 +1,5 @@
 {
-  "commit": "a1999eb0db192f808a0d523d82258f6e35864ed3",
-  "time": "2026-01-10T03:50:18.800Z",
-  "version": "1.14.1"
+  "commit": "c91088ff8a466bdf3a9b204cd8b0b1cf001028a4",
+  "time": "2026-01-11T21:38:35.222Z",
+  "version": "1.16.0"
 }

package/dist/constants/react-sources.d.ts

@@ -0,0 +1,4 @@
+import type { TSESTree } from "@typescript-eslint/types";
+import type { EnvironmentMode } from "../types/environment-mode";
+export declare function getReactSources(environment: EnvironmentMode): Set<string>;
+export declare function isReactImport(node: TSESTree.ImportDeclaration, reactSources: Set<string>): boolean;

package/dist/index.d.ts

@@ -5,15 +5,18 @@ export type { ComplexityConfiguration } from "./rules/enforce-ianitor-check-type
 export type { NoGodComponentsOptions } from "./rules/no-god-components";
 export type { NoIdentityMapOptions } from "./rules/no-identity-map";
 export type { NoInstanceMethodsOptions } from "./rules/no-instance-methods-without-this";
+export type { NoMemoChildrenOptions } from "./rules/no-memo-children";
 export type { NoShorthandOptions } from "./rules/no-shorthand-names";
 export type { NoUselessUseSpringOptions } from "./rules/no-useless-use-spring";
 export type { PreferEnumItemOptions } from "./rules/prefer-enum-item";
-export type { EffectFunctionOptions, EnvironmentMode, HookConfiguration } from "./rules/require-named-effect-functions";
+export type { RequireModuleLevelInstantiationOptions } from "./rules/require-module-level-instantiation";
+export type { EffectFunctionOptions, HookConfiguration } from "./rules/require-named-effect-functions";
 export type { PairConfiguration, RequirePairedCallsOptions } from "./rules/require-paired-calls";
 export type { ReactKeysOptions } from "./rules/require-react-component-keys";
 export type { RequireReactDisplayNamesOptions } from "./rules/require-react-display-names";
 export type { HookEntry, UseExhaustiveDependenciesOptions } from "./rules/use-exhaustive-dependencies";
-export { createBanInstancesOptions, createComplexityConfiguration, createEffectFunctionOptions, createHookConfiguration, createNoGodComponentsOptions, createNoInstanceMethodsOptions, createNoShorthandOptions, createNoUselessUseSpringOptions, createPairConfiguration, createPreferPatternReplacementsOptions, createReactKeysOptions, createRequirePairedCallsOptions, createRequireReactDisplayNamesOptions, createUseExhaustiveDependenciesOptions, createUseHookAtTopLevelOptions, defaultRobloxProfilePair, } from "./utilities/configure-utilities";
+export type { EnvironmentMode } from "./types/environment-mode";
+export { createBanInstancesOptions, createComplexityConfiguration, createEffectFunctionOptions, createHookConfiguration, createNoGodComponentsOptions, createNoInstanceMethodsOptions, createNoMemoChildrenOptions, createNoShorthandOptions, createNoUselessUseSpringOptions, createPairConfiguration, createPreferEnumItemOptions, createPreferPatternReplacementsOptions, createReactKeysOptions, createRequireModuleLevelInstantiationOptions, createRequirePairedCallsOptions, createRequireReactDisplayNamesOptions, createUseExhaustiveDependenciesOptions, createUseHookAtTopLevelOptions, defaultRobloxProfilePair, } from "./utilities/configure-utilities";
 export type { Pattern, PreferPatternReplacementsOptions } from "./utilities/pattern-replacement";
 export { pattern } from "./utilities/pattern-replacement";
 /**
@@ -47,6 +50,7 @@ declare const recommended: {
         readonly "cease-nonsense/no-god-components": "error";
         readonly "cease-nonsense/no-identity-map": "error";
         readonly "cease-nonsense/no-instance-methods-without-this": "error";
+        readonly "cease-nonsense/no-memo-children": "error";
         readonly "cease-nonsense/no-print": "error";
         readonly "cease-nonsense/no-shorthand-names": "error";
         readonly "cease-nonsense/no-warn": "error";
@@ -68,4 +72,3 @@ interface Plugin {
 }
 declare const plugin: Plugin;
 export default plugin;
-//# sourceMappingURL=index.d.ts.map