@pnpm/napi 12.3.3 → 12.4.0

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @pnpm/napi
 
+## 12.4.0
+
+### Patch Changes
+
+- Fixed a memory leak in the N-API bindings. Concurrent calls that resolved the same configuration each retained their own copy for the life of the process [pnpm/pnpm#14386](https://github.com/pnpm/pnpm/issues/14386).
+
+## 12.3.4
+
 ## 12.3.3
 
 ## 12.3.2

package/README.md

@@ -102,12 +102,13 @@ The addon ships as prebuilt per-platform packages, the same model as the
   `@pnpm/napi.<platform>` optional dependency, then a local build.
 - CI cross-compiles the addon per target (`napi build --release --target
   <rust-triple>`), uploads each as `pnpm-napi.<codeTarget>.node` at the repo
-  root, then runs `scripts/generate-packages.mjs` to produce the eight
-  `@pnpm/napi.<platform>` packages and wire them as this wrapper's
-  `optionalDependencies`.
+  root, then runs `scripts/generate-packages.mjs` to produce the
+  `@pnpm/napi.<platform>` packages listed below and wire them as this
+  wrapper's `optionalDependencies`.
 
 Supported targets: `win32-x64`, `win32-arm64`, `darwin-x64`, `darwin-arm64`,
-`linux-x64`, `linux-arm64`, `linux-x64-musl`, `linux-arm64-musl`.
+`linux-x64`, `linux-arm64`, `linux-riscv64`, `linux-ppc64`, `linux-s390x`,
+`linux-x64-musl`, `linux-arm64-musl`, `freebsd-x64`, `android-arm64`, `android-x64`.
 
 ## Local development
 

package/index.js

@@ -13,6 +13,7 @@
 
 const path = require('node:path')
 const fs = require('node:fs')
+const os = require('node:os')
 
 // `'glibc' | 'musl' | null` — `null` when the host isn't Linux or the libc
 // can't be probed (`process.report` may be unavailable/disabled). glibc builds
@@ -39,6 +40,14 @@ function platformTriples() {
   return [`${platform}-${arch}`]
 }
 
+// Node reports both POWER endiannesses as `ppc64` and npm's `cpu` field cannot
+// tell them apart, so a big-endian host can install the little-endian addon.
+// Only the little-endian build is released, so no platform package can serve
+// such a host and one built locally is all that is left.
+function hasReleasedPlatformPackage() {
+  return process.arch !== 'ppc64' || os.endianness() === 'LE'
+}
+
 function tryLoad(candidate, loadErrors) {
   if (!candidate) return null
   try {
@@ -73,11 +82,12 @@ function isMissingCandidate(err, candidate) {
 }
 
 function loadFailure(triple, loadErrors) {
-  const error = new Error(
-    `Failed to load the pnpm Rust engine for ${triple}. ` +
-      'Install the matching @pnpm/napi platform package, or point ' +
+  const remedy = hasReleasedPlatformPackage()
+    ? 'Install the matching @pnpm/napi platform package, or point ' +
       'PNPM_NAPI_BINARY at a locally built .node file.'
-  )
+    : 'No addon is published for this host, so point PNPM_NAPI_BINARY at a ' +
+      'locally built .node file.'
+  const error = new Error(`Failed to load the pnpm Rust engine for ${triple}. ${remedy}`)
   if (loadErrors.length > 0) {
     error.cause = loadErrors[0]
   }
@@ -104,9 +114,10 @@ function loadBinding() {
   // Platform packages / local artifacts. On Linux both libc variants are tried,
   // so a wrong-ABI first candidate (an `ERR_DLOPEN_FAILED`) falls through to the
   // other rather than aborting.
+  const platformPackages = hasReleasedPlatformPackage()
   const candidates = [
     ...triples.flatMap((triple) => [
-      `@pnpm/napi.${triple}`,
+      ...(platformPackages ? [`@pnpm/napi.${triple}`] : []),
       path.join(__dirname, `pnpm-napi.${triple}.node`),
     ]),
     path.join(__dirname, 'pnpm-napi.node'),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pnpm/napi",
-  "version": "12.3.3",
+  "version": "12.4.0",
   "description": "Node.js addon bindings for the pnpm v12 Rust engine (pacquet)",
   "keywords": [
     "pnpm",
@@ -28,14 +28,20 @@
     "THIRD-PARTY-NOTICES.md"
   ],
   "optionalDependencies": {
-    "@pnpm/napi.win32-x64": "12.3.3",
-    "@pnpm/napi.win32-arm64": "12.3.3",
-    "@pnpm/napi.darwin-x64": "12.3.3",
-    "@pnpm/napi.darwin-arm64": "12.3.3",
-    "@pnpm/napi.linux-x64": "12.3.3",
-    "@pnpm/napi.linux-arm64": "12.3.3",
-    "@pnpm/napi.linux-x64-musl": "12.3.3",
-    "@pnpm/napi.linux-arm64-musl": "12.3.3"
+    "@pnpm/napi.win32-x64": "12.4.0",
+    "@pnpm/napi.win32-arm64": "12.4.0",
+    "@pnpm/napi.darwin-x64": "12.4.0",
+    "@pnpm/napi.darwin-arm64": "12.4.0",
+    "@pnpm/napi.linux-x64": "12.4.0",
+    "@pnpm/napi.linux-arm64": "12.4.0",
+    "@pnpm/napi.linux-riscv64": "12.4.0",
+    "@pnpm/napi.linux-ppc64": "12.4.0",
+    "@pnpm/napi.linux-s390x": "12.4.0",
+    "@pnpm/napi.linux-x64-musl": "12.4.0",
+    "@pnpm/napi.linux-arm64-musl": "12.4.0",
+    "@pnpm/napi.freebsd-x64": "12.4.0",
+    "@pnpm/napi.android-arm64": "12.4.0",
+    "@pnpm/napi.android-x64": "12.4.0"
   },
   "scripts": {
     "generate-packages": "node scripts/generate-packages.mjs"