@pnpm/installing.commands 1100.7.2 → 1100.7.3

package/lib/handleIgnoredBuilds.js

@@ -1,5 +1,5 @@
+import { allowBuildKeyFromIgnoredBuild } from '@pnpm/building.policy';
 import { writeSettings } from '@pnpm/config.writer';
-import { parse } from '@pnpm/deps.path';
 import { IgnoredBuildsError, } from '@pnpm/installing.deps-installer';
 import { lexCompare } from '@pnpm/util.lex-comparator';
 export async function handleIgnoredBuilds(opts, ignoredBuilds) {
@@ -29,6 +29,6 @@ async function writeIgnoredBuildsToAllowBuilds(opts, ignoredBuilds) {
     }
 }
 function packageNamesFromIgnoredBuilds(ignoredBuilds) {
-    return Array.from(new Set(Array.from(ignoredBuilds).map((dp) => parse(dp).name ?? dp))).sort(lexCompare);
+    return Array.from(new Set(Array.from(ignoredBuilds).map(allowBuildKeyFromIgnoredBuild))).sort(lexCompare);
 }
 //# sourceMappingURL=handleIgnoredBuilds.js.map

package/lib/install.js

@@ -208,7 +208,7 @@ by any dependencies, so it is an emulation of a flat node_modules',
                         name: '--ignore-workspace',
                     },
                     {
-                        description: "If false, doesn't check whether packages in the store were mutated",
+                        description: 'If false, skips store integrity checks. These checks detect accidental corruption, not tampering by untrusted users with write access to the store',
                         name: '--[no-]verify-store-integrity',
                     },
                     {

package/lib/installDeps.js

@@ -21,6 +21,7 @@ import { setupPolicyHandlers } from './policyHandlers.js';
 import { createMatcher, makeIgnorePatterns, matchDependencies, recursive, } from './recursive.js';
 import { makeRunPacquet } from './runPacquet.js';
 import { createWorkspaceSpecs, updateToWorkspacePackagesFromManifest } from './updateWorkspaceDependencies.js';
+import { verifyPacquetIdentity } from './verifyPacquetIdentity.js';
 const OVERWRITE_UPDATE_OPTIONS = {
     allowNew: true,
     update: false,
@@ -67,11 +68,26 @@ export async function installDeps(opts, params) {
     // optional `@pacquet/<plat>-<arch>` binary sub-packages, so the
     // resolved \`node_modules/.pnpm-config/<name>\` layout pacquet's
     // wrapper expects is identical either way.
-    const pacquetConfigDepName = opts.configDependencies?.['@pnpm/pacquet'] != null
+    //
+    // `configDependencies` come from the repository's `pnpm-workspace.yaml`, so
+    // the declaration cannot be trusted to authorize spawning a native binary on
+    // its own. `verifyPacquetIdentity` confirms, against the canonical npm
+    // registry, that the installed bytes carry a valid registry signature for
+    // that `name@version` before we delegate; otherwise we fall back to pnpm's
+    // own engine.
+    const declaredPacquetConfigDepName = opts.configDependencies?.['@pnpm/pacquet'] != null
         ? '@pnpm/pacquet'
         : opts.configDependencies?.pacquet != null
             ? 'pacquet'
             : undefined;
+    const pacquetConfigDepName = declaredPacquetConfigDepName != null &&
+        await verifyPacquetIdentity(declaredPacquetConfigDepName, {
+            ...opts,
+            lockfileDir: opts.lockfileDir ?? opts.dir,
+            rootDir: opts.lockfileDir ?? opts.dir,
+        })
+        ? declaredPacquetConfigDepName
+        : undefined;
     const runPacquet = pacquetConfigDepName != null
         ? makeRunPacquet({
             lockfileDir: opts.lockfileDir ?? opts.dir,

package/lib/verifyPacquetIdentity.d.ts

@@ -0,0 +1,34 @@
+import type { CreateFetchFromRegistryOptions, RetryTimeoutOptions } from '@pnpm/network.fetch';
+import type { Registries, RegistryConfig } from '@pnpm/types';
+export interface VerifyPacquetIdentityOptions extends CreateFetchFromRegistryOptions {
+    lockfileDir: string;
+    rootDir: string;
+    registries: Registries;
+    configByUri?: Record<string, RegistryConfig>;
+    retry?: RetryTimeoutOptions;
+    timeout?: number;
+    networkConcurrency?: number;
+}
+/**
+ * Decides whether pnpm may spawn the pacquet binary installed under
+ * `node_modules/.pnpm-config/<packageName>` as an install engine.
+ *
+ * A repository declares pacquet in its `pnpm-workspace.yaml`
+ * `configDependencies` and controls the lockfile integrity and the registry
+ * the bytes came from — so the declaration alone cannot authorize running a
+ * native binary. This verifies that the exact bytes installed on disk (the
+ * `pacquet` shim and the host's `@pacquet/<platform>-<arch>` binary, which is
+ * what actually executes) carry a valid npm registry signature for that
+ * `name@version`, checked against npm's embedded public keys. The signature is
+ * verified over the *installed* integrity, so substituted or tampered bytes
+ * fail — and because the keys are embedded rather than fetched, a repository
+ * pointing the registry at a server it controls cannot supply its own key pair.
+ *
+ * Fails closed: if a declared pacquet's signature does not verify, or it cannot
+ * be verified (e.g. the registry is unreachable), this throws rather than
+ * silently running pnpm's own engine — a verification failure should be loud.
+ * The one exception is when pacquet simply has no binary for this platform: that
+ * is unavailability, not tampering, so it returns `false` and the caller uses
+ * pnpm's own install engine.
+ */
+export declare function verifyPacquetIdentity(packageName: 'pacquet' | '@pnpm/pacquet', opts: VerifyPacquetIdentityOptions): Promise<boolean>;

package/lib/verifyPacquetIdentity.js

@@ -0,0 +1,87 @@
+import { pickRegistryForPackage } from '@pnpm/config.pick-registry-for-package';
+import { getNpmSigningKeys, verifyInstalledPackageSignatures, } from '@pnpm/deps.security.signatures';
+import { PnpmError } from '@pnpm/error';
+import { readEnvLockfile } from '@pnpm/lockfile.fs';
+import { logger } from '@pnpm/logger';
+import { createGetAuthHeaderByURI } from '@pnpm/network.auth-header';
+/**
+ * Decides whether pnpm may spawn the pacquet binary installed under
+ * `node_modules/.pnpm-config/<packageName>` as an install engine.
+ *
+ * A repository declares pacquet in its `pnpm-workspace.yaml`
+ * `configDependencies` and controls the lockfile integrity and the registry
+ * the bytes came from — so the declaration alone cannot authorize running a
+ * native binary. This verifies that the exact bytes installed on disk (the
+ * `pacquet` shim and the host's `@pacquet/<platform>-<arch>` binary, which is
+ * what actually executes) carry a valid npm registry signature for that
+ * `name@version`, checked against npm's embedded public keys. The signature is
+ * verified over the *installed* integrity, so substituted or tampered bytes
+ * fail — and because the keys are embedded rather than fetched, a repository
+ * pointing the registry at a server it controls cannot supply its own key pair.
+ *
+ * Fails closed: if a declared pacquet's signature does not verify, or it cannot
+ * be verified (e.g. the registry is unreachable), this throws rather than
+ * silently running pnpm's own engine — a verification failure should be loud.
+ * The one exception is when pacquet simply has no binary for this platform: that
+ * is unavailability, not tampering, so it returns `false` and the caller uses
+ * pnpm's own install engine.
+ */
+export async function verifyPacquetIdentity(packageName, opts) {
+    const trustedKeys = getNpmSigningKeys();
+    const toVerify = await collectPacquetPackagesToVerify(packageName, opts.rootDir, opts.registries);
+    if (toVerify == null) {
+        // pacquet has no installed binary for this platform — use pnpm's own engine.
+        return skip(opts.lockfileDir);
+    }
+    const getAuthHeader = createGetAuthHeaderByURI(opts.configByUri ?? {});
+    let result;
+    try {
+        result = await verifyInstalledPackageSignatures(toVerify, trustedKeys, getAuthHeader, opts);
+    }
+    catch (err) {
+        throw new PnpmError('PACQUET_IDENTITY_UNVERIFIABLE', `Refusing to use pacquet as the install engine: its npm registry signature could not be verified (${String(err)}).`, { hint: 'The registry must be reachable to verify the pacquet release declared in configDependencies. Remove pacquet from configDependencies to use pnpm\'s own install engine.' });
+    }
+    if (!result.verified) {
+        const detail = result.failures.map(({ name, version, reason }) => `${name}@${version}: ${reason}`).join('; ');
+        throw new PnpmError('PACQUET_IDENTITY_MISMATCH', `Refusing to use pacquet as the install engine: the bytes installed for "${packageName}" do not match a published, signed release (${detail}).`, { hint: 'This can indicate a tampered lockfile or a malicious registry. Remove pacquet from configDependencies if this is unexpected.' });
+    }
+    return true;
+}
+async function collectPacquetPackagesToVerify(packageName, rootDir, registries) {
+    const envLockfile = await readEnvLockfile(rootDir);
+    if (envLockfile == null)
+        return undefined;
+    const shim = envLockfile.importers['.']?.configDependencies?.[packageName];
+    if (shim == null)
+        return undefined;
+    const shimKey = `${packageName}@${shim.version}`;
+    const shimIntegrity = registryIntegrity(envLockfile.packages[shimKey]?.resolution);
+    if (shimIntegrity == null)
+        return undefined;
+    // Only the host's platform binary is ever spawned, so that's the one whose
+    // identity matters. If it isn't in the lockfile, pacquet couldn't run here.
+    const platformPkgName = `@pacquet/${process.platform}-${process.arch}`;
+    const platformVersion = envLockfile.snapshots[shimKey]?.optionalDependencies?.[platformPkgName];
+    if (platformVersion == null)
+        return undefined;
+    const platformKey = `${platformPkgName}@${platformVersion}`;
+    const platformIntegrity = registryIntegrity(envLockfile.packages[platformKey]?.resolution);
+    if (platformIntegrity == null)
+        return undefined;
+    return [
+        { name: packageName, version: shim.version, registry: pickRegistryForPackage(registries, packageName), integrity: shimIntegrity },
+        { name: platformPkgName, version: platformVersion, registry: pickRegistryForPackage(registries, platformPkgName), integrity: platformIntegrity },
+    ];
+}
+function registryIntegrity(resolution) {
+    const integrity = resolution?.integrity;
+    return typeof integrity === 'string' && integrity ? integrity : undefined;
+}
+function skip(prefix) {
+    logger.warn({
+        message: "Not using pacquet as the install engine: no pacquet binary is installed for this platform. Using pnpm's own install engine.",
+        prefix,
+    });
+    return false;
+}
+//# sourceMappingURL=verifyPacquetIdentity.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pnpm/installing.commands",
-  "version": "1100.7.2",
+  "version": "1100.7.3",
   "description": "Commands for installation",
   "keywords": [
     "pnpm",
@@ -47,46 +47,51 @@
     "ramda": "npm:@pnpm/ramda@0.28.1",
     "render-help": "^2.0.0",
     "version-selector-type": "^3.0.0",
-    "@pnpm/building.after-install": "1101.0.19",
-    "@pnpm/catalogs.types": "1100.0.0",
-    "@pnpm/cli.common-cli-options-help": "1100.0.1",
+    "@pnpm/building.policy": "1100.0.9",
     "@pnpm/cli.command": "1100.0.1",
-    "@pnpm/cli.utils": "1101.0.9",
+    "@pnpm/catalogs.types": "1100.0.0",
+    "@pnpm/cli.common-cli-options-help": "1100.0.2",
+    "@pnpm/cli.utils": "1101.0.10",
     "@pnpm/config.matcher": "1100.0.1",
-    "@pnpm/config.reader": "1101.6.0",
-    "@pnpm/deps.inspection.outdated": "1100.1.5",
+    "@pnpm/config.pick-registry-for-package": "1100.0.8",
+    "@pnpm/config.writer": "1100.0.12",
     "@pnpm/constants": "1100.0.0",
-    "@pnpm/config.pick-registry-for-package": "1100.0.7",
-    "@pnpm/config.writer": "1100.0.11",
+    "@pnpm/config.reader": "1101.7.0",
+    "@pnpm/deps.inspection.outdated": "1100.1.6",
+    "@pnpm/deps.status": "1100.0.23",
+    "@pnpm/deps.path": "1100.0.7",
+    "@pnpm/deps.security.signatures": "1101.2.0",
+    "@pnpm/error": "1100.0.0",
     "@pnpm/fs.graceful-fs": "1100.1.0",
     "@pnpm/fs.read-modules-dir": "1100.0.1",
-    "@pnpm/global.commands": "1100.0.25",
-    "@pnpm/error": "1100.0.0",
-    "@pnpm/hooks.pnpmfile": "1100.0.12",
-    "@pnpm/installing.context": "1100.0.15",
-    "@pnpm/installing.deps-installer": "1101.7.0",
-    "@pnpm/deps.status": "1100.0.22",
-    "@pnpm/installing.env-installer": "1101.1.6",
-    "@pnpm/lockfile.types": "1100.0.9",
-    "@pnpm/resolving.npm-resolver": "1101.5.0",
-    "@pnpm/pkg-manifest.reader": "1100.0.6",
+    "@pnpm/global.commands": "1100.0.26",
+    "@pnpm/hooks.pnpmfile": "1100.0.13",
+    "@pnpm/installing.context": "1100.0.16",
+    "@pnpm/installing.dedupe.check": "1100.0.10",
+    "@pnpm/building.after-install": "1101.0.20",
+    "@pnpm/installing.deps-installer": "1101.8.0",
+    "@pnpm/lockfile.fs": "1100.1.4",
+    "@pnpm/installing.env-installer": "1101.1.7",
+    "@pnpm/lockfile.types": "1100.0.10",
+    "@pnpm/network.fetch": "1100.1.1",
+    "@pnpm/network.auth-header": "1101.1.1",
+    "@pnpm/resolving.npm-resolver": "1101.5.1",
     "@pnpm/resolving.parse-wanted-dependency": "1100.0.1",
-    "@pnpm/resolving.resolver-base": "1100.4.0",
-    "@pnpm/types": "1101.3.0",
-    "@pnpm/deps.path": "1100.0.6",
-    "@pnpm/store.controller": "1101.0.11",
-    "@pnpm/store.connection-manager": "1100.2.6",
-    "@pnpm/workspace.project-manifest-writer": "1100.0.6",
-    "@pnpm/workspace.projects-filter": "1100.0.18",
-    "@pnpm/workspace.projects-reader": "1101.0.9",
-    "@pnpm/workspace.project-manifest-reader": "1100.0.10",
-    "@pnpm/workspace.projects-sorter": "1100.0.5",
-    "@pnpm/workspace.projects-graph": "1100.0.15",
+    "@pnpm/pkg-manifest.utils": "1100.2.3",
+    "@pnpm/resolving.resolver-base": "1100.4.1",
+    "@pnpm/store.controller": "1101.0.12",
+    "@pnpm/types": "1101.3.1",
+    "@pnpm/store.connection-manager": "1100.2.7",
+    "@pnpm/workspace.project-manifest-reader": "1100.0.11",
+    "@pnpm/workspace.projects-filter": "1100.0.19",
+    "@pnpm/workspace.project-manifest-writer": "1100.0.7",
+    "@pnpm/workspace.projects-reader": "1101.0.10",
+    "@pnpm/workspace.projects-sorter": "1100.0.6",
+    "@pnpm/workspace.projects-graph": "1100.0.16",
+    "@pnpm/workspace.state": "1100.0.20",
+    "@pnpm/workspace.workspace-manifest-writer": "1100.0.12",
     "@pnpm/workspace.root-finder": "1100.0.1",
-    "@pnpm/workspace.state": "1100.0.19",
-    "@pnpm/workspace.workspace-manifest-writer": "1100.0.11",
-    "@pnpm/pkg-manifest.utils": "1100.2.2",
-    "@pnpm/installing.dedupe.check": "1100.0.9"
+    "@pnpm/pkg-manifest.reader": "1100.0.7"
   },
   "peerDependencies": {
     "@pnpm/logger": "^1001.0.1"
@@ -108,19 +113,19 @@
     "write-json-file": "^7.0.0",
     "write-package": "7.2.0",
     "write-yaml-file": "^6.0.0",
-    "@pnpm/assert-project": "1100.0.13",
-    "@pnpm/installing.modules-yaml": "1100.0.7",
+    "@pnpm/installing.commands": "1100.7.3",
+    "@pnpm/installing.modules-yaml": "1100.0.8",
     "@pnpm/logger": "1100.0.0",
-    "@pnpm/installing.commands": "1100.7.2",
-    "@pnpm/prepare": "1100.0.13",
-    "@pnpm/test-fixtures": "1100.0.0",
+    "@pnpm/prepare": "1100.0.14",
+    "@pnpm/assert-project": "1100.0.14",
     "@pnpm/store.index": "1100.1.0",
+    "@pnpm/test-fixtures": "1100.0.0",
+    "@pnpm/testing.command-defaults": "1100.0.4",
+    "@pnpm/testing.registry-mock": "1100.0.4",
+    "@pnpm/testing.mock-agent": "1101.0.1",
     "@pnpm/test-ipc-server": "1100.0.0",
-    "@pnpm/testing.command-defaults": "1100.0.3",
-    "@pnpm/testing.registry-mock": "1100.0.3",
-    "@pnpm/testing.mock-agent": "1101.0.0",
-    "@pnpm/workspace.projects-filter": "1100.0.18",
-    "@pnpm/worker": "1100.1.9"
+    "@pnpm/workspace.projects-filter": "1100.0.19",
+    "@pnpm/worker": "1100.1.10"
   },
   "engines": {
     "node": ">=22.13"