@pnpm/global.packages 1101.1.3 → 1101.1.4

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @pnpm/global.packages
 
+## 1101.1.4
+
+### Patch Changes
+
+- `pnpm add -g`, `pnpm update -g`, and `pnpm remove -g` no longer fail with `ERR_PNPM_PACKAGE_MANIFEST_IO_ERROR` when another global package's link into the store dangles, for example after the store was pruned. The pnpm install script failed the same way on such a machine.
+
+- Updated dependencies:
+  - @pnpm/bins.resolver@1100.0.17
+  - @pnpm/crypto.hash@1100.0.6
+  - @pnpm/pkg-manifest.reader@1100.0.20
+  - @pnpm/types@1102.1.1
+
 ## 1101.1.3
 
 ### Patch Changes

package/lib/scanGlobalPackages.d.ts

@@ -18,4 +18,15 @@ export declare function scanGlobalPackages(globalDir: string): GlobalPackageInfo
 export declare function findGlobalPackage(globalDir: string, alias: string): GlobalPackageInfo | null;
 export declare function getGlobalPackageDetails(info: GlobalPackageInfo): Promise<InstalledGlobalPackage[]>;
 export declare function cleanOrphanedInstallDirs(globalDir: string): void;
+/**
+ * The bin names installed by a group (deduplicated).
+ *
+ * A group whose `node_modules` is wholly absent owns no bins, and neither
+ * does a declared dependency whose directory under `node_modules` is absent,
+ * a link left dangling by a pruned store included: no bin can resolve
+ * through a directory that is not there. Every dependency directory that
+ * does exist must hold a readable, valid manifest: returning a partial set
+ * would make destructive callers mistake unknown ownership for an unowned
+ * bin.
+ */
 export declare function getInstalledBinNames(info: GlobalPackageInfo): Promise<string[]>;

package/lib/scanGlobalPackages.js

@@ -46,9 +46,8 @@ export function scanGlobalPackages(globalDir) {
         entries = fs.readdirSync(globalDir, { withFileTypes: true });
     }
     catch (err) {
-        if (util.types.isNativeError(err) && 'code' in err && err.code === 'ENOENT') {
+        if (isNotFound(err))
             return [];
-        }
         throw err;
     }
     const result = [];
@@ -139,13 +138,36 @@ export function cleanOrphanedInstallDirs(globalDir) {
         fs.rmSync(dirPath, { recursive: true, force: true });
     }
 }
+/**
+ * The bin names installed by a group (deduplicated).
+ *
+ * A group whose `node_modules` is wholly absent owns no bins, and neither
+ * does a declared dependency whose directory under `node_modules` is absent,
+ * a link left dangling by a pruned store included: no bin can resolve
+ * through a directory that is not there. Every dependency directory that
+ * does exist must hold a readable, valid manifest: returning a partial set
+ * would make destructive callers mistake unknown ownership for an unowned
+ * bin.
+ */
 export async function getInstalledBinNames(info) {
     const bins = new Set();
     const aliases = Object.keys(info.dependencies);
     const modulesDir = path.join(info.installDir, 'node_modules');
+    if (!await dirExists(modulesDir))
+        return [];
     await Promise.all(aliases.map(async (alias) => {
         const depDir = path.join(modulesDir, alias);
-        const manifest = await readPackageJsonFromDir(depDir);
+        let manifest;
+        try {
+            manifest = await readPackageJsonFromDir(depDir);
+        }
+        catch (err) {
+            // Probing after the read rather than before also covers a link
+            // pruned while the scan runs.
+            if (isNotFound(err) && !await dirExists(depDir))
+                return;
+            throw err;
+        }
         const binsOfPkg = await getBinsFromPackageManifest(manifest, depDir);
         for (const bin of binsOfPkg) {
             bins.add(bin.name);
@@ -153,4 +175,22 @@ export async function getInstalledBinNames(info) {
     }));
     return [...bins];
 }
+/**
+ * Only ENOENT reads as absent; every other error surfaces, so unreadable
+ * ownership is never mistaken for unowned.
+ */
+async function dirExists(dir) {
+    try {
+        await fs.promises.stat(dir);
+        return true;
+    }
+    catch (err) {
+        if (isNotFound(err))
+            return false;
+        throw err;
+    }
+}
+function isNotFound(err) {
+    return util.types.isNativeError(err) && 'code' in err && err.code === 'ENOENT';
+}
 //# sourceMappingURL=scanGlobalPackages.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pnpm/global.packages",
-  "version": "1101.1.3",
+  "version": "1101.1.4",
   "description": "Utilities for managing isolated global packages",
   "keywords": [
     "pnpm",
@@ -28,14 +28,14 @@
     "!*.map"
   ],
   "dependencies": {
-    "@pnpm/bins.resolver": "1100.0.16",
-    "@pnpm/crypto.hash": "1100.0.5",
-    "@pnpm/pkg-manifest.reader": "1100.0.19",
+    "@pnpm/bins.resolver": "1100.0.17",
+    "@pnpm/crypto.hash": "1100.0.6",
+    "@pnpm/pkg-manifest.reader": "1100.0.20",
     "@pnpm/text.ordinal-comparator": "1100.0.0",
-    "@pnpm/types": "1102.1.0"
+    "@pnpm/types": "1102.1.1"
   },
   "devDependencies": {
-    "@pnpm/global.packages": "1101.1.3"
+    "@pnpm/global.packages": "1101.1.4"
   },
   "engines": {
     "node": ">=22.13"