@pnpm/global.commands 1100.0.6 → 1100.0.7

package/lib/promptApproveGlobalBuilds.d.ts

@@ -20,5 +20,12 @@ export interface PromptApproveGlobalBuildsOptions {
  * only on the install directory — otherwise it would treat the global
  * packages dir as a workspace and discover sibling install directories as
  * workspace projects.
+ *
+ * `modulesDir` is left undefined so that downstream consumers compute it
+ * relative to `lockfileDir`. Passing an absolute value here would be
+ * forwarded as-is to `install.handler`, which treats `modulesDir` as a
+ * path relative to `lockfileDir` and joins it again — producing a
+ * doubled path on Windows (path.join does not collapse an embedded
+ * absolute path).
  */
 export declare function promptApproveGlobalBuilds(opts: PromptApproveGlobalBuildsOptions, commands: CommandHandlerMap): Promise<void>;

package/lib/promptApproveGlobalBuilds.js

@@ -1,4 +1,14 @@
-import path from 'node:path';
+/**
+ * Test-only env var. When set, `promptApproveGlobalBuilds` bypasses the
+ * TTY check and forwards `all: true` so the `approve-builds` command
+ * skips both its multiselect and confirm prompts. The flow then runs
+ * the same install machinery as a real interactive approval, which is
+ * what e2e tests need to reproduce regressions in this code path.
+ *
+ * Not for production use — pnpm has no UI to opt into "approve every
+ * pending build" silently, by design.
+ */
+const AUTO_APPROVE_FOR_TESTS_ENV = 'PNPM_AUTO_APPROVE_BUILDS_FOR_TESTS';
 /**
  * If the previous global install left builds awaiting approval, run the
  * interactive `approve-builds` flow against the install directory.
@@ -11,9 +21,19 @@ import path from 'node:path';
  * only on the install directory — otherwise it would treat the global
  * packages dir as a workspace and discover sibling install directories as
  * workspace projects.
+ *
+ * `modulesDir` is left undefined so that downstream consumers compute it
+ * relative to `lockfileDir`. Passing an absolute value here would be
+ * forwarded as-is to `install.handler`, which treats `modulesDir` as a
+ * path relative to `lockfileDir` and joins it again — producing a
+ * doubled path on Windows (path.join does not collapse an embedded
+ * absolute path).
  */
 export async function promptApproveGlobalBuilds(opts, commands) {
-    if (!opts.ignoredBuilds?.size || !process.stdin.isTTY)
+    if (!opts.ignoredBuilds?.size)
+        return;
+    const autoApproveForTests = process.env[AUTO_APPROVE_FOR_TESTS_ENV] === '1';
+    if (!autoApproveForTests && !process.stdin.isTTY)
         return;
     await commands['approve-builds']({
         ...opts.inheritedOpts,
@@ -21,7 +41,7 @@ export async function promptApproveGlobalBuilds(opts, commands) {
         allProjects: undefined,
         selectedProjectsGraph: undefined,
         workspacePackagePatterns: undefined,
-        modulesDir: path.join(opts.installDir, 'node_modules'),
+        modulesDir: undefined,
         dir: opts.installDir,
         lockfileDir: opts.installDir,
         rootProjectManifest: undefined,
@@ -30,6 +50,9 @@ export async function promptApproveGlobalBuilds(opts, commands) {
         global: false,
         pending: false,
         allowBuilds: opts.allowBuilds,
+        // When set, makes `approve-builds` skip both its multiselect and
+        // confirm prompts and approve every pending build.
+        all: autoApproveForTests ? true : undefined,
     }, [], commands);
 }
 //# sourceMappingURL=promptApproveGlobalBuilds.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pnpm/global.commands",
-  "version": "1100.0.6",
+  "version": "1100.0.7",
   "description": "Global package command handlers for pnpm",
   "keywords": [
     "pnpm",
@@ -28,23 +28,23 @@
     "@pnpm/util.lex-comparator": "^3.0.2",
     "is-subdir": "^2.0.0",
     "symlink-dir": "^10.0.1",
-    "@pnpm/bins.remover": "1100.0.1",
     "@pnpm/bins.linker": "1100.0.2",
+    "@pnpm/bins.remover": "1100.0.1",
     "@pnpm/bins.resolver": "1100.0.1",
     "@pnpm/cli.command": "1100.0.0",
-    "@pnpm/config.reader": "1101.1.2",
-    "@pnpm/cli.utils": "1101.0.0",
+    "@pnpm/cli.utils": "1101.0.1",
     "@pnpm/error": "1100.0.0",
+    "@pnpm/config.reader": "1101.1.2",
     "@pnpm/global.packages": "1100.0.1",
-    "@pnpm/installing.deps-installer": "1101.0.2",
-    "@pnpm/config.matcher": "1100.0.0",
     "@pnpm/pkg-manifest.reader": "1100.0.1",
-    "@pnpm/store.connection-manager": "1100.0.6",
+    "@pnpm/config.matcher": "1100.0.0",
+    "@pnpm/store.connection-manager": "1100.0.7",
+    "@pnpm/installing.deps-installer": "1101.0.3",
     "@pnpm/types": "1101.0.0"
   },
   "devDependencies": {
     "@jest/globals": "30.3.0",
-    "@pnpm/global.commands": "1100.0.6"
+    "@pnpm/global.commands": "1100.0.7"
   },
   "engines": {
     "node": ">=22.13"