@pnpm/fs.graceful-fs 1100.1.1 → 1100.2.1

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @pnpm/fs.graceful-fs
 
+## 1100.2.1
+
+### Patch Changes
+
+- Windows filesystem operations now retry permission errors for up to one second. Permanent permission errors previously delayed failure by a minute. Sharing and lock violations retain their one-minute retry budget [pnpm/pnpm#14682](https://github.com/pnpm/pnpm/issues/14682).
+
+## 1100.2.0
+
+### Minor Changes
+
+- Copying a built package to its other hoisted locations no longer replaces the destination directory. With `nodeLinker: hoisted`, that replacement deleted the dependencies nested inside the destination's `node_modules`, and made concurrent copies of the same build chunk fail with `ERR_PNPM_ENOENT: no such file or directory, rename '.../node_modules/_tmp_...'` [#12880](https://github.com/pnpm/pnpm/issues/12880).
+
 ## 1100.1.1
 
 ### Patch Changes

package/lib/index.d.ts

@@ -1,22 +1,33 @@
-import gfs from 'graceful-fs';
+import fs from 'node:fs';
 declare const _default: {
-    chmod: typeof gfs.chmod.__promisify__;
-    copyFile: typeof gfs.copyFile.__promisify__;
-    copyFileSync: (src: gfs.PathLike, dest: gfs.PathLike, mode?: number | undefined) => void;
-    createReadStream: typeof gfs.createReadStream;
-    link: typeof gfs.link.__promisify__;
-    linkSync: (existingPath: gfs.PathLike, newPath: gfs.PathLike) => void;
-    mkdir: typeof gfs.mkdir.__promisify__;
-    mkdirSync: (path: gfs.PathLike, options?: gfs.MakeDirectoryOptions | gfs.Mode | null | undefined) => string | undefined;
-    renameSync: (oldPath: gfs.PathLike, newPath: gfs.PathLike) => void;
-    readFile: typeof gfs.readFile.__promisify__;
-    readFileSync: typeof gfs.readFileSync;
-    readdirSync: typeof gfs.readdirSync;
-    stat: typeof gfs.stat.__promisify__;
-    statSync: gfs.StatSyncFn;
-    unlink: typeof gfs.unlink.__promisify__;
-    unlinkSync: typeof gfs.unlinkSync;
-    writeFile: typeof gfs.writeFile.__promisify__;
-    writeFileSync: (file: gfs.PathOrFileDescriptor, data: string | NodeJS.ArrayBufferView<ArrayBufferLike>, options?: gfs.WriteFileOptions | undefined) => void;
+    chmod: typeof fs.chmod.__promisify__;
+    copyFile: typeof fs.copyFile.__promisify__;
+    copyFileSync: (src: fs.PathLike, dest: fs.PathLike, mode?: number | undefined) => void;
+    createReadStream: typeof fs.createReadStream;
+    link: typeof fs.link.__promisify__;
+    linkSync: (existingPath: fs.PathLike, newPath: fs.PathLike) => void;
+    mkdir: typeof fs.mkdir.__promisify__;
+    mkdirSync: (path: fs.PathLike, options?: fs.MakeDirectoryOptions | fs.Mode | null | undefined) => string | undefined;
+    renameSync: (oldPath: fs.PathLike, newPath: fs.PathLike) => void;
+    readFile: typeof fs.readFile.__promisify__;
+    readFileSync: typeof fs.readFileSync;
+    readdirSync: typeof fs.readdirSync;
+    stat: typeof fs.stat.__promisify__;
+    statSync: fs.StatSyncFn;
+    unlink: typeof fs.unlink.__promisify__;
+    unlinkSync: typeof fs.unlinkSync;
+    writeFile: typeof fs.writeFile.__promisify__;
+    writeFileSync: (file: fs.PathOrFileDescriptor, data: string | NodeJS.ArrayBufferView<ArrayBufferLike>, options?: fs.WriteFileOptions | undefined) => void;
 };
 export default _default;
+/**
+ * Renames `src` over `dest`, retrying Windows EBUSY errors for up to a minute.
+ * EPERM and EACCES have a one-second budget because they can also indicate
+ * permanent permission or destination conflicts. Other errors are thrown
+ * right away.
+ *
+ * `dest` is never removed to make room for the rename: a concurrent install may
+ * still be reading that dirent, and a reader has to see either the whole file
+ * that was there or the whole file replacing it.
+ */
+export declare function renameFileWithRetry(src: string, dest: string): void;

package/lib/index.js

@@ -1,5 +1,10 @@
+import fs from 'node:fs';
 import util, { promisify } from 'node:util';
 import gfs from 'graceful-fs';
+const RENAME_RETRY_BUDGET_MS = 60_000;
+const PERMISSION_DENIED_RETRY_BUDGET_MS = 1_000;
+const RENAME_RETRY_BACKOFF_CAP_MS = 100;
+const renameRetrySleepBuffer = new Int32Array(new SharedArrayBuffer(4));
 export default {
     chmod: promisify(gfs.chmod),
     copyFile: promisify(gfs.copyFile),
@@ -41,4 +46,45 @@ function withEagainRetry(fn, maxRetries = 15) {
         throw new Error('Unreachable');
     };
 }
+/**
+ * Renames `src` over `dest`, retrying Windows EBUSY errors for up to a minute.
+ * EPERM and EACCES have a one-second budget because they can also indicate
+ * permanent permission or destination conflicts. Other errors are thrown
+ * right away.
+ *
+ * `dest` is never removed to make room for the rename: a concurrent install may
+ * still be reading that dirent, and a reader has to see either the whole file
+ * that was there or the whole file replacing it.
+ */
+export function renameFileWithRetry(src, dest) {
+    const startedAt = Date.now();
+    let backoffMs = 0;
+    let budgetMs = RENAME_RETRY_BUDGET_MS;
+    for (;;) {
+        try {
+            fs.renameSync(src, dest);
+            return;
+        }
+        catch (err) {
+            if (!isTransientRenameError(err))
+                throw err;
+            if (err.code === 'EPERM' || err.code === 'EACCES')
+                budgetMs = Math.min(budgetMs, PERMISSION_DENIED_RETRY_BUDGET_MS);
+            const remainingMs = budgetMs - (Date.now() - startedAt);
+            if (remainingMs <= 0)
+                throw err;
+            if (backoffMs > 0)
+                Atomics.wait(renameRetrySleepBuffer, 0, 0, Math.min(backoffMs, remainingMs));
+            if (Date.now() - startedAt >= budgetMs)
+                throw err;
+            backoffMs = Math.min(backoffMs + 10, RENAME_RETRY_BACKOFF_CAP_MS);
+        }
+    }
+}
+function isTransientRenameError(err) {
+    return process.platform === 'win32' &&
+        util.types.isNativeError(err) &&
+        'code' in err &&
+        (err.code === 'EPERM' || err.code === 'EACCES' || err.code === 'EBUSY');
+}
 //# sourceMappingURL=index.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pnpm/fs.graceful-fs",
-  "version": "1100.1.1",
+  "version": "1100.2.1",
   "description": "Promisified graceful-fs",
   "keywords": [
     "pnpm",
@@ -30,7 +30,8 @@
     "graceful-fs": "^4.2.11"
   },
   "devDependencies": {
-    "@pnpm/fs.graceful-fs": "1100.1.1",
+    "@jest/globals": "30.4.1",
+    "@pnpm/fs.graceful-fs": "1100.2.1",
     "@types/graceful-fs": "^4.1.9"
   },
   "engines": {
@@ -40,8 +41,9 @@
     "preset": "@pnpm/jest-config"
   },
   "scripts": {
-    "lint": "eslint \"src/**/*.ts\"",
-    "test": "pn compile",
-    "compile": "tsgo --build && pn lint --fix"
+    "lint": "eslint \"src/**/*.ts\" \"test/**/*.ts\"",
+    "test": "pn compile && pn .test",
+    "compile": "tsgo --build && pn lint --fix",
+    ".test": "cross-env NODE_OPTIONS=\"$NODE_OPTIONS --experimental-vm-modules --disable-warning=ExperimentalWarning --disable-warning=DEP0169\" jest"
   }
 }