@pnpm/fetching.tarball-fetcher 1003.0.0 → 1100.0.1

package/lib/gitHostedTarballFetcher.d.ts

@@ -2,7 +2,6 @@ import type { FetchFunction } from '@pnpm/fetching.fetcher-base';
 import type { StoreIndex } from '@pnpm/store.index';
 export interface CreateGitHostedTarballFetcher {
     ignoreScripts?: boolean;
-    rawConfig: Record<string, unknown>;
     storeIndex: StoreIndex;
     unsafePerm?: boolean;
 }

package/lib/index.d.ts

@@ -14,7 +14,6 @@ export interface TarballFetchers {
     gitHostedTarball: FetchFunction;
 }
 export declare function createTarballFetcher(fetchFromRegistry: FetchFromRegistry, getAuthHeader: GetAuthHeader, opts: {
-    rawConfig: Record<string, unknown>;
     unsafePerm?: boolean;
     ignoreScripts?: boolean;
     storeIndex: StoreIndex;

package/lib/remoteTarballFetcher.js

@@ -1,4 +1,3 @@
-import assert from 'node:assert';
 import util from 'node:util';
 import { requestRetryLogger } from '@pnpm/core-loggers';
 import { FetchError } from '@pnpm/error';
@@ -38,9 +37,25 @@ export function createDownloader(fetchFromRegistry, gotOpts) {
                         reject(op.mainError());
                         return;
                     }
+                    // Extract error properties into a plain object because Error properties
+                    // are non-enumerable and don't serialize well through the logging system
+                    const errorInfo = {
+                        name: error.name,
+                        message: error.message,
+                        code: error.code,
+                        errno: error.errno,
+                        // For HTTP errors from our ResponseError class
+                        status: error.status,
+                        statusCode: error.statusCode,
+                        // undici wraps the actual network error in a cause property
+                        cause: error.cause ? {
+                            code: error.cause.code,
+                            errno: error.cause.errno,
+                        } : undefined,
+                    };
                     requestRetryLogger.debug({
                         attempt,
-                        error,
+                        error: errorInfo,
                         maxRetries: retryOpts.retries,
                         method: 'GET',
                         timeout,
@@ -66,9 +81,8 @@ export function createDownloader(fetchFromRegistry, gotOpts) {
                     throw new FetchError({ url, authHeaderValue }, res);
                 }
                 const contentLength = res.headers.has('content-length') && res.headers.get('content-length');
-                const size = typeof contentLength === 'string'
-                    ? parseInt(contentLength, 10)
-                    : null;
+                const parsedLength = typeof contentLength === 'string' ? parseInt(contentLength, 10) : NaN;
+                const size = Number.isFinite(parsedLength) && parsedLength >= 0 ? parsedLength : null;
                 if (opts.onStart != null) {
                     opts.onStart(size, currentAttempt);
                 }
@@ -78,19 +92,45 @@ export function createDownloader(fetchFromRegistry, gotOpts) {
                     : undefined;
                 const startTime = Date.now();
                 let downloaded = 0;
-                const chunks = [];
-                // This will handle the 'data', 'error', and 'end' events.
-                for await (const chunk of res.body) {
-                    chunks.push(chunk);
-                    downloaded += chunk.length;
-                    onProgress?.(downloaded);
+                if (size !== null) {
+                    // Known size: pre-allocate and copy directly (avoids intermediate array + second copy pass)
+                    data = Buffer.from(new SharedArrayBuffer(size));
+                    for await (const chunk of res.body) {
+                        const c = chunk;
+                        const nextDownloaded = downloaded + c.byteLength;
+                        if (nextDownloaded > size) {
+                            throw new BadTarballError({
+                                expectedSize: size,
+                                receivedSize: nextDownloaded,
+                                tarballUrl: url,
+                            });
+                        }
+                        data.set(c, downloaded);
+                        downloaded = nextDownloaded;
+                        onProgress?.(downloaded);
+                    }
+                    if (size !== downloaded) {
+                        throw new BadTarballError({
+                            expectedSize: size,
+                            receivedSize: downloaded,
+                            tarballUrl: url,
+                        });
+                    }
                 }
-                if (size !== null && size !== downloaded) {
-                    throw new BadTarballError({
-                        expectedSize: size,
-                        receivedSize: downloaded,
-                        tarballUrl: url,
-                    });
+                else {
+                    const chunks = [];
+                    for await (const chunk of res.body) {
+                        const c = chunk;
+                        chunks.push(c);
+                        downloaded += c.byteLength;
+                        onProgress?.(downloaded);
+                    }
+                    data = Buffer.from(new SharedArrayBuffer(downloaded));
+                    let offset = 0;
+                    for (const chunk of chunks) {
+                        data.set(chunk, offset);
+                        offset += chunk.byteLength;
+                    }
                 }
                 const elapsedSec = (Date.now() - startTime) / 1000;
                 const avgKiBps = Math.floor((downloaded / elapsedSec) / 1024);
@@ -98,20 +138,14 @@ export function createDownloader(fetchFromRegistry, gotOpts) {
                     const sizeKb = Math.floor(downloaded / 1024);
                     globalWarn(`Tarball download average speed ${avgKiBps} KiB/s (size ${sizeKb} KiB) is below ${fetchMinSpeedKiBps} KiB/s: ${url} (GET)`);
                 }
-                data = Buffer.from(new SharedArrayBuffer(downloaded));
-                let offset = 0;
-                for (const chunk of chunks) {
-                    chunk.copy(data, offset);
-                    offset += chunk.length;
-                }
             }
             catch (err) {
-                assert(util.types.isNativeError(err));
-                Object.assign(err, {
+                const error = util.types.isNativeError(err) ? err : new Error(String(err), { cause: err });
+                Object.assign(error, {
                     attempts: currentAttempt,
                     resource: url,
                 });
-                throw err;
+                throw error;
             }
             return addFilesFromTarball({
                 buffer: data,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pnpm/fetching.tarball-fetcher",
-  "version": "1003.0.0",
+  "version": "1100.0.1",
   "description": "Fetcher for packages hosted as tarballs",
   "keywords": [
     "pnpm",
@@ -30,37 +30,37 @@
     "lodash.throttle": "4.1.1",
     "p-map-values": "^0.1.0",
     "ramda": "npm:@pnpm/ramda@0.28.1",
-    "@pnpm/core-loggers": "1001.0.4",
-    "@pnpm/error": "1000.0.5",
-    "@pnpm/fetching.fetcher-base": "1001.0.2",
-    "@pnpm/fs.graceful-fs": "1000.0.1",
-    "@pnpm/fs.packlist": "1000.0.0",
-    "@pnpm/fetching.types": "1000.2.0",
-    "@pnpm/exec.prepare-package": "1000.0.26",
-    "@pnpm/types": "1000.9.0",
-    "@pnpm/store.index": "1000.0.0-0"
+    "@pnpm/core-loggers": "1100.0.1",
+    "@pnpm/exec.prepare-package": "1100.0.1",
+    "@pnpm/error": "1100.0.0",
+    "@pnpm/fetching.fetcher-base": "1100.0.1",
+    "@pnpm/fetching.types": "1100.0.0",
+    "@pnpm/fs.graceful-fs": "1100.0.0",
+    "@pnpm/fs.packlist": "1100.0.0",
+    "@pnpm/types": "1101.0.0",
+    "@pnpm/store.index": "1100.0.0"
   },
   "peerDependencies": {
     "@pnpm/logger": ">=1001.0.0 <1002.0.0",
-    "@pnpm/worker": "^1000.3.0"
+    "@pnpm/worker": "^1100.0.1"
   },
   "devDependencies": {
-    "@jest/globals": "30.0.5",
+    "@jest/globals": "30.3.0",
     "@pnpm/util.lex-comparator": "^3.0.2",
-    "@types/lodash.throttle": "4.1.7",
-    "@types/ramda": "0.29.12",
+    "@types/lodash.throttle": "4.1.9",
+    "@types/ramda": "0.31.1",
     "@types/retry": "^0.12.5",
     "@types/ssri": "^7.1.5",
-    "nock": "13.3.4",
-    "ssri": "13.0.0",
+    "ssri": "13.0.1",
     "tempy": "3.0.0",
-    "@pnpm/fetching.tarball-fetcher": "1003.0.0",
-    "@pnpm/network.fetch": "1000.2.6",
-    "@pnpm/store.cafs-types": "1000.0.0",
-    "@pnpm/store.create-cafs-store": "1000.0.20",
-    "@pnpm/logger": "1001.0.1",
-    "@pnpm/test-fixtures": "1000.0.0",
-    "@pnpm/types": "1000.9.0"
+    "undici": "^7.2.0",
+    "@pnpm/fetching.tarball-fetcher": "1100.0.1",
+    "@pnpm/logger": "1100.0.0",
+    "@pnpm/network.fetch": "1100.0.1",
+    "@pnpm/store.cafs-types": "1100.0.0",
+    "@pnpm/store.create-cafs-store": "1100.0.1",
+    "@pnpm/test-fixtures": "1100.0.0",
+    "@pnpm/types": "1101.0.0"
   },
   "engines": {
     "node": ">=22.13"
@@ -70,8 +70,8 @@
   },
   "scripts": {
     "lint": "eslint \"src/**/*.ts\" \"test/**/*.ts\"",
-    "_test": "cross-env NODE_OPTIONS=\"$NODE_OPTIONS --experimental-vm-modules --disable-warning=ExperimentalWarning --disable-warning=DEP0169\" jest",
-    "test": "pnpm run compile && pnpm run _test",
-    "compile": "tsgo --build && pnpm run lint --fix"
+    "test": "pn compile && pn .test",
+    "compile": "tsgo --build && pn lint --fix",
+    ".test": "cross-env NODE_OPTIONS=\"$NODE_OPTIONS --experimental-vm-modules --disable-warning=ExperimentalWarning --disable-warning=DEP0169\" jest"
   }
 }