@pnpm/deps.graph-builder 1100.0.26 → 1100.1.0

package/CHANGELOG.md

@@ -1,5 +1,31 @@
 # @pnpm/deps.graph-builder
 
+## 1100.1.0
+
+### Minor Changes
+
+- Fixed an installed optional dependency being left without one of its own required dependencies. When a package reached through `optionalDependencies` is installable on the current system but one of its regular `dependencies` is not, a lockfile-based install skipped that dependency and installed the parent anyway, so importing the parent failed with `MODULE_NOT_FOUND`. The dependency is now installed, and an install-check warning reports the incompatibility. A dependency is still only skipped when every path to it is optional, or when the package that pulls it in was itself skipped [#13286](https://github.com/pnpm/pnpm/issues/13286).
+
+### Patch Changes
+
+- Installing a local `file:` directory dependency with the global virtual store enabled no longer fails with `TypeError: Cannot read properties of undefined (reading 'split')` [#13335](https://github.com/pnpm/pnpm/issues/13335).
+
+  Local directory dependencies — `file:` directories and injected workspace packages — now get a global-virtual-store slot of their own per project. They used to share one slot across every project that depended on a directory of the same name, so a project could end up linked to another project's copy of the dependency.
+
+- Updated dependencies:
+  - @pnpm/config.package-is-installable@1100.1.0
+  - @pnpm/core-loggers@1100.3.0
+  - @pnpm/deps.graph-hasher@1100.2.13
+  - @pnpm/deps.path@1100.0.12
+  - @pnpm/fs.symlink-dependency@1100.0.15
+  - @pnpm/hooks.types@1100.2.4
+  - @pnpm/installing.modules-yaml@1100.0.13
+  - @pnpm/lockfile.fs@1100.1.15
+  - @pnpm/lockfile.utils@1100.1.6
+  - @pnpm/patching.config@1100.0.13
+  - @pnpm/store.controller-types@1100.1.11
+  - @pnpm/types@1101.7.0
+
 ## 1100.0.26
 
 ### Patch Changes

package/lib/iteratePkgsForVirtualStore.d.ts

@@ -8,6 +8,7 @@ interface PkgSnapshotWithLocation {
 export declare function iteratePkgsForVirtualStore(lockfile: LockfileObject, opts: {
     allowBuild?: AllowBuild;
     enableGlobalVirtualStore?: boolean;
+    lockfileDir: string;
     virtualStoreDirMaxLength: number;
     virtualStoreDir: string;
     globalVirtualStoreDir: string;

package/lib/iteratePkgsForVirtualStore.js

@@ -15,6 +15,7 @@ export function* iteratePkgsForVirtualStore(lockfile, opts) {
             allowBuild: opts.allowBuild,
             supportedArchitectures: opts.supportedArchitectures,
             nodeVersion,
+            lockfileDir: opts.lockfileDir,
         })) {
             yield {
                 dirInVirtualStore: path.join(opts.globalVirtualStoreDir, hash),
@@ -44,6 +45,7 @@ export function* iteratePkgsForVirtualStore(lockfile, opts) {
                     graph: lockfileToDepGraph(lockfile, opts.supportedArchitectures),
                     supportedArchitectures: opts.supportedArchitectures,
                     nodeVersion,
+                    lockfileDir: opts.lockfileDir,
                 };
                 const hash = calcGraphNodeHash(graphNodeHashOpts, pkgMeta);
                 dirInVirtualStore = path.join(opts.globalVirtualStoreDir, hash);
@@ -58,8 +60,8 @@ export function* iteratePkgsForVirtualStore(lockfile, opts) {
         }
     }
 }
-function hashDependencyPaths(lockfile, { allowBuild, supportedArchitectures, nodeVersion, }) {
-    const graph = lockfileToDepGraph(lockfile, supportedArchitectures);
-    return iterateHashedGraphNodes(graph, iteratePkgMeta(lockfile, graph), allowBuild, supportedArchitectures, nodeVersion);
+function hashDependencyPaths(lockfile, opts) {
+    const graph = lockfileToDepGraph(lockfile, opts.supportedArchitectures);
+    return iterateHashedGraphNodes(graph, iteratePkgMeta(lockfile, graph), opts);
 }
 //# sourceMappingURL=iteratePkgsForVirtualStore.js.map

package/lib/lockfileToDepGraph.d.ts

@@ -49,6 +49,12 @@ export interface LockfileToDepGraphOptions {
     pnpmVersion: string;
     patchedDependencies?: PatchGroupRecord;
     registries: Registries;
+    /**
+     * The dep paths a non-optional edge reaches, as classified by
+     * `filterLockfileByImportersAndEngine`. Installability is evaluated as
+     * optional for everything outside this set.
+     */
+    requiredDepPaths: Set<DepPath>;
     sideEffectsCacheRead: boolean;
     skipped: Set<DepPath>;
     storeController: StoreController;

package/lib/lockfileToDepGraph.js

@@ -81,10 +81,13 @@ async function buildGraphFromPackages(lockfile, currentLockfile, opts) {
             };
             const packageId = packageIdFromSnapshot(depPath, pkgSnapshot);
             if (!opts.force && packageIsInstallable(packageId, pkg, {
-                engineStrict: opts.engineStrict,
+                // An incompatibility inside an `optionalDependencies` subtree is
+                // reported, not fatal — see `filterLockfileByImportersAndEngine`,
+                // which classifies these dep paths.
+                engineStrict: opts.engineStrict && pkgSnapshot.optional !== true,
                 lockfileDir: opts.lockfileDir,
                 nodeVersion: opts.nodeVersion,
-                optional: pkgSnapshot.optional === true,
+                optional: !opts.requiredDepPaths.has(depPath),
                 supportedArchitectures: opts.supportedArchitectures,
             }) === false) {
                 opts.skipped.add(depPath);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pnpm/deps.graph-builder",
-  "version": "1100.0.26",
+  "version": "1100.1.0",
   "description": "A package for building a dependency graph from a lockfile",
   "keywords": [
     "pnpm",
@@ -27,20 +27,20 @@
     "!*.map"
   ],
   "dependencies": {
-    "@pnpm/config.package-is-installable": "1100.0.16",
+    "@pnpm/config.package-is-installable": "1100.1.0",
     "@pnpm/constants": "1100.0.1",
-    "@pnpm/core-loggers": "1100.2.5",
-    "@pnpm/deps.graph-hasher": "1100.2.12",
-    "@pnpm/deps.path": "1100.0.11",
-    "@pnpm/fs.symlink-dependency": "1100.0.14",
-    "@pnpm/hooks.types": "1100.2.3",
-    "@pnpm/installing.modules-yaml": "1100.0.12",
-    "@pnpm/lockfile.fs": "1100.1.14",
-    "@pnpm/lockfile.utils": "1100.1.5",
-    "@pnpm/patching.config": "1100.0.12",
+    "@pnpm/core-loggers": "1100.3.0",
+    "@pnpm/deps.graph-hasher": "1100.2.13",
+    "@pnpm/deps.path": "1100.0.12",
+    "@pnpm/fs.symlink-dependency": "1100.0.15",
+    "@pnpm/hooks.types": "1100.2.4",
+    "@pnpm/installing.modules-yaml": "1100.0.13",
+    "@pnpm/lockfile.fs": "1100.1.15",
+    "@pnpm/lockfile.utils": "1100.1.6",
+    "@pnpm/patching.config": "1100.0.13",
     "@pnpm/patching.types": "1100.0.1",
-    "@pnpm/store.controller-types": "1100.1.10",
-    "@pnpm/types": "1101.6.0",
+    "@pnpm/store.controller-types": "1100.1.11",
+    "@pnpm/types": "1101.7.0",
     "path-exists": "^5.0.0",
     "ramda": "npm:@pnpm/ramda@0.28.1"
   },
@@ -49,9 +49,9 @@
   },
   "devDependencies": {
     "@jest/globals": "30.4.1",
-    "@pnpm/deps.graph-builder": "1100.0.26",
+    "@pnpm/deps.graph-builder": "1100.1.0",
     "@pnpm/logger": "1100.0.0",
-    "@types/ramda": "0.31.1"
+    "@types/ramda": "0.32.0"
   },
   "engines": {
     "node": ">=22.13"