@pnp/cli-microsoft365 6.3.0 → 6.4.0-beta.39e5130

package/dist/m365/flow/commands/run/run-cancel.js

@@ -13,7 +13,7 @@ var __classPrivateFieldGet = (this && this.__classPrivateFieldGet) || function (
     if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot read private member from an object whose class did not declare it");
     return kind === "m" ? f : kind === "a" ? f.call(receiver) : f ? f.value : state.get(receiver);
 };
-var _FlowRunCancelCommand_instances, _FlowRunCancelCommand_initOptions, _FlowRunCancelCommand_initValidators;
+var _FlowRunCancelCommand_instances, _FlowRunCancelCommand_initTelemetry, _FlowRunCancelCommand_initOptions, _FlowRunCancelCommand_initValidators;
 Object.defineProperty(exports, "__esModule", { value: true });
 const Cli_1 = require("../../../../cli/Cli");
 const request_1 = require("../../../../request");
@@ -31,6 +31,7 @@ class FlowRunCancelCommand extends AzmgmtCommand_1.default {
     constructor() {
         super();
         _FlowRunCancelCommand_instances.add(this);
+        __classPrivateFieldGet(this, _FlowRunCancelCommand_instances, "m", _FlowRunCancelCommand_initTelemetry).call(this);
         __classPrivateFieldGet(this, _FlowRunCancelCommand_instances, "m", _FlowRunCancelCommand_initOptions).call(this);
         __classPrivateFieldGet(this, _FlowRunCancelCommand_instances, "m", _FlowRunCancelCommand_initValidators).call(this);
     }
@@ -71,7 +72,13 @@ class FlowRunCancelCommand extends AzmgmtCommand_1.default {
         });
     }
 }
-_FlowRunCancelCommand_instances = new WeakSet(), _FlowRunCancelCommand_initOptions = function _FlowRunCancelCommand_initOptions() {
+_FlowRunCancelCommand_instances = new WeakSet(), _FlowRunCancelCommand_initTelemetry = function _FlowRunCancelCommand_initTelemetry() {
+    this.telemetry.push((args) => {
+        Object.assign(this.telemetryProperties, {
+            confirm: !!args.options.confirm
+        });
+    });
+}, _FlowRunCancelCommand_initOptions = function _FlowRunCancelCommand_initOptions() {
     this.options.unshift({
         option: '-n, --name <name>'
     }, {

package/dist/m365/flow/commands/run/run-list.js

@@ -42,7 +42,7 @@ class FlowRunListCommand extends AzmgmtItemsListCommand_1.AzmgmtItemsListCommand
             if (this.verbose) {
                 logger.logToStderr(`Retrieving list of runs for Microsoft Flow ${args.options.flowName}...`);
             }
-            let url = `${this.resource}providers/Microsoft.ProcessSimple/environments/${formatting_1.formatting.encodeQueryParameter(args.options.environmentName)}/flows/${formatting_1.formatting.encodeQueryParameter(args.options.flowName)}/runs?api-version=2016-11-01`;
+            let url = `${this.resource}providers/Microsoft.ProcessSimple/${args.options.asAdmin ? 'scopes/admin/' : ''}environments/${formatting_1.formatting.encodeQueryParameter(args.options.environmentName)}/flows/${formatting_1.formatting.encodeQueryParameter(args.options.flowName)}/runs?api-version=2016-11-01`;
             const filters = this.getFilters(args.options);
             if (filters.length > 0) {
                 url += `&$filter=${filters.join(' and ')}`;
@@ -86,7 +86,8 @@ _FlowRunListCommand_instances = new WeakSet(), _FlowRunListCommand_initTelemetry
         Object.assign(this.telemetryProperties, {
             status: typeof args.options.status !== 'undefined',
             triggerStartTime: typeof args.options.triggerStartTime !== 'undefined',
-            triggerEndTime: typeof args.options.triggerEndTime !== 'undefined'
+            triggerEndTime: typeof args.options.triggerEndTime !== 'undefined',
+            asAdmin: !!args.options.asAdmin
         });
     });
 }, _FlowRunListCommand_initOptions = function _FlowRunListCommand_initOptions() {
@@ -101,6 +102,8 @@ _FlowRunListCommand_instances = new WeakSet(), _FlowRunListCommand_initTelemetry
         option: '--triggerStartTime [triggerStartTime]'
     }, {
         option: '--triggerEndTime [triggerEndTime]'
+    }, {
+        option: '--asAdmin'
     });
 }, _FlowRunListCommand_initValidators = function _FlowRunListCommand_initValidators() {
     this.validators.push((args) => __awaiter(this, void 0, void 0, function* () {

package/dist/m365/flow/commands.js

@@ -11,6 +11,9 @@ exports.default = {
     EXPORT: `${prefix} export`,
     GET: `${prefix} get`,
     LIST: `${prefix} list`,
+    OWNER_ADD: `${prefix} owner add`,
+    OWNER_LIST: `${prefix} owner list`,
+    OWNER_REMOVE: `${prefix} owner remove`,
     REMOVE: `${prefix} remove`,
     RUN_CANCEL: `${prefix} run cancel`,
     RUN_GET: `${prefix} run get`,

package/dist/m365/planner/commands/roster/roster-member-add.js

@@ -106,6 +106,9 @@ _PlannerRosterMemberAddCommand_instances = new WeakSet(), _PlannerRosterMemberAd
         if (args.options.userId && !validation_1.validation.isValidGuid(args.options.userId)) {
             return `${args.options.userId} is not a valid GUID`;
         }
+        if (args.options.userName && !validation_1.validation.isValidUserPrincipalName(args.options.userName)) {
+            return `${args.options.userName} is not a valid user principal name (UPN)`;
+        }
         return true;
     }));
 };

package/dist/m365/planner/commands/roster/roster-member-get.js

@@ -0,0 +1,98 @@
+"use strict";
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+var __classPrivateFieldGet = (this && this.__classPrivateFieldGet) || function (receiver, state, kind, f) {
+    if (kind === "a" && !f) throw new TypeError("Private accessor was defined without a getter");
+    if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot read private member from an object whose class did not declare it");
+    return kind === "m" ? f : kind === "a" ? f.call(receiver) : f ? f.value : state.get(receiver);
+};
+var _PlannerRosterMemberGetCommand_instances, _PlannerRosterMemberGetCommand_initTelemetry, _PlannerRosterMemberGetCommand_initOptions, _PlannerRosterMemberGetCommand_initOptionSets, _PlannerRosterMemberGetCommand_initValidators;
+Object.defineProperty(exports, "__esModule", { value: true });
+const request_1 = require("../../../../request");
+const validation_1 = require("../../../../utils/validation");
+const GraphCommand_1 = require("../../../base/GraphCommand");
+const commands_1 = require("../../commands");
+const aadUser_1 = require("../../../../utils/aadUser");
+class PlannerRosterMemberGetCommand extends GraphCommand_1.default {
+    get name() {
+        return commands_1.default.ROSTER_MEMBER_GET;
+    }
+    get description() {
+        return 'Gets a member of the specified Microsoft Planner Roster';
+    }
+    constructor() {
+        super();
+        _PlannerRosterMemberGetCommand_instances.add(this);
+        __classPrivateFieldGet(this, _PlannerRosterMemberGetCommand_instances, "m", _PlannerRosterMemberGetCommand_initTelemetry).call(this);
+        __classPrivateFieldGet(this, _PlannerRosterMemberGetCommand_instances, "m", _PlannerRosterMemberGetCommand_initOptions).call(this);
+        __classPrivateFieldGet(this, _PlannerRosterMemberGetCommand_instances, "m", _PlannerRosterMemberGetCommand_initValidators).call(this);
+        __classPrivateFieldGet(this, _PlannerRosterMemberGetCommand_instances, "m", _PlannerRosterMemberGetCommand_initOptionSets).call(this);
+    }
+    commandAction(logger, args) {
+        return __awaiter(this, void 0, void 0, function* () {
+            if (this.verbose) {
+                logger.logToStderr(`Retrieving member ${args.options.userName || args.options.userId} from the Microsoft Planner Roster`);
+            }
+            try {
+                const userId = yield this.getUserId(args);
+                const requestOptions = {
+                    url: `${this.resource}/beta/planner/rosters/${args.options.rosterId}/members/${userId}`,
+                    headers: {
+                        accept: 'application/json;odata.metadata=none'
+                    },
+                    responseType: 'json'
+                };
+                const response = yield request_1.default.get(requestOptions);
+                logger.log(response);
+            }
+            catch (err) {
+                this.handleRejectedODataJsonPromise(err);
+            }
+        });
+    }
+    getUserId(args) {
+        return __awaiter(this, void 0, void 0, function* () {
+            if (args.options.userId) {
+                return args.options.userId;
+            }
+            return aadUser_1.aadUser.getUserIdByUpn(args.options.userName);
+        });
+    }
+}
+_PlannerRosterMemberGetCommand_instances = new WeakSet(), _PlannerRosterMemberGetCommand_initTelemetry = function _PlannerRosterMemberGetCommand_initTelemetry() {
+    this.telemetry.push((args) => {
+        Object.assign(this.telemetryProperties, {
+            userId: typeof args.options.userId !== 'undefined',
+            userName: typeof args.options.userName !== 'undefined'
+        });
+    });
+}, _PlannerRosterMemberGetCommand_initOptions = function _PlannerRosterMemberGetCommand_initOptions() {
+    this.options.unshift({
+        option: '--rosterId <rosterId>'
+    }, {
+        option: '--userId [userId]'
+    }, {
+        option: '--userName [userName]'
+    });
+}, _PlannerRosterMemberGetCommand_initOptionSets = function _PlannerRosterMemberGetCommand_initOptionSets() {
+    this.optionSets.push({ options: ['userId', 'userName'] });
+}, _PlannerRosterMemberGetCommand_initValidators = function _PlannerRosterMemberGetCommand_initValidators() {
+    this.validators.push((args) => __awaiter(this, void 0, void 0, function* () {
+        if (args.options.userId && !validation_1.validation.isValidGuid(args.options.userId)) {
+            return `${args.options.userId} is not a valid GUID`;
+        }
+        if (args.options.userName && !validation_1.validation.isValidUserPrincipalName(args.options.userName)) {
+            return `${args.options.userName} is not a valid userName`;
+        }
+        return true;
+    }));
+};
+module.exports = new PlannerRosterMemberGetCommand();
+//# sourceMappingURL=roster-member-get.js.map

package/dist/m365/planner/commands.js

@@ -15,6 +15,7 @@ exports.default = {
     ROSTER_ADD: `${prefix} roster add`,
     ROSTER_GET: `${prefix} roster get`,
     ROSTER_MEMBER_ADD: `${prefix} roster member add`,
+    ROSTER_MEMBER_GET: `${prefix} roster member get`,
     ROSTER_MEMBER_LIST: `${prefix} roster member list`,
     ROSTER_MEMBER_REMOVE: `${prefix} roster member remove`,
     ROSTER_REMOVE: `${prefix} roster remove`,

package/dist/m365/spfx/commands/spfx-doctor.js

@@ -18,8 +18,8 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const chalk = require("chalk");
 const child_process = require("child_process");
 const semver_1 = require("semver");
-const AnonymousCommand_1 = require("../../base/AnonymousCommand");
 const commands_1 = require("../commands");
+const base_project_command_1 = require("./project/base-project-command");
 /**
  * Has the particular check passed or failed
  */
@@ -64,7 +64,7 @@ var SharePointVersion;
     SharePointVersion[SharePointVersion["SPO"] = 4] = "SPO";
     SharePointVersion[SharePointVersion["All"] = 7] = "All";
 })(SharePointVersion || (SharePointVersion = {}));
-class SpfxDoctorCommand extends AnonymousCommand_1.default {
+class SpfxDoctorCommand extends base_project_command_1.BaseProjectCommand {
     get allowedOutputs() {
         return ['text'];
     }
@@ -479,6 +479,7 @@ class SpfxDoctorCommand extends AnonymousCommand_1.default {
             if (!args.options.output) {
                 args.options.output = 'text';
             }
+            this.projectRootPath = this.getProjectRoot(process.cwd());
             logger.log(' ');
             logger.log('CLI for Microsoft 365 SharePoint Framework doctor');
             logger.log('Verifying configuration of your system for working with the SharePoint Framework');
@@ -557,9 +558,11 @@ class SpfxDoctorCommand extends AnonymousCommand_1.default {
         });
     }
     checkSharePointFrameworkVersion(spfxVersionRequested, fixes, logger) {
-        return this
-            .getPackageVersion('@microsoft/generator-sharepoint', PackageSearchMode.GlobalOnly, HandlePromise.Continue, logger)
-            .then((spfxVersionDetected) => {
+        return __awaiter(this, void 0, void 0, function* () {
+            let spfxVersionDetected = this.getSPFxVersionFromYoRcFile(logger);
+            if (!spfxVersionDetected) {
+                spfxVersionDetected = yield this.getPackageVersion('@microsoft/generator-sharepoint', PackageSearchMode.GlobalOnly, HandlePromise.Continue, logger);
+            }
             const versionCheck = {
                 range: spfxVersionRequested,
                 fix: `npm i -g @microsoft/generator-sharepoint@${spfxVersionRequested}`
@@ -625,39 +628,50 @@ class SpfxDoctorCommand extends AnonymousCommand_1.default {
     spVersionStringToEnum(sp) {
         return SharePointVersion[sp.toUpperCase()];
     }
+    getSPFxVersionFromYoRcFile(logger) {
+        if (this.projectRootPath !== null) {
+            const spfxVersion = this.getProjectVersion();
+            if (spfxVersion) {
+                if (this.debug) {
+                    logger.logToStderr(`SPFx version retrieved from .yo-rc.json file. Retrieved version: ${spfxVersion}`);
+                }
+                return spfxVersion;
+            }
+        }
+        return undefined;
+    }
     getSharePointFrameworkVersion(logger) {
-        return new Promise((resolve, reject) => {
-            if (this.debug) {
-                logger.logToStderr('Detecting SharePoint Framework version based on @microsoft/sp-core-library local...');
+        return __awaiter(this, void 0, void 0, function* () {
+            let spfxVersion = this.getSPFxVersionFromYoRcFile(logger);
+            if (spfxVersion) {
+                return spfxVersion;
             }
-            this
-                .getPackageVersion('@microsoft/sp-core-library', PackageSearchMode.LocalOnly, HandlePromise.Fail, logger)
-                .then((version) => {
+            try {
+                spfxVersion = yield this.getPackageVersion('@microsoft/sp-core-library', PackageSearchMode.LocalOnly, HandlePromise.Fail, logger);
                 if (this.debug) {
-                    logger.logToStderr(`Found @microsoft/sp-core-library@${version}`);
+                    logger.logToStderr(`Found @microsoft/sp-core-library@${spfxVersion}`);
                 }
-                return Promise.resolve(version);
-            })
-                .catch(() => {
+                return spfxVersion;
+            }
+            catch (_a) {
                 if (this.debug) {
                     logger.logToStderr(`@microsoft/sp-core-library not found. Search for @microsoft/generator-sharepoint local or global...`);
                 }
-                return this.getPackageVersion('@microsoft/generator-sharepoint', PackageSearchMode.LocalAndGlobal, HandlePromise.Fail, logger);
-            })
-                .then((version) => {
-                resolve(version);
-            })
-                .catch((error) => {
-                if (this.debug) {
-                    logger.logToStderr('@microsoft/generator-sharepoint not found');
-                }
-                if (error && error.indexOf('ENOENT') > -1) {
-                    reject('npm not found');
+                try {
+                    return yield this.getPackageVersion('@microsoft/generator-sharepoint', PackageSearchMode.LocalAndGlobal, HandlePromise.Fail, logger);
                 }
-                else {
-                    resolve('');
+                catch (error) {
+                    if (this.debug) {
+                        logger.logToStderr('@microsoft/generator-sharepoint not found');
+                    }
+                    if (error && error.indexOf('ENOENT') > -1) {
+                        throw 'npm not found';
+                    }
+                    else {
+                        return '';
+                    }
                 }
-            });
+            }
         });
     }
     getPackageVersion(packageName, searchMode, handlePromise, logger) {

package/dist/m365/spo/commands/customaction/customaction-get.js

@@ -77,14 +77,26 @@ class SpoCustomActionGetCommand extends SpoCommand_1.default {
                 }
                 return customAction;
             }
-            const customActions = yield spo_1.spo.getCustomActions(options.webUrl, options.scope, `Title eq '${formatting_1.formatting.encodeQueryParameter(options.title)}'`);
-            if (customActions.length === 1) {
-                return customActions[0];
+            else if (options.title) {
+                const customActions = yield spo_1.spo.getCustomActions(options.webUrl, options.scope, `Title eq '${formatting_1.formatting.encodeQueryParameter(options.title)}'`);
+                if (customActions.length === 1) {
+                    return customActions[0];
+                }
+                if (customActions.length === 0) {
+                    throw `No user custom action with title '${options.title}' found`;
+                }
+                throw `Multiple user custom actions with title '${options.title}' found. Please disambiguate using IDs: ${customActions.map(a => a.Id).join(', ')}`;
             }
-            if (customActions.length === 0) {
-                throw `No user custom action with title '${options.title}' found`;
+            else {
+                const customActions = yield spo_1.spo.getCustomActions(options.webUrl, options.scope, `ClientSideComponentId eq guid'${options.clientSideComponentId}'`);
+                if (customActions.length === 0) {
+                    throw `No user custom action with ClientSideComponentId '${options.clientSideComponentId}' found`;
+                }
+                if (customActions.length > 1) {
+                    throw `Multiple user custom actions with ClientSideComponentId '${options.clientSideComponentId}' found. Please disambiguate using IDs: ${customActions.map((customAction) => customAction.Id).join(', ')}`;
+                }
+                return customActions[0];
             }
-            throw `Multiple user custom actions with title '${options.title}' found. Please disambiguate using IDs: ${customActions.map(a => a.Id).join(', ')}`;
         });
     }
     humanizeScope(scope) {
@@ -100,6 +112,9 @@ class SpoCustomActionGetCommand extends SpoCommand_1.default {
 _SpoCustomActionGetCommand_instances = new WeakSet(), _SpoCustomActionGetCommand_initTelemetry = function _SpoCustomActionGetCommand_initTelemetry() {
     this.telemetry.push((args) => {
         Object.assign(this.telemetryProperties, {
+            id: typeof args.options.id !== 'undefined',
+            title: typeof args.options.title !== 'undefined',
+            clientSideComponentId: typeof args.options.clientSideComponentId !== 'undefined',
             scope: args.options.scope || 'All'
         });
     });
@@ -108,6 +123,8 @@ _SpoCustomActionGetCommand_instances = new WeakSet(), _SpoCustomActionGetCommand
         option: '-i, --id [id]'
     }, {
         option: '-t, --title [title]'
+    }, {
+        option: '-c, --clientSideComponentId [clientSideComponentId]'
     }, {
         option: '-u, --webUrl <webUrl>'
     }, {
@@ -130,10 +147,13 @@ _SpoCustomActionGetCommand_instances = new WeakSet(), _SpoCustomActionGetCommand
                 return `${args.options.scope} is not a valid custom action scope. Allowed values are Site|Web|All`;
             }
         }
+        if (args.options.clientSideComponentId && validation_1.validation.isValidGuid(args.options.clientSideComponentId) === false) {
+            return `${args.options.clientSideComponentId} is not a valid GUID.`;
+        }
         return true;
     }));
 }, _SpoCustomActionGetCommand_initOptionSets = function _SpoCustomActionGetCommand_initOptionSets() {
-    this.optionSets.push({ options: ['id', 'title'] });
+    this.optionSets.push({ options: ['id', 'title', 'clientSideComponentId'] });
 };
 module.exports = new SpoCustomActionGetCommand();
 //# sourceMappingURL=customaction-get.js.map

package/dist/m365/spo/commands/file/file-move.js

@@ -55,7 +55,7 @@ class SpoFileMoveCommand extends SpoCommand_1.default {
                 // A user might enter folder instead of file as source url by mistake
                 // then there are edge cases when deleteIfAlreadyExists flag is set
                 // the user can receive misleading error message.
-                this.fileExists(tenantUrl, webUrl, args.options.sourceUrl);
+                yield this.fileExists(tenantUrl, webUrl, args.options.sourceUrl);
                 if (args.options.deleteIfAlreadyExists) {
                     // try delete target file, if deleteIfAlreadyExists flag is set
                     const filename = args.options.sourceUrl.replace(/^.*[\\\/]/, '');

package/dist/m365/spo/commands/group/group-member-add.js

@@ -15,15 +15,14 @@ var __classPrivateFieldGet = (this && this.__classPrivateFieldGet) || function (
 };
 var _SpoGroupMemberAddCommand_instances, _SpoGroupMemberAddCommand_initTelemetry, _SpoGroupMemberAddCommand_initOptions, _SpoGroupMemberAddCommand_initValidators, _SpoGroupMemberAddCommand_initOptionSets;
 Object.defineProperty(exports, "__esModule", { value: true });
-const Cli_1 = require("../../../../cli/Cli");
 const request_1 = require("../../../../request");
 const formatting_1 = require("../../../../utils/formatting");
 const validation_1 = require("../../../../utils/validation");
-const AadUserGetCommand = require("../../../aad/commands/user/user-get");
-const AadGroupGetCommand = require("../../../aad/commands/group/group-get");
-const SpoUserGetCommand = require("../user/user-get");
 const SpoCommand_1 = require("../../../base/SpoCommand");
 const commands_1 = require("../../commands");
+const aadUser_1 = require("../../../../utils/aadUser");
+const aadGroup_1 = require("../../../../utils/aadGroup");
+const spo_1 = require("../../../../utils/spo");
 class SpoGroupMemberAddCommand extends SpoCommand_1.default {
     get name() {
         return commands_1.default.GROUP_MEMBER_ADD;
@@ -48,21 +47,20 @@ class SpoGroupMemberAddCommand extends SpoCommand_1.default {
                 const groupId = yield this.getGroupId(args, logger);
                 const resolvedUsernameList = yield this.getValidUsers(args, logger);
                 if (this.verbose) {
-                    logger.logToStderr(`Adding user(s) to SharePoint Group ${args.options.groupId || args.options.groupName}`);
+                    logger.logToStderr(`Adding resource(s) to SharePoint Group ${args.options.groupId || args.options.groupName}`);
                 }
-                const data = {
-                    url: args.options.webUrl,
-                    peoplePickerInput: this.getFormattedUserList(resolvedUsernameList),
-                    roleValue: `group:${groupId}`
-                };
                 const requestOptions = {
                     url: `${args.options.webUrl}/_api/SP.Web.ShareObject`,
                     headers: {
-                        'Accept': 'application/json;odata=nometadata',
-                        'Content-type': 'application/json;odata=verbose'
+                        accept: 'application/json;odata=nometadata',
+                        'content-type': 'application/json;odata=nometadata'
                     },
-                    data: data,
-                    responseType: 'json'
+                    responseType: 'json',
+                    data: {
+                        url: args.options.webUrl,
+                        peoplePickerInput: this.getFormattedUserList(resolvedUsernameList),
+                        roleValue: `group:${groupId}`
+                    }
                 };
                 const sharingResult = yield request_1.default.post(requestOptions);
                 if (sharingResult.ErrorMessage !== null) {
@@ -83,7 +81,7 @@ class SpoGroupMemberAddCommand extends SpoCommand_1.default {
             `GetByName('${formatting_1.formatting.encodeQueryParameter(args.options.groupName)}')` :
             `GetById('${args.options.groupId}')`;
         const requestOptions = {
-            url: `${args.options.webUrl}/_api/web/sitegroups/${getGroupMethod}`,
+            url: `${args.options.webUrl}/_api/web/sitegroups/${getGroupMethod}?$select=Id`,
             headers: {
                 'accept': 'application/json;odata=nometadata'
             },
@@ -91,91 +89,52 @@ class SpoGroupMemberAddCommand extends SpoCommand_1.default {
         };
         return request_1.default
             .get(requestOptions)
-            .then(response => {
-            const groupId = response.Id;
-            if (!groupId) {
-                return Promise.reject(`The specified group does not exist in the SharePoint site`);
-            }
-            return groupId;
-        });
+            .then(response => response.Id);
     }
     getValidUsers(args, logger) {
-        if (this.verbose) {
-            logger.logToStderr(`Checking if the specified users exist`);
-        }
-        const validUserNames = [];
-        const invalidUserNames = [];
-        const userIdentifiers = args.options.userName || args.options.email || args.options.aadGroupId || args.options.aadGroupName || args.options.userId.toString();
-        return Promise
-            .all(userIdentifiers.split(',').map((userIdentifier) => __awaiter(this, void 0, void 0, function* () {
-            const user = userIdentifier.trim();
-            try {
-                if (args.options.userId) {
-                    yield this.spoUserGet(args.options, user, logger, validUserNames);
-                }
-                else if (args.options.aadGroupId || args.options.aadGroupName) {
-                    yield this.aadGroupGet(args.options, user, logger, validUserNames);
-                }
-                else {
-                    yield this.aadUserGet(args.options, user, logger, validUserNames);
-                }
-            }
-            catch (err) {
-                logger.logToStderr(err.stderr);
-                invalidUserNames.push(userIdentifier);
-                return err;
-            }
-        })))
-            .then(() => {
-            if (invalidUserNames.length > 0) {
-                return Promise.reject(`Users not added to the group because the following users don't exist: ${invalidUserNames.join(', ')}`);
-            }
-            return Promise.resolve(validUserNames);
-        });
-    }
-    aadUserGet(options, userIdentifier, logger, validUserNames) {
+        var _a, _b, _c, _d;
         return __awaiter(this, void 0, void 0, function* () {
             if (this.verbose) {
-                logger.logToStderr(`Get UPN from Azure AD for user ${userIdentifier}`);
+                logger.logToStderr('Checking if the specified users and groups exist');
             }
-            const aadUserGetCommandoptions = Object.assign(Object.assign(Object.assign({}, (options.userName && { userName: userIdentifier })), (options.email && { email: userIdentifier })), { output: 'json', debug: options.debug, verbose: options.verbose });
-            const aadUserGetOutput = yield Cli_1.Cli.executeCommandWithOutput(AadUserGetCommand, { options: Object.assign(Object.assign({}, aadUserGetCommandoptions), { _: [] }) });
-            if (this.debug) {
-                logger.logToStderr(aadUserGetOutput.stderr);
-            }
-            validUserNames.push(JSON.parse(aadUserGetOutput.stdout).userPrincipalName);
-        });
-    }
-    aadGroupGet(options, userIdentifier, logger, validUserNames) {
-        return __awaiter(this, void 0, void 0, function* () {
-            if (this.verbose) {
-                logger.logToStderr(`Get UPN from Azure AD for group ${userIdentifier}`);
-            }
-            const aadUserGetCommandoptions = Object.assign(Object.assign(Object.assign({}, (options.aadGroupId && { id: userIdentifier })), (options.aadGroupName && { title: userIdentifier })), { output: 'json', debug: options.debug, verbose: options.verbose });
-            const aadGroupGetOutput = yield Cli_1.Cli.executeCommandWithOutput(AadGroupGetCommand, { options: Object.assign(Object.assign({}, aadUserGetCommandoptions), { _: [] }) });
-            if (this.debug) {
-                logger.logToStderr(aadGroupGetOutput.stderr);
-            }
-            validUserNames.push(JSON.parse(aadGroupGetOutput.stdout).mail);
-        });
-    }
-    spoUserGet(options, userIdentifier, logger, validUserNames) {
-        return __awaiter(this, void 0, void 0, function* () {
-            if (this.verbose) {
-                logger.logToStderr(`Get UPN from SharePoint for user ${userIdentifier}`);
-            }
-            const spoUserGetCommandoptions = {
-                id: userIdentifier,
-                webUrl: options.webUrl,
-                output: 'json',
-                debug: options.debug,
-                verbose: options.verbose
-            };
-            const spoUserGetOutput = yield Cli_1.Cli.executeCommandWithOutput(SpoUserGetCommand, { options: Object.assign(Object.assign({}, spoUserGetCommandoptions), { _: [] }) });
-            if (this.debug) {
-                logger.logToStderr(spoUserGetOutput.stderr);
-            }
-            validUserNames.push(JSON.parse(spoUserGetOutput.stdout).UserPrincipalName);
+            const validUserNames = [];
+            const identifiers = (_d = (_c = (_b = (_a = args.options.userName) !== null && _a !== void 0 ? _a : args.options.email) !== null && _b !== void 0 ? _b : args.options.aadGroupId) !== null && _c !== void 0 ? _c : args.options.aadGroupName) !== null && _d !== void 0 ? _d : args.options.userId.toString();
+            yield Promise.all(identifiers.split(',').map((identifier) => __awaiter(this, void 0, void 0, function* () {
+                const trimmedIdentifier = identifier.trim();
+                try {
+                    if (args.options.userId) {
+                        if (this.verbose) {
+                            logger.logToStderr(`Getting AAD ID of user with ID ${trimmedIdentifier}`);
+                        }
+                        const spoUserAzureId = yield spo_1.spo.getUserAzureIdBySpoId(args.options.webUrl, trimmedIdentifier);
+                        validUserNames.push(spoUserAzureId);
+                    }
+                    else if (args.options.userName) {
+                        validUserNames.push(trimmedIdentifier);
+                    }
+                    else if (args.options.aadGroupId) {
+                        validUserNames.push(trimmedIdentifier);
+                    }
+                    else if (args.options.aadGroupName) {
+                        if (this.verbose) {
+                            logger.logToStderr(`Getting ID of Azure AD group ${trimmedIdentifier}`);
+                        }
+                        const groupId = yield aadGroup_1.aadGroup.getGroupIdByDisplayName(trimmedIdentifier);
+                        validUserNames.push(groupId);
+                    }
+                    else {
+                        if (this.verbose) {
+                            logger.logToStderr(`Getting Azure AD ID for user ${trimmedIdentifier}`);
+                        }
+                        const upn = yield aadUser_1.aadUser.getUserIdByEmail(trimmedIdentifier);
+                        validUserNames.push(upn);
+                    }
+                }
+                catch (err) {
+                    throw `Resource '${trimmedIdentifier}' does not exist.`;
+                }
+            })));
+            return validUserNames;
         });
     }
     getFormattedUserList(activeUserList) {

package/dist/m365/spo/commands/list/list-add.js

@@ -106,7 +106,7 @@ class SpoListAddCommand extends SpoCommand_1.default {
     mapRequestBody(options) {
         const requestBody = {
             Title: options.title,
-            BaseTemplate: ListTemplateType_1.ListTemplateType[options.baseTemplate.trim()].valueOf()
+            BaseTemplate: options.baseTemplate ? ListTemplateType_1.ListTemplateType[options.baseTemplate.trim()].valueOf() : ListTemplateType_1.ListTemplateType.GenericList
         };
         if (options.description) {
             requestBody.Description = options.description;
@@ -148,7 +148,7 @@ class SpoListAddCommand extends SpoCommand_1.default {
             requestBody.DisableGridEditing = options.disableGridEditing;
         }
         if (options.draftVersionVisibility) {
-            requestBody.DraftVersionVisibility = options.draftVersionVisibility;
+            requestBody.DraftVersionVisibility = DraftVisibilityType_1.DraftVisibilityType[options.draftVersionVisibility.trim()];
         }
         if (options.emailAlias) {
             requestBody.EmailAlias = options.emailAlias;
@@ -226,7 +226,7 @@ class SpoListAddCommand extends SpoCommand_1.default {
             requestBody.IsApplicationList = options.isApplicationList;
         }
         if (options.listExperienceOptions) {
-            requestBody.ListExperienceOptions = options.listExperienceOptions;
+            requestBody.ListExperienceOptions = ListExperience_1.ListExperience[options.listExperienceOptions.trim()];
         }
         if (options.majorVersionLimit) {
             requestBody.MajorVersionLimit = options.majorVersionLimit;
@@ -296,6 +296,7 @@ _SpoListAddCommand_instances = new WeakSet(), _SpoListAddCommand_initTelemetry =
         const telemetryProps = {};
         // add properties with identifiable data
         [
+            'baseTemplate',
             'description',
             'templateFeatureId',
             'schemaXml',
@@ -342,7 +343,7 @@ _SpoListAddCommand_instances = new WeakSet(), _SpoListAddCommand_initTelemetry =
     this.options.unshift({
         option: '-t, --title <title>'
     }, {
-        option: '--baseTemplate <baseTemplate>',
+        option: '--baseTemplate [baseTemplate]',
         autocomplete: this.listTemplateTypeMap
     }, {
         option: '-u, --webUrl <webUrl>'
@@ -520,9 +521,11 @@ _SpoListAddCommand_instances = new WeakSet(), _SpoListAddCommand_initTelemetry =
         if (isValidSharePointUrl !== true) {
             return isValidSharePointUrl;
         }
-        const template = ListTemplateType_1.ListTemplateType[args.options.baseTemplate.trim()];
-        if (!template) {
-            return `${args.options.baseTemplate} is not a valid baseTemplate value`;
+        if (args.options.baseTemplate) {
+            const template = ListTemplateType_1.ListTemplateType[args.options.baseTemplate.trim()];
+            if (!template) {
+                return `${args.options.baseTemplate} is not a valid baseTemplate value`;
+            }
         }
         if (args.options.templateFeatureId &&
             !validation_1.validation.isValidGuid(args.options.templateFeatureId)) {
@@ -538,7 +541,7 @@ _SpoListAddCommand_instances = new WeakSet(), _SpoListAddCommand_initTelemetry =
         }
         if (args.options.draftVersionVisibility) {
             const draftType = DraftVisibilityType_1.DraftVisibilityType[args.options.draftVersionVisibility.trim()];
-            if (!draftType) {
+            if (draftType === undefined) {
                 return `${args.options.draftVersionVisibility} is not a valid draftVisibilityType value`;
             }
         }