@pnp/cli-microsoft365 6.0.0-beta.78fdd2c → 6.0.0-beta.7920dfd

package/dist/m365/spo/commands/file/file-add.js

@@ -19,7 +19,11 @@ const fs = require("fs");
 const path = require("path");
 const uuid_1 = require("uuid");
 const request_1 = require("../../../../request");
-const utils_1 = require("../../../../utils");
+const formatting_1 = require("../../../../utils/formatting");
+const fsUtil_1 = require("../../../../utils/fsUtil");
+const spo_1 = require("../../../../utils/spo");
+const urlUtil_1 = require("../../../../utils/urlUtil");
+const validation_1 = require("../../../../utils/validation");
 const SpoCommand_1 = require("../../../base/SpoCommand");
 const commands_1 = require("../../commands");
 class SpoFileAddCommand extends SpoCommand_1.default {
@@ -42,73 +46,66 @@ class SpoFileAddCommand extends SpoCommand_1.default {
     allowUnknownOptions() {
         return true;
     }
-    commandAction(logger, args, cb) {
-        const folderPath = utils_1.urlUtil.getServerRelativePath(args.options.webUrl, args.options.folder);
-        const fullPath = path.resolve(args.options.path);
-        const fileName = utils_1.fsUtil.getSafeFileName(path.basename(fullPath));
-        let isCheckedOut = false;
-        let listSettings;
-        if (this.debug) {
-            logger.logToStderr(`folder path: ${folderPath}...`);
-        }
-        if (this.debug) {
-            logger.logToStderr('Check if the specified folder exists.');
-            logger.logToStderr('');
-        }
-        if (this.debug) {
-            logger.logToStderr(`file name: ${fileName}...`);
-        }
-        const requestOptions = {
-            url: `${args.options.webUrl}/_api/web/GetFolderByServerRelativeUrl('${encodeURIComponent(folderPath)}')`,
-            headers: {
-                'accept': 'application/json;odata=nometadata'
-            }
-        };
-        request_1.default.get(requestOptions).catch(() => {
-            // folder does not exist so will attempt to create the folder tree
-            return utils_1.spo.ensureFolder(args.options.webUrl, folderPath, logger, this.debug);
-        })
-            .then(() => {
-            if (args.options.checkOut) {
-                return this.fileCheckOut(fileName, args.options.webUrl, folderPath)
-                    .then(() => {
-                    // flag the file is checkedOut by the command
-                    // so in case of command failure we can try check it in
-                    isCheckedOut = true;
-                    return Promise.resolve();
-                })
-                    .catch((err) => {
-                    return Promise.reject(err);
-                });
+    commandAction(logger, args) {
+        return __awaiter(this, void 0, void 0, function* () {
+            const folderPath = urlUtil_1.urlUtil.getServerRelativePath(args.options.webUrl, args.options.folder);
+            const fullPath = path.resolve(args.options.path);
+            const fileName = fsUtil_1.fsUtil.getSafeFileName(path.basename(fullPath));
+            let isCheckedOut = false;
+            let listSettings;
+            if (this.debug) {
+                logger.logToStderr(`folder path: ${folderPath}...`);
             }
-            return Promise.resolve();
-        })
-            .then(() => {
-            if (this.verbose) {
-                logger.logToStderr(`Upload file to site ${args.options.webUrl}...`);
+            if (this.debug) {
+                logger.logToStderr('Check if the specified folder exists.');
+                logger.logToStderr('');
             }
-            const fileStats = fs.statSync(fullPath);
-            const fileSize = fileStats.size;
             if (this.debug) {
-                logger.logToStderr(`File size is ${fileSize} bytes`);
+                logger.logToStderr(`file name: ${fileName}...`);
             }
-            // only up to 250 MB are allowed in a single request
-            if (fileSize > this.fileChunkingThreshold) {
-                const fileChunkCount = Math.ceil(fileSize / this.fileChunkSize);
+            try {
+                try {
+                    const requestOptions = {
+                        url: `${args.options.webUrl}/_api/web/GetFolderByServerRelativeUrl('${formatting_1.formatting.encodeQueryParameter(folderPath)}')`,
+                        headers: {
+                            'accept': 'application/json;odata=nometadata'
+                        }
+                    };
+                    yield request_1.default.get(requestOptions);
+                }
+                catch (err) {
+                    // folder does not exist so will attempt to create the folder tree
+                    yield spo_1.spo.ensureFolder(args.options.webUrl, folderPath, logger, this.debug);
+                }
+                if (args.options.checkOut) {
+                    yield this.fileCheckOut(fileName, args.options.webUrl, folderPath);
+                    // flag the file is checkedOut by the command
+                    // so in case of command failure we can try check it in
+                    isCheckedOut = true;
+                }
                 if (this.verbose) {
-                    logger.logToStderr(`Uploading ${fileSize} bytes in ${fileChunkCount} chunks...`);
+                    logger.logToStderr(`Upload file to site ${args.options.webUrl}...`);
                 }
-                // initiate chunked upload session
-                const uploadId = (0, uuid_1.v4)();
-                const requestOptions = {
-                    url: `${args.options.webUrl}/_api/web/GetFolderByServerRelativeUrl('${encodeURIComponent(folderPath)}')/Files/GetByPathOrAddStub(DecodedUrl='${encodeURIComponent(fileName)}')/StartUpload(uploadId=guid'${uploadId}')`,
-                    headers: {
-                        'accept': 'application/json;odata=nometadata'
+                const fileStats = fs.statSync(fullPath);
+                const fileSize = fileStats.size;
+                if (this.debug) {
+                    logger.logToStderr(`File size is ${fileSize} bytes`);
+                }
+                // only up to 250 MB are allowed in a single request
+                if (fileSize > this.fileChunkingThreshold) {
+                    const fileChunkCount = Math.ceil(fileSize / this.fileChunkSize);
+                    if (this.verbose) {
+                        logger.logToStderr(`Uploading ${fileSize} bytes in ${fileChunkCount} chunks...`);
                     }
-                };
-                return request_1.default
-                    .post(requestOptions)
-                    .then(() => {
+                    // initiate chunked upload session
+                    const uploadId = (0, uuid_1.v4)();
+                    const requestOptions = {
+                        url: `${args.options.webUrl}/_api/web/GetFolderByServerRelativeUrl('${formatting_1.formatting.encodeQueryParameter(folderPath)}')/Files/GetByPathOrAddStub(DecodedUrl='${formatting_1.formatting.encodeQueryParameter(fileName)}')/StartUpload(uploadId=guid'${uploadId}')`,
+                        headers: {
+                            'accept': 'application/json;odata=nometadata'
+                        }
+                    };
+                    yield request_1.default.post(requestOptions);
                     // session started successfully, now upload our file chunks
                     const fileUploadInfo = {
                         Name: fileName,
@@ -120,143 +117,128 @@ class SpoFileAddCommand extends SpoCommand_1.default {
                         Position: 0,
                         Size: fileSize
                     };
-                    return new Promise((resolve, reject) => {
-                        this.uploadFileChunks(fileUploadInfo, logger, resolve, reject);
-                    })
-                        .then(() => {
+                    try {
+                        yield new Promise((resolve, reject) => {
+                            this.uploadFileChunks(fileUploadInfo, logger, resolve, reject);
+                        });
                         if (this.verbose) {
                             logger.logToStderr(`Finished uploading ${fileUploadInfo.Position} bytes in ${fileChunkCount} chunks`);
                         }
-                        return Promise.resolve();
-                    })
-                        .catch((err) => {
+                    }
+                    catch (err) {
                         if (this.verbose) {
                             logger.logToStderr('Cancelling upload session due to error...');
                         }
                         const requestOptions = {
-                            url: `${args.options.webUrl}/_api/web/GetFolderByServerRelativeUrl('${encodeURIComponent(folderPath)}')/Files('${encodeURIComponent(fileName)}')/cancelupload(uploadId=guid'${uploadId}')`,
+                            url: `${args.options.webUrl}/_api/web/GetFolderByServerRelativeUrl('${formatting_1.formatting.encodeQueryParameter(folderPath)}')/Files('${formatting_1.formatting.encodeQueryParameter(fileName)}')/cancelupload(uploadId=guid'${uploadId}')`,
                             headers: {
                                 'accept': 'application/json;odata=nometadata'
                             }
                         };
-                        return request_1.default
-                            .post(requestOptions)
-                            .then(() => {
-                            return Promise.reject(err); // original error
-                        })
-                            .catch((err_) => {
+                        try {
+                            yield request_1.default.post(requestOptions);
+                            throw err;
+                        }
+                        catch (err) {
                             if (this.debug) {
-                                logger.logToStderr(`Failed to cancel upload session: ${err_}`);
+                                logger.logToStderr(`Failed to cancel upload session: ${err}`);
                             }
-                            return Promise.reject(err); // original error
-                        });
-                    });
-                });
-            }
-            // upload small file in a single request
-            const fileBody = fs.readFileSync(fullPath);
-            const bodyLength = fileBody.byteLength;
-            const requestOptions = {
-                url: `${args.options.webUrl}/_api/web/GetFolderByServerRelativeUrl('${encodeURIComponent(folderPath)}')/Files/Add(url='${encodeURIComponent(fileName)}', overwrite=true)`,
-                data: fileBody,
-                headers: {
-                    'accept': 'application/json;odata=nometadata',
-                    'content-length': bodyLength
-                },
-                maxBodyLength: this.fileChunkingThreshold
-            };
-            return request_1.default.post(requestOptions);
-        })
-            .then(() => {
-            if (args.options.contentType || args.options.publish || args.options.approve) {
-                return this.getFileParentList(fileName, args.options.webUrl, folderPath, logger)
-                    .then((listSettingsResp) => {
-                    listSettings = listSettingsResp;
+                            throw err;
+                        }
+                    }
+                }
+                else {
+                    // upload small file in a single request
+                    const fileBody = fs.readFileSync(fullPath);
+                    const bodyLength = fileBody.byteLength;
+                    const requestOptions = {
+                        url: `${args.options.webUrl}/_api/web/GetFolderByServerRelativeUrl('${formatting_1.formatting.encodeQueryParameter(folderPath)}')/Files/Add(url='${formatting_1.formatting.encodeQueryParameter(fileName)}', overwrite=true)`,
+                        data: fileBody,
+                        headers: {
+                            'accept': 'application/json;odata=nometadata',
+                            'content-length': bodyLength
+                        },
+                        maxBodyLength: this.fileChunkingThreshold
+                    };
+                    yield request_1.default.post(requestOptions);
+                }
+                if (args.options.contentType || args.options.publish || args.options.approve) {
+                    listSettings = yield this.getFileParentList(fileName, args.options.webUrl, folderPath, logger);
                     if (args.options.contentType) {
-                        return this.listHasContentType(args.options.contentType, args.options.webUrl, listSettings, logger);
+                        yield this.listHasContentType(args.options.contentType, args.options.webUrl, listSettings, logger);
                     }
-                    return Promise.resolve();
-                });
-            }
-            return Promise.resolve();
-        })
-            .then(() => {
-            // check if there are unknown options
-            // and map them as fields to update
-            const fieldsToUpdate = this.mapUnknownOptionsAsFieldValue(args.options);
-            if (args.options.contentType) {
-                fieldsToUpdate.push({
-                    FieldName: 'ContentType',
-                    FieldValue: args.options.contentType
-                });
-            }
-            if (fieldsToUpdate.length > 0) {
-                // perform list item update and checkin
-                return this.validateUpdateListItem(args.options.webUrl, folderPath, fileName, fieldsToUpdate, logger, args.options.checkInComment);
-            }
-            else if (isCheckedOut) {
-                // perform checkin
-                return this.fileCheckIn(args, fileName);
-            }
-            return Promise.resolve();
-        })
-            .then(() => {
-            // approve and publish cannot be used together
-            // when approve is used it will automatically publish the file
-            // so then no need to publish afterwards
-            if (args.options.approve) {
-                if (this.verbose) {
-                    logger.logToStderr(`Approve file ${fileName}`);
                 }
-                // approve the existing file with given comment
-                const requestOptions = {
-                    url: `${args.options.webUrl}/_api/web/GetFolderByServerRelativeUrl('${encodeURIComponent(folderPath)}')/Files('${encodeURIComponent(fileName)}')/approve(comment='${encodeURIComponent(args.options.approveComment || '')}')`,
-                    headers: {
-                        'accept': 'application/json;odata=nometadata'
-                    },
-                    responseType: 'json'
-                };
-                return request_1.default.post(requestOptions);
-            }
-            else if (args.options.publish) {
-                if (listSettings.EnableModeration && listSettings.EnableMinorVersions) {
-                    return Promise.reject('The file cannot be published without approval. Moderation for this list is enabled. Use the --approve option instead of --publish to approve and publish the file');
+                // check if there are unknown options
+                // and map them as fields to update
+                const fieldsToUpdate = this.mapUnknownOptionsAsFieldValue(args.options);
+                if (args.options.contentType) {
+                    fieldsToUpdate.push({
+                        FieldName: 'ContentType',
+                        FieldValue: args.options.contentType
+                    });
                 }
-                if (this.verbose) {
-                    logger.logToStderr(`Publish file ${fileName}`);
+                if (fieldsToUpdate.length > 0) {
+                    // perform list item update and checkin
+                    yield this.validateUpdateListItem(args.options.webUrl, folderPath, fileName, fieldsToUpdate, logger, args.options.checkInComment);
                 }
-                // publish the existing file with given comment
-                const requestOptions = {
-                    url: `${args.options.webUrl}/_api/web/GetFolderByServerRelativeUrl('${encodeURIComponent(folderPath)}')/Files('${encodeURIComponent(fileName)}')/publish(comment='${encodeURIComponent(args.options.publishComment || '')}')`,
-                    headers: {
-                        'accept': 'application/json;odata=nometadata'
-                    },
-                    responseType: 'json'
-                };
-                return request_1.default.post(requestOptions);
-            }
-            return Promise.resolve();
-        })
-            .then(_ => cb(), (err) => {
-            if (isCheckedOut) {
-                // in a case the command has done checkout
-                // then have to rollback the checkout
-                const requestOptions = {
-                    url: `${args.options.webUrl}/_api/web/GetFolderByServerRelativeUrl('${encodeURIComponent(folderPath)}')/Files('${encodeURIComponent(fileName)}')/UndoCheckOut()`
-                };
-                request_1.default.post(requestOptions)
-                    .then(_ => this.handleRejectedODataJsonPromise(err, logger, cb))
-                    .catch(checkoutError => {
+                else if (isCheckedOut) {
+                    // perform checkin
+                    yield this.fileCheckIn(args, fileName);
+                }
+                // approve and publish cannot be used together
+                // when approve is used it will automatically publish the file
+                // so then no need to publish afterwards
+                if (args.options.approve) {
+                    if (this.verbose) {
+                        logger.logToStderr(`Approve file ${fileName}`);
+                    }
+                    // approve the existing file with given comment
+                    const requestOptions = {
+                        url: `${args.options.webUrl}/_api/web/GetFolderByServerRelativeUrl('${formatting_1.formatting.encodeQueryParameter(folderPath)}')/Files('${formatting_1.formatting.encodeQueryParameter(fileName)}')/approve(comment='${formatting_1.formatting.encodeQueryParameter(args.options.approveComment || '')}')`,
+                        headers: {
+                            'accept': 'application/json;odata=nometadata'
+                        },
+                        responseType: 'json'
+                    };
+                    yield request_1.default.post(requestOptions);
+                }
+                else if (args.options.publish) {
+                    if (listSettings.EnableModeration && listSettings.EnableMinorVersions) {
+                        throw 'The file cannot be published without approval. Moderation for this list is enabled. Use the --approve option instead of --publish to approve and publish the file';
+                    }
                     if (this.verbose) {
-                        logger.logToStderr('Could not rollback file checkout');
-                        logger.logToStderr(checkoutError);
-                        logger.logToStderr('');
+                        logger.logToStderr(`Publish file ${fileName}`);
                     }
-                    this.handleRejectedODataJsonPromise(err, logger, cb);
-                });
+                    // publish the existing file with given comment
+                    const requestOptions = {
+                        url: `${args.options.webUrl}/_api/web/GetFolderByServerRelativeUrl('${formatting_1.formatting.encodeQueryParameter(folderPath)}')/Files('${formatting_1.formatting.encodeQueryParameter(fileName)}')/publish(comment='${formatting_1.formatting.encodeQueryParameter(args.options.publishComment || '')}')`,
+                        headers: {
+                            'accept': 'application/json;odata=nometadata'
+                        },
+                        responseType: 'json'
+                    };
+                    yield request_1.default.post(requestOptions);
+                }
             }
-            else {
-                this.handleRejectedODataJsonPromise(err, logger, cb);
+            catch (err) {
+                if (isCheckedOut) {
+                    // in a case the command has done checkout
+                    // then have to rollback the checkout
+                    const requestOptions = {
+                        url: `${args.options.webUrl}/_api/web/GetFolderByServerRelativeUrl('${formatting_1.formatting.encodeQueryParameter(folderPath)}')/Files('${formatting_1.formatting.encodeQueryParameter(fileName)}')/UndoCheckOut()`
+                    };
+                    try {
+                        yield request_1.default.post(requestOptions);
+                    }
+                    catch (err) {
+                        if (this.verbose) {
+                            logger.logToStderr('Could not rollback file checkout');
+                            logger.logToStderr(err);
+                            logger.logToStderr('');
+                        }
+                    }
+                }
+                this.handleRejectedODataJsonPromise(err);
             }
         });
     }
@@ -284,7 +266,7 @@ class SpoFileAddCommand extends SpoCommand_1.default {
     fileCheckOut(fileName, webUrl, folder) {
         // check if file already exists, otherwise it can't be checked out
         const requestOptions = {
-            url: `${webUrl}/_api/web/GetFolderByServerRelativeUrl('${encodeURIComponent(folder)}')/Files('${encodeURIComponent(fileName)}')`,
+            url: `${webUrl}/_api/web/GetFolderByServerRelativeUrl('${formatting_1.formatting.encodeQueryParameter(folder)}')/Files('${formatting_1.formatting.encodeQueryParameter(fileName)}')`,
             headers: {
                 'accept': 'application/json;odata=nometadata'
             }
@@ -293,7 +275,7 @@ class SpoFileAddCommand extends SpoCommand_1.default {
             .then(() => {
             // checkout the existing file
             const requestOptions = {
-                url: `${webUrl}/_api/web/GetFolderByServerRelativeUrl('${encodeURIComponent(folder)}')/Files('${encodeURIComponent(fileName)}')/CheckOut()`,
+                url: `${webUrl}/_api/web/GetFolderByServerRelativeUrl('${formatting_1.formatting.encodeQueryParameter(folder)}')/Files('${formatting_1.formatting.encodeQueryParameter(fileName)}')/CheckOut()`,
                 headers: {
                     'accept': 'application/json;odata=nometadata'
                 },
@@ -318,7 +300,7 @@ class SpoFileAddCommand extends SpoCommand_1.default {
                 fileBuffer = fileBuffer.slice(0, readCount);
             }
             const requestOptions = {
-                url: `${info.WebUrl}/_api/web/GetFolderByServerRelativeUrl('${encodeURIComponent(info.FolderPath)}')/Files('${encodeURIComponent(info.Name)}')/${isLastChunk ? 'Finish' : 'Continue'}Upload(uploadId=guid'${info.Id}',fileOffset=${offset})`,
+                url: `${info.WebUrl}/_api/web/GetFolderByServerRelativeUrl('${formatting_1.formatting.encodeQueryParameter(info.FolderPath)}')/Files('${formatting_1.formatting.encodeQueryParameter(info.Name)}')/${isLastChunk ? 'Finish' : 'Continue'}Upload(uploadId=guid'${info.Id}',fileOffset=${offset})`,
                 data: fileBuffer,
                 headers: {
                     'accept': 'application/json;odata=nometadata',
@@ -376,7 +358,7 @@ class SpoFileAddCommand extends SpoCommand_1.default {
             logger.logToStderr(`Getting list details in order to get its available content types afterwards...`);
         }
         const requestOptions = {
-            url: `${webUrl}/_api/web/GetFolderByServerRelativeUrl('${encodeURIComponent(folder)}')/Files('${encodeURIComponent(fileName)}')/ListItemAllFields/ParentList?$Select=Id,EnableModeration,EnableVersioning,EnableMinorVersions`,
+            url: `${webUrl}/_api/web/GetFolderByServerRelativeUrl('${formatting_1.formatting.encodeQueryParameter(folder)}')/Files('${formatting_1.formatting.encodeQueryParameter(fileName)}')/ListItemAllFields/ParentList?$Select=Id,EnableModeration,EnableVersioning,EnableMinorVersions`,
             headers: {
                 'accept': 'application/json;odata=nometadata'
             },
@@ -399,7 +381,7 @@ class SpoFileAddCommand extends SpoCommand_1.default {
         }
         // update the existing file list item fields
         const requestOptions = {
-            url: `${webUrl}/_api/web/GetFolderByServerRelativeUrl('${encodeURIComponent(folderPath)}')/Files('${encodeURIComponent(fileName)}')/ListItemAllFields/ValidateUpdateListItem()`,
+            url: `${webUrl}/_api/web/GetFolderByServerRelativeUrl('${formatting_1.formatting.encodeQueryParameter(folderPath)}')/Files('${formatting_1.formatting.encodeQueryParameter(fileName)}')/ListItemAllFields/ValidateUpdateListItem()`,
             headers: {
                 'accept': 'application/json;odata=nometadata'
             },
@@ -423,7 +405,7 @@ class SpoFileAddCommand extends SpoCommand_1.default {
     }
     fileCheckIn(args, fileName) {
         const requestOptions = {
-            url: `${args.options.webUrl}/_api/web/GetFolderByServerRelativeUrl('${encodeURIComponent(args.options.folder)}')/Files('${encodeURIComponent(fileName)}')/CheckIn(comment='${encodeURIComponent(args.options.checkInComment || '')}',checkintype=0)`,
+            url: `${args.options.webUrl}/_api/web/GetFolderByServerRelativeUrl('${formatting_1.formatting.encodeQueryParameter(args.options.folder)}')/Files('${formatting_1.formatting.encodeQueryParameter(fileName)}')/CheckIn(comment='${formatting_1.formatting.encodeQueryParameter(args.options.checkInComment || '')}',checkintype=0)`,
             headers: {
                 'accept': 'application/json;odata=nometadata'
             },
@@ -498,7 +480,7 @@ _SpoFileAddCommand_instances = new WeakSet(), _SpoFileAddCommand_initTelemetry =
     });
 }, _SpoFileAddCommand_initValidators = function _SpoFileAddCommand_initValidators() {
     this.validators.push((args) => __awaiter(this, void 0, void 0, function* () {
-        const isValidSharePointUrl = utils_1.validation.isValidSharePointUrl(args.options.webUrl);
+        const isValidSharePointUrl = validation_1.validation.isValidSharePointUrl(args.options.webUrl);
         if (isValidSharePointUrl !== true) {
             return isValidSharePointUrl;
         }

package/dist/m365/spo/commands/file/file-checkin.js

@@ -13,10 +13,11 @@ var __classPrivateFieldGet = (this && this.__classPrivateFieldGet) || function (
     if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot read private member from an object whose class did not declare it");
     return kind === "m" ? f : kind === "a" ? f.call(receiver) : f ? f.value : state.get(receiver);
 };
-var _SpoFileCheckinCommand_instances, _SpoFileCheckinCommand_initTelemetry, _SpoFileCheckinCommand_initOptions, _SpoFileCheckinCommand_initValidators;
+var _SpoFileCheckinCommand_instances, _SpoFileCheckinCommand_initTelemetry, _SpoFileCheckinCommand_initOptions, _SpoFileCheckinCommand_initValidators, _SpoFileCheckinCommand_initOptionSets;
 Object.defineProperty(exports, "__esModule", { value: true });
 const request_1 = require("../../../../request");
-const utils_1 = require("../../../../utils");
+const formatting_1 = require("../../../../utils/formatting");
+const validation_1 = require("../../../../utils/validation");
 const SpoCommand_1 = require("../../../base/SpoCommand");
 const commands_1 = require("../../commands");
 var CheckinType;
@@ -32,6 +33,7 @@ class SpoFileCheckinCommand extends SpoCommand_1.default {
         __classPrivateFieldGet(this, _SpoFileCheckinCommand_instances, "m", _SpoFileCheckinCommand_initTelemetry).call(this);
         __classPrivateFieldGet(this, _SpoFileCheckinCommand_instances, "m", _SpoFileCheckinCommand_initOptions).call(this);
         __classPrivateFieldGet(this, _SpoFileCheckinCommand_instances, "m", _SpoFileCheckinCommand_initValidators).call(this);
+        __classPrivateFieldGet(this, _SpoFileCheckinCommand_instances, "m", _SpoFileCheckinCommand_initOptionSets).call(this);
     }
     get name() {
         return commands_1.default.FILE_CHECKIN;
@@ -39,45 +41,50 @@ class SpoFileCheckinCommand extends SpoCommand_1.default {
     get description() {
         return 'Checks in specified file';
     }
-    commandAction(logger, args, cb) {
-        let type = CheckinType.Major;
-        if (args.options.type) {
-            switch (args.options.type.toLowerCase()) {
-                case 'minor':
-                    type = CheckinType.Minor;
-                    break;
-                case 'overwrite':
-                    type = CheckinType.Overwrite;
+    commandAction(logger, args) {
+        return __awaiter(this, void 0, void 0, function* () {
+            let type = CheckinType.Major;
+            if (args.options.type) {
+                switch (args.options.type.toLowerCase()) {
+                    case 'minor':
+                        type = CheckinType.Minor;
+                        break;
+                    case 'overwrite':
+                        type = CheckinType.Overwrite;
+                }
             }
-        }
-        let comment = '';
-        if (args.options.comment) {
-            comment = encodeURIComponent(args.options.comment);
-        }
-        let requestUrl = '';
-        if (args.options.id) {
-            requestUrl = `${args.options.webUrl}/_api/web/GetFileById('${encodeURIComponent(args.options.id)}')/checkin(comment='${comment}',checkintype=${type})`;
-        }
-        if (args.options.fileUrl) {
-            requestUrl = `${args.options.webUrl}/_api/web/GetFileByServerRelativeUrl('${encodeURIComponent(args.options.fileUrl)}')/checkin(comment='${comment}',checkintype=${type})`;
-        }
-        const requestOptions = {
-            url: requestUrl,
-            headers: {
-                'accept': 'application/json;odata=nometadata'
-            },
-            responseType: 'json'
-        };
-        request_1.default
-            .post(requestOptions)
-            .then(_ => cb(), (err) => this.handleRejectedODataJsonPromise(err, logger, cb));
+            let comment = '';
+            if (args.options.comment) {
+                comment = formatting_1.formatting.encodeQueryParameter(args.options.comment);
+            }
+            let requestUrl = '';
+            if (args.options.id) {
+                requestUrl = `${args.options.webUrl}/_api/web/GetFileById('${formatting_1.formatting.encodeQueryParameter(args.options.id)}')/checkin(comment='${comment}',checkintype=${type})`;
+            }
+            if (args.options.url) {
+                requestUrl = `${args.options.webUrl}/_api/web/GetFileByServerRelativeUrl('${formatting_1.formatting.encodeQueryParameter(args.options.url)}')/checkin(comment='${comment}',checkintype=${type})`;
+            }
+            const requestOptions = {
+                url: requestUrl,
+                headers: {
+                    'accept': 'application/json;odata=nometadata'
+                },
+                responseType: 'json'
+            };
+            try {
+                yield request_1.default.post(requestOptions);
+            }
+            catch (err) {
+                this.handleRejectedODataJsonPromise(err);
+            }
+        });
     }
 }
 _SpoFileCheckinCommand_instances = new WeakSet(), _SpoFileCheckinCommand_initTelemetry = function _SpoFileCheckinCommand_initTelemetry() {
     this.telemetry.push((args) => {
         Object.assign(this.telemetryProperties, {
             id: (!(!args.options.id)).toString(),
-            url: (!(!args.options.fileUrl)).toString(),
+            url: (!(!args.options.url)).toString(),
             type: args.options.type || 'Major',
             comment: typeof args.options.comment !== 'undefined'
         });
@@ -86,7 +93,7 @@ _SpoFileCheckinCommand_instances = new WeakSet(), _SpoFileCheckinCommand_initTel
     this.options.unshift({
         option: '-u, --webUrl <webUrl>'
     }, {
-        option: '-f, --fileUrl [fileUrl]'
+        option: '-f, --url [url]'
     }, {
         option: '-i, --id [id]'
     }, {
@@ -97,21 +104,15 @@ _SpoFileCheckinCommand_instances = new WeakSet(), _SpoFileCheckinCommand_initTel
     });
 }, _SpoFileCheckinCommand_initValidators = function _SpoFileCheckinCommand_initValidators() {
     this.validators.push((args) => __awaiter(this, void 0, void 0, function* () {
-        const isValidSharePointUrl = utils_1.validation.isValidSharePointUrl(args.options.webUrl);
+        const isValidSharePointUrl = validation_1.validation.isValidSharePointUrl(args.options.webUrl);
         if (isValidSharePointUrl !== true) {
             return isValidSharePointUrl;
         }
         if (args.options.id) {
-            if (!utils_1.validation.isValidGuid(args.options.id)) {
+            if (!validation_1.validation.isValidGuid(args.options.id)) {
                 return `${args.options.id} is not a valid GUID`;
             }
         }
-        if (args.options.id && args.options.fileUrl) {
-            return 'Specify either fileUrl or id but not both';
-        }
-        if (!args.options.id && !args.options.fileUrl) {
-            return 'Specify fileUrl or id, one is required';
-        }
         if (args.options.comment && args.options.comment.length > 1023) {
             return 'The length of the comment must be less than 1024 letters';
         }
@@ -124,6 +125,8 @@ _SpoFileCheckinCommand_instances = new WeakSet(), _SpoFileCheckinCommand_initTel
         }
         return true;
     }));
+}, _SpoFileCheckinCommand_initOptionSets = function _SpoFileCheckinCommand_initOptionSets() {
+    this.optionSets.push({ options: ['url', 'id'] });
 };
 module.exports = new SpoFileCheckinCommand();
 //# sourceMappingURL=file-checkin.js.map