@pnp/cli-microsoft365 6.0.0-beta.6a854fc → 6.0.0-beta.9d619b2

package/dist/m365/spo/commands/customaction/customaction-remove.js

@@ -12,6 +12,11 @@ class SpoCustomActionRemoveCommand extends SpoCommand_1.default {
     get description() {
         return 'Removes the specified custom action';
     }
+    optionSets() {
+        return [
+            ['id', 'title']
+        ];
+    }
     getTelemetryProperties(args) {
         const telemetryProps = super.getTelemetryProperties(args);
         telemetryProps.scope = args.options.scope || 'All';
@@ -54,16 +59,43 @@ class SpoCustomActionRemoveCommand extends SpoCommand_1.default {
             });
         }
     }
-    removeScopedCustomAction(options) {
-        const requestOptions = {
-            url: `${options.url}/_api/${options.scope}/UserCustomActions('${encodeURIComponent(options.id)}')`,
+    getCustomActionId(options) {
+        if (options.id) {
+            return Promise.resolve(options.id);
+        }
+        const customActionRequestOptions = {
+            url: `${options.url}/_api/${options.scope}/UserCustomActions?$filter=Title eq '${encodeURIComponent(options.title)}'`,
             headers: {
-                accept: 'application/json;odata=nometadata',
-                'X-HTTP-Method': 'DELETE'
+                accept: 'application/json;odata=nometadata'
             },
             responseType: 'json'
         };
-        return request_1.default.post(requestOptions);
+        return request_1.default
+            .get(customActionRequestOptions)
+            .then((res) => {
+            if (res.value.length === 1) {
+                return Promise.resolve(res.value[0].Id);
+            }
+            if (res.value.length === 0) {
+                return Promise.reject(`No user custom action with title '${options.title}' found`);
+            }
+            return Promise.reject(`Multiple user custom actions with title '${options.title}' found. Please disambiguate using IDs: ${res.value.map(a => a.Id).join(', ')}`);
+        });
+    }
+    removeScopedCustomAction(options) {
+        return this
+            .getCustomActionId(options)
+            .then((customActionId) => {
+            const requestOptions = {
+                url: `${options.url}/_api/${options.scope}/UserCustomActions('${encodeURIComponent(customActionId)}')')`,
+                headers: {
+                    accept: 'application/json;odata=nometadata',
+                    'X-HTTP-Method': 'DELETE'
+                },
+                responseType: 'json'
+            };
+            return request_1.default.post(requestOptions);
+        });
     }
     /**
      * Remove request with `web` scope is send first.
@@ -95,7 +127,10 @@ class SpoCustomActionRemoveCommand extends SpoCommand_1.default {
     options() {
         const options = [
             {
-                option: '-i, --id <id>'
+                option: '-i, --id [id]'
+            },
+            {
+                option: '-t, --title [title]'
             },
             {
                 option: '-u, --url <url>'
@@ -112,7 +147,7 @@ class SpoCustomActionRemoveCommand extends SpoCommand_1.default {
         return options.concat(parentOptions);
     }
     validate(args) {
-        if (utils_1.validation.isValidGuid(args.options.id) === false) {
+        if (args.options.id && utils_1.validation.isValidGuid(args.options.id) === false) {
             return `${args.options.id} is not valid. Custom action Id (GUID) expected.`;
         }
         if (utils_1.validation.isValidSharePointUrl(args.options.url) !== true) {

package/dist/m365/spo/commands/list/list-list.js

@@ -14,18 +14,12 @@ class SpoListListCommand extends SpoCommand_1.default {
     defaultProperties() {
         return ['Title', 'Url', 'Id'];
     }
-    getTelemetryProperties(args) {
-        const telemetryProps = super.getTelemetryProperties(args);
-        telemetryProps.executeWithLimitedPermissions = !!args.options.executeWithLimitedPermissions;
-        return telemetryProps;
-    }
     commandAction(logger, args, cb) {
         if (this.verbose) {
             logger.logToStderr(`Retrieving all lists in site at ${args.options.webUrl}...`);
         }
-        const suffix = args.options.executeWithLimitedPermissions ? '&$select=RootFolder/ServerRelativeUrl,*' : '';
         const requestOptions = {
-            url: `${args.options.webUrl}/_api/web/lists?$expand=RootFolder${suffix}`,
+            url: `${args.options.webUrl}/_api/web/lists?$expand=RootFolder&$select=RootFolder/ServerRelativeUrl,*`,
             method: 'GET',
             headers: {
                 'accept': 'application/json;odata=nometadata'
@@ -46,9 +40,6 @@ class SpoListListCommand extends SpoCommand_1.default {
         const options = [
             {
                 option: '-u, --webUrl <webUrl>'
-            },
-            {
-                option: '--executeWithLimitedPermissions'
             }
         ];
         const parentOptions = super.options();

package/dist/m365/spo/commands/site/site-list.js

@@ -18,7 +18,7 @@ class SpoSiteListCommand extends SpoCommand_1.default {
         telemetryProps.filter = (!(!args.options.filter)).toString();
         telemetryProps.includeOneDriveSites = typeof args.options.includeOneDriveSites !== 'undefined';
         telemetryProps.deleted = typeof args.options.deleted !== 'undefined';
-        telemetryProps.siteType = args.options.type || 'TeamSite';
+        telemetryProps.siteType = args.options.type;
         return telemetryProps;
     }
     defaultProperties() {
@@ -84,11 +84,6 @@ class SpoSiteListCommand extends SpoCommand_1.default {
             }, err => reject(err));
         });
     }
-    /*
-      The type property currently defaults to Teamsite.
-      It makes more sense to default to All. Certainly after adding the 'includeOneDriveSites' option.
-      Changing this will be a breaking change. We'll remove the default the next major version.
-    */
     getWebTemplateId(options) {
         if (options.webTemplate) {
             return options.webTemplate;
@@ -96,11 +91,7 @@ class SpoSiteListCommand extends SpoCommand_1.default {
         if (options.includeOneDriveSites) {
             return '';
         }
-        let siteType = options.type;
-        if (!siteType) {
-            siteType = 'TeamSite';
-        }
-        switch (siteType) {
+        switch (options.type) {
             case "TeamSite":
                 return 'GROUP#0';
             case "CommunicationSite":
@@ -113,9 +104,7 @@ class SpoSiteListCommand extends SpoCommand_1.default {
         const options = [
             {
                 option: '-t, --type [type]',
-                // To not introduce a breaking change, 'All' has been added.
-                // You should use all when using '--includeOneDriveSites'
-                autocomplete: ['TeamSite', 'CommunicationSite', 'All']
+                autocomplete: ['TeamSite', 'CommunicationSite']
             },
             {
                 option: '--webTemplate [webTemplate]'
@@ -137,14 +126,14 @@ class SpoSiteListCommand extends SpoCommand_1.default {
         if (args.options.type && args.options.webTemplate) {
             return 'Specify either type or webTemplate, but not both';
         }
-        const typeValues = ['TeamSite', 'CommunicationSite', 'All'];
+        const typeValues = ['TeamSite', 'CommunicationSite'];
         if (args.options.type &&
             typeValues.indexOf(args.options.type) < 0) {
             return `${args.options.type} is not a valid value for the type option. Allowed values are ${typeValues.join('|')}`;
         }
         if (args.options.includeOneDriveSites
-            && (!args.options.type || args.options.type !== 'All')) {
-            return 'When using includeOneDriveSites, specify All as value for type';
+            && (args.options.type || args.options.webTemplate)) {
+            return 'When using includeOneDriveSites, don\'t specify the type or webTemplate options';
         }
         return true;
     }